| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:ac4a4c94-fed4-5f65-69d7-365debba1454 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C832:1C94F:1B080A3:22995D9:6B0198D0 |
| html-safe-nonce | c422f9845f58f098fa8039d81611395b90f27725a3b15d0ccb0379f1d80137cf |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDODMyOjFDOTRGOjFCMDgwQTM6MjI5OTVEOTo2QjAxOThEMCIsInZpc2l0b3JfaWQiOiIzNjc1NTc5OTYyMjc2MDI2NTc2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | b9ac119f1944d0b4582a6b0bffc5f1d84bb98d573015e6c092d69000395db90c |
| hovercard-subject-tag | pull_request:1007336137 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/3170/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e396af0641b39e592f9359998558205fd0f26eb5a1c51aa7fc8b0e666b44005f/coder/coder/pull/3170 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e396af0641b39e592f9359998558205fd0f26eb5a1c51aa7fc8b0e666b44005f/coder/coder/pull/3170 |
| og:image:alt | With this PR we now always buffer command output.
The ExpectMatch function was also refactored a bit to avoid a race where a timeout could fire whilst writing to buffer (concurrent read/write), or ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mafredri |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/coder/coder git https://github.com/coder/coder.git |
| octolytics-dimension-user_id | 95932066 |
| octolytics-dimension-user_login | coder |
| octolytics-dimension-repository_id | 440752086 |
| octolytics-dimension-repository_nwo | coder/coder |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 440752086 |
| octolytics-dimension-repository_network_root_nwo | coder/coder |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/coder/coder/pull/3170#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F3170 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F3170 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder |
| Reload | https://github.com/coder/coder/pull/3170 |
| Reload | https://github.com/coder/coder/pull/3170 |
| Reload | https://github.com/coder/coder/pull/3170 |
| coder | https://github.com/coder |
| coder | https://github.com/coder/coder |
| Code | https://github.com/coder/coder |
| Issues320 (320) | https://github.com/coder/coder/issues |
| Pull requests470 (470) | https://github.com/coder/coder/pulls |
| Discussions | https://github.com/coder/coder/discussions |
| Actions | https://github.com/coder/coder/actions |
| Projects | https://github.com/coder/coder/projects |
| Security and quality49 (49) | https://github.com/coder/coder/security |
| Insights | https://github.com/coder/coder/insights |
| https://github.com/coder/coder |
| mafredri | https://github.com/mafredri |
| main | https://github.com/coder/coder/tree/main |
| mafredri/ptytest-buffer-output | https://github.com/coder/coder/tree/mafredri/ptytest-buffer-output |
| Conversation | https://github.com/coder/coder/pull/3170 |
| Commits7 (7) | https://github.com/coder/coder/pull/3170/commits |
| Checks | https://github.com/coder/coder/pull/3170/checks |
| Files changed | https://github.com/coder/coder/pull/3170/files |
| fix: Rewrite ptytest to buffer stdout | https://github.com/coder/coder/pull/3170#top |
| mafredri | https://github.com/mafredri |
| main | https://github.com/coder/coder/tree/main |
| mafredri/ptytest-buffer-output | https://github.com/coder/coder/tree/mafredri/ptytest-buffer-output |
|
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| Jul 25, 2022 | https://github.com/coder/coder/pull/3170#issue-1316867056 |
| #2122 | https://github.com/coder/coder/issues/2122 |
| Please reload this page | https://github.com/coder/coder/pull/3170 |
|
| https://github.com/mafredri |
| fix: Rewrite ptytest to buffer stdout | https://github.com/coder/coder/pull/3170/commits/ffda8cde08e668ac5a5caf9b84ee2091b32846bd |
| ffda8cd | https://github.com/coder/coder/pull/3170/commits/ffda8cde08e668ac5a5caf9b84ee2091b32846bd |
| #2122 | https://github.com/coder/coder/issues/2122 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| Jul 25, 2022 | https://github.com/coder/coder/pull/3170#event-7056729837 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| July 25, 2022 13:46 | https://github.com/coder/coder/pull/3170#event-7056729964 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
|
Jul 25, 2022
| https://github.com/coder/coder/pull/3170#pullrequestreview-1049502254 |
|
View reviewed changes
| https://github.com/coder/coder/pull/3170/files/ffda8cde08e668ac5a5caf9b84ee2091b32846bd |
| pty/ptytest/ptytest.go | https://github.com/coder/coder/pull/3170/files/ffda8cde08e668ac5a5caf9b84ee2091b32846bd#diff-14d80887c4dfd5b6a5c8b20ca0d48cee0a00aab5c4fc888c77fdebdf284c0890 |
| Please reload this page | https://github.com/coder/coder/pull/3170 |
| mafredri | https://github.com/mafredri |
| July 25, 2022 16:54 | https://github.com/coder/coder/pull/3170#commits-pushed-c1112a5 |
|
| https://github.com/mafredri |
| Lint fixes | https://github.com/coder/coder/pull/3170/commits/c1112a59b91507b6040c008b30dfeedf37a1216f |
| c1112a5 | https://github.com/coder/coder/pull/3170/commits/c1112a59b91507b6040c008b30dfeedf37a1216f |
|
| https://github.com/mafredri |
| Fix eof | https://github.com/coder/coder/pull/3170/commits/f974351cd572a250d7647d736b540cda5c545947 |
| f974351 | https://github.com/coder/coder/pull/3170/commits/f974351cd572a250d7647d736b540cda5c545947 |
| https://github.com/kylecarbs |
| kylecarbs | https://github.com/kylecarbs |
|
Jul 25, 2022
| https://github.com/coder/coder/pull/3170#pullrequestreview-1049691668 |
|
View reviewed changes
| https://github.com/coder/coder/pull/3170/files/f974351cd572a250d7647d736b540cda5c545947 |
| kylecarbs | https://github.com/kylecarbs |
| https://github.com/coder/coder/pull/3170#pullrequestreview-1049691668 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/3170 |
| pty/ptytest/ptytest.go | https://github.com/coder/coder/pull/3170/files/f974351cd572a250d7647d736b540cda5c545947#diff-14d80887c4dfd5b6a5c8b20ca0d48cee0a00aab5c4fc888c77fdebdf284c0890 |
| Please reload this page | https://github.com/coder/coder/pull/3170 |
| mafredri | https://github.com/mafredri |
| July 25, 2022 19:00 | https://github.com/coder/coder/pull/3170#commits-pushed-7b331cd |
|
| https://github.com/mafredri |
| chore: Simplify timeout in ExpectMatch | https://github.com/coder/coder/pull/3170/commits/7b331cd3c4cea992ac811060088e50bd77d8d89f |
| 7b331cd | https://github.com/coder/coder/pull/3170/commits/7b331cd3c4cea992ac811060088e50bd77d8d89f |
|
| https://github.com/mafredri |
| chore: Rename ctx to timeout | https://github.com/coder/coder/pull/3170/commits/d747356c2664894341bf7156dc1f16e08ba8d7f3 |
| d747356 | https://github.com/coder/coder/pull/3170/commits/d747356c2664894341bf7156dc1f16e08ba8d7f3 |
|
| https://github.com/mafredri |
| fix: Ensure goroutine cleanup | https://github.com/coder/coder/pull/3170/commits/372f60cb09c0e6e743df59fe6c1523d78f3a3162 |
| 372f60c | https://github.com/coder/coder/pull/3170/commits/372f60cb09c0e6e743df59fe6c1523d78f3a3162 |
|
| https://github.com/mafredri |
| chore: Cleanup goroutine via inline function | https://github.com/coder/coder/pull/3170/commits/3cd1bc85e5cbfe8cdb12d487d93b4a98df493ab0 |
| 3cd1bc8 | https://github.com/coder/coder/pull/3170/commits/3cd1bc85e5cbfe8cdb12d487d93b4a98df493ab0 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| 92a95fb | https://github.com/coder/coder/commit/92a95fbd5f0486992dc98f04e761eea91c5b81a1 |
| Jul 25, 2022 | https://github.com/coder/coder/pull/3170#event-7058269853 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| July 25, 2022 17:02 | https://github.com/coder/coder/pull/3170#event-7058269925 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
|
Aug 12, 2022
| https://github.com/coder/coder/pull/3170#ref-issue-1290460481 |
|
Test Flake: TestSSH/ImmediateExit
#2759
| https://github.com/coder/coder/issues/2759 |
| https://github.co/hiddenchars |
| https://github.com/coder/coder/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F3170 |
|
| https://github.com/kylecarbs |
|
kylecarbs
| https://github.com/kylecarbs |
|
| https://github.com/coder/coder/pull/3170/files/f974351cd572a250d7647d736b540cda5c545947 |
| Please reload this page | https://github.com/coder/coder/pull/3170 |
|
| https://github.com/mafredri |
|
mafredri
| https://github.com/mafredri |
|
Tests using Cobra with ptytest can hang on macOS (and Windows) unless the output is consumed
| https://github.com/coder/coder/issues/2122 |
| Please reload this page | https://github.com/coder/coder/pull/3170 |
|
| https://github.com/mafredri |
|
| https://github.com/kylecarbs |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |