René's URL Explorer Experiment


Title: fix: Rewrite ptytest to buffer stdout by mafredri · Pull Request #3170 · coder/coder · GitHub

Open Graph Title: fix: Rewrite ptytest to buffer stdout by mafredri · Pull Request #3170 · coder/coder

X Title: fix: Rewrite ptytest to buffer stdout by mafredri · Pull Request #3170 · coder/coder

Description: Secure environments for developers and their agents - fix: Rewrite ptytest to buffer stdout by mafredri · Pull Request #3170 · coder/coder

Open Graph Description: With this PR we now always buffer command output. The ExpectMatch function was also refactored a bit to avoid a race where a timeout could fire whilst writing to buffer (concurrent read/write), or ...

X Description: With this PR we now always buffer command output. The ExpectMatch function was also refactored a bit to avoid a race where a timeout could fire whilst writing to buffer (concurrent read/write), or ...

Opengraph URL: https://github.com/coder/coder/pull/3170

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ac4a4c94-fed4-5f65-69d7-365debba1454
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC832:1C94F:1B080A3:22995D9:6B0198D0
html-safe-noncec422f9845f58f098fa8039d81611395b90f27725a3b15d0ccb0379f1d80137cf
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDODMyOjFDOTRGOjFCMDgwQTM6MjI5OTVEOTo2QjAxOThEMCIsInZpc2l0b3JfaWQiOiIzNjc1NTc5OTYyMjc2MDI2NTc2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb9ac119f1944d0b4582a6b0bffc5f1d84bb98d573015e6c092d69000395db90c
hovercard-subject-tagpull_request:1007336137
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/3170/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e396af0641b39e592f9359998558205fd0f26eb5a1c51aa7fc8b0e666b44005f/coder/coder/pull/3170
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e396af0641b39e592f9359998558205fd0f26eb5a1c51aa7fc8b0e666b44005f/coder/coder/pull/3170
og:image:altWith this PR we now always buffer command output. The ExpectMatch function was also refactored a bit to avoid a race where a timeout could fire whilst writing to buffer (concurrent read/write), or ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemafredri
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/coder/coder/pull/3170#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F3170
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F3170
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/pull/3170
Reloadhttps://github.com/coder/coder/pull/3170
Reloadhttps://github.com/coder/coder/pull/3170
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
https://github.com/coder/coder
mafredrihttps://github.com/mafredri
mainhttps://github.com/coder/coder/tree/main
mafredri/ptytest-buffer-outputhttps://github.com/coder/coder/tree/mafredri/ptytest-buffer-output
Conversationhttps://github.com/coder/coder/pull/3170
Commits7 (7)https://github.com/coder/coder/pull/3170/commits
Checkshttps://github.com/coder/coder/pull/3170/checks
Files changedhttps://github.com/coder/coder/pull/3170/files
fix: Rewrite ptytest to buffer stdouthttps://github.com/coder/coder/pull/3170#top
mafredrihttps://github.com/mafredri
mainhttps://github.com/coder/coder/tree/main
mafredri/ptytest-buffer-outputhttps://github.com/coder/coder/tree/mafredri/ptytest-buffer-output
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Jul 25, 2022https://github.com/coder/coder/pull/3170#issue-1316867056
#2122https://github.com/coder/coder/issues/2122
Please reload this pagehttps://github.com/coder/coder/pull/3170
https://github.com/mafredri
fix: Rewrite ptytest to buffer stdouthttps://github.com/coder/coder/pull/3170/commits/ffda8cde08e668ac5a5caf9b84ee2091b32846bd
ffda8cdhttps://github.com/coder/coder/pull/3170/commits/ffda8cde08e668ac5a5caf9b84ee2091b32846bd
#2122https://github.com/coder/coder/issues/2122
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Jul 25, 2022https://github.com/coder/coder/pull/3170#event-7056729837
https://github.com/mafredri
mafredrihttps://github.com/mafredri
July 25, 2022 13:46https://github.com/coder/coder/pull/3170#event-7056729964
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Jul 25, 2022 https://github.com/coder/coder/pull/3170#pullrequestreview-1049502254
View reviewed changes https://github.com/coder/coder/pull/3170/files/ffda8cde08e668ac5a5caf9b84ee2091b32846bd
pty/ptytest/ptytest.gohttps://github.com/coder/coder/pull/3170/files/ffda8cde08e668ac5a5caf9b84ee2091b32846bd#diff-14d80887c4dfd5b6a5c8b20ca0d48cee0a00aab5c4fc888c77fdebdf284c0890
Please reload this pagehttps://github.com/coder/coder/pull/3170
mafredrihttps://github.com/mafredri
July 25, 2022 16:54https://github.com/coder/coder/pull/3170#commits-pushed-c1112a5
https://github.com/mafredri
Lint fixeshttps://github.com/coder/coder/pull/3170/commits/c1112a59b91507b6040c008b30dfeedf37a1216f
c1112a5https://github.com/coder/coder/pull/3170/commits/c1112a59b91507b6040c008b30dfeedf37a1216f
https://github.com/mafredri
Fix eofhttps://github.com/coder/coder/pull/3170/commits/f974351cd572a250d7647d736b540cda5c545947
f974351https://github.com/coder/coder/pull/3170/commits/f974351cd572a250d7647d736b540cda5c545947
https://github.com/kylecarbs
kylecarbshttps://github.com/kylecarbs
Jul 25, 2022 https://github.com/coder/coder/pull/3170#pullrequestreview-1049691668
View reviewed changes https://github.com/coder/coder/pull/3170/files/f974351cd572a250d7647d736b540cda5c545947
kylecarbshttps://github.com/kylecarbs
https://github.com/coder/coder/pull/3170#pullrequestreview-1049691668
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/3170
pty/ptytest/ptytest.gohttps://github.com/coder/coder/pull/3170/files/f974351cd572a250d7647d736b540cda5c545947#diff-14d80887c4dfd5b6a5c8b20ca0d48cee0a00aab5c4fc888c77fdebdf284c0890
Please reload this pagehttps://github.com/coder/coder/pull/3170
mafredrihttps://github.com/mafredri
July 25, 2022 19:00https://github.com/coder/coder/pull/3170#commits-pushed-7b331cd
https://github.com/mafredri
chore: Simplify timeout in ExpectMatchhttps://github.com/coder/coder/pull/3170/commits/7b331cd3c4cea992ac811060088e50bd77d8d89f
7b331cdhttps://github.com/coder/coder/pull/3170/commits/7b331cd3c4cea992ac811060088e50bd77d8d89f
https://github.com/mafredri
chore: Rename ctx to timeouthttps://github.com/coder/coder/pull/3170/commits/d747356c2664894341bf7156dc1f16e08ba8d7f3
d747356https://github.com/coder/coder/pull/3170/commits/d747356c2664894341bf7156dc1f16e08ba8d7f3
https://github.com/mafredri
fix: Ensure goroutine cleanuphttps://github.com/coder/coder/pull/3170/commits/372f60cb09c0e6e743df59fe6c1523d78f3a3162
372f60chttps://github.com/coder/coder/pull/3170/commits/372f60cb09c0e6e743df59fe6c1523d78f3a3162
https://github.com/mafredri
chore: Cleanup goroutine via inline functionhttps://github.com/coder/coder/pull/3170/commits/3cd1bc85e5cbfe8cdb12d487d93b4a98df493ab0
3cd1bc8https://github.com/coder/coder/pull/3170/commits/3cd1bc85e5cbfe8cdb12d487d93b4a98df493ab0
https://github.com/mafredri
mafredrihttps://github.com/mafredri
92a95fbhttps://github.com/coder/coder/commit/92a95fbd5f0486992dc98f04e761eea91c5b81a1
Jul 25, 2022https://github.com/coder/coder/pull/3170#event-7058269853
https://github.com/mafredri
mafredrihttps://github.com/mafredri
July 25, 2022 17:02https://github.com/coder/coder/pull/3170#event-7058269925
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Aug 12, 2022 https://github.com/coder/coder/pull/3170#ref-issue-1290460481
Test Flake: TestSSH/ImmediateExit #2759 https://github.com/coder/coder/issues/2759
https://github.co/hiddenchars
https://github.com/coder/coder/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F3170
https://github.com/kylecarbs
kylecarbs https://github.com/kylecarbs
https://github.com/coder/coder/pull/3170/files/f974351cd572a250d7647d736b540cda5c545947
Please reload this pagehttps://github.com/coder/coder/pull/3170
https://github.com/mafredri
mafredri https://github.com/mafredri
Tests using Cobra with ptytest can hang on macOS (and Windows) unless the output is consumed https://github.com/coder/coder/issues/2122
Please reload this pagehttps://github.com/coder/coder/pull/3170
https://github.com/mafredri
https://github.com/kylecarbs
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.