| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:ea948928-b7ae-d824-598e-ffa386168157 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9B80:363D8E:1CE026D:24AF59A:6B014371 |
| html-safe-nonce | d2e2dbc2d3f5920137aa640f53f48fcaa5e917655b36f5a72c7c938a35dfcba5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QjgwOjM2M0Q4RToxQ0UwMjZEOjI0QUY1OUE6NkIwMTQzNzEiLCJ2aXNpdG9yX2lkIjoiNDE1Mjc0NTQ2NDQ0NzQ1MjAxNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 74af4b6e5a89dcfea05a6ee218549e92efa5aa750f1001e64c97de91ed469426 |
| hovercard-subject-tag | pull_request:5057858493 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/31462/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/8f96db3b59b51e3ea55c79092e0815f27647e1f81705c0d6f785162f11ecd921/coder/coder/pull/31462 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8f96db3b59b51e3ea55c79092e0815f27647e1f81705c0d6f785162f11ecd921/coder/coder/pull/31462 |
| og:image:alt | Xum opened this PR for Mike.
read_skill_file checked the requested path lexically, then read <skill dir>/<path> through the agent's general file reader, which follows symlinks. A s... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ibetitsmike |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/coder/coder git https://github.com/coder/coder.git |
| octolytics-dimension-user_id | 95932066 |
| octolytics-dimension-user_login | coder |
| octolytics-dimension-repository_id | 440752086 |
| octolytics-dimension-repository_nwo | coder/coder |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 440752086 |
| octolytics-dimension-repository_network_root_nwo | coder/coder |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/coder/coder/pull/31462#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F31462 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F31462 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder |
| Reload | https://github.com/coder/coder/pull/31462 |
| Reload | https://github.com/coder/coder/pull/31462 |
| Reload | https://github.com/coder/coder/pull/31462 |
| coder | https://github.com/coder |
| coder | https://github.com/coder/coder |
| Code | https://github.com/coder/coder |
| Issues320 (320) | https://github.com/coder/coder/issues |
| Pull requests468 (468) | https://github.com/coder/coder/pulls |
| Discussions | https://github.com/coder/coder/discussions |
| Actions | https://github.com/coder/coder/actions |
| Projects | https://github.com/coder/coder/projects |
| Security and quality49 (49) | https://github.com/coder/coder/security |
| Insights | https://github.com/coder/coder/insights |
| https://github.com/coder/coder |
| ibetitsmike | https://github.com/ibetitsmike |
| main | https://github.com/coder/coder/tree/main |
| mike/read-skill-file-symlink-containment | https://github.com/coder/coder/tree/mike/read-skill-file-symlink-containment |
| Conversation | https://github.com/coder/coder/pull/31462 |
| Commits10 (10) | https://github.com/coder/coder/pull/31462/commits |
| Checks | https://github.com/coder/coder/pull/31462/checks |
| Files changed | https://github.com/coder/coder/pull/31462/files |
| fix: confine read_skill_file reads to the skill directory | https://github.com/coder/coder/pull/31462#top |
| ibetitsmike | https://github.com/ibetitsmike |
| main | https://github.com/coder/coder/tree/main |
| mike/read-skill-file-symlink-containment | https://github.com/coder/coder/tree/mike/read-skill-file-symlink-containment |
|
| https://github.com/ibetitsmike |
| ibetitsmike | https://github.com/ibetitsmike |
| Oct 28, 2026 | https://github.com/coder/coder/pull/31462#issue-6087670615 |
| Please reload this page | https://github.com/coder/coder/pull/31462 |
| 132c7be | https://github.com/coder/coder/commit/132c7bed668814d6a201cc239f661a886cfb086b |
| Please reload this page | https://github.com/coder/coder/pull/31462 |
| ibetitsmike | https://github.com/ibetitsmike |
| October 28, 2026 19:12 | https://github.com/coder/coder/pull/31462#commits-pushed-0103705 |
|
| https://github.com/ibetitsmike |
| fix(coderd/x/chatd/chattool): refuse skill files that resolve outside… | https://github.com/coder/coder/pull/31462/commits/01037053e0ba14d5668d913784660f27abbf2a30 |
| 0103705 | https://github.com/coder/coder/pull/31462/commits/01037053e0ba14d5668d913784660f27abbf2a30 |
|
| https://github.com/ibetitsmike |
| fix: confine read_skill_file to the skill directory in the workspace … | https://github.com/coder/coder/pull/31462/commits/132c7bed668814d6a201cc239f661a886cfb086b |
| 132c7be | https://github.com/coder/coder/pull/31462/commits/132c7bed668814d6a201cc239f661a886cfb086b |
|
| https://github.com/ibetitsmike |
| test(coderd/x/chatd/chattool): drop duplicate skill file refusal test | https://github.com/coder/coder/pull/31462/commits/af43ca8e6b569e9e9657ac0b60748373c2dfcf89 |
| af43ca8 | https://github.com/coder/coder/pull/31462/commits/af43ca8e6b569e9e9657ac0b60748373c2dfcf89 |
|
| https://github.com/ibetitsmike |
| test(codersdk/workspacesdk): cover ReadFileInRoot against the agent r… | https://github.com/coder/coder/pull/31462/commits/90cf106db9d4f836fca7dc652c13203b52e67401 |
| 90cf106 | https://github.com/coder/coder/pull/31462/commits/90cf106db9d4f836fca7dc652c13203b52e67401 |
|
| https://github.com/ibetitsmike |
| docs(docs/ai-coder/agents): clarify which skill file symlinks read_sk… | https://github.com/coder/coder/pull/31462/commits/3a15aff61edee38b74b3c58cb7452453690951f1 |
| 3a15aff | https://github.com/coder/coder/pull/31462/commits/3a15aff61edee38b74b3c58cb7452453690951f1 |
| https://github.com/apps/linear-code |
| linear-code | https://github.com/apps/linear-code |
| Oct 28, 2026 | https://github.com/coder/coder/pull/31462#issuecomment-6480937853 |
| CODAGT-1496 | https://linear.app/codercom/issue/CODAGT-1496 |
| Please reload this page | https://github.com/coder/coder/pull/31462 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Oct 28, 2026 | https://github.com/coder/coder/pull/31462#issuecomment-6480940175 |
| docs/ai-coder/agents/extending-agents.md | https://coder.com/docs/@mike%2Fread-skill-file-symlink-containment/ai-coder/agents/extending-agents |
| Please reload this page | https://github.com/coder/coder/pull/31462 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| ibetitsmike | https://github.com/ibetitsmike |
| Oct 28, 2026 | https://github.com/coder/coder/pull/31462#event-34521340142 |
| https://github.com/ibetitsmike |
| ibetitsmike | https://github.com/ibetitsmike |
| Oct 28, 2026 | https://github.com/coder/coder/pull/31462#issuecomment-6480941952 |
| @codex | https://github.com/codex |
| Please reload this page | https://github.com/coder/coder/pull/31462 |
| https://github.com/apps/chatgpt-codex-connector |
| chatgpt-codex-connector | https://github.com/apps/chatgpt-codex-connector |
| Oct 28, 2026 | https://github.com/coder/coder/pull/31462#issuecomment-6480947459 |
| Please reload this page | https://github.com/coder/coder/pull/31462 |
| Your team has set up Codex to review pull requests in this repo | https://chatgpt.com/codex/cloud/settings/general |
| @codex | https://github.com/codex |
| @codex | https://github.com/codex |
| Please reload this page | https://github.com/coder/coder/pull/31462 |
| https://github.com/apps/chatgpt-codex-connector |
| chatgpt-codex-connector | https://github.com/apps/chatgpt-codex-connector |
| Oct 28, 2026 | https://github.com/coder/coder/pull/31462#issuecomment-6480982809 |
| Your team has set up Codex to review pull requests in this repo | https://chatgpt.com/codex/cloud/settings/general |
| @codex | https://github.com/codex |
| @codex | https://github.com/codex |
| Please reload this page | https://github.com/coder/coder/pull/31462 |
| https://github.com/ibetitsmike |
| ibetitsmike | https://github.com/ibetitsmike |
| Oct 28, 2026 | https://github.com/coder/coder/pull/31462#issuecomment-6481705165 |
| @codex | https://github.com/codex |
| Please reload this page | https://github.com/coder/coder/pull/31462 |
| https://github.com/apps/chatgpt-codex-connector |
| chatgpt-codex-connector | https://github.com/apps/chatgpt-codex-connector |
| Oct 28, 2026 | https://github.com/coder/coder/pull/31462#issuecomment-6481785961 |
| View security finding report | https://chatgpt.com/codex/cloud/tasks/task_b_6ae26fff7f688329aba8fbdb44d5044e |
| @codex | https://github.com/codex |
| @codex | https://github.com/codex |
| Please reload this page | https://github.com/coder/coder/pull/31462 |
| https://github.com/ibetitsmike |
| ibetitsmike | https://github.com/ibetitsmike |
|
Oct 28, 2026
| https://github.com/coder/coder/pull/31462#pullrequestreview-5690766531 |
|
View reviewed changes
| https://github.com/coder/coder/pull/31462/files/3a15aff61edee38b74b3c58cb7452453690951f1 |
| ibetitsmike | https://github.com/ibetitsmike |
| https://github.com/coder/coder/pull/31462#pullrequestreview-5690766531 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/31462 |
| agent/agentfiles/files.go | https://github.com/coder/coder/pull/31462/files/3a15aff61edee38b74b3c58cb7452453690951f1#diff-06f7f86a3d81160c8bb0b76bd59c31cfcfaf059beda6ca6a2623a4bf6a4435b4 |
| Please reload this page | https://github.com/coder/coder/pull/31462 |
| agent/agentfiles/files.go | https://github.com/coder/coder/pull/31462/files/3a15aff61edee38b74b3c58cb7452453690951f1#diff-06f7f86a3d81160c8bb0b76bd59c31cfcfaf059beda6ca6a2623a4bf6a4435b4 |
| ibetitsmike | https://github.com/ibetitsmike |
| Oct 28, 2026 | https://github.com/coder/coder/pull/31462#discussion_r4406948498 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/31462 |
| ibetitsmike | https://github.com/ibetitsmike |
| Oct 28, 2026 | https://github.com/coder/coder/pull/31462#discussion_r4407160243 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/31462 |
| coderd/x/chatd/chattool/skill.go | https://github.com/coder/coder/pull/31462/files/3a15aff61edee38b74b3c58cb7452453690951f1#diff-37e468454bbdcfdc10afd485d397409fe21701ec3dd81f1771a2fb4b67cd0ec6 |
| Please reload this page | https://github.com/coder/coder/pull/31462 |
|
| https://github.com/ibetitsmike |
| fix(coderd/x/chatd/chattool): clarify skill file read errors for the … | https://github.com/coder/coder/pull/31462/commits/bdfa1ed9bcbc61cba329cfa2b0bd497ae2d74815 |
| bdfa1ed | https://github.com/coder/coder/pull/31462/commits/bdfa1ed9bcbc61cba329cfa2b0bd497ae2d74815 |
| https://github.com/ibetitsmike |
| ibetitsmike | https://github.com/ibetitsmike |
| October 28, 2026 23:30 | https://github.com/coder/coder/pull/31462#event-34531100532 |
| https://github.com/apps/pr-queue-manager |
| pr-queue-manager | https://github.com/apps/pr-queue-manager |
| ethanndickson | https://github.com/ethanndickson |
| hugodutka | https://github.com/hugodutka |
| hugodutka | https://github.com/hugodutka |
| October 28, 2026 23:32 | https://github.com/coder/coder/pull/31462#event-34531199407 |
| ethanndickson | https://github.com/ethanndickson |
| October 29, 2026 07:31 | https://github.com/coder/coder/pull/31462#commits-pushed-64d7d9c |
|
| https://github.com/ethanndickson |
| fix: refuse a read-file root that is a symlink | https://github.com/coder/coder/pull/31462/commits/64d7d9ce7947ab10cc0598116505a8a5d0ecb43b |
| 64d7d9c | https://github.com/coder/coder/pull/31462/commits/64d7d9ce7947ab10cc0598116505a8a5d0ecb43b |
|
| https://github.com/ethanndickson |
| docs(docs/ai-coder/agents): note that read_skill_file refuses a symli… | https://github.com/coder/coder/pull/31462/commits/b4f48fe8131fe46ea4862e336f97b165c9157eba |
| b4f48fe | https://github.com/coder/coder/pull/31462/commits/b4f48fe8131fe46ea4862e336f97b165c9157eba |
|
| https://github.com/ethanndickson |
| docs(docs/ai-coder/agents): remove the symlinked skill directory note | https://github.com/coder/coder/pull/31462/commits/e01507e49d1ed39cab54078f79df3acb32221a38 |
| e01507e | https://github.com/coder/coder/pull/31462/commits/e01507e49d1ed39cab54078f79df3acb32221a38 |
| https://github.com/ethanndickson |
| ethanndickson | https://github.com/ethanndickson |
| Oct 29, 2026 | https://github.com/coder/coder/pull/31462#issuecomment-6491048015 |
| @codex | https://github.com/codex |
| Please reload this page | https://github.com/coder/coder/pull/31462 |
| https://github.com/ethanndickson |
| ethanndickson | https://github.com/ethanndickson |
| Oct 29, 2026 | https://github.com/coder/coder/pull/31462#issuecomment-6491049830 |
| @codex | https://github.com/codex |
| Please reload this page | https://github.com/coder/coder/pull/31462 |
| https://github.com/apps/chatgpt-codex-connector |
| chatgpt-codex-connector | https://github.com/apps/chatgpt-codex-connector |
| Oct 29, 2026 | https://github.com/coder/coder/pull/31462#issuecomment-6491081635 |
| Your team has set up Codex to review pull requests in this repo | https://chatgpt.com/codex/cloud/settings/general |
| @codex | https://github.com/codex |
| @codex | https://github.com/codex |
| Please reload this page | https://github.com/coder/coder/pull/31462 |
| https://github.com/apps/chatgpt-codex-connector |
| chatgpt-codex-connector | https://github.com/apps/chatgpt-codex-connector |
| Oct 29, 2026 | https://github.com/coder/coder/pull/31462#issuecomment-6491111871 |
| View security finding report | https://chatgpt.com/codex/cloud/tasks/task_b_6ae2fa5ab384832cbc35db4f10c9b083 |
| @codex | https://github.com/codex |
| @codex | https://github.com/codex |
| Please reload this page | https://github.com/coder/coder/pull/31462 |
|
| https://github.com/ethanndickson |
| docs(docs/ai-coder/agents): drop the absolute symlink line from read_… | https://github.com/coder/coder/pull/31462/commits/bfbd99e17615ae997bb928efd08916077c4f84e4 |
| bfbd99e | https://github.com/coder/coder/pull/31462/commits/bfbd99e17615ae997bb928efd08916077c4f84e4 |
| https://github.com/ethanndickson |
| ethanndickson | https://github.com/ethanndickson |
|
Oct 29, 2026
| https://github.com/coder/coder/pull/31462#pullrequestreview-5694700597 |
|
View reviewed changes
| https://github.com/coder/coder/pull/31462/files/bfbd99e17615ae997bb928efd08916077c4f84e4 |
| https://github.com/ibetitsmike |
| ibetitsmike | https://github.com/ibetitsmike |
| f10eabb | https://github.com/coder/coder/commit/f10eabbb0cb68a5e7d1c9934aa8182c17620a6e9 |
| Oct 29, 2026 | https://github.com/coder/coder/pull/31462#event-34567193221 |
| Please reload this page | https://github.com/coder/coder/pull/31462 |
| https://github.com/ibetitsmike |
| ibetitsmike | https://github.com/ibetitsmike |
| October 29, 2026 09:18 | https://github.com/coder/coder/pull/31462#event-34567197910 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Oct 29, 2026 | https://github.com/coder/coder/pull/31462#event-34567206531 |
| https://github.com/apps/coder |
| coder | https://github.com/apps/coder |
|
backport
| https://github.com/coder/coder/issues?q=state%3Aopen%20label%3Abackport |
| Oct 29, 2026 | https://github.com/coder/coder/pull/31462#event-34594483992 |
| https://github.co/hiddenchars |
| https://github.com/coder/coder/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F31462 |
|
| https://github.com/ethanndickson |
|
ethanndickson
| https://github.com/ethanndickson |
|
| https://github.com/coder/coder/pull/31462/files/bfbd99e17615ae997bb928efd08916077c4f84e4 |
| Please reload this page | https://github.com/coder/coder/pull/31462 |
|
| https://github.com/ibetitsmike |
|
ibetitsmike
| https://github.com/ibetitsmike |
|
backport
| https://github.com/coder/coder/issues?q=state%3Aopen%20label%3Abackport |
| Please reload this page | https://github.com/coder/coder/pull/31462 |
|
| https://github.com/ibetitsmike |
|
| https://github.com/ethanndickson |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |