René's URL Explorer Experiment


Title: fix: confine read_skill_file reads to the skill directory by ibetitsmike · Pull Request #31462 · coder/coder · GitHub

Open Graph Title: fix: confine read_skill_file reads to the skill directory by ibetitsmike · Pull Request #31462 · coder/coder

X Title: fix: confine read_skill_file reads to the skill directory by ibetitsmike · Pull Request #31462 · coder/coder

Description: Secure environments for developers and their agents - fix: confine read_skill_file reads to the skill directory by ibetitsmike · Pull Request #31462 · coder/coder

Open Graph Description: Xum opened this PR for Mike. read_skill_file checked the requested path lexically, then read <skill dir>/<path> through the agent's general file reader, which follows symlinks. A s...

X Description: Xum opened this PR for Mike. read_skill_file checked the requested path lexically, then read &lt;skill dir&gt;/&lt;path&gt; through the agent&#39;s general file reader, which f...

Opengraph URL: https://github.com/coder/coder/pull/31462

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ea948928-b7ae-d824-598e-ffa386168157
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9B80:363D8E:1CE026D:24AF59A:6B014371
html-safe-nonced2e2dbc2d3f5920137aa640f53f48fcaa5e917655b36f5a72c7c938a35dfcba5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QjgwOjM2M0Q4RToxQ0UwMjZEOjI0QUY1OUE6NkIwMTQzNzEiLCJ2aXNpdG9yX2lkIjoiNDE1Mjc0NTQ2NDQ0NzQ1MjAxNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac74af4b6e5a89dcfea05a6ee218549e92efa5aa750f1001e64c97de91ed469426
hovercard-subject-tagpull_request:5057858493
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/31462/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8f96db3b59b51e3ea55c79092e0815f27647e1f81705c0d6f785162f11ecd921/coder/coder/pull/31462
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8f96db3b59b51e3ea55c79092e0815f27647e1f81705c0d6f785162f11ecd921/coder/coder/pull/31462
og:image:altXum opened this PR for Mike. read_skill_file checked the requested path lexically, then read <skill dir>/<path> through the agent's general file reader, which follows symlinks. A s...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameibetitsmike
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/coder/coder/pull/31462#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F31462
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F31462
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/pull/31462
Reloadhttps://github.com/coder/coder/pull/31462
Reloadhttps://github.com/coder/coder/pull/31462
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests468 (468)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
https://github.com/coder/coder
ibetitsmikehttps://github.com/ibetitsmike
mainhttps://github.com/coder/coder/tree/main
mike/read-skill-file-symlink-containmenthttps://github.com/coder/coder/tree/mike/read-skill-file-symlink-containment
Conversationhttps://github.com/coder/coder/pull/31462
Commits10 (10)https://github.com/coder/coder/pull/31462/commits
Checkshttps://github.com/coder/coder/pull/31462/checks
Files changedhttps://github.com/coder/coder/pull/31462/files
fix: confine read_skill_file reads to the skill directoryhttps://github.com/coder/coder/pull/31462#top
ibetitsmikehttps://github.com/ibetitsmike
mainhttps://github.com/coder/coder/tree/main
mike/read-skill-file-symlink-containmenthttps://github.com/coder/coder/tree/mike/read-skill-file-symlink-containment
https://github.com/ibetitsmike
ibetitsmikehttps://github.com/ibetitsmike
Oct 28, 2026https://github.com/coder/coder/pull/31462#issue-6087670615
Please reload this pagehttps://github.com/coder/coder/pull/31462
132c7behttps://github.com/coder/coder/commit/132c7bed668814d6a201cc239f661a886cfb086b
Please reload this pagehttps://github.com/coder/coder/pull/31462
ibetitsmikehttps://github.com/ibetitsmike
October 28, 2026 19:12https://github.com/coder/coder/pull/31462#commits-pushed-0103705
https://github.com/ibetitsmike
fix(coderd/x/chatd/chattool): refuse skill files that resolve outside…https://github.com/coder/coder/pull/31462/commits/01037053e0ba14d5668d913784660f27abbf2a30
0103705https://github.com/coder/coder/pull/31462/commits/01037053e0ba14d5668d913784660f27abbf2a30
https://github.com/ibetitsmike
fix: confine read_skill_file to the skill directory in the workspace …https://github.com/coder/coder/pull/31462/commits/132c7bed668814d6a201cc239f661a886cfb086b
132c7behttps://github.com/coder/coder/pull/31462/commits/132c7bed668814d6a201cc239f661a886cfb086b
https://github.com/ibetitsmike
test(coderd/x/chatd/chattool): drop duplicate skill file refusal testhttps://github.com/coder/coder/pull/31462/commits/af43ca8e6b569e9e9657ac0b60748373c2dfcf89
af43ca8https://github.com/coder/coder/pull/31462/commits/af43ca8e6b569e9e9657ac0b60748373c2dfcf89
https://github.com/ibetitsmike
test(codersdk/workspacesdk): cover ReadFileInRoot against the agent r…https://github.com/coder/coder/pull/31462/commits/90cf106db9d4f836fca7dc652c13203b52e67401
90cf106https://github.com/coder/coder/pull/31462/commits/90cf106db9d4f836fca7dc652c13203b52e67401
https://github.com/ibetitsmike
docs(docs/ai-coder/agents): clarify which skill file symlinks read_sk…https://github.com/coder/coder/pull/31462/commits/3a15aff61edee38b74b3c58cb7452453690951f1
3a15affhttps://github.com/coder/coder/pull/31462/commits/3a15aff61edee38b74b3c58cb7452453690951f1
https://github.com/apps/linear-code
linear-codehttps://github.com/apps/linear-code
Oct 28, 2026https://github.com/coder/coder/pull/31462#issuecomment-6480937853
CODAGT-1496https://linear.app/codercom/issue/CODAGT-1496
Please reload this pagehttps://github.com/coder/coder/pull/31462
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 28, 2026https://github.com/coder/coder/pull/31462#issuecomment-6480940175
docs/ai-coder/agents/extending-agents.mdhttps://coder.com/docs/@mike%2Fread-skill-file-symlink-containment/ai-coder/agents/extending-agents
Please reload this pagehttps://github.com/coder/coder/pull/31462
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
ibetitsmikehttps://github.com/ibetitsmike
Oct 28, 2026https://github.com/coder/coder/pull/31462#event-34521340142
https://github.com/ibetitsmike
ibetitsmikehttps://github.com/ibetitsmike
Oct 28, 2026https://github.com/coder/coder/pull/31462#issuecomment-6480941952
@codexhttps://github.com/codex
Please reload this pagehttps://github.com/coder/coder/pull/31462
https://github.com/apps/chatgpt-codex-connector
chatgpt-codex-connectorhttps://github.com/apps/chatgpt-codex-connector
Oct 28, 2026https://github.com/coder/coder/pull/31462#issuecomment-6480947459
Please reload this pagehttps://github.com/coder/coder/pull/31462
Your team has set up Codex to review pull requests in this repohttps://chatgpt.com/codex/cloud/settings/general
@codexhttps://github.com/codex
@codexhttps://github.com/codex
Please reload this pagehttps://github.com/coder/coder/pull/31462
https://github.com/apps/chatgpt-codex-connector
chatgpt-codex-connectorhttps://github.com/apps/chatgpt-codex-connector
Oct 28, 2026https://github.com/coder/coder/pull/31462#issuecomment-6480982809
Your team has set up Codex to review pull requests in this repohttps://chatgpt.com/codex/cloud/settings/general
@codexhttps://github.com/codex
@codexhttps://github.com/codex
Please reload this pagehttps://github.com/coder/coder/pull/31462
https://github.com/ibetitsmike
ibetitsmikehttps://github.com/ibetitsmike
Oct 28, 2026https://github.com/coder/coder/pull/31462#issuecomment-6481705165
@codexhttps://github.com/codex
Please reload this pagehttps://github.com/coder/coder/pull/31462
https://github.com/apps/chatgpt-codex-connector
chatgpt-codex-connectorhttps://github.com/apps/chatgpt-codex-connector
Oct 28, 2026https://github.com/coder/coder/pull/31462#issuecomment-6481785961
View security finding reporthttps://chatgpt.com/codex/cloud/tasks/task_b_6ae26fff7f688329aba8fbdb44d5044e
@codexhttps://github.com/codex
@codexhttps://github.com/codex
Please reload this pagehttps://github.com/coder/coder/pull/31462
https://github.com/ibetitsmike
ibetitsmikehttps://github.com/ibetitsmike
Oct 28, 2026 https://github.com/coder/coder/pull/31462#pullrequestreview-5690766531
View reviewed changes https://github.com/coder/coder/pull/31462/files/3a15aff61edee38b74b3c58cb7452453690951f1
ibetitsmikehttps://github.com/ibetitsmike
https://github.com/coder/coder/pull/31462#pullrequestreview-5690766531
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/31462
agent/agentfiles/files.gohttps://github.com/coder/coder/pull/31462/files/3a15aff61edee38b74b3c58cb7452453690951f1#diff-06f7f86a3d81160c8bb0b76bd59c31cfcfaf059beda6ca6a2623a4bf6a4435b4
Please reload this pagehttps://github.com/coder/coder/pull/31462
agent/agentfiles/files.gohttps://github.com/coder/coder/pull/31462/files/3a15aff61edee38b74b3c58cb7452453690951f1#diff-06f7f86a3d81160c8bb0b76bd59c31cfcfaf059beda6ca6a2623a4bf6a4435b4
ibetitsmikehttps://github.com/ibetitsmike
Oct 28, 2026https://github.com/coder/coder/pull/31462#discussion_r4406948498
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/31462
ibetitsmikehttps://github.com/ibetitsmike
Oct 28, 2026https://github.com/coder/coder/pull/31462#discussion_r4407160243
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/31462
coderd/x/chatd/chattool/skill.gohttps://github.com/coder/coder/pull/31462/files/3a15aff61edee38b74b3c58cb7452453690951f1#diff-37e468454bbdcfdc10afd485d397409fe21701ec3dd81f1771a2fb4b67cd0ec6
Please reload this pagehttps://github.com/coder/coder/pull/31462
https://github.com/ibetitsmike
fix(coderd/x/chatd/chattool): clarify skill file read errors for the …https://github.com/coder/coder/pull/31462/commits/bdfa1ed9bcbc61cba329cfa2b0bd497ae2d74815
bdfa1edhttps://github.com/coder/coder/pull/31462/commits/bdfa1ed9bcbc61cba329cfa2b0bd497ae2d74815
https://github.com/ibetitsmike
ibetitsmikehttps://github.com/ibetitsmike
October 28, 2026 23:30https://github.com/coder/coder/pull/31462#event-34531100532
https://github.com/apps/pr-queue-manager
pr-queue-managerhttps://github.com/apps/pr-queue-manager
ethanndicksonhttps://github.com/ethanndickson
hugodutkahttps://github.com/hugodutka
hugodutkahttps://github.com/hugodutka
October 28, 2026 23:32https://github.com/coder/coder/pull/31462#event-34531199407
ethanndicksonhttps://github.com/ethanndickson
October 29, 2026 07:31https://github.com/coder/coder/pull/31462#commits-pushed-64d7d9c
https://github.com/ethanndickson
fix: refuse a read-file root that is a symlinkhttps://github.com/coder/coder/pull/31462/commits/64d7d9ce7947ab10cc0598116505a8a5d0ecb43b
64d7d9chttps://github.com/coder/coder/pull/31462/commits/64d7d9ce7947ab10cc0598116505a8a5d0ecb43b
https://github.com/ethanndickson
docs(docs/ai-coder/agents): note that read_skill_file refuses a symli…https://github.com/coder/coder/pull/31462/commits/b4f48fe8131fe46ea4862e336f97b165c9157eba
b4f48fehttps://github.com/coder/coder/pull/31462/commits/b4f48fe8131fe46ea4862e336f97b165c9157eba
https://github.com/ethanndickson
docs(docs/ai-coder/agents): remove the symlinked skill directory notehttps://github.com/coder/coder/pull/31462/commits/e01507e49d1ed39cab54078f79df3acb32221a38
e01507ehttps://github.com/coder/coder/pull/31462/commits/e01507e49d1ed39cab54078f79df3acb32221a38
https://github.com/ethanndickson
ethanndicksonhttps://github.com/ethanndickson
Oct 29, 2026https://github.com/coder/coder/pull/31462#issuecomment-6491048015
@codexhttps://github.com/codex
Please reload this pagehttps://github.com/coder/coder/pull/31462
https://github.com/ethanndickson
ethanndicksonhttps://github.com/ethanndickson
Oct 29, 2026https://github.com/coder/coder/pull/31462#issuecomment-6491049830
@codexhttps://github.com/codex
Please reload this pagehttps://github.com/coder/coder/pull/31462
https://github.com/apps/chatgpt-codex-connector
chatgpt-codex-connectorhttps://github.com/apps/chatgpt-codex-connector
Oct 29, 2026https://github.com/coder/coder/pull/31462#issuecomment-6491081635
Your team has set up Codex to review pull requests in this repohttps://chatgpt.com/codex/cloud/settings/general
@codexhttps://github.com/codex
@codexhttps://github.com/codex
Please reload this pagehttps://github.com/coder/coder/pull/31462
https://github.com/apps/chatgpt-codex-connector
chatgpt-codex-connectorhttps://github.com/apps/chatgpt-codex-connector
Oct 29, 2026https://github.com/coder/coder/pull/31462#issuecomment-6491111871
View security finding reporthttps://chatgpt.com/codex/cloud/tasks/task_b_6ae2fa5ab384832cbc35db4f10c9b083
@codexhttps://github.com/codex
@codexhttps://github.com/codex
Please reload this pagehttps://github.com/coder/coder/pull/31462
https://github.com/ethanndickson
docs(docs/ai-coder/agents): drop the absolute symlink line from read_…https://github.com/coder/coder/pull/31462/commits/bfbd99e17615ae997bb928efd08916077c4f84e4
bfbd99ehttps://github.com/coder/coder/pull/31462/commits/bfbd99e17615ae997bb928efd08916077c4f84e4
https://github.com/ethanndickson
ethanndicksonhttps://github.com/ethanndickson
Oct 29, 2026 https://github.com/coder/coder/pull/31462#pullrequestreview-5694700597
View reviewed changes https://github.com/coder/coder/pull/31462/files/bfbd99e17615ae997bb928efd08916077c4f84e4
https://github.com/ibetitsmike
ibetitsmikehttps://github.com/ibetitsmike
f10eabbhttps://github.com/coder/coder/commit/f10eabbb0cb68a5e7d1c9934aa8182c17620a6e9
Oct 29, 2026https://github.com/coder/coder/pull/31462#event-34567193221
Please reload this pagehttps://github.com/coder/coder/pull/31462
https://github.com/ibetitsmike
ibetitsmikehttps://github.com/ibetitsmike
October 29, 2026 09:18https://github.com/coder/coder/pull/31462#event-34567197910
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 29, 2026https://github.com/coder/coder/pull/31462#event-34567206531
https://github.com/apps/coder
coderhttps://github.com/apps/coder
backport https://github.com/coder/coder/issues?q=state%3Aopen%20label%3Abackport
Oct 29, 2026https://github.com/coder/coder/pull/31462#event-34594483992
https://github.co/hiddenchars
https://github.com/coder/coder/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F31462
https://github.com/ethanndickson
ethanndickson https://github.com/ethanndickson
https://github.com/coder/coder/pull/31462/files/bfbd99e17615ae997bb928efd08916077c4f84e4
Please reload this pagehttps://github.com/coder/coder/pull/31462
https://github.com/ibetitsmike
ibetitsmike https://github.com/ibetitsmike
backport https://github.com/coder/coder/issues?q=state%3Aopen%20label%3Abackport
Please reload this pagehttps://github.com/coder/coder/pull/31462
https://github.com/ibetitsmike
https://github.com/ethanndickson
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.