René's URL Explorer Experiment


Title: perf(site/src/pages/AgentsPage/components): avoid descendant :focus-within selectors by mafredri · Pull Request #31366 · coder/coder · GitHub

Open Graph Title: perf(site/src/pages/AgentsPage/components): avoid descendant :focus-within selectors by mafredri · Pull Request #31366 · coder/coder

X Title: perf(site/src/pages/AgentsPage/components): avoid descendant :focus-within selectors by mafredri · Pull Request #31366 · coder/coder

Description: Base: #31365 (perf/chat-code-block-scroll). Third of five stacked fixes. In WebKit, each A:focus-within B rule restyles every ancestor's subtree on each focus change. Tailwind's group-focus-within on the attachment overlays makes 3 such rules, and monaco's stylesheet, which #31367 stops loading, holds 18 (4 before #31663). With monaco 0.55.1 on an earlier 60k-node page, deleting those 3 cut idle focus from 238 to 145 ms, and all 7 to 12 ms. The composer's attachment card and the transcript's attachment frame now style their buttons through custom properties on their own hover and subject-position focus-within, so focus on any control of an attachment shows all of them. Paste inline and Remove keep main's opacity-only hiding and DOM positions: they stay in the tab order in both directions, and the upload overlay still paints over Paste inline and under Remove. A --actions-pointer-events variable blocks their pointer input while hidden, so hovering a hidden button's overhang no longer shows them. The transcript's Download link now hides the same way instead of main's visibility, so Shift+Tab reaches it, and its blur applies only while it shows, so hidden links add no compositing layers, where on main WebKit gave each hidden link one. Devices without hover now show the composer's buttons, as the transcript already did. #31278 bench (a tool, not for merging), production builds of the pre-rebase versions of 2d657a137f (base) and 23da06724b (this PR), both on main at eba39ae252 with monaco 0.55.1: 2 long chats, 139k nodes, 3 alternating runs. idle focus, pointer p50 base this PR WebKit 1,044 to 1,060 ms 645 to 725 ms Chromium (within noise) 7 to 18 ms 13 to 17 ms 🤖 This PR was created with the help of Coder Agents, and will be reviewed by a human. 🏂🏻

Open Graph Description: Base: #31365 (perf/chat-code-block-scroll). Third of five stacked fixes. In WebKit, each A:focus-within B rule restyles every ancestor's subtree on each focus change. Tailwind's group-focus...

X Description: Base: #31365 (perf/chat-code-block-scroll). Third of five stacked fixes. In WebKit, each A:focus-within B rule restyles every ancestor's subtree on each focus change. Tailwind's gro...

Opengraph URL: https://github.com/coder/coder/pull/31366

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:84f3fb71-e191-d191-281b-7b6bda6355a0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC07A:EA09B:247F2AB:3061119:6B019769
html-safe-nonce0a0ea9bfba14fa656e3cd940aaac5aae6388370212318fb0265d6f3fa2a59841
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMDdBOkVBMDlCOjI0N0YyQUI6MzA2MTExOTo2QjAxOTc2OSIsInZpc2l0b3JfaWQiOiI3MTIwNTkwOTM0MjUyODIwMzI5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac42b67c1744510f5a1696a51f7960a39a236a007c3e6db7322ea14c9f5894dc30
hovercard-subject-tagpull_request:5038576911
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/coder/coder/pull/31366/files
twitter:imagehttps://avatars.githubusercontent.com/u/147409?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/147409?s=400&v=4
og:image:altBase: #31365 (perf/chat-code-block-scroll). Third of five stacked fixes. In WebKit, each A:focus-within B rule restyles every ancestor's subtree on each focus change. Tailwind's group-focus...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/coder/coder/pull/31366/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F31366%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F31366%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/pull/31366/files
Reloadhttps://github.com/coder/coder/pull/31366/files
Reloadhttps://github.com/coder/coder/pull/31366/files
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fcoder%2Fcoder%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fcoder%2Fcoder%2Fissues%2Fnew%2Fchoose
mafredrihttps://github.com/mafredri
perf/chat-code-block-scrollhttps://github.com/coder/coder/tree/perf/chat-code-block-scroll
perf/chat-focus-withinhttps://github.com/coder/coder/tree/perf/chat-focus-within
Conversation 57 https://github.com/coder/coder/pull/31366
Commits 16 https://github.com/coder/coder/pull/31366/commits
Checks 30 https://github.com/coder/coder/pull/31366/checks
Files changed 4 https://github.com/coder/coder/pull/31366/files
perf(site/src/pages/AgentsPage/components): avoid descendant :focus-within selectors https://github.com/coder/coder/pull/31366/files#top
Show all changes 16 commits https://github.com/coder/coder/pull/31366/files
c2ecaf2 perf(site): avoid descendant :focus-within selectors mafredri Oct 26, 2026 https://github.com/coder/coder/pull/31366/commits/c2ecaf2d15c2c67c2234676ebb30dadae7f7de91
413356e fix(site/src/pages/AgentsPage/components): paint the upload overlay o… mafredri Oct 27, 2026 https://github.com/coder/coder/pull/31366/commits/413356e1ddaeceb8ece8221d70700b8e88bcda2b
82a60dd test(site/src/pages/AgentsPage/components): leave overlay visibility … mafredri Oct 27, 2026 https://github.com/coder/coder/pull/31366/commits/82a60ddf41937965581eaa0be1da6bd6c877c517
3f6c8fc fix(site/src/pages/AgentsPage/components/ChatConversation): hide the … mafredri Oct 27, 2026 https://github.com/coder/coder/pull/31366/commits/3f6c8fcdf3e4f8e6d3a46d699fdc364ba8b14799
7297b96 test(site/src/pages/AgentsPage/components): capture the card-focus an… mafredri Oct 27, 2026 https://github.com/coder/coder/pull/31366/commits/7297b9636e4365564ca0d4d666e9fae771d6c9d7
9627b9a fix(site/src/pages/AgentsPage/components): show attachment buttons fr… mafredri Oct 27, 2026 https://github.com/coder/coder/pull/31366/commits/9627b9a1e40ee71222471c632a7474573e6b1914
92cf177 test(site/src/pages/AgentsPage/components): write the focus stories p… mafredri Oct 27, 2026 https://github.com/coder/coder/pull/31366/commits/92cf17719fb4e2e113bd4bb78f068b5ea9971dd4
02fb818 docs(site/src/pages/AgentsPage/components): shorten the attachment vi… mafredri Oct 27, 2026 https://github.com/coder/coder/pull/31366/commits/02fb8185905fefaae7b7fc4d0642e78c0353477a
5389e59 test(site/src/pages/AgentsPage/components): tab without waiting for a… mafredri Oct 27, 2026 https://github.com/coder/coder/pull/31366/commits/5389e59616842d24e706a94c868e3736e89f15ba
de4b302 fix(site/src/pages/AgentsPage/components): keep hidden attachment but… mafredri Oct 27, 2026 https://github.com/coder/coder/pull/31366/commits/de4b302ea24420f2c43343a81945431a4930fa08
20210dc test(site/src/pages/AgentsPage/components): leave focus order to the … mafredri Oct 27, 2026 https://github.com/coder/coder/pull/31366/commits/20210dcdbe289af2956f3c510ab7d0b24b13b837
c5a2590 docs(site/src/pages/AgentsPage/components): name the rule the attachm… mafredri Oct 27, 2026 https://github.com/coder/coder/pull/31366/commits/c5a25907e6e09f671793543a81c1378cdeee1738
ee9ed7e test(site/src/pages/AgentsPage/components): capture the transcript im… mafredri Oct 27, 2026 https://github.com/coder/coder/pull/31366/commits/ee9ed7e41e3a5e2343061c08898221385c123c84
446c78e fix(site/src/pages/AgentsPage/components): keep the hidden download l… mafredri Oct 27, 2026 https://github.com/coder/coder/pull/31366/commits/446c78e670c2d9cc2c1a24b299842f38ea80be93
30d26d3 perf(site/src/pages/AgentsPage/components): blur the download link on… mafredri Oct 27, 2026 https://github.com/coder/coder/pull/31366/commits/30d26d37dd198feef77db69146a270ae0ddb3c2d
23da067 fix(site/src/pages/AgentsPage/components): fade the Download link's blur mafredri Oct 27, 2026 https://github.com/coder/coder/pull/31366/commits/23da06724b8030e972335828a0dac858985fc761
Clear filters https://github.com/coder/coder/pull/31366/files
Please reload this pagehttps://github.com/coder/coder/pull/31366/files
Please reload this pagehttps://github.com/coder/coder/pull/31366/files
AttachmentPreview.stories.tsx https://github.com/coder/coder/pull/31366/files#diff-3610dea0fdba7999f9e71446f42f0184b1f5d503b57f434cc9f5697bbbe3c4fb
AttachmentPreview.tsx https://github.com/coder/coder/pull/31366/files#diff-6eb480b4cd4f82b8843610bb7b4e880b7d77772353b63668686e1baf7a2bbfad
AttachmentBlocks.tsx https://github.com/coder/coder/pull/31366/files#diff-4408160678af7beabb25fe225be160e28564464c5edaed3105d5ec984ad8d890
ConversationTimeline.stories.tsx https://github.com/coder/coder/pull/31366/files#diff-e2e10262df7706e341d6385100bc196b373ab3065881d97542cb55e4527feff2
https://github.com/coder/coder/blob/main/CODEOWNERS#L31
site/src/pages/AgentsPage/components/AttachmentPreview.stories.tsxhttps://github.com/coder/coder/pull/31366/files#diff-3610dea0fdba7999f9e71446f42f0184b1f5d503b57f434cc9f5697bbbe3c4fb
View file https://github.com/coder/coder/blob/23da06724b8030e972335828a0dac858985fc761/site/src/pages/AgentsPage/components/AttachmentPreview.stories.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/31366/{{ revealButtonHref }}
https://github.com/coder/coder/pull/31366/files#diff-3610dea0fdba7999f9e71446f42f0184b1f5d503b57f434cc9f5697bbbe3c4fb
https://github.com/coder/coder/pull/31366/files#diff-3610dea0fdba7999f9e71446f42f0184b1f5d503b57f434cc9f5697bbbe3c4fb
https://github.com/coder/coder/blob/main/CODEOWNERS#L31
site/src/pages/AgentsPage/components/AttachmentPreview.tsxhttps://github.com/coder/coder/pull/31366/files#diff-6eb480b4cd4f82b8843610bb7b4e880b7d77772353b63668686e1baf7a2bbfad
View file https://github.com/coder/coder/blob/23da06724b8030e972335828a0dac858985fc761/site/src/pages/AgentsPage/components/AttachmentPreview.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/31366/{{ revealButtonHref }}
https://github.com/coder/coder/pull/31366/files#diff-6eb480b4cd4f82b8843610bb7b4e880b7d77772353b63668686e1baf7a2bbfad
Please reload this pagehttps://github.com/coder/coder/pull/31366/files
https://github.com/coder/coder/pull/31366/files#diff-6eb480b4cd4f82b8843610bb7b4e880b7d77772353b63668686e1baf7a2bbfad
https://github.com/coder/coder/pull/31366/files#diff-6eb480b4cd4f82b8843610bb7b4e880b7d77772353b63668686e1baf7a2bbfad
https://github.com/coder/coder/pull/31366/files#diff-6eb480b4cd4f82b8843610bb7b4e880b7d77772353b63668686e1baf7a2bbfad
https://github.com/coder/coder/pull/31366/files#diff-6eb480b4cd4f82b8843610bb7b4e880b7d77772353b63668686e1baf7a2bbfad
https://github.com/coder/coder/pull/31366/files#diff-6eb480b4cd4f82b8843610bb7b4e880b7d77772353b63668686e1baf7a2bbfad
https://github.com/coder/coder/blob/main/CODEOWNERS#L31
site/src/pages/AgentsPage/components/ChatConversation/AttachmentBlocks.tsxhttps://github.com/coder/coder/pull/31366/files#diff-4408160678af7beabb25fe225be160e28564464c5edaed3105d5ec984ad8d890
View file https://github.com/coder/coder/blob/23da06724b8030e972335828a0dac858985fc761/site/src/pages/AgentsPage/components/ChatConversation/AttachmentBlocks.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/31366/{{ revealButtonHref }}
https://github.com/coder/coder/pull/31366/files#diff-4408160678af7beabb25fe225be160e28564464c5edaed3105d5ec984ad8d890
jakehwllhttps://github.com/jakehwll
Nov 17, 2026https://github.com/coder/coder/pull/31366/files#r4594642910
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/31366/files
https://github.com/coder/coder/pull/31366/files#diff-4408160678af7beabb25fe225be160e28564464c5edaed3105d5ec984ad8d890
coder-agents-reviewhttps://github.com/apps/coder-agents-review
Oct 27, 2026https://github.com/coder/coder/pull/31366/files#r4395200188
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
555e1c8https://github.com/coder/coder/commit/555e1c8f5ed51c20f7ce681f3a38fba92656fc21
Please reload this pagehttps://github.com/coder/coder/pull/31366/files
mafredrihttps://github.com/mafredri
Oct 27, 2026https://github.com/coder/coder/pull/31366/files#r4395494519
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/31366/files
Please reload this pagehttps://github.com/coder/coder/pull/31366/files
https://github.com/coder/coder/pull/31366/files#diff-4408160678af7beabb25fe225be160e28564464c5edaed3105d5ec984ad8d890
https://github.com/coder/coder/blob/main/CODEOWNERS#L31
site/src/pages/AgentsPage/components/ChatConversation/ConversationTimeline.stories.tsxhttps://github.com/coder/coder/pull/31366/files#diff-e2e10262df7706e341d6385100bc196b373ab3065881d97542cb55e4527feff2
View file https://github.com/coder/coder/blob/23da06724b8030e972335828a0dac858985fc761/site/src/pages/AgentsPage/components/ChatConversation/ConversationTimeline.stories.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/31366/{{ revealButtonHref }}
https://github.com/coder/coder/pull/31366/files#diff-e2e10262df7706e341d6385100bc196b373ab3065881d97542cb55e4527feff2
Please reload this pagehttps://github.com/coder/coder/pull/31366/files
https://github.com/coder/coder/pull/31366/files#diff-e2e10262df7706e341d6385100bc196b373ab3065881d97542cb55e4527feff2
Please reload this pagehttps://github.com/coder/coder/pull/31366/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.