Title: fix: show each OpenAI reasoning summary title on its own line by mafredri · Pull Request #31349 · coder/coder · GitHub
Open Graph Title: fix: show each OpenAI reasoning summary title on its own line by mafredri · Pull Request #31349 · coder/coder
X Title: fix: show each OpenAI reasoning summary title on its own line by mafredri · Pull Request #31349 · coder/coder
Description: OpenAI reasoning summaries stream as parts that each open with a bold title. Fantasy sent a single "\n" before each part, which Markdown renders as a space, so the chat UI showed every title after the first at the end of the previous paragraph. #30551 stopped the UI from dropping that "\n", but one newline is still not a paragraph break. This moves the fantasy pin to coder/fantasy#67, which sends "\n\n" before every summary part. The first part gets one too: the UI joins adjacent reasoning items into one thinking block, including across web_search calls, and without it the next item's title would follow the previous sentence with no space. Messages saved before this change keep the single newline. The go.mod fork notes gain item 16, which points at the upstream PR, charmbracelet/fantasy#436. Dogfood data behind the leading blank line 7 days of dogfood chat_messages for OpenAI Responses models (openai, and Bedrock openai.*): In every completed reasoning part, the stored text is exactly "\n" + summary[0] + "\n" + summary[1] ..., so fantasy's separator is the only one. All 4,044 summary parts start with **Title**\n\n. No part starts or ends with whitespace. 884 summary parts follow another part of the same item. A blank line between parts fixes these. 355 boundaries in 262 of 2,802 messages are between reasoning items that the UI joins into one block. A blank line only between parts of one item would have shown these as sentence.**Title**. Interrupted turns store each delta as its own part (2 OpenAI messages in 45 days), so they show whatever fantasy streams. Verification go build ./... and make pre-commit pass. go test passes on every package that imports fantasy (coderd/x/chatd/..., coderd/database/db2sdk, coderd/mcp), and go test ./coderd -run 'TestChat|TestExpChat|TestMCP|TestAIBridge' passes. coder/fantasy#67 has Stream and Generate tests that fail with the old separator. No coder test covers this: chattest's Responses mock streams one summary part per reasoning item. Not checked against live OpenAI or in the UI. 🤖 This PR was created with the help of Coder Agents, and will be reviewed by a human. 🏂🏻
Open Graph Description: OpenAI reasoning summaries stream as parts that each open with a bold title. Fantasy sent a single "\n" before each part, which Markdown renders as a space, so the chat UI showed every ti...
X Description: OpenAI reasoning summaries stream as parts that each open with a bold title. Fantasy sent a single "\n" before each part, which Markdown renders as a space, so the chat UI showed ...
Opengraph URL: https://github.com/coder/coder/pull/31349
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:efdb6a1e-586a-ae15-2819-f5bd6069e3f7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A25C:4D9F2:C8C39A:10AFF38:6B01CA8E |
| html-safe-nonce | 811360ce200181a38882ade3d40d95893c6b0b9f2f2c6b0ffbae9d7af64ef02e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMjVDOjREOUYyOkM4QzM5QToxMEFGRjM4OjZCMDFDQThFIiwidmlzaXRvcl9pZCI6IjQyNTA4NTg3NzgyMzQzMDkyNjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | ae2f76e795de500ff1e0b261b5969541caff6fe3cf6dfb6e57d24317de5bf369 |
| hovercard-subject-tag | pull_request:5034974189 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/coder/coder/pull/31349/files |
| twitter:image | https://avatars.githubusercontent.com/u/147409?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/147409?s=400&v=4 |
| og:image:alt | OpenAI reasoning summaries stream as parts that each open with a bold title. Fantasy sent a single "\n" before each part, which Markdown renders as a space, so the chat UI showed every ti... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/coder/coder git https://github.com/coder/coder.git |
| octolytics-dimension-user_id | 95932066 |
| octolytics-dimension-user_login | coder |
| octolytics-dimension-repository_id | 440752086 |
| octolytics-dimension-repository_nwo | coder/coder |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 440752086 |
| octolytics-dimension-repository_network_root_nwo | coder/coder |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width