René's URL Explorer Experiment


Title: fix: set a failed canceled job status correctly by Kira-Pilot · Pull Request #3101 · coder/coder · GitHub

Open Graph Title: fix: set a failed canceled job status correctly by Kira-Pilot · Pull Request #3101 · coder/coder

X Title: fix: set a failed canceled job status correctly by Kira-Pilot · Pull Request #3101 · coder/coder

Description: Secure environments for developers and their agents - fix: set a failed canceled job status correctly by Kira-Pilot · Pull Request #3101 · coder/coder

Open Graph Description: Using in favor of #3061 resolves #1374 When a previous job was canceled and that cancellation was unsuccessful, we incorrectly set the job status as canceled. This fix remedies that issue by settin...

X Description: Using in favor of #3061 resolves #1374 When a previous job was canceled and that cancellation was unsuccessful, we incorrectly set the job status as canceled. This fix remedies that issue by settin...

Opengraph URL: https://github.com/coder/coder/pull/3101

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6b5d1ba2-bdbd-05eb-b071-ea14df4368a5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA028:240CD1:22173FF:2B4F60A:6B017B2E
html-safe-noncee88e9fa425987866d175540303c6cc17fb1c43e05dd5d2b99d7a3bad0a0f0799
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMDI4OjI0MENEMToyMjE3M0ZGOjJCNEY2MEE6NkIwMTdCMkUiLCJ2aXNpdG9yX2lkIjoiMTcyMzc1MDM5NjkzOTMwMzcyNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6977de585eee36774307165045808c2884816fb950c1db93ca93dfc7f09670e3
hovercard-subject-tagpull_request:1004640149
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/3101/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/50c79b6da51ca7f01127520391a1de14ac2b5e3623f46d499d15f6cd99005e34/coder/coder/pull/3101
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/50c79b6da51ca7f01127520391a1de14ac2b5e3623f46d499d15f6cd99005e34/coder/coder/pull/3101
og:image:altUsing in favor of #3061 resolves #1374 When a previous job was canceled and that cancellation was unsuccessful, we incorrectly set the job status as canceled. This fix remedies that issue by settin...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameKira-Pilot
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/coder/coder/pull/3101#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F3101
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F3101
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/pull/3101
Reloadhttps://github.com/coder/coder/pull/3101
Reloadhttps://github.com/coder/coder/pull/3101
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
https://github.com/coder/coder
Kira-Pilothttps://github.com/Kira-Pilot
mainhttps://github.com/coder/coder/tree/main
cp-failed-canceled-job/kira-pilothttps://github.com/coder/coder/tree/cp-failed-canceled-job/kira-pilot
Conversationhttps://github.com/coder/coder/pull/3101
Commits4 (4)https://github.com/coder/coder/pull/3101/commits
Checkshttps://github.com/coder/coder/pull/3101/checks
Files changedhttps://github.com/coder/coder/pull/3101/files
fix: set a failed canceled job status correctlyhttps://github.com/coder/coder/pull/3101#top
Kira-Pilothttps://github.com/Kira-Pilot
mainhttps://github.com/coder/coder/tree/main
cp-failed-canceled-job/kira-pilothttps://github.com/coder/coder/tree/cp-failed-canceled-job/kira-pilot
https://github.com/Kira-Pilot
Kira-Pilothttps://github.com/Kira-Pilot
Jul 21, 2022https://github.com/coder/coder/pull/3101#issue-1313754605
#3061https://github.com/coder/coder/pull/3061
#1374https://github.com/coder/coder/issues/1374
Please reload this pagehttps://github.com/coder/coder/pull/3101
Kira-Pilothttps://github.com/Kira-Pilot
July 21, 2022 20:07https://github.com/coder/coder/pull/3101#commits-pushed-b4f8c53
https://github.com/Kira-Pilot
set a failed canceled job status correctlyhttps://github.com/coder/coder/pull/3101/commits/b4f8c53b93f78d69d053ce101bcc4799b1b977a6
b4f8c53https://github.com/coder/coder/pull/3101/commits/b4f8c53b93f78d69d053ce101bcc4799b1b977a6
#1374https://github.com/coder/coder/issues/1374
https://github.com/Kira-Pilot
added unit test for convertProvisionerJobhttps://github.com/coder/coder/pull/3101/commits/5df285a27184a846a04193bda2810657fc663d1e
5df285ahttps://github.com/coder/coder/pull/3101/commits/5df285a27184a846a04193bda2810657fc663d1e
https://github.com/Kira-Pilot
https://github.com/johnstcn
Update coderd/provisionerjobs_internal_test.gohttps://github.com/coder/coder/pull/3101/commits/4e00334b6ef76d2565dafc6a08d58a2db18c9a05
4e00334https://github.com/coder/coder/pull/3101/commits/4e00334b6ef76d2565dafc6a08d58a2db18c9a05
https://github.com/Kira-Pilot
PR feedbackhttps://github.com/coder/coder/pull/3101/commits/4c92556f2484f8affd18c380386166f85621fcf8
4c92556https://github.com/coder/coder/pull/3101/commits/4c92556f2484f8affd18c380386166f85621fcf8
https://github.com/Kira-Pilot
Kira-Pilothttps://github.com/Kira-Pilot
Jul 21, 2022 https://github.com/coder/coder/pull/3101#ref-pullrequest-1311026757
fix: set a failed canceled job status correctly #3061 https://github.com/coder/coder/pull/3061
https://github.com/Kira-Pilot
Kira-Pilothttps://github.com/Kira-Pilot
July 21, 2022 20:34https://github.com/coder/coder/pull/3101#event-7041288996
https://github.com/johnstcn
johnstcnhttps://github.com/johnstcn
Jul 21, 2022 https://github.com/coder/coder/pull/3101#pullrequestreview-1047120040
View reviewed changes https://github.com/coder/coder/pull/3101/files/4c92556f2484f8affd18c380386166f85621fcf8
https://github.com/Kira-Pilot
Kira-Pilothttps://github.com/Kira-Pilot
0aa8c2ehttps://github.com/coder/coder/commit/0aa8c2efeb38da5495bc11b828b53a0cab76d6c8
Jul 21, 2022https://github.com/coder/coder/pull/3101#event-7041353356
https://github.com/Kira-Pilot
Kira-Pilothttps://github.com/Kira-Pilot
July 21, 2022 20:47https://github.com/coder/coder/pull/3101#event-7041353432
https://github.co/hiddenchars
https://github.com/coder/coder/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F3101
https://github.com/johnstcn
johnstcn https://github.com/johnstcn
https://github.com/coder/coder/pull/3101/files/4c92556f2484f8affd18c380386166f85621fcf8
Please reload this pagehttps://github.com/coder/coder/pull/3101
Error while canceling job should result in failed; instead results in canceled https://github.com/coder/coder/issues/1374
Please reload this pagehttps://github.com/coder/coder/pull/3101
https://github.com/Kira-Pilot
https://github.com/johnstcn
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.