| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:6b5d1ba2-bdbd-05eb-b071-ea14df4368a5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A028:240CD1:22173FF:2B4F60A:6B017B2E |
| html-safe-nonce | e88e9fa425987866d175540303c6cc17fb1c43e05dd5d2b99d7a3bad0a0f0799 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMDI4OjI0MENEMToyMjE3M0ZGOjJCNEY2MEE6NkIwMTdCMkUiLCJ2aXNpdG9yX2lkIjoiMTcyMzc1MDM5NjkzOTMwMzcyNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 6977de585eee36774307165045808c2884816fb950c1db93ca93dfc7f09670e3 |
| hovercard-subject-tag | pull_request:1004640149 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/3101/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/50c79b6da51ca7f01127520391a1de14ac2b5e3623f46d499d15f6cd99005e34/coder/coder/pull/3101 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/50c79b6da51ca7f01127520391a1de14ac2b5e3623f46d499d15f6cd99005e34/coder/coder/pull/3101 |
| og:image:alt | Using in favor of #3061
resolves #1374
When a previous job was canceled and that cancellation was unsuccessful, we incorrectly set the job status as canceled. This fix remedies that issue by settin... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Kira-Pilot |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/coder/coder git https://github.com/coder/coder.git |
| octolytics-dimension-user_id | 95932066 |
| octolytics-dimension-user_login | coder |
| octolytics-dimension-repository_id | 440752086 |
| octolytics-dimension-repository_nwo | coder/coder |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 440752086 |
| octolytics-dimension-repository_network_root_nwo | coder/coder |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/coder/coder/pull/3101#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F3101 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F3101 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder |
| Reload | https://github.com/coder/coder/pull/3101 |
| Reload | https://github.com/coder/coder/pull/3101 |
| Reload | https://github.com/coder/coder/pull/3101 |
| coder | https://github.com/coder |
| coder | https://github.com/coder/coder |
| Code | https://github.com/coder/coder |
| Issues320 (320) | https://github.com/coder/coder/issues |
| Pull requests470 (470) | https://github.com/coder/coder/pulls |
| Discussions | https://github.com/coder/coder/discussions |
| Actions | https://github.com/coder/coder/actions |
| Projects | https://github.com/coder/coder/projects |
| Security and quality49 (49) | https://github.com/coder/coder/security |
| Insights | https://github.com/coder/coder/insights |
| https://github.com/coder/coder |
| Kira-Pilot | https://github.com/Kira-Pilot |
| main | https://github.com/coder/coder/tree/main |
| cp-failed-canceled-job/kira-pilot | https://github.com/coder/coder/tree/cp-failed-canceled-job/kira-pilot |
| Conversation | https://github.com/coder/coder/pull/3101 |
| Commits4 (4) | https://github.com/coder/coder/pull/3101/commits |
| Checks | https://github.com/coder/coder/pull/3101/checks |
| Files changed | https://github.com/coder/coder/pull/3101/files |
| fix: set a failed canceled job status correctly | https://github.com/coder/coder/pull/3101#top |
| Kira-Pilot | https://github.com/Kira-Pilot |
| main | https://github.com/coder/coder/tree/main |
| cp-failed-canceled-job/kira-pilot | https://github.com/coder/coder/tree/cp-failed-canceled-job/kira-pilot |
|
| https://github.com/Kira-Pilot |
| Kira-Pilot | https://github.com/Kira-Pilot |
| Jul 21, 2022 | https://github.com/coder/coder/pull/3101#issue-1313754605 |
| #3061 | https://github.com/coder/coder/pull/3061 |
| #1374 | https://github.com/coder/coder/issues/1374 |
| Please reload this page | https://github.com/coder/coder/pull/3101 |
| Kira-Pilot | https://github.com/Kira-Pilot |
| July 21, 2022 20:07 | https://github.com/coder/coder/pull/3101#commits-pushed-b4f8c53 |
|
| https://github.com/Kira-Pilot |
| set a failed canceled job status correctly | https://github.com/coder/coder/pull/3101/commits/b4f8c53b93f78d69d053ce101bcc4799b1b977a6 |
| b4f8c53 | https://github.com/coder/coder/pull/3101/commits/b4f8c53b93f78d69d053ce101bcc4799b1b977a6 |
| #1374 | https://github.com/coder/coder/issues/1374 |
|
| https://github.com/Kira-Pilot |
| added unit test for convertProvisionerJob | https://github.com/coder/coder/pull/3101/commits/5df285a27184a846a04193bda2810657fc663d1e |
| 5df285a | https://github.com/coder/coder/pull/3101/commits/5df285a27184a846a04193bda2810657fc663d1e |
|
| https://github.com/Kira-Pilot |
|
| https://github.com/johnstcn |
| Update coderd/provisionerjobs_internal_test.go | https://github.com/coder/coder/pull/3101/commits/4e00334b6ef76d2565dafc6a08d58a2db18c9a05 |
| 4e00334 | https://github.com/coder/coder/pull/3101/commits/4e00334b6ef76d2565dafc6a08d58a2db18c9a05 |
|
| https://github.com/Kira-Pilot |
| PR feedback | https://github.com/coder/coder/pull/3101/commits/4c92556f2484f8affd18c380386166f85621fcf8 |
| 4c92556 | https://github.com/coder/coder/pull/3101/commits/4c92556f2484f8affd18c380386166f85621fcf8 |
| https://github.com/Kira-Pilot |
| Kira-Pilot | https://github.com/Kira-Pilot |
|
Jul 21, 2022
| https://github.com/coder/coder/pull/3101#ref-pullrequest-1311026757 |
|
fix: set a failed canceled job status correctly
#3061
| https://github.com/coder/coder/pull/3061 |
| https://github.com/Kira-Pilot |
| Kira-Pilot | https://github.com/Kira-Pilot |
| July 21, 2022 20:34 | https://github.com/coder/coder/pull/3101#event-7041288996 |
| https://github.com/johnstcn |
| johnstcn | https://github.com/johnstcn |
|
Jul 21, 2022
| https://github.com/coder/coder/pull/3101#pullrequestreview-1047120040 |
|
View reviewed changes
| https://github.com/coder/coder/pull/3101/files/4c92556f2484f8affd18c380386166f85621fcf8 |
| https://github.com/Kira-Pilot |
| Kira-Pilot | https://github.com/Kira-Pilot |
| 0aa8c2e | https://github.com/coder/coder/commit/0aa8c2efeb38da5495bc11b828b53a0cab76d6c8 |
| Jul 21, 2022 | https://github.com/coder/coder/pull/3101#event-7041353356 |
| https://github.com/Kira-Pilot |
| Kira-Pilot | https://github.com/Kira-Pilot |
| July 21, 2022 20:47 | https://github.com/coder/coder/pull/3101#event-7041353432 |
| https://github.co/hiddenchars |
| https://github.com/coder/coder/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F3101 |
|
| https://github.com/johnstcn |
|
johnstcn
| https://github.com/johnstcn |
|
| https://github.com/coder/coder/pull/3101/files/4c92556f2484f8affd18c380386166f85621fcf8 |
| Please reload this page | https://github.com/coder/coder/pull/3101 |
|
Error while canceling job should result in failed; instead results in canceled
| https://github.com/coder/coder/issues/1374 |
| Please reload this page | https://github.com/coder/coder/pull/3101 |
|
| https://github.com/Kira-Pilot |
|
| https://github.com/johnstcn |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |