René's URL Explorer Experiment


Title: fix: Deadlock and race in `peer`, test improvements by mafredri · Pull Request #3086 · coder/coder · GitHub

Open Graph Title: fix: Deadlock and race in `peer`, test improvements by mafredri · Pull Request #3086 · coder/coder

X Title: fix: Deadlock and race in `peer`, test improvements by mafredri · Pull Request #3086 · coder/coder

Description: Secure environments for developers and their agents - fix: Deadlock and race in `peer`, test improvements by mafredri · Pull Request #3086 · coder/coder

Open Graph Description: This PR fixes a few edge cases that I noticed whilst combing over the peer package. Some of the tests were also updated in an attempt to increase robustness and improve cleanup (e.g. closing channe...

X Description: This PR fixes a few edge cases that I noticed whilst combing over the peer package. Some of the tests were also updated in an attempt to increase robustness and improve cleanup (e.g. closing channe...

Opengraph URL: https://github.com/coder/coder/pull/3086

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c0c83b32-d39c-7cce-94a4-e3d8acaa9785
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8EFC:19B6A2:2502E1:30ABBC:6B018B92
html-safe-nonce8deba917170ddd208f38e8fac1844e841ea7472a08dccefb7bf1010ff17c703d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RUZDOjE5QjZBMjoyNTAyRTE6MzBBQkJDOjZCMDE4QjkyIiwidmlzaXRvcl9pZCI6IjY4NTI2MDUwMzg0MTIwNzIyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacaecc551dcf8f0c06c839380ea7d3745d4d8a9a7d74bd783b5c44c0b7ce2423b3
hovercard-subject-tagpull_request:1004171879
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/3086/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/fa89f9d1b8aa5619c66c0c000a31b76308ad1339dc4b5b16d55a060d7a2166f9/coder/coder/pull/3086
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/fa89f9d1b8aa5619c66c0c000a31b76308ad1339dc4b5b16d55a060d7a2166f9/coder/coder/pull/3086
og:image:altThis PR fixes a few edge cases that I noticed whilst combing over the peer package. Some of the tests were also updated in an attempt to increase robustness and improve cleanup (e.g. closing channe...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemafredri
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/coder/coder/pull/3086#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F3086
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F3086
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/pull/3086
Reloadhttps://github.com/coder/coder/pull/3086
Reloadhttps://github.com/coder/coder/pull/3086
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
https://github.com/coder/coder
mafredrihttps://github.com/mafredri
mainhttps://github.com/coder/coder/tree/main
mafredri/peer-fixeshttps://github.com/coder/coder/tree/mafredri/peer-fixes
Conversationhttps://github.com/coder/coder/pull/3086
Commits8 (8)https://github.com/coder/coder/pull/3086/commits
Checkshttps://github.com/coder/coder/pull/3086/checks
Files changedhttps://github.com/coder/coder/pull/3086/files
fix: Deadlock and race in peer, test improvementshttps://github.com/coder/coder/pull/3086#top
mafredrihttps://github.com/mafredri
mainhttps://github.com/coder/coder/tree/main
mafredri/peer-fixeshttps://github.com/coder/coder/tree/mafredri/peer-fixes
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Jul 21, 2022https://github.com/coder/coder/pull/3086#issue-1313230096
#1644https://github.com/coder/coder/issues/1644
Please reload this pagehttps://github.com/coder/coder/pull/3086
mafredrihttps://github.com/mafredri
July 21, 2022 12:31https://github.com/coder/coder/pull/3086#commits-pushed-eaacbca
https://github.com/mafredri
fix: Potential deadlock in peer.Channel dc.OnOpenhttps://github.com/coder/coder/pull/3086/commits/eaacbca74ff99d3b66116b0e2ed4e8648369e948
eaacbcahttps://github.com/coder/coder/pull/3086/commits/eaacbca74ff99d3b66116b0e2ed4e8648369e948
https://github.com/mafredri
fix: Potential send on closed channelhttps://github.com/coder/coder/pull/3086/commits/5b5dde93e97eac202925d807fd6731594c5fe906
5b5dde9https://github.com/coder/coder/pull/3086/commits/5b5dde93e97eac202925d807fd6731594c5fe906
https://github.com/mafredri
fix: Improve robustness of waitOpened during closehttps://github.com/coder/coder/pull/3086/commits/8061d4c031aeb4f6c9f9a3e200f30892b186dccb
8061d4chttps://github.com/coder/coder/pull/3086/commits/8061d4c031aeb4f6c9f9a3e200f30892b186dccb
https://github.com/mafredri
chore: Simplify statementshttps://github.com/coder/coder/pull/3086/commits/077b02e56c6ca5977856bfe837a533b85026ec3f
077b02ehttps://github.com/coder/coder/pull/3086/commits/077b02e56c6ca5977856bfe837a533b85026ec3f
https://github.com/mafredri
fix: Improve teardown and timeout of peer testshttps://github.com/coder/coder/pull/3086/commits/0474aa934e1fae2604c37c37f998927dfa356f81
0474aa9https://github.com/coder/coder/pull/3086/commits/0474aa934e1fae2604c37c37f998927dfa356f81
https://github.com/mafredri
fix: Improve robustness of TestConn/Buffering testhttps://github.com/coder/coder/pull/3086/commits/5e33a9a4a72681b27354050f20f24f3edef4e6d8
5e33a9ahttps://github.com/coder/coder/pull/3086/commits/5e33a9a4a72681b27354050f20f24f3edef4e6d8
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Jul 21, 2022https://github.com/coder/coder/pull/3086#event-7038144903
https://github.com/mafredri
mafredrihttps://github.com/mafredri
kylecarbshttps://github.com/kylecarbs
July 21, 2022 13:05https://github.com/coder/coder/pull/3086#event-7038145004
https://github.com/Emyrk
Emyrkhttps://github.com/Emyrk
Jul 21, 2022 https://github.com/coder/coder/pull/3086#pullrequestreview-1046533982
View reviewed changes https://github.com/coder/coder/pull/3086/files/5e33a9a4a72681b27354050f20f24f3edef4e6d8
peer/channel.gohttps://github.com/coder/coder/pull/3086/files/5e33a9a4a72681b27354050f20f24f3edef4e6d8#diff-e05b55fdf628140891035293a023189e484854757503a5e383021ea3d4f919ec
Emyrkhttps://github.com/Emyrk
Jul 21, 2022https://github.com/coder/coder/pull/3086#discussion_r926677553
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/3086
mafredrihttps://github.com/mafredri
Jul 21, 2022https://github.com/coder/coder/pull/3086#discussion_r926697694
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/3086
mafredrihttps://github.com/mafredri
Jul 21, 2022https://github.com/coder/coder/pull/3086#discussion_r926705287
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/3086
Emyrkhttps://github.com/Emyrk
Jul 21, 2022https://github.com/coder/coder/pull/3086#discussion_r926727470
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/3086
mafredrihttps://github.com/mafredri
Jul 21, 2022https://github.com/coder/coder/pull/3086#discussion_r926732935
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://go.dev/play/p/c35kE0948klhttps://go.dev/play/p/c35kE0948kl
Please reload this pagehttps://github.com/coder/coder/pull/3086
peer/channel.gohttps://github.com/coder/coder/pull/3086/files/5e33a9a4a72681b27354050f20f24f3edef4e6d8#diff-e05b55fdf628140891035293a023189e484854757503a5e383021ea3d4f919ec
Please reload this pagehttps://github.com/coder/coder/pull/3086
mafredrihttps://github.com/mafredri
July 21, 2022 16:48https://github.com/coder/coder/pull/3086#commits-pushed-ca349ca
https://github.com/mafredri
https://github.com/Emyrk
Update peer/channel.gohttps://github.com/coder/coder/pull/3086/commits/ca349ca9cf74fb15e9110b65d5178505ac1f10a6
ca349cahttps://github.com/coder/coder/pull/3086/commits/ca349ca9cf74fb15e9110b65d5178505ac1f10a6
https://github.com/mafredri
chore: Re-introduce re-check commenthttps://github.com/coder/coder/pull/3086/commits/445e8b097a10998eb85e9de95af2cea1bae7d0a0
445e8b0https://github.com/coder/coder/pull/3086/commits/445e8b097a10998eb85e9de95af2cea1bae7d0a0
https://github.com/johnstcn
johnstcnhttps://github.com/johnstcn
Jul 21, 2022 https://github.com/coder/coder/pull/3086#pullrequestreview-1046585567
View reviewed changes https://github.com/coder/coder/pull/3086/files/445e8b097a10998eb85e9de95af2cea1bae7d0a0
https://github.com/kylecarbs
kylecarbshttps://github.com/kylecarbs
Jul 21, 2022 https://github.com/coder/coder/pull/3086#pullrequestreview-1046645277
View reviewed changes https://github.com/coder/coder/pull/3086/files/445e8b097a10998eb85e9de95af2cea1bae7d0a0
kylecarbshttps://github.com/kylecarbs
https://github.com/coder/coder/pull/3086#pullrequestreview-1046645277
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/3086
https://github.com/mafredri
mafredrihttps://github.com/mafredri
e33a749https://github.com/coder/coder/commit/e33a74975eea2887c184a647740a1e3397dfe64f
Jul 21, 2022https://github.com/coder/coder/pull/3086#event-7039539272
https://github.com/mafredri
mafredrihttps://github.com/mafredri
July 21, 2022 15:47https://github.com/coder/coder/pull/3086#event-7039539418
https://github.co/hiddenchars
https://github.com/coder/coder/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F3086
https://github.com/Emyrk
Emyrk https://github.com/Emyrk
https://github.com/coder/coder/pull/3086/files/5e33a9a4a72681b27354050f20f24f3edef4e6d8
https://github.com/johnstcn
johnstcn https://github.com/johnstcn
https://github.com/coder/coder/pull/3086/files/445e8b097a10998eb85e9de95af2cea1bae7d0a0
https://github.com/kylecarbs
kylecarbs https://github.com/kylecarbs
https://github.com/coder/coder/pull/3086/files/445e8b097a10998eb85e9de95af2cea1bae7d0a0
Please reload this pagehttps://github.com/coder/coder/pull/3086
https://github.com/mafredri
mafredri https://github.com/mafredri
Please reload this pagehttps://github.com/coder/coder/pull/3086
https://github.com/mafredri
https://github.com/johnstcn
https://github.com/Emyrk
https://github.com/kylecarbs
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.