| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:c0c83b32-d39c-7cce-94a4-e3d8acaa9785 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8EFC:19B6A2:2502E1:30ABBC:6B018B92 |
| html-safe-nonce | 8deba917170ddd208f38e8fac1844e841ea7472a08dccefb7bf1010ff17c703d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RUZDOjE5QjZBMjoyNTAyRTE6MzBBQkJDOjZCMDE4QjkyIiwidmlzaXRvcl9pZCI6IjY4NTI2MDUwMzg0MTIwNzIyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | aecc551dcf8f0c06c839380ea7d3745d4d8a9a7d74bd783b5c44c0b7ce2423b3 |
| hovercard-subject-tag | pull_request:1004171879 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/3086/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/fa89f9d1b8aa5619c66c0c000a31b76308ad1339dc4b5b16d55a060d7a2166f9/coder/coder/pull/3086 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/fa89f9d1b8aa5619c66c0c000a31b76308ad1339dc4b5b16d55a060d7a2166f9/coder/coder/pull/3086 |
| og:image:alt | This PR fixes a few edge cases that I noticed whilst combing over the peer package. Some of the tests were also updated in an attempt to increase robustness and improve cleanup (e.g. closing channe... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mafredri |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/coder/coder git https://github.com/coder/coder.git |
| octolytics-dimension-user_id | 95932066 |
| octolytics-dimension-user_login | coder |
| octolytics-dimension-repository_id | 440752086 |
| octolytics-dimension-repository_nwo | coder/coder |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 440752086 |
| octolytics-dimension-repository_network_root_nwo | coder/coder |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/coder/coder/pull/3086#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F3086 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F3086 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder |
| Reload | https://github.com/coder/coder/pull/3086 |
| Reload | https://github.com/coder/coder/pull/3086 |
| Reload | https://github.com/coder/coder/pull/3086 |
| coder | https://github.com/coder |
| coder | https://github.com/coder/coder |
| Code | https://github.com/coder/coder |
| Issues320 (320) | https://github.com/coder/coder/issues |
| Pull requests470 (470) | https://github.com/coder/coder/pulls |
| Discussions | https://github.com/coder/coder/discussions |
| Actions | https://github.com/coder/coder/actions |
| Projects | https://github.com/coder/coder/projects |
| Security and quality49 (49) | https://github.com/coder/coder/security |
| Insights | https://github.com/coder/coder/insights |
| https://github.com/coder/coder |
| mafredri | https://github.com/mafredri |
| main | https://github.com/coder/coder/tree/main |
| mafredri/peer-fixes | https://github.com/coder/coder/tree/mafredri/peer-fixes |
| Conversation | https://github.com/coder/coder/pull/3086 |
| Commits8 (8) | https://github.com/coder/coder/pull/3086/commits |
| Checks | https://github.com/coder/coder/pull/3086/checks |
| Files changed | https://github.com/coder/coder/pull/3086/files |
| fix: Deadlock and race in peer, test improvements | https://github.com/coder/coder/pull/3086#top |
| mafredri | https://github.com/mafredri |
| main | https://github.com/coder/coder/tree/main |
| mafredri/peer-fixes | https://github.com/coder/coder/tree/mafredri/peer-fixes |
|
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| Jul 21, 2022 | https://github.com/coder/coder/pull/3086#issue-1313230096 |
| #1644 | https://github.com/coder/coder/issues/1644 |
| Please reload this page | https://github.com/coder/coder/pull/3086 |
| mafredri | https://github.com/mafredri |
| July 21, 2022 12:31 | https://github.com/coder/coder/pull/3086#commits-pushed-eaacbca |
|
| https://github.com/mafredri |
| fix: Potential deadlock in peer.Channel dc.OnOpen | https://github.com/coder/coder/pull/3086/commits/eaacbca74ff99d3b66116b0e2ed4e8648369e948 |
| eaacbca | https://github.com/coder/coder/pull/3086/commits/eaacbca74ff99d3b66116b0e2ed4e8648369e948 |
|
| https://github.com/mafredri |
| fix: Potential send on closed channel | https://github.com/coder/coder/pull/3086/commits/5b5dde93e97eac202925d807fd6731594c5fe906 |
| 5b5dde9 | https://github.com/coder/coder/pull/3086/commits/5b5dde93e97eac202925d807fd6731594c5fe906 |
|
| https://github.com/mafredri |
| fix: Improve robustness of waitOpened during close | https://github.com/coder/coder/pull/3086/commits/8061d4c031aeb4f6c9f9a3e200f30892b186dccb |
| 8061d4c | https://github.com/coder/coder/pull/3086/commits/8061d4c031aeb4f6c9f9a3e200f30892b186dccb |
|
| https://github.com/mafredri |
| chore: Simplify statements | https://github.com/coder/coder/pull/3086/commits/077b02e56c6ca5977856bfe837a533b85026ec3f |
| 077b02e | https://github.com/coder/coder/pull/3086/commits/077b02e56c6ca5977856bfe837a533b85026ec3f |
|
| https://github.com/mafredri |
| fix: Improve teardown and timeout of peer tests | https://github.com/coder/coder/pull/3086/commits/0474aa934e1fae2604c37c37f998927dfa356f81 |
| 0474aa9 | https://github.com/coder/coder/pull/3086/commits/0474aa934e1fae2604c37c37f998927dfa356f81 |
|
| https://github.com/mafredri |
| fix: Improve robustness of TestConn/Buffering test | https://github.com/coder/coder/pull/3086/commits/5e33a9a4a72681b27354050f20f24f3edef4e6d8 |
| 5e33a9a | https://github.com/coder/coder/pull/3086/commits/5e33a9a4a72681b27354050f20f24f3edef4e6d8 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| Jul 21, 2022 | https://github.com/coder/coder/pull/3086#event-7038144903 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| kylecarbs | https://github.com/kylecarbs |
| July 21, 2022 13:05 | https://github.com/coder/coder/pull/3086#event-7038145004 |
| https://github.com/Emyrk |
| Emyrk | https://github.com/Emyrk |
|
Jul 21, 2022
| https://github.com/coder/coder/pull/3086#pullrequestreview-1046533982 |
|
View reviewed changes
| https://github.com/coder/coder/pull/3086/files/5e33a9a4a72681b27354050f20f24f3edef4e6d8 |
| peer/channel.go | https://github.com/coder/coder/pull/3086/files/5e33a9a4a72681b27354050f20f24f3edef4e6d8#diff-e05b55fdf628140891035293a023189e484854757503a5e383021ea3d4f919ec |
| Emyrk | https://github.com/Emyrk |
| Jul 21, 2022 | https://github.com/coder/coder/pull/3086#discussion_r926677553 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/3086 |
| mafredri | https://github.com/mafredri |
| Jul 21, 2022 | https://github.com/coder/coder/pull/3086#discussion_r926697694 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/3086 |
| mafredri | https://github.com/mafredri |
| Jul 21, 2022 | https://github.com/coder/coder/pull/3086#discussion_r926705287 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/3086 |
| Emyrk | https://github.com/Emyrk |
| Jul 21, 2022 | https://github.com/coder/coder/pull/3086#discussion_r926727470 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/3086 |
| mafredri | https://github.com/mafredri |
| Jul 21, 2022 | https://github.com/coder/coder/pull/3086#discussion_r926732935 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://go.dev/play/p/c35kE0948kl | https://go.dev/play/p/c35kE0948kl |
| Please reload this page | https://github.com/coder/coder/pull/3086 |
| peer/channel.go | https://github.com/coder/coder/pull/3086/files/5e33a9a4a72681b27354050f20f24f3edef4e6d8#diff-e05b55fdf628140891035293a023189e484854757503a5e383021ea3d4f919ec |
| Please reload this page | https://github.com/coder/coder/pull/3086 |
| mafredri | https://github.com/mafredri |
| July 21, 2022 16:48 | https://github.com/coder/coder/pull/3086#commits-pushed-ca349ca |
|
| https://github.com/mafredri |
|
| https://github.com/Emyrk |
| Update peer/channel.go | https://github.com/coder/coder/pull/3086/commits/ca349ca9cf74fb15e9110b65d5178505ac1f10a6 |
| ca349ca | https://github.com/coder/coder/pull/3086/commits/ca349ca9cf74fb15e9110b65d5178505ac1f10a6 |
|
| https://github.com/mafredri |
| chore: Re-introduce re-check comment | https://github.com/coder/coder/pull/3086/commits/445e8b097a10998eb85e9de95af2cea1bae7d0a0 |
| 445e8b0 | https://github.com/coder/coder/pull/3086/commits/445e8b097a10998eb85e9de95af2cea1bae7d0a0 |
| https://github.com/johnstcn |
| johnstcn | https://github.com/johnstcn |
|
Jul 21, 2022
| https://github.com/coder/coder/pull/3086#pullrequestreview-1046585567 |
|
View reviewed changes
| https://github.com/coder/coder/pull/3086/files/445e8b097a10998eb85e9de95af2cea1bae7d0a0 |
| https://github.com/kylecarbs |
| kylecarbs | https://github.com/kylecarbs |
|
Jul 21, 2022
| https://github.com/coder/coder/pull/3086#pullrequestreview-1046645277 |
|
View reviewed changes
| https://github.com/coder/coder/pull/3086/files/445e8b097a10998eb85e9de95af2cea1bae7d0a0 |
| kylecarbs | https://github.com/kylecarbs |
| https://github.com/coder/coder/pull/3086#pullrequestreview-1046645277 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/3086 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| e33a749 | https://github.com/coder/coder/commit/e33a74975eea2887c184a647740a1e3397dfe64f |
| Jul 21, 2022 | https://github.com/coder/coder/pull/3086#event-7039539272 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| July 21, 2022 15:47 | https://github.com/coder/coder/pull/3086#event-7039539418 |
| https://github.co/hiddenchars |
| https://github.com/coder/coder/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F3086 |
|
| https://github.com/Emyrk |
|
Emyrk
| https://github.com/Emyrk |
|
| https://github.com/coder/coder/pull/3086/files/5e33a9a4a72681b27354050f20f24f3edef4e6d8 |
|
| https://github.com/johnstcn |
|
johnstcn
| https://github.com/johnstcn |
|
| https://github.com/coder/coder/pull/3086/files/445e8b097a10998eb85e9de95af2cea1bae7d0a0 |
|
| https://github.com/kylecarbs |
|
kylecarbs
| https://github.com/kylecarbs |
|
| https://github.com/coder/coder/pull/3086/files/445e8b097a10998eb85e9de95af2cea1bae7d0a0 |
| Please reload this page | https://github.com/coder/coder/pull/3086 |
|
| https://github.com/mafredri |
|
mafredri
| https://github.com/mafredri |
| Please reload this page | https://github.com/coder/coder/pull/3086 |
|
| https://github.com/mafredri |
|
| https://github.com/johnstcn |
|
| https://github.com/Emyrk |
|
| https://github.com/kylecarbs |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |