René's URL Explorer Experiment


Title: fix: coderdtest: increase ForceCancelInterval by johnstcn · Pull Request #3085 · coder/coder · GitHub

Open Graph Title: fix: coderdtest: increase ForceCancelInterval by johnstcn · Pull Request #3085 · coder/coder

X Title: fix: coderdtest: increase ForceCancelInterval by johnstcn · Pull Request #3085 · coder/coder

Description: Two coderd unit tests (TestPatchCancelTemplateVersion/Success and TestPatchCancelWorkspaceBuild) implied erroneously that the job was canceled successfully. This is not the case, as these unit tests do not include a Provision_Complete response in the input to the echo provisioner. Now explicitly checking the job error and bumping the force cancel interval to be longer. I'm not sure if this is the "correct" fix here; I'm mainly unblocking #3061. It seems that the "right" way would be to allow some way of modifying the contents of the test provisioner's job in-flight. For example in this use-case, we want to have the job initially returning only logs (implying in progress), and then also returning a complete after we cancel. There's another use case where we want the status quo, e.g. to test the force cancelation logic. Fixes #3083.

Open Graph Description: Two coderd unit tests (TestPatchCancelTemplateVersion/Success and TestPatchCancelWorkspaceBuild) implied erroneously that the job was canceled successfully. This is not the case, as these unit test...

X Description: Two coderd unit tests (TestPatchCancelTemplateVersion/Success and TestPatchCancelWorkspaceBuild) implied erroneously that the job was canceled successfully. This is not the case, as these unit test...

Opengraph URL: https://github.com/coder/coder/pull/3085

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7c01e141-5da1-1158-b304-6ca7a7f8ce5b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id855E:2E5652:29BAAE1:3524435:6B01A809
html-safe-nonce1c9bcae7f93c88e49e60efadfc5794198d2bbd6cc76a62a2ec674672deda62bb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NTVFOjJFNTY1MjoyOUJBQUUxOjM1MjQ0MzU6NkIwMUE4MDkiLCJ2aXNpdG9yX2lkIjoiNjc4MDg4MTg0ODg5MDQwMjgyNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac328ef17e3e4ec91e4fd77677b5045eda929ade9cda5d1cc492d07eeb5d8b4773
hovercard-subject-tagpull_request:1004158201
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/coder/coder/pull/3085/files
twitter:imagehttps://avatars.githubusercontent.com/u/4949514?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4949514?s=400&v=4
og:image:altTwo coderd unit tests (TestPatchCancelTemplateVersion/Success and TestPatchCancelWorkspaceBuild) implied erroneously that the job was canceled successfully. This is not the case, as these unit test...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/coder/coder/pull/3085/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F3085%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F3085%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/pull/3085/files
Reloadhttps://github.com/coder/coder/pull/3085/files
Reloadhttps://github.com/coder/coder/pull/3085/files
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fcoder%2Fcoder%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fcoder%2Fcoder%2Fissues%2Fnew%2Fchoose
johnstcnhttps://github.com/johnstcn
mainhttps://github.com/coder/coder/tree/main
cj/gh-3083/test-cancel-provisionerjob-timeouthttps://github.com/coder/coder/tree/cj/gh-3083/test-cancel-provisionerjob-timeout
Conversation 4 https://github.com/coder/coder/pull/3085
Commits 2 https://github.com/coder/coder/pull/3085/commits
Checks 0 https://github.com/coder/coder/pull/3085/checks
Files changed https://github.com/coder/coder/pull/3085/files
Please reload this pagehttps://github.com/coder/coder/pull/3085/files
fix: coderdtest: increase ForceCancelInterval https://github.com/coder/coder/pull/3085/files#top
Show all changes 2 commits https://github.com/coder/coder/pull/3085/files
65ca9ec fix: coderd: TestPatchCancelTemplateVersion: check job error johnstcn Jul 21, 2022 https://github.com/coder/coder/pull/3085/commits/65ca9ec9c6bff38456007af4728f63521735778c
7b491d6 fixup! fix: coderd: TestPatchCancelTemplateVersion: check job error johnstcn Jul 21, 2022 https://github.com/coder/coder/pull/3085/commits/7b491d62257ea45d1dd219f15d6b33042dd23f56
Clear filters https://github.com/coder/coder/pull/3085/files
Please reload this pagehttps://github.com/coder/coder/pull/3085/files
Please reload this pagehttps://github.com/coder/coder/pull/3085/files
coderdtest.go https://github.com/coder/coder/pull/3085/files#diff-ce351d3003b0d62f64a8a41cddbe8d08a84895cd70b7bfe385b6e667477f6351
templateversions_test.go https://github.com/coder/coder/pull/3085/files#diff-d885f53866699b1dfb9d32c7e3ded571633d3cbb8e4503aa3593c9b1c041f0d7
workspacebuilds_test.go https://github.com/coder/coder/pull/3085/files#diff-81081239b93aaa61eb8d180a5f9870fda8f0ab5cb4c6727d9d1636aa933e597b
coderd/coderdtest/coderdtest.gohttps://github.com/coder/coder/pull/3085/files#diff-ce351d3003b0d62f64a8a41cddbe8d08a84895cd70b7bfe385b6e667477f6351
View file https://github.com/coder/coder/blob/7b491d62257ea45d1dd219f15d6b33042dd23f56/coderd/coderdtest/coderdtest.go
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/3085/{{ revealButtonHref }}
https://github.com/coder/coder/pull/3085/files#diff-ce351d3003b0d62f64a8a41cddbe8d08a84895cd70b7bfe385b6e667477f6351
https://github.com/coder/coder/pull/3085/files#diff-ce351d3003b0d62f64a8a41cddbe8d08a84895cd70b7bfe385b6e667477f6351
coderd/templateversions_test.gohttps://github.com/coder/coder/pull/3085/files#diff-d885f53866699b1dfb9d32c7e3ded571633d3cbb8e4503aa3593c9b1c041f0d7
View file https://github.com/coder/coder/blob/7b491d62257ea45d1dd219f15d6b33042dd23f56/coderd/templateversions_test.go
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/3085/{{ revealButtonHref }}
https://github.com/coder/coder/pull/3085/files#diff-d885f53866699b1dfb9d32c7e3ded571633d3cbb8e4503aa3593c9b1c041f0d7
https://github.com/coder/coder/pull/3085/files#diff-d885f53866699b1dfb9d32c7e3ded571633d3cbb8e4503aa3593c9b1c041f0d7
mafredrihttps://github.com/mafredri
Jul 21, 2022https://github.com/coder/coder/pull/3085/files#r926684304
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/3085/files
spikecurtishttps://github.com/spikecurtis
Jul 21, 2022https://github.com/coder/coder/pull/3085/files#r926913805
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/3085/files
https://github.com/coder/coder/pull/3085/files#diff-d885f53866699b1dfb9d32c7e3ded571633d3cbb8e4503aa3593c9b1c041f0d7
coderd/workspacebuilds_test.gohttps://github.com/coder/coder/pull/3085/files#diff-81081239b93aaa61eb8d180a5f9870fda8f0ab5cb4c6727d9d1636aa933e597b
View file https://github.com/coder/coder/blob/7b491d62257ea45d1dd219f15d6b33042dd23f56/coderd/workspacebuilds_test.go
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/3085/{{ revealButtonHref }}
https://github.com/coder/coder/pull/3085/files#diff-81081239b93aaa61eb8d180a5f9870fda8f0ab5cb4c6727d9d1636aa933e597b
https://github.com/coder/coder/pull/3085/files#diff-81081239b93aaa61eb8d180a5f9870fda8f0ab5cb4c6727d9d1636aa933e597b
https://github.com/coder/coder/pull/3085/files#diff-81081239b93aaa61eb8d180a5f9870fda8f0ab5cb4c6727d9d1636aa933e597b
https://github.com/coder/coder/pull/3085/files#diff-81081239b93aaa61eb8d180a5f9870fda8f0ab5cb4c6727d9d1636aa933e597b
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.