Title: ci: fix release-labels sync for drafts and cross-PR run cancellation by ethanndickson · Pull Request #29329 · coder/coder · GitHub
Open Graph Title: ci: fix release-labels sync for drafts and cross-PR run cancellation by ethanndickson · Pull Request #29329 · coder/coder
X Title: ci: fix release-labels sync for drafts and cross-PR run cancellation by ethanndickson · Pull Request #29329 · coder/coder
Description: The release-labels job skips draft PRs, so when the release/breaking label was added to #29207 whilst it was a draft, nothing happened. When it was marked ready for review, the ready_for_review branch only checked for a ! in the title without the label, not the other way around, so the job just logged the mismatch and exited successfully: https://github.com/coder/coder/actions/runs/34917703558 Action: ready_for_review Title: fix: authenticate confidential clients on the OAuth2 refresh grant Labels: release/breaking This is the third patch around the draft skip (#14667, #16616), and I couldn't find a reason for it; it was a review suggestion on #5724 with no rationale given. The script only reacts to explicit labeled, unlabeled and edited events, so running it on drafts just syncs at the time of the action, when the intent is unambiguous. So, we'll just remove the skip. Whilst looking at this I noticed the workflow's concurrency group is pr-${{ github.ref }}, but on pull_request_target github.ref is the base branch, so every PR into main (and every issue_comment run) shares one group. GitHub keeps one running and one pending run per group and cancels the rest. At 01:32:04 on the 11th, nine of eleven contrib runs across six unrelated PRs were cancelled, and any labeled or edited event that lands in a cancelled run is lost for good. The fix is just to key the group on the PR number, which is what the comment above it claims it does. #29251 and #28178 were merged with the label but no ! for the same reason. Since this is a pull_request_target workflow, none of this takes effect until it's on main.
Open Graph Description: The release-labels job skips draft PRs, so when the release/breaking label was added to #29207 whilst it was a draft, nothing happened. When it was marked ready for review, the ready_for_review bra...
X Description: The release-labels job skips draft PRs, so when the release/breaking label was added to #29207 whilst it was a draft, nothing happened. When it was marked ready for review, the ready_for_review bra...
Opengraph URL: https://github.com/coder/coder/pull/29329
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:547583cf-e6f6-15bd-403e-6f6d5dad38b3 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EA40:D1D28:DFB57:129ED5:6B0182FD |
| html-safe-nonce | 5b3690908a46d67e8a04bb680f4b947f0e91e3c0dbaedfe0c378240765bd78e2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQTQwOkQxRDI4OkRGQjU3OjEyOUVENTo2QjAxODJGRCIsInZpc2l0b3JfaWQiOiIzMTEyNjA2MTg4OTY2MDg1MzczIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 9adbae62a84c30ffb549144ca9038a1dab99aeaa2e34871d4b4857018d06f421 |
| hovercard-subject-tag | pull_request:4532620383 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/coder/coder/pull/29329/files |
| twitter:image | https://avatars.githubusercontent.com/u/39577870?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/39577870?s=400&v=4 |
| og:image:alt | The release-labels job skips draft PRs, so when the release/breaking label was added to #29207 whilst it was a draft, nothing happened. When it was marked ready for review, the ready_for_review bra... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/coder/coder git https://github.com/coder/coder.git |
| octolytics-dimension-user_id | 95932066 |
| octolytics-dimension-user_login | coder |
| octolytics-dimension-repository_id | 440752086 |
| octolytics-dimension-repository_nwo | coder/coder |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 440752086 |
| octolytics-dimension-repository_network_root_nwo | coder/coder |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width