| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:628d5ca6-5a00-7167-f37d-d42b0667904c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AC24:2DBB21:1A65352:232484F:6B0159EE |
| html-safe-nonce | 3734a2472ade84fb3910fd393311f72038359e25c258c754d52df048a76a5af2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQzI0OjJEQkIyMToxQTY1MzUyOjIzMjQ4NEY6NkIwMTU5RUUiLCJ2aXNpdG9yX2lkIjoiNzUzMDUzNDc5OTQ2Nzk2MDgxNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 3c3d462fa06b58790ae7d8434b598da33cc48828d434aff9cc175504541c4afc |
| hovercard-subject-tag | pull_request:4501504526 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/29206/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/710e742bb90b6f88b8d952bb2b07b07f1d4a61edfb66a155f037254b6f727750/coder/coder/pull/29206 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/710e742bb90b6f88b8d952bb2b07b07f1d4a61edfb66a155f037254b6f727750/coder/coder/pull/29206 |
| og:image:alt | TL;DR
First of three for the client authentication gaps in SEC-348. The authorization code grant is the only OAuth2 handler that checks a confidential client's secret. The refresh grant (PLAT-5... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | BobbyHo |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/coder/coder git https://github.com/coder/coder.git |
| octolytics-dimension-user_id | 95932066 |
| octolytics-dimension-user_login | coder |
| octolytics-dimension-repository_id | 440752086 |
| octolytics-dimension-repository_nwo | coder/coder |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 440752086 |
| octolytics-dimension-repository_network_root_nwo | coder/coder |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/coder/coder/pull/29206#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F29206 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F29206 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder |
| Reload | https://github.com/coder/coder/pull/29206 |
| Reload | https://github.com/coder/coder/pull/29206 |
| Reload | https://github.com/coder/coder/pull/29206 |
| coder | https://github.com/coder |
| coder | https://github.com/coder/coder |
| Code | https://github.com/coder/coder |
| Issues320 (320) | https://github.com/coder/coder/issues |
| Pull requests470 (470) | https://github.com/coder/coder/pulls |
| Discussions | https://github.com/coder/coder/discussions |
| Actions | https://github.com/coder/coder/actions |
| Projects | https://github.com/coder/coder/projects |
| Security and quality49 (49) | https://github.com/coder/coder/security |
| Insights | https://github.com/coder/coder/insights |
| https://github.com/coder/coder |
| BobbyHo | https://github.com/BobbyHo |
| main | https://github.com/coder/coder/tree/main |
| coder-sec-348-authenticate-client | https://github.com/coder/coder/tree/coder-sec-348-authenticate-client |
| Conversation | https://github.com/coder/coder/pull/29206 |
| Commits160 (160) | https://github.com/coder/coder/pull/29206/commits |
| Checks | https://github.com/coder/coder/pull/29206/checks |
| Files changed | https://github.com/coder/coder/pull/29206/files |
| refactor(coderd/oauth2provider): extract OAuth2 client authentication helpers | https://github.com/coder/coder/pull/29206#top |
| BobbyHo | https://github.com/BobbyHo |
| main | https://github.com/coder/coder/tree/main |
| coder-sec-348-authenticate-client | https://github.com/coder/coder/tree/coder-sec-348-authenticate-client |
|
| https://github.com/BobbyHo |
| BobbyHo | https://github.com/BobbyHo |
| Sep 11, 2026 | https://github.com/coder/coder/pull/29206#issue-5419108518 |
| Please reload this page | https://github.com/coder/coder/pull/29206 |
| #29207 | https://github.com/coder/coder/pull/29207 |
| #29208 | https://github.com/coder/coder/pull/29208 |
| fix!: authenticate confidential clients at OAuth2 token revocation #29208 | https://github.com/coder/coder/pull/29208 |
| #28752 | https://github.com/coder/coder/pull/28752 |
| #29207 | https://github.com/coder/coder/pull/29207 |
| #29208 | https://github.com/coder/coder/pull/29208 |
| Please reload this page | https://github.com/coder/coder/pull/29206 |
| BobbyHo | https://github.com/BobbyHo |
| August 14, 2026 17:02 | https://github.com/coder/coder/pull/29206#commits-pushed-a672066 |
|
| https://github.com/BobbyHo |
| feat(coderd/rbac): compare scopes by permission coverage | https://github.com/coder/coder/pull/29206/commits/a6720664d7125a70e5e1407f513c5451b161bfb5 |
| a672066 | https://github.com/coder/coder/pull/29206/commits/a6720664d7125a70e5e1407f513c5451b161bfb5 |
|
| https://github.com/BobbyHo |
| Merge branch 'main' into plat479-1-rbac-scope-coverage | https://github.com/coder/coder/pull/29206/commits/4315706ed62335823ec556eb11ff1b93aac4075d |
| 4315706 | https://github.com/coder/coder/pull/29206/commits/4315706ed62335823ec556eb11ff1b93aac4075d |
|
| https://github.com/BobbyHo |
|
| https://github.com/claude |
| docs(coderd/rbac): shorten the ScopesCover doc comment | https://github.com/coder/coder/pull/29206/commits/787c4614f0358259851ef89713f516915fa586bf |
| 787c461 | https://github.com/coder/coder/pull/29206/commits/787c4614f0358259851ef89713f516915fa586bf |
|
| https://github.com/BobbyHo |
| Merge branch 'main' into plat479-1-rbac-scope-coverage | https://github.com/coder/coder/pull/29206/commits/2d39e04a63dedf25975cee5a859896333d6b2833 |
| 2d39e04 | https://github.com/coder/coder/pull/29206/commits/2d39e04a63dedf25975cee5a859896333d6b2833 |
|
| https://github.com/BobbyHo |
|
| https://github.com/claude |
| fix(coderd/rbac): guard allowed-side org and user permissions | https://github.com/coder/coder/pull/29206/commits/2f6c44e3c80e388be7986ef0d13f4f4ea414f42f |
| 2f6c44e | https://github.com/coder/coder/pull/29206/commits/2f6c44e3c80e388be7986ef0d13f4f4ea414f42f |
|
| https://github.com/BobbyHo |
| refactor(coderd/rbac): drop the unreachable negative skip in coverage | https://github.com/coder/coder/pull/29206/commits/bd4027025da8a84ddb5aef9aa9b7e1ae5ed9348f |
| bd40270 | https://github.com/coder/coder/pull/29206/commits/bd4027025da8a84ddb5aef9aa9b7e1ae5ed9348f |
|
| https://github.com/BobbyHo |
| test(coderd/rbac): pin the scope coverage table's weak assertions | https://github.com/coder/coder/pull/29206/commits/3139c54fe0dfda18835de1c73ca9530d5f82ff71 |
| 3139c54 | https://github.com/coder/coder/pull/29206/commits/3139c54fe0dfda18835de1c73ca9530d5f82ff71 |
|
| https://github.com/BobbyHo |
| refactor(coderd/rbac): make the coverage guards reachable from tests | https://github.com/coder/coder/pull/29206/commits/9276bb87f42eac8ad8aa9a103ed43c535aab7c21 |
| 9276bb8 | https://github.com/coder/coder/pull/29206/commits/9276bb87f42eac8ad8aa9a103ed43c535aab7c21 |
|
| https://github.com/BobbyHo |
| refactor(coderd/rbac): share the alias table and name the canonical c… | https://github.com/coder/coder/pull/29206/commits/865eb9a56785dd737235fa613f8592e87909bff4 |
| 865eb9a | https://github.com/coder/coder/pull/29206/commits/865eb9a56785dd737235fa613f8592e87909bff4 |
|
| https://github.com/BobbyHo |
| docs(coderd/rbac): document the expansion invariant where it can be b… | https://github.com/coder/coder/pull/29206/commits/26a6bed5766575d018bb6a86291a832557f3afe7 |
| 26a6bed | https://github.com/coder/coder/pull/29206/commits/26a6bed5766575d018bb6a86291a832557f3afe7 |
|
| https://github.com/BobbyHo |
| Merge branch 'main' into plat479-1-rbac-scope-coverage | https://github.com/coder/coder/pull/29206/commits/7cca7b318f665dd81645ba5df7eabca2ab779b31 |
| 7cca7b3 | https://github.com/coder/coder/pull/29206/commits/7cca7b318f665dd81645ba5df7eabca2ab779b31 |
|
| https://github.com/BobbyHo |
|
| https://github.com/claude |
| test(coderd/rbac): pin the coverage guards at one strength | https://github.com/coder/coder/pull/29206/commits/1678a77a661a4d644e69abaf1c852fec8d3327cf |
| 1678a77 | https://github.com/coder/coder/pull/29206/commits/1678a77a661a4d644e69abaf1c852fec8d3327cf |
|
| https://github.com/BobbyHo |
|
| https://github.com/claude |
| fix(coderd/rbac): name the scope once in expansion errors | https://github.com/coder/coder/pull/29206/commits/aba3c6c0f78d08bc0a7a9d2b1428cbb257229ae0 |
| aba3c6c | https://github.com/coder/coder/pull/29206/commits/aba3c6c0f78d08bc0a7a9d2b1428cbb257229ae0 |
|
| https://github.com/BobbyHo |
|
| https://github.com/claude |
| docs(coderd/rbac): correct the external scope list contract | https://github.com/coder/coder/pull/29206/commits/9a081051b0f37b9db5fe7adb65d29bffa47f7cbc |
| 9a08105 | https://github.com/coder/coder/pull/29206/commits/9a081051b0f37b9db5fe7adb65d29bffa47f7cbc |
|
| https://github.com/BobbyHo |
|
| https://github.com/claude |
| docs(coderd/rbac): trim the restated coverage invariant | https://github.com/coder/coder/pull/29206/commits/2fcce8b2d67271e006310cf3acbc9adf2a2d3225 |
| 2fcce8b | https://github.com/coder/coder/pull/29206/commits/2fcce8b2d67271e006310cf3acbc9adf2a2d3225 |
|
| https://github.com/BobbyHo |
| docs(coderd/rbac): correct the negative permission cross-reference | https://github.com/coder/coder/pull/29206/commits/a775a482cd28ccb1c9a1d96d066cd7c16ea69764 |
| a775a48 | https://github.com/coder/coder/pull/29206/commits/a775a482cd28ccb1c9a1d96d066cd7c16ea69764 |
|
| https://github.com/BobbyHo |
| docs(coderd/rbac): name every category IsExternalScope admits | https://github.com/coder/coder/pull/29206/commits/e0c0d4ac5d7bbd5589ad8a82351680a7be6255f6 |
| e0c0d4a | https://github.com/coder/coder/pull/29206/commits/e0c0d4ac5d7bbd5589ad8a82351680a7be6255f6 |
|
| https://github.com/BobbyHo |
| test(coderd/rbac): pin the alias list invariants on the alias table | https://github.com/coder/coder/pull/29206/commits/189740dc21566573255a81bc839eba054f92afa9 |
| 189740d | https://github.com/coder/coder/pull/29206/commits/189740dc21566573255a81bc839eba054f92afa9 |
|
| https://github.com/BobbyHo |
| Merge branch 'main' into plat479-1-rbac-scope-coverage | https://github.com/coder/coder/pull/29206/commits/7d08e492a0a9efbded2ad94b9ad0941a79e2786e |
| 7d08e49 | https://github.com/coder/coder/pull/29206/commits/7d08e492a0a9efbded2ad94b9ad0941a79e2786e |
|
| https://github.com/BobbyHo |
| feat(coderd/oauth2provider): negotiate and persist authorization scope | https://github.com/coder/coder/pull/29206/commits/ca4dc522eb6ac82ef953843002ad9594b9bf2302 |
| ca4dc52 | https://github.com/coder/coder/pull/29206/commits/ca4dc522eb6ac82ef953843002ad9594b9bf2302 |
|
| https://github.com/BobbyHo |
| feat(site): state the negotiated scope on the OAuth2 consent page | https://github.com/coder/coder/pull/29206/commits/f402e1a44bf772bcaf351662aa3f06da27a44601 |
| f402e1a | https://github.com/coder/coder/pull/29206/commits/f402e1a44bf772bcaf351662aa3f06da27a44601 |
|
| https://github.com/BobbyHo |
| fix(coderd/oauth2provider): return invalid_scope to the client's call… | https://github.com/coder/coder/pull/29206/commits/28ef5bab04c5195b46419e1aee2e01f96831b51b |
| 28ef5ba | https://github.com/coder/coder/pull/29206/commits/28ef5bab04c5195b46419e1aee2e01f96831b51b |
|
| https://github.com/BobbyHo |
| test(coderd/rbac): close two mutation gaps in scope coverage tests | https://github.com/coder/coder/pull/29206/commits/62950d36e12d2b822f908f0f710acee36270f144 |
| 62950d3 | https://github.com/coder/coder/pull/29206/commits/62950d36e12d2b822f908f0f710acee36270f144 |
|
| https://github.com/BobbyHo |
| Merge branch 'main' into plat479-2-negotiate-scope | https://github.com/coder/coder/pull/29206/commits/554a70319cba347ca892f1a4e9e6397d273efeba |
| 554a703 | https://github.com/coder/coder/pull/29206/commits/554a70319cba347ca892f1a4e9e6397d273efeba |
|
| https://github.com/BobbyHo |
| refactor(coderd/oauth2provider): rename validateRequestedScope to neg… | https://github.com/coder/coder/pull/29206/commits/09bc1b4e8584888058d5c1662f8fc30bed427066 |
| 09bc1b4 | https://github.com/coder/coder/pull/29206/commits/09bc1b4e8584888058d5c1662f8fc30bed427066 |
|
| https://github.com/BobbyHo |
| test(coderd/oauth2provider): bind the wire-level scope reasons to the… | https://github.com/coder/coder/pull/29206/commits/6fe6c7100ca41248b57e2cc5f37ede6d86025bc9 |
| 6fe6c71 | https://github.com/coder/coder/pull/29206/commits/6fe6c7100ca41248b57e2cc5f37ede6d86025bc9 |
|
| https://github.com/BobbyHo |
| refactor(coderd): log undecidable oauth2 scope coverage instead of re… | https://github.com/coder/coder/pull/29206/commits/e296ddab0fe10237ef368d6f3e97a4e0d970c085 |
| e296dda | https://github.com/coder/coder/pull/29206/commits/e296ddab0fe10237ef368d6f3e97a4e0d970c085 |
|
| https://github.com/BobbyHo |
| fix(coderd/oauth2provider): name the stored allowlist when none of it… | https://github.com/coder/coder/pull/29206/commits/2760db5789ad5cff95d6ef8bbc801d1875a9033e |
| 2760db5 | https://github.com/coder/coder/pull/29206/commits/2760db5789ad5cff95d6ef8bbc801d1875a9033e |
|
| https://github.com/BobbyHo |
| refactor(coderd/oauth2provider): reword the oauth2 scope rejection re… | https://github.com/coder/coder/pull/29206/commits/5b2ca577787838a5278b32b0976929fc554bcccd |
| 5b2ca57 | https://github.com/coder/coder/pull/29206/commits/5b2ca577787838a5278b32b0976929fc554bcccd |
|
| https://github.com/BobbyHo |
| docs: correct what the oauth2 authorize scope parameter promises | https://github.com/coder/coder/pull/29206/commits/90a6f8381dc228f76da6839f2d2bacd2717aae33 |
| 90a6f83 | https://github.com/coder/coder/pull/29206/commits/90a6f8381dc228f76da6839f2d2bacd2717aae33 |
| BobbyHo | https://github.com/BobbyHo |
| September 9, 2026 11:46 | https://github.com/coder/coder/pull/29206#commits-pushed-fefddb5 |
|
| https://github.com/BobbyHo |
| Merge branch 'main' into plat481-2-single-use-refresh | https://github.com/coder/coder/pull/29206/commits/fefddb5aafe2f58b4004d2517d9043f9ba5067b6 |
| fefddb5 | https://github.com/coder/coder/pull/29206/commits/fefddb5aafe2f58b4004d2517d9043f9ba5067b6 |
|
| https://github.com/BobbyHo |
| Merge branch 'main' into plat481-2-single-use-refresh | https://github.com/coder/coder/pull/29206/commits/2bacd8c4f30ccbdb154eded516e14e03ed6102c6 |
| 2bacd8c | https://github.com/coder/coder/pull/29206/commits/2bacd8c4f30ccbdb154eded516e14e03ed6102c6 |
|
| https://github.com/BobbyHo |
| Merge branch 'main' into plat481-2-single-use-refresh | https://github.com/coder/coder/pull/29206/commits/1cebdf73be5b9b15de85dbb00023b407c7caa5eb |
| 1cebdf7 | https://github.com/coder/coder/pull/29206/commits/1cebdf73be5b9b15de85dbb00023b407c7caa5eb |
|
| https://github.com/BobbyHo |
| refactor(coderd/oauth2provider): extract OAuth2 client authentication… | https://github.com/coder/coder/pull/29206/commits/ea5e03fdb216c63def40758349ed1a954dbbad31 |
| ea5e03f | https://github.com/coder/coder/pull/29206/commits/ea5e03fdb216c63def40758349ed1a954dbbad31 |
| https://github.com/apps/linear-code |
| linear-code | https://github.com/apps/linear-code |
| Sep 11, 2026 | https://github.com/coder/coder/pull/29206#issuecomment-5627877419 |
| SEC-348 | https://linear.app/codercom/issue/SEC-348 |
| Please reload this page | https://github.com/coder/coder/pull/29206 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| BobbyHo | https://github.com/BobbyHo |
| Sep 11, 2026 | https://github.com/coder/coder/pull/29206#event-30941764317 |
|
fix: authenticate confidential clients on the OAuth2 refresh grant
#29207
| https://github.com/coder/coder/pull/29207 |
|
fix!: authenticate confidential clients at OAuth2 token revocation
#29208
| https://github.com/coder/coder/pull/29208 |
| BobbyHo | https://github.com/BobbyHo |
| September 10, 2026 18:22 | https://github.com/coder/coder/pull/29206#commits-pushed-097e59a |
|
| https://github.com/BobbyHo |
| test(coderd/oauth2provider): create the test context inside each para… | https://github.com/coder/coder/pull/29206/commits/097e59a157c14d6c510023e3967cecf0e94d07d6 |
| 097e59a | https://github.com/coder/coder/pull/29206/commits/097e59a157c14d6c510023e3967cecf0e94d07d6 |
|
| https://github.com/BobbyHo |
| docs(coderd/oauth2provider): shorten the mergeBasicClientAuth comment | https://github.com/coder/coder/pull/29206/commits/49e9f5dbadfde42569185c7dd80397d06ed21f6e |
| 49e9f5d | https://github.com/coder/coder/pull/29206/commits/49e9f5dbadfde42569185c7dd80397d06ed21f6e |
|
| https://github.com/BobbyHo |
| docs(coderd/oauth2provider): shorten the authenticateClient comments | https://github.com/coder/coder/pull/29206/commits/6bbace743677274e51b756cabfe5fab48cd2d675 |
| 6bbace7 | https://github.com/coder/coder/pull/29206/commits/6bbace743677274e51b756cabfe5fab48cd2d675 |
| https://github.com/BobbyHo |
| BobbyHo | https://github.com/BobbyHo |
| Sep 11, 2026 | https://github.com/coder/coder/pull/29206#issuecomment-5628039812 |
| Please reload this page | https://github.com/coder/coder/pull/29206 |
| https://github.com/apps/coder-agents-review |
| coder-agents-review | https://github.com/apps/coder-agents-review |
| Sep 11, 2026 | https://github.com/coder/coder/pull/29206#issuecomment-5628040681 |
| Please reload this page | https://github.com/coder/coder/pull/29206 |
| View chat | https://dogfood.cdr.dev/agents/99a6845d-f6ed-49a7-92c5-15fe5bfcebba |
| @BobbyHo | https://github.com/BobbyHo |
| 1cebdf7..6bbace7 | https://github.com/coder/coder/compare/1cebdf73be5b9b15de85dbb00023b407c7caa5eb...6bbace743677274e51b756cabfe5fab48cd2d675 |
| Review | https://github.com/coder/coder/pull/29206#pullrequestreview-5174202784 |
| #29206 | https://github.com/coder/coder/pull/29206 |
| #29207 | https://github.com/coder/coder/pull/29207 |
| #29208 | https://github.com/coder/coder/pull/29208 |
| 1cebdf7 | https://github.com/coder/coder/commit/1cebdf73be5b9b15de85dbb00023b407c7caa5eb |
| 6bbace7 | https://github.com/coder/coder/commit/6bbace743677274e51b756cabfe5fab48cd2d675 |
| Coder Agents | https://coder.com |
| Please reload this page | https://github.com/coder/coder/pull/29206 |
| https://github.com/apps/coder-agents-review |
| coder-agents-review | https://github.com/apps/coder-agents-review |
|
Sep 11, 2026
| https://github.com/coder/coder/pull/29206#pullrequestreview-5174202784 |
|
View reviewed changes
| https://github.com/coder/coder/pull/29206/files/6bbace743677274e51b756cabfe5fab48cd2d675 |
| coder-agents-review | https://github.com/apps/coder-agents-review |
| https://github.com/coder/coder/pull/29206#pullrequestreview-5174202784 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #29207 | https://github.com/coder/coder/pull/29207 |
| #29208 | https://github.com/coder/coder/pull/29208 |
| Please reload this page | https://github.com/coder/coder/pull/29206 |
| coderd/oauth2provider/tokens.go | https://github.com/coder/coder/pull/29206/files/6bbace743677274e51b756cabfe5fab48cd2d675#diff-b7cdb379f8db8561c7e6cdb6423de679c8c7ed955cadce0322817679c00c9caf |
| Please reload this page | https://github.com/coder/coder/pull/29206 |
| coderd/oauth2provider/tokens_internal_test.go | https://github.com/coder/coder/pull/29206/files/6bbace743677274e51b756cabfe5fab48cd2d675#diff-38791eba1f125ea1fe958e99d0cb351bab1ef966785a11f7c5a318cffbd1d806 |
| Please reload this page | https://github.com/coder/coder/pull/29206 |
| coderd/oauth2provider/tokens.go | https://github.com/coder/coder/pull/29206/files/6bbace743677274e51b756cabfe5fab48cd2d675#diff-b7cdb379f8db8561c7e6cdb6423de679c8c7ed955cadce0322817679c00c9caf |
| Please reload this page | https://github.com/coder/coder/pull/29206 |
| coderd/oauth2provider/tokens.go | https://github.com/coder/coder/pull/29206/files/6bbace743677274e51b756cabfe5fab48cd2d675#diff-b7cdb379f8db8561c7e6cdb6423de679c8c7ed955cadce0322817679c00c9caf |
| Please reload this page | https://github.com/coder/coder/pull/29206 |
| coderd/oauth2provider/tokens.go | https://github.com/coder/coder/pull/29206/files/6bbace743677274e51b756cabfe5fab48cd2d675#diff-b7cdb379f8db8561c7e6cdb6423de679c8c7ed955cadce0322817679c00c9caf |
| Please reload this page | https://github.com/coder/coder/pull/29206 |
| coderd/oauth2provider/tokens_internal_test.go | https://github.com/coder/coder/pull/29206/files/6bbace743677274e51b756cabfe5fab48cd2d675#diff-38791eba1f125ea1fe958e99d0cb351bab1ef966785a11f7c5a318cffbd1d806 |
| Please reload this page | https://github.com/coder/coder/pull/29206 |
| coderd/oauth2provider/tokens_internal_test.go | https://github.com/coder/coder/pull/29206/files/6bbace743677274e51b756cabfe5fab48cd2d675#diff-38791eba1f125ea1fe958e99d0cb351bab1ef966785a11f7c5a318cffbd1d806 |
| Please reload this page | https://github.com/coder/coder/pull/29206 |
| coderd/oauth2provider/tokens.go | https://github.com/coder/coder/pull/29206/files/6bbace743677274e51b756cabfe5fab48cd2d675#diff-b7cdb379f8db8561c7e6cdb6423de679c8c7ed955cadce0322817679c00c9caf |
| Please reload this page | https://github.com/coder/coder/pull/29206 |
| coderd/oauth2provider/tokens.go | https://github.com/coder/coder/pull/29206/files/6bbace743677274e51b756cabfe5fab48cd2d675#diff-b7cdb379f8db8561c7e6cdb6423de679c8c7ed955cadce0322817679c00c9caf |
| Please reload this page | https://github.com/coder/coder/pull/29206 |
| BobbyHo | https://github.com/BobbyHo |
| September 10, 2026 20:29 | https://github.com/coder/coder/pull/29206#commits-pushed-12e30c2 |
|
| https://github.com/BobbyHo |
| Merge branch 'main' into plat481-2-single-use-refresh | https://github.com/coder/coder/pull/29206/commits/12e30c2d745e3385ef6943ea5291cb21e3c7e2a6 |
| 12e30c2 | https://github.com/coder/coder/pull/29206/commits/12e30c2d745e3385ef6943ea5291cb21e3c7e2a6 |
|
| https://github.com/BobbyHo |
| Merge branch 'plat481-2-single-use-refresh' into coder-sec-348-authen… | https://github.com/coder/coder/pull/29206/commits/5b571d1e92c3424e739292fae68d82ef85b38c3e |
| 5b571d1 | https://github.com/coder/coder/pull/29206/commits/5b571d1e92c3424e739292fae68d82ef85b38c3e |
|
| https://github.com/BobbyHo |
| docs(coderd/oauth2provider): explain the app binding in authenticateC… | https://github.com/coder/coder/pull/29206/commits/af19d9693a75344a58f615c9d5789753be35cf31 |
| af19d96 | https://github.com/coder/coder/pull/29206/commits/af19d9693a75344a58f615c9d5789753be35cf31 |
|
| https://github.com/BobbyHo |
| chore(coderd/oauth2provider): address review of the client auth helpers | https://github.com/coder/coder/pull/29206/commits/314e184b55459411735c5dab4abac639896d6e59 |
| 314e184 | https://github.com/coder/coder/pull/29206/commits/314e184b55459411735c5dab4abac639896d6e59 |
| September 11, 2026 19:47 | https://github.com/coder/coder/pull/29206#event-30995842145 |
|
| https://github.com/BobbyHo |
| Merge branch 'main' into coder-sec-348-authenticate-client | https://github.com/coder/coder/pull/29206/commits/4876e0c978673c85bc5dd93f829a9cba5fd95a68 |
| 4876e0c | https://github.com/coder/coder/pull/29206/commits/4876e0c978673c85bc5dd93f829a9cba5fd95a68 |
| https://github.com/BobbyHo |
| BobbyHo | https://github.com/BobbyHo |
| September 11, 2026 19:50 | https://github.com/coder/coder/pull/29206#event-30995953217 |
| https://github.com/BobbyHo |
| BobbyHo | https://github.com/BobbyHo |
| dylanhuff-at-coder | https://github.com/dylanhuff-at-coder |
| September 11, 2026 19:50 | https://github.com/coder/coder/pull/29206#event-30995959308 |
| BobbyHo | https://github.com/BobbyHo |
| September 14, 2026 07:54 | https://github.com/coder/coder/pull/29206#commits-pushed-f942729 |
|
| https://github.com/BobbyHo |
| Merge branch 'main' into coder-sec-348-authenticate-client | https://github.com/coder/coder/pull/29206/commits/f942729a17004255319c0efbbe725de8f76e8b17 |
| f942729 | https://github.com/coder/coder/pull/29206/commits/f942729a17004255319c0efbbe725de8f76e8b17 |
|
| https://github.com/BobbyHo |
| Merge branch 'main' into coder-sec-348-authenticate-client | https://github.com/coder/coder/pull/29206/commits/a32e7a84f7698027902223b8e4957e2ca4e8f1ae |
| a32e7a8 | https://github.com/coder/coder/pull/29206/commits/a32e7a84f7698027902223b8e4957e2ca4e8f1ae |
| https://github.com/dylanhuff-at-coder |
| dylanhuff-at-coder | https://github.com/dylanhuff-at-coder |
|
Sep 14, 2026
| https://github.com/coder/coder/pull/29206#pullrequestreview-5204065903 |
|
View reviewed changes
| https://github.com/coder/coder/pull/29206/files/a32e7a84f7698027902223b8e4957e2ca4e8f1ae |
| dylanhuff-at-coder | https://github.com/dylanhuff-at-coder |
| https://github.com/coder/coder/pull/29206#pullrequestreview-5204065903 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/29206 |
| coderd/oauth2provider/tokens.go | https://github.com/coder/coder/pull/29206/files/a32e7a84f7698027902223b8e4957e2ca4e8f1ae#diff-b7cdb379f8db8561c7e6cdb6423de679c8c7ed955cadce0322817679c00c9caf |
| Please reload this page | https://github.com/coder/coder/pull/29206 |
| BobbyHo | https://github.com/BobbyHo |
| September 15, 2026 00:07 | https://github.com/coder/coder/pull/29206#commits-pushed-87d183e |
|
| https://github.com/BobbyHo |
| fix(coderd/oauth2provider): trim inaccurate PKCE claim from authentic… | https://github.com/coder/coder/pull/29206/commits/87d183e99dac9ffcd605b32a1a7a6016604943f1 |
| 87d183e | https://github.com/coder/coder/pull/29206/commits/87d183e99dac9ffcd605b32a1a7a6016604943f1 |
|
| https://github.com/BobbyHo |
| Merge branch 'main' into coder-sec-348-authenticate-client | https://github.com/coder/coder/pull/29206/commits/2f67cc04feed488a523c542950c9e02f9477dee1 |
| 2f67cc0 | https://github.com/coder/coder/pull/29206/commits/2f67cc04feed488a523c542950c9e02f9477dee1 |
| https://github.com/BobbyHo |
| BobbyHo | https://github.com/BobbyHo |
| 52e5bf7 | https://github.com/coder/coder/commit/52e5bf7e8235aac66cf321d1cd3b0dcfcdcdb9b3 |
| Sep 15, 2026 | https://github.com/coder/coder/pull/29206#event-31139063032 |
| Please reload this page | https://github.com/coder/coder/pull/29206 |
| https://github.com/BobbyHo |
| BobbyHo | https://github.com/BobbyHo |
| September 15, 2026 00:40 | https://github.com/coder/coder/pull/29206#event-31139064836 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Sep 15, 2026 | https://github.com/coder/coder/pull/29206#event-31139067418 |
| https://github.co/hiddenchars |
| https://github.com/coder/coder/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F29206 |
|
| https://github.com/dylanhuff-at-coder |
|
dylanhuff-at-coder
| https://github.com/dylanhuff-at-coder |
|
| https://github.com/coder/coder/pull/29206/files/a32e7a84f7698027902223b8e4957e2ca4e8f1ae |
|
| https://github.com/apps/coder-agents-review |
|
coder-agents-review[bot]
| https://github.com/apps/coder-agents-review |
|
| https://github.com/coder/coder/pull/29206/files/6bbace743677274e51b756cabfe5fab48cd2d675 |
| Please reload this page | https://github.com/coder/coder/pull/29206 |
|
| https://github.com/BobbyHo |
|
BobbyHo
| https://github.com/BobbyHo |
| Please reload this page | https://github.com/coder/coder/pull/29206 |
|
| https://github.com/BobbyHo |
|
| https://github.com/dylanhuff-at-coder |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |