René's URL Explorer Experiment


Title: fix: strip headers containing underscores from being signed before sending to Bedrock by johnstcn · Pull Request #29131 · coder/coder · GitHub

Open Graph Title: fix: strip headers containing underscores from being signed before sending to Bedrock by johnstcn · Pull Request #29131 · coder/coder

X Title: fix: strip headers containing underscores from being signed before sending to Bedrock by johnstcn · Pull Request #29131 · coder/coder

Description: Secure environments for developers and their agents - fix: strip headers containing underscores from being signed before sending to Bedrock by johnstcn · Pull Request #29131 · coder/coder

Open Graph Description: While testing the changes in #28404 / #28420 using the Pi coding agent, an issue surfaced with headers containing underscores. It appears that they don't make it all the way to AWS. The best fi...

X Description: While testing the changes in #28404 / #28420 using the Pi coding agent, an issue surfaced with headers containing underscores. It appears that they don't make it all the way to AWS. The bes...

Opengraph URL: https://github.com/coder/coder/pull/29131

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:72335865-8b25-51a8-53f4-78a590bc3059
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB814:1EC9BC:2BD9102:37E9D24:6B01B809
html-safe-noncea17fab1b2a97c762daaeb8d5586f2ff7829ac52213858fdbff8a7569356656ed
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODE0OjFFQzlCQzoyQkQ5MTAyOjM3RTlEMjQ6NkIwMUI4MDkiLCJ2aXNpdG9yX2lkIjoiNTg4MTA1MTczNzU2MDgyMzgxNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac36ee68c3f774ea698b6c7dcdade643dc219eb0e75c17fb24ed76a72018329e5a
hovercard-subject-tagpull_request:4484836634
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/29131/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1d9f828b0ff5dfff5d3e3a8c9774695077646af5a0a0814d4da8a9b9e2cde929/coder/coder/pull/29131
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1d9f828b0ff5dfff5d3e3a8c9774695077646af5a0a0814d4da8a9b9e2cde929/coder/coder/pull/29131
og:image:altWhile testing the changes in #28404 / #28420 using the Pi coding agent, an issue surfaced with headers containing underscores. It appears that they don't make it all the way to AWS. The best fi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejohnstcn
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/coder/coder/pull/29131#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F29131
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F29131
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/pull/29131
Reloadhttps://github.com/coder/coder/pull/29131
Reloadhttps://github.com/coder/coder/pull/29131
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
https://github.com/coder/coder
johnstcnhttps://github.com/johnstcn
mainhttps://github.com/coder/coder/tree/main
cj/bedrocksig_underscoreshttps://github.com/coder/coder/tree/cj/bedrocksig_underscores
Conversationhttps://github.com/coder/coder/pull/29131
Commits4 (4)https://github.com/coder/coder/pull/29131/commits
Checkshttps://github.com/coder/coder/pull/29131/checks
Files changedhttps://github.com/coder/coder/pull/29131/files
fix: strip headers containing underscores from being signed before sending to Bedrockhttps://github.com/coder/coder/pull/29131#top
johnstcnhttps://github.com/johnstcn
mainhttps://github.com/coder/coder/tree/main
cj/bedrocksig_underscoreshttps://github.com/coder/coder/tree/cj/bedrocksig_underscores
https://github.com/johnstcn
johnstcnhttps://github.com/johnstcn
Sep 9, 2026https://github.com/coder/coder/pull/29131#issue-5399356247
Please reload this pagehttps://github.com/coder/coder/pull/29131
#28404https://github.com/coder/coder/pull/28404
#28420https://github.com/coder/coder/pull/28420
Please reload this pagehttps://github.com/coder/coder/pull/29131
https://github.com/Shelnutt2
refactor(aibridge): generalize AWS SigV4 signing beyond Bedrockhttps://github.com/coder/coder/pull/29131/commits/76530562cbf7b356e679652654799155ca365c33
7653056https://github.com/coder/coder/pull/29131/commits/76530562cbf7b356e679652654799155ca365c33
https://github.com/johnstcn
johnstcnhttps://github.com/johnstcn
Sep 9, 2026https://github.com/coder/coder/pull/29131#event-30827650439
https://github.com/johnstcn
johnstcnhttps://github.com/johnstcn
stack #28447https://github.com/coder/coder/stack/28447
September 9, 2026 12:25https://github.com/coder/coder/pull/29131#event-30827651007
https://github.com/apps/copilot-pull-request-reviewer
Copilothttps://github.com/apps/copilot-pull-request-reviewer
September 9, 2026 12:25https://github.com/coder/coder/pull/29131#event-30827651288
started reviewinghttps://github.com/coder/coder/sessions/703b90e4-9cfd-4c4c-9b96-3bea27d99bd9
johnstcnhttps://github.com/johnstcn
September 9, 2026 12:25https://github.com/coder/coder/pull/29131#event-30827685344
View session https://github.com/coder/coder/sessions/703b90e4-9cfd-4c4c-9b96-3bea27d99bd9
https://github.com/johnstcn
johnstcnhttps://github.com/johnstcn
evgeniy-scherbinahttps://github.com/evgeniy-scherbina
pawbanahttps://github.com/pawbana
September 9, 2026 12:26https://github.com/coder/coder/pull/29131#event-30827693499
https://github.com/apps/copilot-pull-request-reviewer
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Sep 9, 2026 https://github.com/coder/coder/pull/29131#pullrequestreview-5154185147
View reviewed changes https://github.com/coder/coder/pull/29131/files
Copilothttps://github.com/apps/copilot-pull-request-reviewer
https://github.com/coder/coder/pull/29131#pullrequestreview-5154185147
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Add a code-review agent skillhttps://github.com/coder/coder/new/cj/hack/bedrock-openai?filename=.github/skills/code-review/SKILL.md
Learn more in the docs.https://docs.github.com/copilot/how-tos/use-copilot-agents/request-a-code-review/use-code-review?tool=webui#mcp-servers-and-agent-skills
Please reload this pagehttps://github.com/coder/coder/pull/29131
https://github.com/dannykopping
dannykoppinghttps://github.com/dannykopping
Sep 9, 2026 https://github.com/coder/coder/pull/29131#pullrequestreview-5154204277
View reviewed changes https://github.com/coder/coder/pull/29131/files
aibridge/intercept/bedrocksig/bedrocksig.gohttps://github.com/coder/coder/pull/29131/files#diff-29014f747e822edbf78dff7c63b20c6b3b9dafa08de6e622a120bfbe31f3aa82
dannykoppinghttps://github.com/dannykopping
Sep 9, 2026https://github.com/coder/coder/pull/29131#discussion_r3968309773
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/29131
johnstcnhttps://github.com/johnstcn
Sep 9, 2026https://github.com/coder/coder/pull/29131#discussion_r3968610922
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/29131
dannykoppinghttps://github.com/dannykopping
Sep 9, 2026https://github.com/coder/coder/pull/29131#discussion_r3968620949
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/29131
aibridge/intercept/bedrocksig/bedrocksig_test.gohttps://github.com/coder/coder/pull/29131/files#diff-5a98308a267e1dd9b07c40cbe367cd07c96987d151f628e7cb3eb1ee17114ba7
Please reload this pagehttps://github.com/coder/coder/pull/29131
aibridge/intercept/bedrocksig/bedrocksig.gohttps://github.com/coder/coder/pull/29131/files#diff-29014f747e822edbf78dff7c63b20c6b3b9dafa08de6e622a120bfbe31f3aa82
Please reload this pagehttps://github.com/coder/coder/pull/29131
https://github.com/johnstcn
johnstcnhttps://github.com/johnstcn
Sep 9, 2026 https://github.com/coder/coder/pull/29131#ref-pullrequest-5376129647
refactor(aibridge): generalize AWS SigV4 signing beyond Bedrock #29047 https://github.com/coder/coder/pull/29047
https://github.com/dannykopping
dannykoppinghttps://github.com/dannykopping
Sep 9, 2026 https://github.com/coder/coder/pull/29131#pullrequestreview-5155366799
View reviewed changes https://github.com/coder/coder/pull/29131/files
dannykoppinghttps://github.com/dannykopping
https://github.com/coder/coder/pull/29131#pullrequestreview-5155366799
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/29131
https://github.com/johnstcn
johnstcnhttps://github.com/johnstcn
force-pushedhttps://github.com/coder/coder/compare/86b6b9d7d99f039842de2dacb422c1ac6b8ec4a0..64fe2fd3b23fc33e16f8f01e02b295c49a962c47
86b6b9dhttps://github.com/coder/coder/commit/86b6b9d7d99f039842de2dacb422c1ac6b8ec4a0
64fe2fdhttps://github.com/coder/coder/commit/64fe2fd3b23fc33e16f8f01e02b295c49a962c47
Compare https://github.com/coder/coder/compare/86b6b9d7d99f039842de2dacb422c1ac6b8ec4a0..64fe2fd3b23fc33e16f8f01e02b295c49a962c47
September 9, 2026 14:27https://github.com/coder/coder/pull/29131#event-30835882186
https://github.com/pawbana
pawbanahttps://github.com/pawbana
Sep 9, 2026https://github.com/coder/coder/pull/29131#issuecomment-5603986121
https://docs.aws.amazon.com/elasticloadbalancing/latest/application/application-load-balancers.htmlhttps://docs.aws.amazon.com/elasticloadbalancing/latest/application/application-load-balancers.html
https://repost.aws/questions/QUgTKJm0-cSrKiAJHJp1eWGQ/underscores-in-headers-aws-api-gatewayhttps://repost.aws/questions/QUgTKJm0-cSrKiAJHJp1eWGQ/underscores-in-headers-aws-api-gateway
Please reload this pagehttps://github.com/coder/coder/pull/29131
https://github.com/pawbana
pawbanahttps://github.com/pawbana
Sep 9, 2026 https://github.com/coder/coder/pull/29131#pullrequestreview-5156581758
View reviewed changes https://github.com/coder/coder/pull/29131/files
September 9, 2026 17:29https://github.com/coder/coder/pull/29131#event-30847232630
https://github.com/johnstcn
johnstcnhttps://github.com/johnstcn
Sep 10, 2026https://github.com/coder/coder/pull/29131#event-30890060885
https://github.com/johnstcn
johnstcnhttps://github.com/johnstcn
force-pushedhttps://github.com/coder/coder/compare/9d84e2eb68dcc75dba3fe06d421b8e0237c74c43..d72f2be71d270ffa42dd8f752b0d4660b5776c28
9d84e2ehttps://github.com/coder/coder/commit/9d84e2eb68dcc75dba3fe06d421b8e0237c74c43
d72f2behttps://github.com/coder/coder/commit/d72f2be71d270ffa42dd8f752b0d4660b5776c28
Compare https://github.com/coder/coder/compare/9d84e2eb68dcc75dba3fe06d421b8e0237c74c43..d72f2be71d270ffa42dd8f752b0d4660b5776c28
September 11, 2026 22:43https://github.com/coder/coder/pull/29131#event-31003018597
johnstcnhttps://github.com/johnstcn
September 14, 2026 13:05https://github.com/coder/coder/pull/29131#commits-pushed-2b912b3
https://github.com/johnstcn
chore: merge mainhttps://github.com/coder/coder/pull/29131/commits/2b912b3895fc1e4c7af5e210c562d84077d576d4
2b912b3https://github.com/coder/coder/pull/29131/commits/2b912b3895fc1e4c7af5e210c562d84077d576d4
https://github.com/johnstcn
refactor(aibridge): separate Bedrock workaroundhttps://github.com/coder/coder/pull/29131/commits/0ae023469cc45f6cc3e4305d951579d198865e60
0ae0234https://github.com/coder/coder/pull/29131/commits/0ae023469cc45f6cc3e4305d951579d198865e60
https://github.com/johnstcn
fix(aibridge): strip unsafe Bedrock headershttps://github.com/coder/coder/pull/29131/commits/210df9f531be2822c6407086e9088b0b53cccdcd
210df9fhttps://github.com/coder/coder/pull/29131/commits/210df9f531be2822c6407086e9088b0b53cccdcd
https://github.com/johnstcn
johnstcnhttps://github.com/johnstcn
force-pushedhttps://github.com/coder/coder/compare/d72f2be71d270ffa42dd8f752b0d4660b5776c28..210df9f531be2822c6407086e9088b0b53cccdcd
d72f2behttps://github.com/coder/coder/commit/d72f2be71d270ffa42dd8f752b0d4660b5776c28
210df9fhttps://github.com/coder/coder/commit/210df9f531be2822c6407086e9088b0b53cccdcd
Compare https://github.com/coder/coder/compare/d72f2be71d270ffa42dd8f752b0d4660b5776c28..210df9f531be2822c6407086e9088b0b53cccdcd
September 15, 2026 13:42https://github.com/coder/coder/pull/29131#event-31176591032
https://github.com/johnstcn
johnstcnhttps://github.com/johnstcn
Sep 25, 2026https://github.com/coder/coder/pull/29131#event-31843366959
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 25, 2026https://github.com/coder/coder/pull/29131#event-31843378386
https://github.co/hiddenchars
https://github.com/coder/coder/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F29131
Copilot code review https://github.com/apps/copilot-pull-request-reviewer
Copilot https://github.com/apps/copilot-pull-request-reviewer
Learn more about Copilot code review.https://gh.io/copilot-code-review-docs
https://github.com/coder/coder/pull/29131/files/4b805ca7ee86f1c2935433860b7438bdb2a3e353
https://github.com/dannykopping
dannykopping https://github.com/dannykopping
https://github.com/coder/coder/pull/29131/files/86b6b9d7d99f039842de2dacb422c1ac6b8ec4a0
https://github.com/pawbana
pawbana https://github.com/pawbana
https://github.com/coder/coder/pull/29131/files/64fe2fd3b23fc33e16f8f01e02b295c49a962c47
https://github.com/evgeniy-scherbina
evgeniy-scherbina https://github.com/evgeniy-scherbina
Please reload this pagehttps://github.com/coder/coder/pull/29131
https://github.com/johnstcn
johnstcn https://github.com/johnstcn
Please reload this pagehttps://github.com/coder/coder/pull/29131
https://github.com/johnstcn
https://github.com/pawbana
https://github.com/dannykopping
https://github.com/apps/copilot-pull-request-reviewer
https://github.com/Shelnutt2
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.