| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:72335865-8b25-51a8-53f4-78a590bc3059 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B814:1EC9BC:2BD9102:37E9D24:6B01B809 |
| html-safe-nonce | a17fab1b2a97c762daaeb8d5586f2ff7829ac52213858fdbff8a7569356656ed |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODE0OjFFQzlCQzoyQkQ5MTAyOjM3RTlEMjQ6NkIwMUI4MDkiLCJ2aXNpdG9yX2lkIjoiNTg4MTA1MTczNzU2MDgyMzgxNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 36ee68c3f774ea698b6c7dcdade643dc219eb0e75c17fb24ed76a72018329e5a |
| hovercard-subject-tag | pull_request:4484836634 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/29131/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/1d9f828b0ff5dfff5d3e3a8c9774695077646af5a0a0814d4da8a9b9e2cde929/coder/coder/pull/29131 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1d9f828b0ff5dfff5d3e3a8c9774695077646af5a0a0814d4da8a9b9e2cde929/coder/coder/pull/29131 |
| og:image:alt | While testing the changes in #28404 / #28420 using the Pi coding agent, an issue surfaced with headers containing underscores. It appears that they don't make it all the way to AWS. The best fi... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | johnstcn |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/coder/coder git https://github.com/coder/coder.git |
| octolytics-dimension-user_id | 95932066 |
| octolytics-dimension-user_login | coder |
| octolytics-dimension-repository_id | 440752086 |
| octolytics-dimension-repository_nwo | coder/coder |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 440752086 |
| octolytics-dimension-repository_network_root_nwo | coder/coder |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/coder/coder/pull/29131#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F29131 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F29131 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder |
| Reload | https://github.com/coder/coder/pull/29131 |
| Reload | https://github.com/coder/coder/pull/29131 |
| Reload | https://github.com/coder/coder/pull/29131 |
| coder | https://github.com/coder |
| coder | https://github.com/coder/coder |
| Code | https://github.com/coder/coder |
| Issues320 (320) | https://github.com/coder/coder/issues |
| Pull requests470 (470) | https://github.com/coder/coder/pulls |
| Discussions | https://github.com/coder/coder/discussions |
| Actions | https://github.com/coder/coder/actions |
| Projects | https://github.com/coder/coder/projects |
| Security and quality49 (49) | https://github.com/coder/coder/security |
| Insights | https://github.com/coder/coder/insights |
| https://github.com/coder/coder |
| johnstcn | https://github.com/johnstcn |
| main | https://github.com/coder/coder/tree/main |
| cj/bedrocksig_underscores | https://github.com/coder/coder/tree/cj/bedrocksig_underscores |
| Conversation | https://github.com/coder/coder/pull/29131 |
| Commits4 (4) | https://github.com/coder/coder/pull/29131/commits |
| Checks | https://github.com/coder/coder/pull/29131/checks |
| Files changed | https://github.com/coder/coder/pull/29131/files |
| fix: strip headers containing underscores from being signed before sending to Bedrock | https://github.com/coder/coder/pull/29131#top |
| johnstcn | https://github.com/johnstcn |
| main | https://github.com/coder/coder/tree/main |
| cj/bedrocksig_underscores | https://github.com/coder/coder/tree/cj/bedrocksig_underscores |
|
| https://github.com/johnstcn |
| johnstcn | https://github.com/johnstcn |
| Sep 9, 2026 | https://github.com/coder/coder/pull/29131#issue-5399356247 |
| Please reload this page | https://github.com/coder/coder/pull/29131 |
| #28404 | https://github.com/coder/coder/pull/28404 |
| #28420 | https://github.com/coder/coder/pull/28420 |
| Please reload this page | https://github.com/coder/coder/pull/29131 |
|
| https://github.com/Shelnutt2 |
| refactor(aibridge): generalize AWS SigV4 signing beyond Bedrock | https://github.com/coder/coder/pull/29131/commits/76530562cbf7b356e679652654799155ca365c33 |
| 7653056 | https://github.com/coder/coder/pull/29131/commits/76530562cbf7b356e679652654799155ca365c33 |
| https://github.com/johnstcn |
| johnstcn | https://github.com/johnstcn |
| Sep 9, 2026 | https://github.com/coder/coder/pull/29131#event-30827650439 |
| https://github.com/johnstcn |
| johnstcn | https://github.com/johnstcn |
| stack #28447 | https://github.com/coder/coder/stack/28447 |
| September 9, 2026 12:25 | https://github.com/coder/coder/pull/29131#event-30827651007 |
|
| https://github.com/apps/copilot-pull-request-reviewer |
| Copilot | https://github.com/apps/copilot-pull-request-reviewer |
| September 9, 2026 12:25 | https://github.com/coder/coder/pull/29131#event-30827651288 |
| started reviewing | https://github.com/coder/coder/sessions/703b90e4-9cfd-4c4c-9b96-3bea27d99bd9 |
| johnstcn | https://github.com/johnstcn |
| September 9, 2026 12:25 | https://github.com/coder/coder/pull/29131#event-30827685344 |
|
View session
| https://github.com/coder/coder/sessions/703b90e4-9cfd-4c4c-9b96-3bea27d99bd9 |
| https://github.com/johnstcn |
| johnstcn | https://github.com/johnstcn |
| evgeniy-scherbina | https://github.com/evgeniy-scherbina |
| pawbana | https://github.com/pawbana |
| September 9, 2026 12:26 | https://github.com/coder/coder/pull/29131#event-30827693499 |
|
| https://github.com/apps/copilot-pull-request-reviewer |
| Copilot | https://github.com/apps/copilot-pull-request-reviewer |
|
Sep 9, 2026
| https://github.com/coder/coder/pull/29131#pullrequestreview-5154185147 |
|
View reviewed changes
| https://github.com/coder/coder/pull/29131/files |
| Copilot | https://github.com/apps/copilot-pull-request-reviewer |
| https://github.com/coder/coder/pull/29131#pullrequestreview-5154185147 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Add a code-review agent skill | https://github.com/coder/coder/new/cj/hack/bedrock-openai?filename=.github/skills/code-review/SKILL.md |
| Learn more in the docs. | https://docs.github.com/copilot/how-tos/use-copilot-agents/request-a-code-review/use-code-review?tool=webui#mcp-servers-and-agent-skills |
| Please reload this page | https://github.com/coder/coder/pull/29131 |
| https://github.com/dannykopping |
| dannykopping | https://github.com/dannykopping |
|
Sep 9, 2026
| https://github.com/coder/coder/pull/29131#pullrequestreview-5154204277 |
|
View reviewed changes
| https://github.com/coder/coder/pull/29131/files |
| aibridge/intercept/bedrocksig/bedrocksig.go | https://github.com/coder/coder/pull/29131/files#diff-29014f747e822edbf78dff7c63b20c6b3b9dafa08de6e622a120bfbe31f3aa82 |
| dannykopping | https://github.com/dannykopping |
| Sep 9, 2026 | https://github.com/coder/coder/pull/29131#discussion_r3968309773 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/29131 |
| johnstcn | https://github.com/johnstcn |
| Sep 9, 2026 | https://github.com/coder/coder/pull/29131#discussion_r3968610922 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/29131 |
| dannykopping | https://github.com/dannykopping |
| Sep 9, 2026 | https://github.com/coder/coder/pull/29131#discussion_r3968620949 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/29131 |
| aibridge/intercept/bedrocksig/bedrocksig_test.go | https://github.com/coder/coder/pull/29131/files#diff-5a98308a267e1dd9b07c40cbe367cd07c96987d151f628e7cb3eb1ee17114ba7 |
| Please reload this page | https://github.com/coder/coder/pull/29131 |
| aibridge/intercept/bedrocksig/bedrocksig.go | https://github.com/coder/coder/pull/29131/files#diff-29014f747e822edbf78dff7c63b20c6b3b9dafa08de6e622a120bfbe31f3aa82 |
| Please reload this page | https://github.com/coder/coder/pull/29131 |
| https://github.com/johnstcn |
| johnstcn | https://github.com/johnstcn |
|
Sep 9, 2026
| https://github.com/coder/coder/pull/29131#ref-pullrequest-5376129647 |
|
refactor(aibridge): generalize AWS SigV4 signing beyond Bedrock
#29047
| https://github.com/coder/coder/pull/29047 |
| https://github.com/dannykopping |
| dannykopping | https://github.com/dannykopping |
|
Sep 9, 2026
| https://github.com/coder/coder/pull/29131#pullrequestreview-5155366799 |
|
View reviewed changes
| https://github.com/coder/coder/pull/29131/files |
| dannykopping | https://github.com/dannykopping |
| https://github.com/coder/coder/pull/29131#pullrequestreview-5155366799 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/29131 |
| https://github.com/johnstcn |
| johnstcn | https://github.com/johnstcn |
| force-pushed | https://github.com/coder/coder/compare/86b6b9d7d99f039842de2dacb422c1ac6b8ec4a0..64fe2fd3b23fc33e16f8f01e02b295c49a962c47 |
| 86b6b9d | https://github.com/coder/coder/commit/86b6b9d7d99f039842de2dacb422c1ac6b8ec4a0 |
| 64fe2fd | https://github.com/coder/coder/commit/64fe2fd3b23fc33e16f8f01e02b295c49a962c47 |
|
Compare
| https://github.com/coder/coder/compare/86b6b9d7d99f039842de2dacb422c1ac6b8ec4a0..64fe2fd3b23fc33e16f8f01e02b295c49a962c47 |
| September 9, 2026 14:27 | https://github.com/coder/coder/pull/29131#event-30835882186 |
| https://github.com/pawbana |
| pawbana | https://github.com/pawbana |
| Sep 9, 2026 | https://github.com/coder/coder/pull/29131#issuecomment-5603986121 |
| https://docs.aws.amazon.com/elasticloadbalancing/latest/application/application-load-balancers.html | https://docs.aws.amazon.com/elasticloadbalancing/latest/application/application-load-balancers.html |
| https://repost.aws/questions/QUgTKJm0-cSrKiAJHJp1eWGQ/underscores-in-headers-aws-api-gateway | https://repost.aws/questions/QUgTKJm0-cSrKiAJHJp1eWGQ/underscores-in-headers-aws-api-gateway |
| Please reload this page | https://github.com/coder/coder/pull/29131 |
| https://github.com/pawbana |
| pawbana | https://github.com/pawbana |
|
Sep 9, 2026
| https://github.com/coder/coder/pull/29131#pullrequestreview-5156581758 |
|
View reviewed changes
| https://github.com/coder/coder/pull/29131/files |
| September 9, 2026 17:29 | https://github.com/coder/coder/pull/29131#event-30847232630 |
| https://github.com/johnstcn |
| johnstcn | https://github.com/johnstcn |
| Sep 10, 2026 | https://github.com/coder/coder/pull/29131#event-30890060885 |
| https://github.com/johnstcn |
| johnstcn | https://github.com/johnstcn |
| force-pushed | https://github.com/coder/coder/compare/9d84e2eb68dcc75dba3fe06d421b8e0237c74c43..d72f2be71d270ffa42dd8f752b0d4660b5776c28 |
| 9d84e2e | https://github.com/coder/coder/commit/9d84e2eb68dcc75dba3fe06d421b8e0237c74c43 |
| d72f2be | https://github.com/coder/coder/commit/d72f2be71d270ffa42dd8f752b0d4660b5776c28 |
|
Compare
| https://github.com/coder/coder/compare/9d84e2eb68dcc75dba3fe06d421b8e0237c74c43..d72f2be71d270ffa42dd8f752b0d4660b5776c28 |
| September 11, 2026 22:43 | https://github.com/coder/coder/pull/29131#event-31003018597 |
| johnstcn | https://github.com/johnstcn |
| September 14, 2026 13:05 | https://github.com/coder/coder/pull/29131#commits-pushed-2b912b3 |
|
| https://github.com/johnstcn |
| chore: merge main | https://github.com/coder/coder/pull/29131/commits/2b912b3895fc1e4c7af5e210c562d84077d576d4 |
| 2b912b3 | https://github.com/coder/coder/pull/29131/commits/2b912b3895fc1e4c7af5e210c562d84077d576d4 |
|
| https://github.com/johnstcn |
| refactor(aibridge): separate Bedrock workaround | https://github.com/coder/coder/pull/29131/commits/0ae023469cc45f6cc3e4305d951579d198865e60 |
| 0ae0234 | https://github.com/coder/coder/pull/29131/commits/0ae023469cc45f6cc3e4305d951579d198865e60 |
|
| https://github.com/johnstcn |
| fix(aibridge): strip unsafe Bedrock headers | https://github.com/coder/coder/pull/29131/commits/210df9f531be2822c6407086e9088b0b53cccdcd |
| 210df9f | https://github.com/coder/coder/pull/29131/commits/210df9f531be2822c6407086e9088b0b53cccdcd |
| https://github.com/johnstcn |
| johnstcn | https://github.com/johnstcn |
| force-pushed | https://github.com/coder/coder/compare/d72f2be71d270ffa42dd8f752b0d4660b5776c28..210df9f531be2822c6407086e9088b0b53cccdcd |
| d72f2be | https://github.com/coder/coder/commit/d72f2be71d270ffa42dd8f752b0d4660b5776c28 |
| 210df9f | https://github.com/coder/coder/commit/210df9f531be2822c6407086e9088b0b53cccdcd |
|
Compare
| https://github.com/coder/coder/compare/d72f2be71d270ffa42dd8f752b0d4660b5776c28..210df9f531be2822c6407086e9088b0b53cccdcd |
| September 15, 2026 13:42 | https://github.com/coder/coder/pull/29131#event-31176591032 |
| https://github.com/johnstcn |
| johnstcn | https://github.com/johnstcn |
| Sep 25, 2026 | https://github.com/coder/coder/pull/29131#event-31843366959 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Sep 25, 2026 | https://github.com/coder/coder/pull/29131#event-31843378386 |
| https://github.co/hiddenchars |
| https://github.com/coder/coder/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F29131 |
|
Copilot code review
| https://github.com/apps/copilot-pull-request-reviewer |
|
Copilot
| https://github.com/apps/copilot-pull-request-reviewer |
| Learn more about Copilot code review. | https://gh.io/copilot-code-review-docs |
|
| https://github.com/coder/coder/pull/29131/files/4b805ca7ee86f1c2935433860b7438bdb2a3e353 |
|
| https://github.com/dannykopping |
|
dannykopping
| https://github.com/dannykopping |
|
| https://github.com/coder/coder/pull/29131/files/86b6b9d7d99f039842de2dacb422c1ac6b8ec4a0 |
|
| https://github.com/pawbana |
|
pawbana
| https://github.com/pawbana |
|
| https://github.com/coder/coder/pull/29131/files/64fe2fd3b23fc33e16f8f01e02b295c49a962c47 |
|
| https://github.com/evgeniy-scherbina |
|
evgeniy-scherbina
| https://github.com/evgeniy-scherbina |
| Please reload this page | https://github.com/coder/coder/pull/29131 |
|
| https://github.com/johnstcn |
|
johnstcn
| https://github.com/johnstcn |
| Please reload this page | https://github.com/coder/coder/pull/29131 |
|
| https://github.com/johnstcn |
|
| https://github.com/pawbana |
|
| https://github.com/dannykopping |
|
| https://github.com/apps/copilot-pull-request-reviewer |
|
| https://github.com/Shelnutt2 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |