René's URL Explorer Experiment


Title: feat: reject secret creation and fix reporting for public clients by BobbyHo · Pull Request #28097 · coder/coder · GitHub

Open Graph Title: feat: reject secret creation and fix reporting for public clients by BobbyHo · Pull Request #28097 · coder/coder

X Title: feat: reject secret creation and fix reporting for public clients by BobbyHo · Pull Request #28097 · coder/coder

Description: TL;DR On top of #28047, closing the last two gaps in the stack split out of #27873. A public client can now register (#28046) and exchange a code (#28047), but the admin secrets API will still issue it a secret that authenticates nothing, and the registration responses still report an auth method the token endpoint will not accept. PR What it does #27712 Schema: app_secret_id becomes nullable and tokens gain an always-populated app_id, so ownership checks work without a secret row. #28041 Accepts bare custom-scheme redirect URIs (vscode://, cursor://) that native apps actually register. #28043 Derives and stores client_type (public vs confidential) from the requested token_endpoint_auth_method, and pins it across updates. #28046 Registration issues no secret for a public client and returns no client_secret. #28047 The token endpoint accepts the exchange without a client_secret. Discovery advertises none. #28097 (this) The admin secrets API refuses to create a secret for a public client, and registration, read, and update report the auth method the token endpoint actually enforces. A public client can only come into existence through dynamic client registration, which is off by default, so neither guard is reachable until DCR is enabled. Where in the flow POST /oauth2-provider/apps/{app}/secrets, the admin secrets API. The rest of the secret lifecycle is untouched: GET and DELETE are unchanged, and a confidential app behaves exactly as before. The three RFC 7591 and 7592 responses that carry token_endpoint_auth_method: registration (POST), read (GET), and update (PUT). Only what is reported changes; the stored column is left as the client sent it. Authorize, token exchange, refresh, and revocation are untouched. What it satisfies RFC 7591 §2: none means the client is public and "does not have a client secret", so the secrets API should not create one for it. RFC 7591 §3.2.1: the server MUST return all registered metadata and MAY replace a requested value with a suitable one. Reporting the enforced method in place of a stored one that contradicts client_type is that substitution. RFC 7592 §2.2: an update MUST include all metadata as returned by a previous registration, read, or update. Because clients echo back what Coder reports, reporting the enforced method is what lets a legacy row heal on the client's next PUT. RFC 7591 §2 default: an app with no stored method reports client_secret_basic, which is both the RFC default and what ApplyDefaults substitutes on update. OAuth 2.1 §3.2.1: the token endpoint enforces on client_type, so a reported method that disagrees with it tells a client to authenticate in a way the server will reject. CreateAppSecret returns 400 for a public client before generating anything. The secret would authenticate nothing, since the token endpoint no longer checks one for a public client. Deleting it would be worse: oauth2_provider_app_tokens.app_secret_id is ON DELETE CASCADE, so removing a confidential app's secret takes its tokens with it, but a public client's tokens carry a NULL app_secret_id (#27712) and survive. An admin who deleted the secret would think they had cut off the client when they had not. reportedAuthMethod() replaces the raw stored value in all three registration responses. It returns the stored method when it agrees with client_type, none for a public app, and client_secret_basic otherwise. The rows that can disagree are clients registered before #28043 derived the type from the method: the method was stored as sent while the type was always confidential. Such a client holds a secret its exchange still requires, while GET reported none and told it to drop that secret. The stored column is deliberately not rewritten, so the response can still differ from the row. That divergence is what a read-modify-write client resolves on its next update, and the test asserts the row keeps what the client sent. Coverage: the secrets guard asserts the 400 and that no partial secret row was left behind. A table test walks GET then PUT over six stored-method and client-type pairs: the legacy mismatch in both resend shapes, the reverse mismatch that registration cannot produce but the function still handles, an empty stored method, and the single pair that already agrees and must be reported as stored. Docs: the client type is fixed at registration and a type-changing update is rejected with invalid_client_metadata (behavior from #28043 that was never written down), plus what a legacy none client now sees. Refs https://linear.app/codercom/issue/ENG-3029/oauth2-support-public-client Manual Tests Verified by hand against a local dev deployment (v2.36.3-devel+c85e4621ef, dev Postgres), in addition to the automated suite. Both guards are reachable only through dynamic client registration, which was confirmed off by default on this deployment and enabled for the run. Two of the scenarios need a row where client_type and token_endpoint_auth_method disagree, which registration cannot produce since #28043 derives one from the other, so those rows were seeded by updating the method column directly on a purpose-built client. # Scenario Result 1 Secrets API refuses a public client, with the guard's own message Pass 2 No partial secret row is left behind by the rejection Pass 3 A confidential app's secret create, list, and delete are unchanged Pass 4 Admin-created apps are always confidential, so the guard is unreachable there Pass 5 When stored method and client type agree, the stored value is reported unchanged Pass 6 A legacy confidential row storing none reports client_secret_basic Pass 7 The reported method is the one the token endpoint enforces, in both directions Pass 8 An update resending the stored value is accepted and leaves the row alone Pass 9 An update resending the reported value heals the row Pass 10 The reverse mismatch, a public row storing a secret method, reports none Pass 11 An empty or unrecognized stored method falls back to client_secret_basic Pass 12 Type-changing updates are rejected both ways, client_secret_basic to client_secret_post is allowed Pass 13 Regression sweep of the merged stack, discovery through revocation Pass 14 Every claim in the new docs paragraphs matches observed behavior Pass No correctness defects found. Commands and captured output for each scenario below. Two notes for anyone re-running this. The previous runbook for this stack asserts the opposite of scenario 12: it flips a confidential client to public with a PUT and records 200. That was correct before #28043 pinned the client type. The 400 here is the fix, not a regression. Generate the PKCE verifier with enough entropy that stripping =+/ still leaves 43 characters. The openssl rand -base64 32 | tr -d "=+/" | cut -c -43 recipe yields 38 to 43, so most runs are rejected by the token endpoint under RFC 7636 section 4.1 with an error that looks unrelated. Same trap noted in #28045. Shell helpers used throughout export BASE_URL=http://localhost:3000 export AUTH_HEADER="Coder-Session-Token: $(cat ./.coderv2/session)" export PGURL="postgres://coder@localhost:$(cat ./.coderv2/postgres/port)/coder?sslmode=disable&password=$(cat ./.coderv2/postgres/password)" # Enable DCR; both guards are unreachable without it. curl -s -X PUT "$BASE_URL/api/v2/oauth2-provider/settings" -H "$AUTH_HEADER" \ -H "Content-Type: application/json" \ -d '{"dynamic_client_registration_enabled": true}' # Print "HTTP " then the body. show() { local out; out=$(curl -s -w '\n%{http_code}' "$@") echo "HTTP $(printf '%s\n' "$out" | tail -n1)" printf '%s\n' "$out" | sed '$d' | jq . 2>/dev/null || printf '%s\n' "$out" | sed '$d' } # $1=name, $2=auth method ("" to omit the field). register() { local body if [ -z "$2" ]; then body=$(jq -nc --arg n "$1" '{client_name:$n,redirect_uris:["http://localhost:9876/callback"]}') else body=$(jq -nc --arg n "$1" --arg m "$2" '{client_name:$n,redirect_uris:["http://localhost:9876/callback"],token_endpoint_auth_method:$m}') fi curl -s -X POST "$BASE_URL/oauth2/register" -H "Content-Type: application/json" -d "$body" } # The stored row, as opposed to what the API reports. stored() { psql "$PGURL" -At -c "select client_type || ' | ' || coalesce(token_endpoint_auth_method,'') from oauth2_provider_apps where id = '$1';" } # 43 characters from the unreserved set, always. See the note above. gen_verifier() { openssl rand -base64 96 | tr -d "=+/\n" | cut -c -43; } challenge_for() { printf '%s' "$1" | openssl dgst -sha256 -binary | base64 | tr -d "=" | tr '+/' '-_'; } # Full PKCE authorize plus exchange. $1=client_id, $2=client_secret ("" for none). exchange() { local verifier challenge redirect code args verifier=$(gen_verifier); challenge=$(challenge_for "$verifier") redirect=$(curl -s -X POST \ "$BASE_URL/oauth2/authorize?client_id=$1&response_type=code&redirect_uri=http://localhost:9876/callback&state=$(openssl rand -hex 16)&code_challenge=$challenge&code_challenge_method=S256" \ -H "$AUTH_HEADER" -w '\n%{redirect_url}' -o /dev/null) code=$(printf '%s' "$redirect" | grep -oE 'code=[^&]+' | sed 's/code=//') args=(-d "grant_type=authorization_code" -d "code=$code" -d "client_id=$1" -d "redirect_uri=http://localhost:9876/callback" -d "code_verifier=$verifier") [ -n "$2" ] && args+=(-d "client_secret=$2") curl -s -X POST "$BASE_URL/oauth2/tokens" -H "Content-Type: application/x-www-form-urlencoded" "${args[@]}" } 1. Secrets API refuses a public client A bare non-201 would also be produced by a request that failed on authentication, routing, or a malformed UUID before reaching the guard, so the status and the message are both asserted. PUB=$(register manual-28097-public none) PUB_ID=$(echo "$PUB" | jq -r '.client_id') stored "$PUB_ID" show -X POST "$BASE_URL/api/v2/oauth2-provider/apps/$PUB_ID/secrets" -H "$AUTH_HEADER" public | none HTTP 400 { "message": "Cannot create a client secret for a public OAuth2 app.", "detail": "Public clients authenticate with PKCE and have no client secret. The client type is fixed at registration, so register a new confidential client instead." } The message is the guard's own, so execution reached CreateAppSecret and returned at the IsPublic() check. The detail points at registering a new confidential client, which scenario 12 confirms is the only remedy. 2. No partial secret row is left behind The guard returns before GenerateSecret(), so nothing should exist at either layer. The count was already 0 at registration, and a confidential app is queried the same way as a control, so 0 is not merely what this query always returns. curl -s "$BASE_URL/api/v2/oauth2-provider/apps/$PUB_ID/secrets" -H "$AUTH_HEADER" | jq -c . psql "$PGURL" -At -c "select count(*) from oauth2_provider_app_secrets where app_id = '$PUB_ID';" psql "$PGURL" -At -c "select count(*) from oauth2_provider_app_secrets where app_id = '$CONF_ID';" [] 0 1 3. A confidential app's secret lifecycle is unchanged CONF=$(register manual-28097-confidential "") CONF_ID=$(echo "$CONF" | jq -r '.client_id') show -X POST "$BASE_URL/api/v2/oauth2-provider/apps/$CONF_ID/secrets" -H "$AUTH_HEADER" curl -s "$BASE_URL/api/v2/oauth2-provider/apps/$CONF_ID/secrets" -H "$AUTH_HEADER" | jq -c '[.[].id]' curl -s -X DELETE "$BASE_URL/api/v2/oauth2-provider/apps/$CONF_ID/secrets/$SECRET_ID" \ -H "$AUTH_HEADER" -o /dev/null -w "delete: HTTP %{http_code}\n" HTTP 201 { "id": "da7a1029-47c4-435e-988a-557ffa4aeacf", "client_secret_full": "coder_POUtoElODM_" } ["b2fc55b6-...","da7a1029-...","24f8f8c2-..."] delete: HTTP 204 ["b2fc55b6-...","da7a1029-..."] Create, list, and delete all behave as before. The guard keys on client_type and nothing else on this path changed. Unrelated observation, not a finding against this PR: the listing returns two different client_secret_truncated formats. Secrets issued at registration are asterisk-padded (***...TzqEOt, from createDisplaySecret), while secrets issued through the admin API show the bare last six characters (Rixs60). Both write the same column and surface through the same field. Cosmetic and pre-existing, but a UI listing both kinds together would render them inconsistently. 4. Admin-created apps are always confidential postOAuth2ProviderApp hardcodes the client type, so the guard is unreachable through the admin create path. ADMIN_APP=$(curl -s -X POST "$BASE_URL/api/v2/oauth2-provider/apps" -H "$AUTH_HEADER" \ -H "Content-Type: application/json" \ -d '{"name":"manual-28097-admin","callback_url":"http://localhost:9876/callback"}') ADMIN_ID=$(echo "$ADMIN_APP" | jq -r '.id') stored "$ADMIN_ID" show -X POST "$BASE_URL/api/v2/oauth2-provider/apps/$ADMIN_ID/secrets" -H "$AUTH_HEADER" confidential | client_secret_post HTTP 201 { "id": "a77ab276-ea74-4711-ba8b-955a8cb97951", "client_secret_full": "coder_eGlt04LhYg_" } Together with scenario 1 this brackets the guard: it fires for a dynamically registered public client and for nothing else. Note the admin API stores client_secret_post, not the RFC 7591 section 2 default, so every admin-created app is an agreement case for scenario 5. Such apps carry no registration access token, so they cannot reach the RFC 7592 endpoints where the reporting change applies at all. 5. Agreement cases report the stored value unchanged The client_secret_post case is the one that matters. An implementation that substituted the type default on every call would still pass the public case, since none is the public default, but would rewrite this client to client_secret_basic and tell it to send its secret in the wrong place. curl -s "$BASE_URL/oauth2/clients/$PUB_ID" -H "Authorization: Bearer $PUB_RAT" \ | jq -c '{reported: .token_endpoint_auth_method}' POST_REG=$(register manual-28097-post client_secret_post) POST_ID=$(echo "$POST_REG" | jq -r '.client_id') echo "$POST_REG" | jq -c '{reported_on_register: .token_endpoint_auth_method}' curl -s "$BASE_URL/oauth2/clients/$POST_ID" -H "Authorization: Bearer $POST_RAT" \ | jq -c '.token_endpoint_auth_method' stored "$POST_ID" {"reported":"none"} {"reported_on_register":"client_secret_post"} "client_secret_post" confidential | client_secret_post Registration and read both report the stored value. The update site is covered by scenarios 8 and 9. 6. A legacy confidential row storing `none` reports `client_secret_basic` Seeded from a real confidential client so it genuinely holds the secret its exchange requires, with only the method column rewritten. This is the pre-#28043 shape and cannot be produced through the API any more. LEGACY=$(register manual-28097-legacy "") LEGACY_ID=$(echo "$LEGACY" | jq -r '.client_id') LEGACY_SECRET=$(echo "$LEGACY" | jq -r '.client_secret') stored "$LEGACY_ID" psql "$PGURL" -c "update oauth2_provider_apps set token_endpoint_auth_method = 'none' where id = '$LEGACY_ID';" stored "$LEGACY_ID" psql "$PGURL" -At -c "select count(*) from oauth2_provider_app_secrets where app_id = '$LEGACY_ID';" curl -s "$BASE_URL/oauth2/clients/$LEGACY_ID" -H "Authorization: Bearer $LEGACY_RAT" \ | jq -c '{reported: .token_endpoint_auth_method}' stored "$LEGACY_ID" confidential | client_secret_basic UPDATE 1 confidential | none 1 {"reported":"client_secret_basic"} confidential | none The response substitutes and the row is deliberately not rewritten. A read has no side effects. 7. The reported method is the one actually enforced The token endpoint enforces on client_type, which is still confidential, so the secret is required regardless of what the method column says. exchange "$LEGACY_ID" "$LEGACY_SECRET" | jq -c '{has_access: has("access_token"), error, error_description}' exchange "$LEGACY_ID" "" | jq -c '{has_access: has("access_token"), error, error_description}' {"has_access":true,"error":null,"error_description":null} {"has_access":false,"error":"invalid_request","error_description":"Missing required parameter: client_secret"} The second line is the pre-fix breakage reproduced. A client that read "token_endpoint_auth_method": "none" from GET and dropped its secret accordingly, which is what RFC 7592 tells it to do, would have hit exactly this on its next exchange. The old response was not internally inconsistent, it was actionable and wrong. Scenario 10 shows the same property in the opposite direction. 8. An update resending the stored value is accepted and changes nothing show -X PUT "$BASE_URL/oauth2/clients/$LEGACY_ID" \ -H "Authorization: Bearer $LEGACY_RAT" -H "Content-Type: application/json" \ -d '{"client_name":"manual-28097-legacy","redirect_uris":["http://localhost:9876/callback"],"token_endpoint_auth_method":"none"}' stored "$LEGACY_ID" HTTP 200 "token_endpoint_auth_method": "client_secret_basic", confidential | none Three things at once. The update is accepted, which is why the type-change guard requires the auth method to actually change: the requested none implies a public client while the row is confidential, so a guard keyed on the type mismatch alone would reject this and lock a legacy client out of managing its own registration. The PUT reports the same substituted value as the GET, covering the third call site. The row keeps what the client sent, so the divergence persists until scenario 9. 9. An update resending the reported value heals the row show -X PUT "$BASE_URL/oauth2/clients/$LEGACY_ID" \ -H "Authorization: Bearer $LEGACY_RAT" -H "Content-Type: application/json" \ -d '{"client_name":"manual-28097-legacy","redirect_uris":["http://localhost:9876/callback"],"token_endpoint_auth_method":"client_secret_basic"}' stored "$LEGACY_ID" curl -s "$BASE_URL/oauth2/clients/$LEGACY_ID" -H "Authorization: Bearer $LEGACY_RAT" \ | jq -c '{reported: .token_endpoint_auth_method}' exchange "$LEGACY_ID" "$LEGACY_SECRET" | jq -c '{has_access: has("access_token")}' HTTP 200 "token_endpoint_auth_method": "client_secret_basic", confidential | client_secret_basic {"reported":"client_secret_basic"} {"has_access":true} The row healed through an ordinary read-modify-write cycle, with no migration, backfill, or admin action. That works only because scenario 8 keeps the door open and this response gives the client a correct value to echo back; remove either and the row stays inconsistent indefinitely. 10. The reverse mismatch reports `none` Registration cannot produce this direction either, but reportedAuthMethod branches on the general disagreement rather than the one shape known to exist, so it is covered. REVERSE=$(register manual-28097-reverse none) REVERSE_ID=$(echo "$REVERSE" | jq -r '.client_id') psql "$PGURL" -c "update oauth2_provider_apps set token_endpoint_auth_method = 'client_secret_basic' where id = '$REVERSE_ID';" stored "$REVERSE_ID" curl -s "$BASE_URL/oauth2/clients/$REVERSE_ID" -H "Authorization: Bearer $REVERSE_RAT" \ | jq -c '{reported: .token_endpoint_auth_method}' exchange "$REVERSE_ID" "" | jq -c '{has_access: has("access_token"), error}' public | client_secret_basic {"reported":"none"} {"has_access":true,"error":null} This client has no secret row at all and the token endpoint does not ask for one, so none is what the response should say. Reporting the stored client_secret_basic would have instructed it to send a secret that does not exist. Both resend shapes behave symmetrically with scenarios 8 and 9: resend stored (client_secret_basic) -> reported "none", row unchanged resend reported (none) -> reported "none", row now public | none 11. Empty or unrecognized stored methods fall back to the default NULL and '' are indistinguishable once read into sql.NullString. A third case was added because the function gates on validity rather than emptiness. for v in "null" "''" "'private_key_jwt'"; do psql "$PGURL" -At -c "update oauth2_provider_apps set token_endpoint_auth_method = $v where id = '$CONF_ID';" stored "$CONF_ID" curl -s "$BASE_URL/oauth2/clients/$CONF_ID" -H "Authorization: Bearer $CONF_RAT" \ | jq -c '.token_endpoint_auth_method' done confidential | "client_secret_basic" confidential | "client_secret_basic" confidential | private_key_jwt "client_secret_basic" private_key_jwt is a real RFC 7591 method that Coder does not implement. Reporting it back would advertise an authentication scheme the token endpoint cannot honor, which is the same class of problem as the legacy none report in scenario 7. 12. Type-changing updates are rejected both ways show -X PUT "$BASE_URL/oauth2/clients/$CONF_ID" \ -H "Authorization: Bearer $CONF_RAT" -H "Content-Type: application/json" \ -d '{"client_name":"manual-28097-confidential","redirect_uris":["http://localhost:9876/callback"],"token_endpoint_auth_method":"none"}' stored "$CONF_ID" show -X PUT "$BASE_URL/oauth2/clients/$PUB_ID" \ -H "Authorization: Bearer $PUB_RAT" -H "Content-Type: application/json" \ -d '{"client_name":"manual-28097-public","redirect_uris":["http://localhost:9876/callback"],"token_endpoint_auth_method":"client_secret_basic"}' stored "$PUB_ID" show -X PUT "$BASE_URL/oauth2/clients/$CONF_ID" \ -H "Authorization: Bearer $CONF_RAT" -H "Content-Type: application/json" \ -d '{"client_name":"manual-28097-confidential","redirect_uris":["http://localhost:9876/callback"],"token_endpoint_auth_method":"client_secret_post"}' stored "$CONF_ID" HTTP 400 { "error": "invalid_client_metadata", "error_description": "token_endpoint_auth_method cannot move an existing client between public and confidential (stored \"client_secret_basic\", requested \"none\"); the client type is fixed at registration, so register a new client instead" } confidential | client_secret_basic HTTP 400 { "error": "invalid_client_metadata", "error_description": "token_endpoint_auth_method cannot move an existing client between public and confidential (stored \"none\", requested \"client_secret_basic\"); the client type is fixed at registration, so register a new client instead" } public | none HTTP 200 "token_endpoint_auth_method": "client_secret_post", confidential | client_secret_post Both rejections leave the row and its secrets untouched. A partial application would be the dangerous outcome here, a client left confidential while its caller believes it went public. The third case is the control. Two 400s alone would be equally consistent with a guard that rejects every token_endpoint_auth_method change, a considerably more disruptive rule than the documented one. The 200 pins the guard to the derived client type rather than the method string. The second case is also what backs scenario 1. If public to confidential were permitted, the workaround to a refused secret request would be to flip the type and ask again. The two guards close that loop, which is why the same remedy appears in both error messages. 13. Regression sweep of the merged stack Nothing here is new in this PR, but the guards sit on top of it. discovery token_endpoint_auth_methods_supported : ["client_secret_basic","client_secret_post","none"] public registration, client_secret key present : false confidential registration, secret issued : true, method defaulted to client_secret_basic PKCE-only exchange, no client_secret sent : access + refresh issued access token against /api/v2/users/me : 200 token row app_id / app_secret_id : populated / NULL RFC 7009 revoke of own refresh token : 200, access token then 401 authorized-apps listing while a token is live : [{"name":"manual-28097-public"}] bulk DELETE /oauth2/tokens : 204, listing then [] The NULL app_secret_id is what makes the secrets guard necessary. That column is ON DELETE CASCADE, so deleting a confidential app's secret takes its tokens with it, while a public client's tokens would survive. An admin who deleted such a secret would believe access was cut off when it was not. PKCE failure modes were checked separately, since the token endpoint distinguishes two the previous runbook treated as one: verifier omitted : invalid_request, RFC 7636 section 4.1 bounds well-formed 43 chars but wrong : invalid_grant, "The PKCE code verifier is invalid" correct verifier, replaying that code: invalid_grant, "invalid or expired" The third confirms the failed check destroys the code, so a leaked code cannot absorb repeated verifier guesses. 14. The new docs paragraphs match observed behavior pnpm run lint-docs reports 0 errors across 501 files, pnpm run format-docs rewrites nothing, and Vale reports 0 errors with 2 warnings, both on pre-existing gerund headings that the same file on main also produces. The new prose is one sentence per line. Documented claim Verified by A client's type is fixed when it registers 12 A type-changing update is rejected with invalid_client_metadata 12, both directions The client either holds a secret that would stop being required or has none and no way to be issued one 12 (2 secrets), 1 and 12 (0 secrets, issuance refused) Switching between client_secret_basic and client_secret_post is allowed 12 To change type, register a new client matches the remedy in both errors and in scenario 1's detail Legacy none clients are stored as confidential and still require their client_secret 6, 7 Coder reports client_secret_basic for those clients 6 So that what it reports matches what it enforces 7, both directions The mismatch clears itself the next time the client updates its registration 9 One wording note. Scenario 8 shows the mismatch does not clear on an update that resends the stored value, so strictly it clears on the next update carrying the reported value. A read-modify-write client, which is what RFC 7592 section 2.2 prescribes, always carries the reported value, so the sentence holds for the client it describes. A client that hardcodes its own metadata would not self-heal, but it would also not be following RFC 7592. Cleanup for id in "$PUB_ID" "$CONF_ID" "$POST_ID" "$LEGACY_ID" "$REVERSE_ID" "$ADMIN_ID"; do curl -s -X DELETE "$BASE_URL/api/v2/oauth2-provider/apps/$id" -H "$AUTH_HEADER" \ -o /dev/null -w "%{http_code}\n" done curl -s -X PUT "$BASE_URL/api/v2/oauth2-provider/settings" -H "$AUTH_HEADER" \ -H "Content-Type: application/json" -d '{"dynamic_client_registration_enabled": false}' show -X POST "$BASE_URL/oauth2/register" -H "Content-Type: application/json" \ -d '{"client_name":"should-fail","redirect_uris":["http://localhost:9876/callback"],"token_endpoint_auth_method":"none"}' 204 (x6) {"dynamic_client_registration_enabled":false} HTTP 403 {"error":"invalid_request","error_description":"Dynamic client registration is disabled on this deployment"} All six test apps deleted with no orphaned secret or token rows. Both seeded rows had already healed to a consistent state before deletion. DCR is back off, confirmed by a registration attempt rather than by reading the flag back.

Open Graph Description: TL;DR On top of #28047, closing the last two gaps in the stack split out of #27873. A public client can now register (#28046) and exchange a code (#28047), but the admin secrets API will still issu...

X Description: TL;DR On top of #28047, closing the last two gaps in the stack split out of #27873. A public client can now register (#28046) and exchange a code (#28047), but the admin secrets API will still issu...

Opengraph URL: https://github.com/coder/coder/pull/28097

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:105d85c6-77c8-e633-3cf9-6b32b779c144
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBFAC:3A8E64:45FD7A:5CCBC5:6B019942
html-safe-nonced1042fc32e2ba07ea585434fc9be865d469a9e43e7b217f4963f1265acd4dc28
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRkFDOjNBOEU2NDo0NUZEN0E6NUNDQkM1OjZCMDE5OTQyIiwidmlzaXRvcl9pZCI6IjE5ODkzMDkzMjg2NTc1ODY0OTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacba986d2426364929ac0e57c4fdb32601a3b9a57299c2cfe9ccafae1efd831829
hovercard-subject-tagpull_request:4267078351
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/coder/coder/pull/28097/files
twitter:imagehttps://avatars.githubusercontent.com/u/23092290?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/23092290?s=400&v=4
og:image:altTL;DR On top of #28047, closing the last two gaps in the stack split out of #27873. A public client can now register (#28046) and exchange a code (#28047), but the admin secrets API will still issu...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/coder/coder/pull/28097/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F28097%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F28097%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/pull/28097/files
Reloadhttps://github.com/coder/coder/pull/28097/files
Reloadhttps://github.com/coder/coder/pull/28097/files
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fcoder%2Fcoder%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fcoder%2Fcoder%2Fissues%2Fnew%2Fchoose
BobbyHohttps://github.com/BobbyHo
mainhttps://github.com/coder/coder/tree/main
oauth2-public-clients-guardshttps://github.com/coder/coder/tree/oauth2-public-clients-guards
Conversation 35 https://github.com/coder/coder/pull/28097
Commits 77 https://github.com/coder/coder/pull/28097/commits
Checks 38 https://github.com/coder/coder/pull/28097/checks
Files changed https://github.com/coder/coder/pull/28097/files
Please reload this pagehttps://github.com/coder/coder/pull/28097/files
feat: reject secret creation and fix reporting for public clients https://github.com/coder/coder/pull/28097/files#top
Show all changes 77 commits https://github.com/coder/coder/pull/28097/files
7e3f6c0 fix(coderd/oauth2provider): reject PKCE code_verifier below RFC 7636 … BobbyHo Aug 10, 2026 https://github.com/coder/coder/pull/28097/commits/7e3f6c0e6391fb80670f0205226d36dbf99b85eb
a125238 fix(scripts/oauth2): generate PKCE verifiers at the RFC 7636 floor le… BobbyHo Aug 10, 2026 https://github.com/coder/coder/pull/28097/commits/a125238d71ce4c6b146383d29be0352b1e78b1a6
eea4094 fix(coderd/oauth2provider): validate code_challenge format at authorize BobbyHo Aug 10, 2026 https://github.com/coder/coder/pull/28097/commits/eea4094037bab1328c0eeabc812fae39e524751b
e7d78d5 fix(coderd/oauth2provider): return invalid_request for malformed code… BobbyHo Aug 10, 2026 https://github.com/coder/coder/pull/28097/commits/e7d78d5d446e95a86a91dc895104bf9de6eff37b
fb7e90b fix(coderd/oauth2provider/oauth2providertest): restore e2e coverage o… BobbyHo Aug 11, 2026 https://github.com/coder/coder/pull/28097/commits/fb7e90b1b9f103bd134382497e0d538a382c804a
4fe0b1b fix(coderd/oauth2provider): revoke authorization code on PKCE failure BobbyHo Aug 11, 2026 https://github.com/coder/coder/pull/28097/commits/4fe0b1bfc4a5d4a050311bf1dded16347e3c5164
663865a fix: resolve remaining coder-agents-review findings on PKCE hardening BobbyHo Aug 11, 2026 https://github.com/coder/coder/pull/28097/commits/663865aa51f588de0cbada35da9f0091fbdc337e
912ce41 fix(docs/admin): document PKCE length and charset requirement BobbyHo Aug 11, 2026 https://github.com/coder/coder/pull/28097/commits/912ce41b4bd02f62d5ae7035d0f24731524e2a02
9440708 fix: allow bare custom-scheme redirects for public clients BobbyHo Aug 11, 2026 https://github.com/coder/coder/pull/28097/commits/9440708f1697be490aa0dda3287186a10fabe3d7
450d037 fix(codersdk/oauth2_validation): state the real reason for the mailto… BobbyHo Aug 12, 2026 https://github.com/coder/coder/pull/28097/commits/450d0377839565e63ee654d1ce14569645c09455
8c4a1c0 feat: derive OAuth2 client type from token_endpoint_auth_method BobbyHo Aug 11, 2026 https://github.com/coder/coder/pull/28097/commits/8c4a1c0c4c2c51177de93af5c4d8eae0fb648ad1
1821ad4 fix: allow bare custom-scheme redirects for public clients (#28041) BobbyHo Aug 12, 2026 https://github.com/coder/coder/pull/28097/commits/1821ad4ca366de9c53ce0710f4eb28ad23c31f4b
c8b703d Merge branch 'oauth2-pkce-verifier-length' into oauth2-public-clients… BobbyHo Aug 12, 2026 https://github.com/coder/coder/pull/28097/commits/c8b703d67393933485b551cf9202e6984f235366
39e4beb fix: pin OAuth2 client type across RFC 7592 updates BobbyHo Aug 12, 2026 https://github.com/coder/coder/pull/28097/commits/39e4bebedfcb91c1780c1e73eee09140e9a9d478
df7135d Merge remote-tracking branch 'origin/main' into oauth2-public-clients… BobbyHo Aug 12, 2026 https://github.com/coder/coder/pull/28097/commits/df7135d0f1d560d68c9c15b705cc7f9aa33c4466
7c124e7 feat(coderd/oauth2provider): register public clients without a secret BobbyHo Aug 11, 2026 https://github.com/coder/coder/pull/28097/commits/7c124e7e841e8392d9fc94f73542597da7080fca
4725dec Merge branch 'main' into oauth2-public-clients-vocabulary BobbyHo Aug 13, 2026 https://github.com/coder/coder/pull/28097/commits/4725dec204686f5907009c0d14bc59e8c7deac83
577538b feat: accept PKCE-only token exchange for public clients BobbyHo Aug 11, 2026 https://github.com/coder/coder/pull/28097/commits/577538b7849f57c315b3d4a02fd49522d534f5ec
d93704d docs: describe public client PKCE as proof of possession BobbyHo Aug 15, 2026 https://github.com/coder/coder/pull/28097/commits/d93704dc5c3aa3989394050321387b123947b438
aca591d test(coderd): restructure public client token exchange and lifecycle … BobbyHo Aug 15, 2026 https://github.com/coder/coder/pull/28097/commits/aca591d49af6f9689204b8395841cf9970561fa6
240db54 refactor(coderd/oauth2provider): read IsPublic at the branch that use… BobbyHo Aug 15, 2026 https://github.com/coder/coder/pull/28097/commits/240db543aa7e7746779e76c58865fd60c1184cc1
12e1cab refactor(coderd/oauth2provider): scope the validated client secret to… BobbyHo Aug 15, 2026 https://github.com/coder/coder/pull/28097/commits/12e1cab378f1360812c8407f8dbc5bd54f974f33
29ec017 docs(coderd/oauth2provider): trim the revocation ownership comments t… BobbyHo Aug 15, 2026 https://github.com/coder/coder/pull/28097/commits/29ec01734b58497ebc282cb18228a6c301be8f4c
b5457af docs(coderd): trim the public-client test comments to what they assert BobbyHo Aug 15, 2026 https://github.com/coder/coder/pull/28097/commits/b5457af886379adb4a7d04777b6141c018d2ddcc
96083c0 feat: advertise the none token endpoint auth method in discovery BobbyHo Aug 17, 2026 https://github.com/coder/coder/pull/28097/commits/96083c036271ec01aecc4e18e8ae2e3e9720895e
6e510b7 Merge branch 'main' into oauth2-public-clients-vocabulary BobbyHo Aug 17, 2026 https://github.com/coder/coder/pull/28097/commits/6e510b7608680b74d7e435479decb58b1cb477e8
9198095 Merge branch 'oauth2-public-clients-vocabulary' into oauth2-public-cl… BobbyHo Aug 17, 2026 https://github.com/coder/coder/pull/28097/commits/91980959ccf1e1f8cb5fdd2190479d1c56e3f999
5a0bc6b Merge branch 'oauth2-public-clients-registration' into oauth2-public-… BobbyHo Aug 17, 2026 https://github.com/coder/coder/pull/28097/commits/5a0bc6b69f47b5add143ec7e6fb2ee6880f6f1c6
432b2a5 docs: correct the public client token endpoint and redirect URI claims BobbyHo Aug 17, 2026 https://github.com/coder/coder/pull/28097/commits/432b2a5d5fab0e4f372e69dd44724793008d240d
16b45cc refactor(codersdk): derive auth method validity from one list BobbyHo Aug 17, 2026 https://github.com/coder/coder/pull/28097/commits/16b45cc562429fbfacef7f2c1310a22ec866ee9d
a336906 docs(coderd/oauth2provider): describe what the code ownership check b… BobbyHo Aug 17, 2026 https://github.com/coder/coder/pull/28097/commits/a336906a9ce1b11d3ba1aea2313e15cf3ae78a9d
cb8fb61 Merge branch 'oauth2-public-clients-registration' into oauth2-public-… BobbyHo Aug 17, 2026 https://github.com/coder/coder/pull/28097/commits/cb8fb61e8f1c46805f444df7b9136c1daa55077c
ca01e04 docs: drop the caveat that public clients cannot obtain a token BobbyHo Aug 17, 2026 https://github.com/coder/coder/pull/28097/commits/ca01e04c68f8753cc74a5b06226b0da6d545fd97
6acd7bc docs(coderd/oauth2provider): use plainer wording in the client type c… BobbyHo Aug 17, 2026 https://github.com/coder/coder/pull/28097/commits/6acd7bcddb753e47839fc87cf9aca3c06c26baef
794ed0d Merge branch 'oauth2-public-clients-vocabulary' into oauth2-public-cl… BobbyHo Aug 17, 2026 https://github.com/coder/coder/pull/28097/commits/794ed0ddee3fa3018f5157f38cda78e67d410b2c
38c3353 Merge branch 'main' into oauth2-public-clients-vocabulary BobbyHo Aug 17, 2026 https://github.com/coder/coder/pull/28097/commits/38c3353bf8396f396e6e00f7d463dcdcdd262033
21fdfed Merge branch 'oauth2-public-clients-vocabulary' into oauth2-public-cl… BobbyHo Aug 17, 2026 https://github.com/coder/coder/pull/28097/commits/21fdfed1d4bc5bbb9510161277743f216550bd5c
b9992c5 Merge branch 'oauth2-public-clients-registration' into oauth2-public-… BobbyHo Aug 17, 2026 https://github.com/coder/coder/pull/28097/commits/b9992c5c2771876aecb198aa9bb777e5c249a168
83c02d7 Merge branch 'main' into oauth2-public-clients-vocabulary BobbyHo Aug 18, 2026 https://github.com/coder/coder/pull/28097/commits/83c02d7b95c01f825067e406fe604e26410c95b1
e8cfef2 Merge branch 'main' into oauth2-public-clients-vocabulary BobbyHo Aug 18, 2026 https://github.com/coder/coder/pull/28097/commits/e8cfef2adfe3a31244d4ecb3f948a768d42394f7
c347f5c refactor(coderd/oauth2provider): name the client type change conjuncts BobbyHo Aug 19, 2026 https://github.com/coder/coder/pull/28097/commits/c347f5cfe4b2352ac31e472e79115a7079e7f50b
99e26eb refactor(codersdk): derive token endpoint auth method Valid from the … BobbyHo Aug 19, 2026 https://github.com/coder/coder/pull/28097/commits/99e26ebf03e31139fef81b18e36326626639f4fc
f3e05bd Merge remote-tracking branch 'origin/oauth2-public-clients-vocabulary… BobbyHo Aug 19, 2026 https://github.com/coder/coder/pull/28097/commits/f3e05bdac4b4b463581aba9ffdc05297ca76d55e
83a6495 Merge remote-tracking branch 'origin/main' into oauth2-public-clients… BobbyHo Aug 19, 2026 https://github.com/coder/coder/pull/28097/commits/83a6495e4f0d3efd9454672463cc96c05e9e9081
3d40daa Merge branch 'main' into oauth2-public-clients-registration BobbyHo Aug 19, 2026 https://github.com/coder/coder/pull/28097/commits/3d40daa0dbfc7cc2519ca5adc1b8e5d3bc40ae2d
c87521b Merge branch 'oauth2-public-clients-registration' into oauth2-public-… BobbyHo Aug 19, 2026 https://github.com/coder/coder/pull/28097/commits/c87521bcabc62265a649fffde9eb725627a96dac
a7e132c Merge branch 'main' into oauth2-public-clients-token-exchange BobbyHo Aug 20, 2026 https://github.com/coder/coder/pull/28097/commits/a7e132ca06b9be05114e9df96c182fd5e536a741
c5b4461 Merge branch 'main' into oauth2-public-clients-token-exchange BobbyHo Aug 21, 2026 https://github.com/coder/coder/pull/28097/commits/c5b4461930730afb2822759d14e6df0bc33b1104
aada1ca docs(coderd/oauth2provider): name the checks that bind the exchange BobbyHo Aug 21, 2026 https://github.com/coder/coder/pull/28097/commits/aada1cadd6514cc02a0611968b006f6c86060a88
f4516c3 Merge remote-tracking branch 'origin/main' into oauth2-public-clients… BobbyHo Aug 21, 2026 https://github.com/coder/coder/pull/28097/commits/f4516c30bf740fce5f90dc9791cce397e06d67de
02a7495 docs(codersdk): state what the token endpoint does with client type BobbyHo Aug 21, 2026 https://github.com/coder/coder/pull/28097/commits/02a7495b519126ce920551fdeb53fc513c119791
05c0580 test(coderd/oauth2provider): pin the advertised auth methods BobbyHo Aug 21, 2026 https://github.com/coder/coder/pull/28097/commits/05c05804a3d4cf440e4f63653e1c2b02cfa701dc
09a9cbe docs: drop the public client aside from the code_verifier parameter BobbyHo Aug 21, 2026 https://github.com/coder/coder/pull/28097/commits/09a9cbee946b3aee9a971a93568acd9ec568cbe0
8255649 Merge branch 'main' into oauth2-public-clients-token-exchange BobbyHo Aug 21, 2026 https://github.com/coder/coder/pull/28097/commits/82556492a9c6642cb1b7be3aa322f3e81f2eb85a
9f65876 test(coderd): drop positional anchors from public client comments BobbyHo Aug 22, 2026 https://github.com/coder/coder/pull/28097/commits/9f6587693a364c0b35347ba6bb2e8fb9ac55aea8
f2f0a9c Merge branch 'main' into oauth2-public-clients-token-exchange BobbyHo Aug 22, 2026 https://github.com/coder/coder/pull/28097/commits/f2f0a9cf65f75c91fbcf7ae867b761016186b041
a938dad feat: reject secret creation and fix reporting for public clients BobbyHo Aug 13, 2026 https://github.com/coder/coder/pull/28097/commits/a938dadb41157f043392363882724732cad9e591
ebb9b8e test(coderd/oauth2provider): cover reported token_endpoint_auth_method BobbyHo Aug 19, 2026 https://github.com/coder/coder/pull/28097/commits/ebb9b8ee2578af92268d1931b90f3898012b0a9b
9627868 docs: drop the redirect URI matching note BobbyHo Aug 19, 2026 https://github.com/coder/coder/pull/28097/commits/9627868d7b4ba812e3b982df5e0669df241fef9e
d32f432 Merge branch 'main' into oauth2-public-clients-token-exchange BobbyHo Aug 23, 2026 https://github.com/coder/coder/pull/28097/commits/d32f4325822d6f06a756ab44da8f21d0c20cb28c
9cb8b0f test(coderd/oauth2provider): pin the reported client_secret_post method BobbyHo Aug 23, 2026 https://github.com/coder/coder/pull/28097/commits/9cb8b0f22bec9f09e2dca38714857c5745979d9c
effb05b fix(coderd): name the remedy when rejecting a public client secret BobbyHo Aug 23, 2026 https://github.com/coder/coder/pull/28097/commits/effb05b5ca5e10d1ebd9cd4c35bcdb7220a9436b
3990e0c docs(coderd): trim duplicated public client rationale BobbyHo Aug 23, 2026 https://github.com/coder/coder/pull/28097/commits/3990e0c654fd4d724aa1308dd838ca10e57764f3
1cf8857 Merge branch 'oauth2-public-clients-token-exchange' into oauth2-publi… BobbyHo Aug 24, 2026 https://github.com/coder/coder/pull/28097/commits/1cf885733f397a9021d39ac3476349224fd92290
476ffe2 Merge branch 'main' into oauth2-public-clients-token-exchange BobbyHo Aug 25, 2026 https://github.com/coder/coder/pull/28097/commits/476ffe2b117e10966b2d2e12025a7c5ca71365d1
9c970ec docs(coderd): drop godoc-style comments from the public client tests BobbyHo Aug 25, 2026 https://github.com/coder/coder/pull/28097/commits/9c970ecbc9b6c87a601279c818b2b3977f728de4
84dc33c docs(coderd): match the older RFC 7636 comment to the trimmed one BobbyHo Aug 25, 2026 https://github.com/coder/coder/pull/28097/commits/84dc33cbca4c2040b8faa39de84cdf2423cf4614
56c0c60 docs(coderd): drop the public client lifecycle test header BobbyHo Aug 25, 2026 https://github.com/coder/coder/pull/28097/commits/56c0c60250eccac47432f12cf41e8f23144995f7
8eb0be5 docs(coderd): drop godoc-style comments from the public client guard … BobbyHo Aug 25, 2026 https://github.com/coder/coder/pull/28097/commits/8eb0be54699e071739f482c4966dc371eb2fdf30
ff4d0f2 Merge branch 'oauth2-public-clients-token-exchange' into oauth2-publi… BobbyHo Aug 25, 2026 https://github.com/coder/coder/pull/28097/commits/ff4d0f2c7bb059db7fa3aa01e2ced294864abfad
fe643c3 Merge branch 'main' into oauth2-public-clients-guards BobbyHo Aug 31, 2026 https://github.com/coder/coder/pull/28097/commits/fe643c3043bd03962a56da8d47b98b6962f35ef6
2f5ec81 Merge branch 'main' into oauth2-public-clients-guards BobbyHo Aug 31, 2026 https://github.com/coder/coder/pull/28097/commits/2f5ec81165c24aceefe6c781631ddcffa3f5b0b5
8e8eee7 chore(coderd): simplify comments on public client guards BobbyHo Aug 31, 2026 https://github.com/coder/coder/pull/28097/commits/8e8eee7f876d3c934e87f53e0e0d2266a112c8ec
c85e462 docs(docs/admin/integrations): one sentence per line in new paragraphs BobbyHo Aug 31, 2026 https://github.com/coder/coder/pull/28097/commits/c85e4621efda09f01053b4d4cea668a5e2751762
7e13ffa Merge branch 'main' into oauth2-public-clients-guards BobbyHo Aug 31, 2026 https://github.com/coder/coder/pull/28097/commits/7e13ffacc06cbb5891a555189e2072b7c93e0876
0034474 docs(docs/admin/integrations): qualify when the legacy auth method mi… BobbyHo Aug 31, 2026 https://github.com/coder/coder/pull/28097/commits/0034474c4598c110d9940558fd778a6f21bb2550
ccadf55 docs: document the 400 response for creating a public client secret BobbyHo Sep 1, 2026 https://github.com/coder/coder/pull/28097/commits/ccadf55c259c8c68d4df6c03cdd1274840cb674e
Clear filters https://github.com/coder/coder/pull/28097/files
Please reload this pagehttps://github.com/coder/coder/pull/28097/files
Please reload this pagehttps://github.com/coder/coder/pull/28097/files
docs.go https://github.com/coder/coder/pull/28097/files#diff-62ac3890066a69746687795ab05779ba2ddf1f4027cf2448425af7728c8da7b4
swagger.json https://github.com/coder/coder/pull/28097/files#diff-f7851d516b0d2ef3ed1f6bbdd199cd120f502761c6f2c2a472bd9ef2bc302d72
oauth2.go https://github.com/coder/coder/pull/28097/files#diff-8c6e99c95c08ac3ac038b05610ec90a68ef65af1181ff01aa7fa23f8f00f81d9
oauth2_test.go https://github.com/coder/coder/pull/28097/files#diff-92e9a528ba24e3a3b55232e1307fca71f7d4b5ee1145ff84e7351dacd694b575
app_secrets.go https://github.com/coder/coder/pull/28097/files#diff-5956ee4538b35f804285ced3a9bfea639e766fe096a2ee57df90106eab717a3c
registration.go https://github.com/coder/coder/pull/28097/files#diff-775dcfdb8865d51df8aac08de8fab3f0cff8631920922affb5f3988e39cd98eb
registration_test.go https://github.com/coder/coder/pull/28097/files#diff-3d62d6dfbb4f1e54e6a7e61f1ebe4425578a2b860eec89c43684e045b21a92d7
oauth2-provider.md https://github.com/coder/coder/pull/28097/files#diff-45214b5c2eed3fbe50a4000a697fa5370506d7659e81214a2ce59294d54d15c6
enterprise.md https://github.com/coder/coder/pull/28097/files#diff-b27c921c256b93fc529c8cde9a4cf56cfa94cf9a6fc8279db55ff77188829757
coderd/apidoc/docs.gohttps://github.com/coder/coder/pull/28097/files#diff-62ac3890066a69746687795ab05779ba2ddf1f4027cf2448425af7728c8da7b4
View file https://github.com/coder/coder/blob/ccadf55c259c8c68d4df6c03cdd1274840cb674e/coderd/apidoc/docs.go
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/coder/coder/pull/28097/files
coderd/apidoc/swagger.jsonhttps://github.com/coder/coder/pull/28097/files#diff-f7851d516b0d2ef3ed1f6bbdd199cd120f502761c6f2c2a472bd9ef2bc302d72
View file https://github.com/coder/coder/blob/ccadf55c259c8c68d4df6c03cdd1274840cb674e/coderd/apidoc/swagger.json
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/coder/coder/pull/28097/files
coderd/oauth2.gohttps://github.com/coder/coder/pull/28097/files#diff-8c6e99c95c08ac3ac038b05610ec90a68ef65af1181ff01aa7fa23f8f00f81d9
View file https://github.com/coder/coder/blob/ccadf55c259c8c68d4df6c03cdd1274840cb674e/coderd/oauth2.go
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/28097/{{ revealButtonHref }}
https://github.com/coder/coder/pull/28097/files#diff-8c6e99c95c08ac3ac038b05610ec90a68ef65af1181ff01aa7fa23f8f00f81d9
https://github.com/coder/coder/pull/28097/files#diff-8c6e99c95c08ac3ac038b05610ec90a68ef65af1181ff01aa7fa23f8f00f81d9
coderd/oauth2_test.gohttps://github.com/coder/coder/pull/28097/files#diff-92e9a528ba24e3a3b55232e1307fca71f7d4b5ee1145ff84e7351dacd694b575
View file https://github.com/coder/coder/blob/ccadf55c259c8c68d4df6c03cdd1274840cb674e/coderd/oauth2_test.go
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/28097/{{ revealButtonHref }}
https://github.com/coder/coder/pull/28097/files#diff-92e9a528ba24e3a3b55232e1307fca71f7d4b5ee1145ff84e7351dacd694b575
https://github.com/coder/coder/pull/28097/files#diff-92e9a528ba24e3a3b55232e1307fca71f7d4b5ee1145ff84e7351dacd694b575
coderd/oauth2provider/app_secrets.gohttps://github.com/coder/coder/pull/28097/files#diff-5956ee4538b35f804285ced3a9bfea639e766fe096a2ee57df90106eab717a3c
View file https://github.com/coder/coder/blob/ccadf55c259c8c68d4df6c03cdd1274840cb674e/coderd/oauth2provider/app_secrets.go
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/28097/{{ revealButtonHref }}
https://github.com/coder/coder/pull/28097/files#diff-5956ee4538b35f804285ced3a9bfea639e766fe096a2ee57df90106eab717a3c
Please reload this pagehttps://github.com/coder/coder/pull/28097/files
Please reload this pagehttps://github.com/coder/coder/pull/28097/files
https://github.com/coder/coder/pull/28097/files#diff-5956ee4538b35f804285ced3a9bfea639e766fe096a2ee57df90106eab717a3c
coderd/oauth2provider/registration.gohttps://github.com/coder/coder/pull/28097/files#diff-775dcfdb8865d51df8aac08de8fab3f0cff8631920922affb5f3988e39cd98eb
View file https://github.com/coder/coder/blob/ccadf55c259c8c68d4df6c03cdd1274840cb674e/coderd/oauth2provider/registration.go
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/28097/{{ revealButtonHref }}
https://github.com/coder/coder/pull/28097/files#diff-775dcfdb8865d51df8aac08de8fab3f0cff8631920922affb5f3988e39cd98eb
https://github.com/coder/coder/pull/28097/files#diff-775dcfdb8865d51df8aac08de8fab3f0cff8631920922affb5f3988e39cd98eb
https://github.com/coder/coder/pull/28097/files#diff-775dcfdb8865d51df8aac08de8fab3f0cff8631920922affb5f3988e39cd98eb
https://github.com/coder/coder/pull/28097/files#diff-775dcfdb8865d51df8aac08de8fab3f0cff8631920922affb5f3988e39cd98eb
https://github.com/coder/coder/pull/28097/files#diff-775dcfdb8865d51df8aac08de8fab3f0cff8631920922affb5f3988e39cd98eb
https://github.com/coder/coder/pull/28097/files#diff-775dcfdb8865d51df8aac08de8fab3f0cff8631920922affb5f3988e39cd98eb
https://github.com/coder/coder/pull/28097/files#diff-775dcfdb8865d51df8aac08de8fab3f0cff8631920922affb5f3988e39cd98eb
Please reload this pagehttps://github.com/coder/coder/pull/28097/files
Please reload this pagehttps://github.com/coder/coder/pull/28097/files
https://github.com/coder/coder/pull/28097/files#diff-775dcfdb8865d51df8aac08de8fab3f0cff8631920922affb5f3988e39cd98eb
coderd/oauth2provider/registration_test.gohttps://github.com/coder/coder/pull/28097/files#diff-3d62d6dfbb4f1e54e6a7e61f1ebe4425578a2b860eec89c43684e045b21a92d7
View file https://github.com/coder/coder/blob/ccadf55c259c8c68d4df6c03cdd1274840cb674e/coderd/oauth2provider/registration_test.go
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/28097/{{ revealButtonHref }}
https://github.com/coder/coder/pull/28097/files#diff-3d62d6dfbb4f1e54e6a7e61f1ebe4425578a2b860eec89c43684e045b21a92d7
Please reload this pagehttps://github.com/coder/coder/pull/28097/files
docs/admin/integrations/oauth2-provider.mdhttps://github.com/coder/coder/pull/28097/files#diff-45214b5c2eed3fbe50a4000a697fa5370506d7659e81214a2ce59294d54d15c6
View file https://github.com/coder/coder/blob/ccadf55c259c8c68d4df6c03cdd1274840cb674e/docs/admin/integrations/oauth2-provider.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/28097/{{ revealButtonHref }}
https://github.com/coder/coder/pull/28097/files#diff-45214b5c2eed3fbe50a4000a697fa5370506d7659e81214a2ce59294d54d15c6
https://github.com/coder/coder/actions/runs/33453612710/job/99688877349?pr=28097
https://github.com/coder/coder/pull/28097/files#diff-45214b5c2eed3fbe50a4000a697fa5370506d7659e81214a2ce59294d54d15c6
https://github.com/coder/coder/pull/28097/files#diff-45214b5c2eed3fbe50a4000a697fa5370506d7659e81214a2ce59294d54d15c6
https://github.com/coder/coder/pull/28097/files#diff-45214b5c2eed3fbe50a4000a697fa5370506d7659e81214a2ce59294d54d15c6
https://github.com/coder/coder/pull/28097/files#diff-45214b5c2eed3fbe50a4000a697fa5370506d7659e81214a2ce59294d54d15c6
https://github.com/coder/coder/actions/runs/33453612710/job/99688877349?pr=28097
https://github.com/coder/coder/pull/28097/files#diff-45214b5c2eed3fbe50a4000a697fa5370506d7659e81214a2ce59294d54d15c6
docs/reference/api/enterprise.mdhttps://github.com/coder/coder/pull/28097/files#diff-b27c921c256b93fc529c8cde9a4cf56cfa94cf9a6fc8279db55ff77188829757
View file https://github.com/coder/coder/blob/ccadf55c259c8c68d4df6c03cdd1274840cb674e/docs/reference/api/enterprise.md
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/coder/coder/pull/28097/files
Please reload this pagehttps://github.com/coder/coder/pull/28097/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.