René's URL Explorer Experiment


Title: fix: preserve Vale severity in CI annotations and add three-severity demo by nickvigilante · Pull Request #26587 · coder/coder · GitHub

Open Graph Title: fix: preserve Vale severity in CI annotations and add three-severity demo by nickvigilante · Pull Request #26587 · coder/coder

X Title: fix: preserve Vale severity in CI annotations and add three-severity demo by nickvigilante · Pull Request #26587 · coder/coder

Description: Closes DOCS-426. Follow-up to #26586 (DOCS-425, strip), which merged first. Problem The Vale problem matcher at .github/vale-problem-matcher.json hard-codes "severity": "warning". Every Vale finding renders as a GitHub warning annotation, regardless of Vale's actual severity. Nick observed this on PR #25501: error-level findings from Coder.BrandNames appear as warnings. This collapsed the doctrine's three-severity ladder (error / warning / suggestion) into a single advisory channel for the reader of a PR diff. This PR restores the ladder visually so contributors and reviewers see each rule's intended severity. Root cause GitHub Actions problem matchers expect either a regex capture group for severity or a hard-coded severity. Vale's --output=line format produces path:line:col:rule:message with severity stripped, so the matcher had no severity to capture and fell back on the hard-coded value. Fix Commit 1: severity rendering Switch the Vale prose lint step to vale --output=JSON and pipe through jq to emit GitHub workflow commands directly. Drop the problem matcher file. Vale severity GitHub workflow command suggestion ::notice:: warning ::warning:: error ::error:: Message bodies are URL-encoded for %, \r, and \n per the GitHub Actions workflow command spec. The Vale step stays advisory (continue-on-error: true, vale --no-exit); rendering becomes correct but the step never fails the job. Commit 2: three-severity demo Three throwaway Coder.Demo* rules at level: suggestion, level: warning, and level: error, plus a docs/.style/_vale-annotation-demo.md file that triggers each rule exactly once. Together with the rendering fix above, this PR's CI surfaces three GitHub annotations in three distinct severities (notice, warning, error). Use the Files Changed view to inspect rendering. The demo files live permanently in docs/.style/, which is excluded from coder.com. They re-trigger annotations only on PRs that touch the demo file itself, so they don't pollute CI on day-to-day PRs. Sample output Out of scope Blocking merge on error-level findings is the natural next step but is sequenced as the final step of the prose-style rollout. It was prototyped in this PR (commit 3, since backed out) and verified end-to-end against the demo doc. The work moved to DOCS-433 so the corpus of enabled rules is broad enough by the time the gate lands that it catches real violations rather than novelty failures from a single rule. Expected CI state on this PR lint-docs passes. The three demo annotations render at lines 17 / 19 / 21 of docs/.style/_vale-annotation-demo.md as ::notice::, ::warning::, and ::error:: respectively. The ::error:: annotation does not fail the job because the Vale step is still advisory under this PR. Local verification of the rendering pipeline: $ printf '%s\n' 'docs/.style/_vale-annotation-demo.md' \ | xargs -d '\n' vale --no-exit --output=JSON \ | jq -r '...' ::notice file=docs/.style/_vale-annotation-demo.md,line=17,col=3,title=Coder.DemoSuggestion::[Demo] Suggestion-level Vale annotation. ::warning file=docs/.style/_vale-annotation-demo.md,line=19,col=3,title=Coder.DemoWarning::[Demo] Warning-level Vale annotation. ::error file=docs/.style/_vale-annotation-demo.md,line=21,col=3,title=Coder.DemoError::[Demo] Error-level Vale annotation. Decision log Workflow commands vs custom Vale template + updated matcher: chose workflow commands because the transform is a 10-line jq pipeline with no extra files to maintain, and it bypasses GitHub Actions problem-matcher limitations entirely. The custom-template option would have kept the matcher infrastructure but required an additional Go template file under .github/. Throwaway demo rules vs reusing existing rules: chose throwaway because we wanted each severity to fire deterministically from a single unambiguous marker. Reusing existing rules would couple the demo to corpus content and obscure the signal. Demo persists vs drops before merge: persists. The merge-gate constraint that originally forced the demo to drop is gone (deferred to DOCS-433). The four demo files live in docs/.style/, excluded from coder.com, and only annotate PRs that touch them. They double as a permanent canary so a future regression in severity rendering surfaces immediately on whichever PR introduces it, and as the verification artifact DOCS-433 uses when re-installing the merge gate. docs/.style/_vale-annotation-demo.md filename: underscore prefix follows Coder convention for files that exist outside the normal docs taxonomy. Not surfaced on coder.com/docs because docs/.style/ is excluded from the manifest, deploy workflow, and docs preview. Merge-block deferred to DOCS-433: the rendering fix and the merge gate are independent changes. Shipping the rendering first lets contributors see the three-severity ladder while the rule catalogue is still small and the false-positive policy hasn't been stress-tested yet. The gate lands as the final step of the rollout, after the catalogue is broad enough that the gate covers real prose-style policy rather than one rule's enforcement. Filed via Coder Agents on Nick's behalf.

Open Graph Description: Closes DOCS-426. Follow-up to #26586 (DOCS-425, strip), which merged first. Problem The Vale problem matcher at .github/vale-problem-matcher.json hard-codes "severity": "warning"...

X Description: Closes DOCS-426. Follow-up to #26586 (DOCS-425, strip), which merged first. Problem The Vale problem matcher at .github/vale-problem-matcher.json hard-codes "severity": "...

Opengraph URL: https://github.com/coder/coder/pull/26587

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2e3ce1d8-4c2a-ddd1-f9cc-a28cbbc2e0fa
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9D1E:4BB79:2214FF5:2B7F01B:6B018249
html-safe-nonce7ca354090f947950545f46f4ac526de5b57315e12a78a11d0ebe2eb8dcefd77e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RDFFOjRCQjc5OjIyMTRGRjU6MkI3RjAxQjo2QjAxODI0OSIsInZpc2l0b3JfaWQiOiI4NTMwMzUzMjIyNjIyMjE2Nzc3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacba76e28f9a7695a58af276474191045af108c5d5734cf80a7b976bd9817729f4
hovercard-subject-tagpull_request:3915410325
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/coder/coder/pull/26587/files
twitter:imagehttps://avatars.githubusercontent.com/u/13631471?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/13631471?s=400&v=4
og:image:altCloses DOCS-426. Follow-up to #26586 (DOCS-425, strip), which merged first. Problem The Vale problem matcher at .github/vale-problem-matcher.json hard-codes "severity": "warning"...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/coder/coder/pull/26587/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F26587%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F26587%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/pull/26587/files
Reloadhttps://github.com/coder/coder/pull/26587/files
Reloadhttps://github.com/coder/coder/pull/26587/files
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fcoder%2Fcoder%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fcoder%2Fcoder%2Fissues%2Fnew%2Fchoose
nickvigilantehttps://github.com/nickvigilante
mainhttps://github.com/coder/coder/tree/main
vigilante/docs-426-fix-vale-ci-annotation-severity-rendering-add-three-severityhttps://github.com/coder/coder/tree/vigilante/docs-426-fix-vale-ci-annotation-severity-rendering-add-three-severity
Conversation 3 https://github.com/coder/coder/pull/26587
Commits 2 https://github.com/coder/coder/pull/26587/commits
Checks 52 https://github.com/coder/coder/pull/26587/checks
Files changed https://github.com/coder/coder/pull/26587/files
Please reload this pagehttps://github.com/coder/coder/pull/26587/files
fix: preserve Vale severity in CI annotations and add three-severity demo https://github.com/coder/coder/pull/26587/files#top
Show all changes 2 commits https://github.com/coder/coder/pull/26587/files
f319798 fix(.github/workflows/ci.yaml): preserve Vale severity in CI annotations nickvigilante Jun 22, 2026 https://github.com/coder/coder/pull/26587/commits/f31979811de8dab5f10775d7df3bc50d48da3766
c55cd7c demo(docs/.style): add three-severity Vale annotation rendering canary nickvigilante Jun 22, 2026 https://github.com/coder/coder/pull/26587/commits/c55cd7c964a3a713d0adb1436e193855354eb306
Clear filters https://github.com/coder/coder/pull/26587/files
Please reload this pagehttps://github.com/coder/coder/pull/26587/files
Please reload this pagehttps://github.com/coder/coder/pull/26587/files
vale-problem-matcher.json https://github.com/coder/coder/pull/26587/files#diff-1a3d33a1c0ea093b5a50723728e3523629244c41b52ed4bb466c1e464b92ed4c
ci.yaml https://github.com/coder/coder/pull/26587/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
_vale-annotation-demo.md https://github.com/coder/coder/pull/26587/files#diff-c349707139d6d97beb7daff2f0463ef04523af0e036487c79f645fd81fa164ef
DemoError.yml https://github.com/coder/coder/pull/26587/files#diff-0e1cb5b5be2b7d98d2e79bf7212c64e8d3c3d2eac3a4204e42191a16103fbf5c
DemoSuggestion.yml https://github.com/coder/coder/pull/26587/files#diff-9889b2cd8ea650b2223f37beba1a63bcdb4d12087cbe6d3c54acdfc37c96db2f
DemoWarning.yml https://github.com/coder/coder/pull/26587/files#diff-c12719ded65178c8a5f039a7b1b26c8c1519523853ce97f6ff23120fd44849b1
https://github.com/coder/coder/blob/main/CODEOWNERS#L33
.github/vale-problem-matcher.jsonhttps://github.com/coder/coder/pull/26587/files#diff-1a3d33a1c0ea093b5a50723728e3523629244c41b52ed4bb466c1e464b92ed4c
View file https://github.com/coder/coder/blob/bdf0e417b12e309a92adb5a6ff3c36d0c5e80288/.github/vale-problem-matcher.json
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/coder/coder/pull/26587/files
https://github.com/coder/coder/blob/main/CODEOWNERS#L33
.github/workflows/ci.yamlhttps://github.com/coder/coder/pull/26587/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
View file https://github.com/coder/coder/blob/c55cd7c964a3a713d0adb1436e193855354eb306/.github/workflows/ci.yaml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/26587/{{ revealButtonHref }}
https://github.com/coder/coder/pull/26587/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
https://github.com/coder/coder/pull/26587/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
docs/.style/_vale-annotation-demo.mdhttps://github.com/coder/coder/pull/26587/files#diff-c349707139d6d97beb7daff2f0463ef04523af0e036487c79f645fd81fa164ef
View file https://github.com/coder/coder/blob/c55cd7c964a3a713d0adb1436e193855354eb306/docs/.style/_vale-annotation-demo.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/26587/{{ revealButtonHref }}
https://github.com/coder/coder/actions/runs/28040775414/job/83006348092?pr=26587
https://github.com/coder/coder/actions/runs/28040775414/job/83006348092?pr=26587
https://github.com/coder/coder/actions/runs/28040775414/job/83006348092?pr=26587
docs/.style/styles/Coder/DemoError.ymlhttps://github.com/coder/coder/pull/26587/files#diff-0e1cb5b5be2b7d98d2e79bf7212c64e8d3c3d2eac3a4204e42191a16103fbf5c
View file https://github.com/coder/coder/blob/c55cd7c964a3a713d0adb1436e193855354eb306/docs/.style/styles/Coder/DemoError.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/26587/{{ revealButtonHref }}
docs/.style/styles/Coder/DemoSuggestion.ymlhttps://github.com/coder/coder/pull/26587/files#diff-9889b2cd8ea650b2223f37beba1a63bcdb4d12087cbe6d3c54acdfc37c96db2f
View file https://github.com/coder/coder/blob/c55cd7c964a3a713d0adb1436e193855354eb306/docs/.style/styles/Coder/DemoSuggestion.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/26587/{{ revealButtonHref }}
docs/.style/styles/Coder/DemoWarning.ymlhttps://github.com/coder/coder/pull/26587/files#diff-c12719ded65178c8a5f039a7b1b26c8c1519523853ce97f6ff23120fd44849b1
View file https://github.com/coder/coder/blob/c55cd7c964a3a713d0adb1436e193855354eb306/docs/.style/styles/Coder/DemoWarning.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/26587/{{ revealButtonHref }}
Please reload this pagehttps://github.com/coder/coder/pull/26587/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.