René's URL Explorer Experiment


Title: Lock the fake database during transactions by spikecurtis · Pull Request #2478 · coder/coder · GitHub

Open Graph Title: Lock the fake database during transactions by spikecurtis · Pull Request #2478 · coder/coder

X Title: Lock the fake database during transactions by spikecurtis · Pull Request #2478 · coder/coder

Description: Secure environments for developers and their agents - Lock the fake database during transactions by spikecurtis · Pull Request #2478 · coder/coder

Open Graph Description: Might fix #2436 entirely, but definitely will fix in the fake db case. There are additional bugs lurking around basically every use of InTx() in our tests that this fixes, because until this PR, tr...

X Description: Might fix #2436 entirely, but definitely will fix in the fake db case. There are additional bugs lurking around basically every use of InTx() in our tests that this fixes, because until this PR, tr...

Opengraph URL: https://github.com/coder/coder/pull/2478

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4e304727-35b3-4d44-1179-4805f4afab90
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE4B6:3CBB3E:1A86D9F:21C6483:6B01929E
html-safe-nonce0aa2a645fb2ba0c599f052baca7df4631b3265c146fb946df52430c5f5d93057
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNEI2OjNDQkIzRToxQTg2RDlGOjIxQzY0ODM6NkIwMTkyOUUiLCJ2aXNpdG9yX2lkIjoiNTU0NzM1NzQ4NjU4NTk4NTU4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc9fe4dec2ac84782b3d180f819f7671e338e608ef7b3346d3c772a4dd9536466
hovercard-subject-tagpull_request:970900993
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/2478/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/03b8b33a0247edff9c3834c57ec029d4c86f018c9c4a0208aab081bff948837f/coder/coder/pull/2478
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/03b8b33a0247edff9c3834c57ec029d4c86f018c9c4a0208aab081bff948837f/coder/coder/pull/2478
og:image:altMight fix #2436 entirely, but definitely will fix in the fake db case. There are additional bugs lurking around basically every use of InTx() in our tests that this fixes, because until this PR, tr...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamespikecurtis
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/coder/coder/pull/2478#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F2478
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F2478
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/pull/2478
Reloadhttps://github.com/coder/coder/pull/2478
Reloadhttps://github.com/coder/coder/pull/2478
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
https://github.com/coder/coder
spikecurtishttps://github.com/spikecurtis
mainhttps://github.com/coder/coder/tree/main
spike/2436_better_fake_db_transaction_isolationhttps://github.com/coder/coder/tree/spike/2436_better_fake_db_transaction_isolation
Conversationhttps://github.com/coder/coder/pull/2478
Commits5 (5)https://github.com/coder/coder/pull/2478/commits
Checkshttps://github.com/coder/coder/pull/2478/checks
Files changedhttps://github.com/coder/coder/pull/2478/files
Lock the fake database during transactionshttps://github.com/coder/coder/pull/2478#top
spikecurtishttps://github.com/spikecurtis
mainhttps://github.com/coder/coder/tree/main
spike/2436_better_fake_db_transaction_isolationhttps://github.com/coder/coder/tree/spike/2436_better_fake_db_transaction_isolation
https://github.com/spikecurtis
spikecurtishttps://github.com/spikecurtis
Jun 17, 2022https://github.com/coder/coder/pull/2478#issue-1275349926
#2436https://github.com/coder/coder/issues/2436
Please reload this pagehttps://github.com/coder/coder/pull/2478
https://github.com/spikecurtis
Lock the fake database during transactionshttps://github.com/coder/coder/pull/2478/commits/fa3a3dbd82b02a3d8509aa809f09168df7f23851
fa3a3dbhttps://github.com/coder/coder/pull/2478/commits/fa3a3dbd82b02a3d8509aa809f09168df7f23851
https://github.com/spikecurtis
spikecurtishttps://github.com/spikecurtis
Emyrkhttps://github.com/Emyrk
June 17, 2022 18:35https://github.com/coder/coder/pull/2478#event-6830872995
https://github.com/spikecurtis
spikecurtishttps://github.com/spikecurtis
Jun 17, 2022 https://github.com/coder/coder/pull/2478#ref-pullrequest-1275315628
fake database locks during transactions #2473 https://github.com/coder/coder/pull/2473
https://github.com/Emyrk
Emyrkhttps://github.com/Emyrk
Jun 17, 2022 https://github.com/coder/coder/pull/2478#pullrequestreview-1010906141
View reviewed changes https://github.com/coder/coder/pull/2478/files/fa3a3dbd82b02a3d8509aa809f09168df7f23851
coderd/database/databasefake/databasefake.gohttps://github.com/coder/coder/pull/2478/files/fa3a3dbd82b02a3d8509aa809f09168df7f23851#diff-7d8285434c7381493f3ec8aa6c8671699af10be17b34acf10d576495f1de16f9
Emyrkhttps://github.com/Emyrk
Jun 17, 2022https://github.com/coder/coder/pull/2478#discussion_r900424225
Please reload this pagehttps://github.com/coder/coder/pull/2478
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/2478
https://github.com/Emyrk
Emyrkhttps://github.com/Emyrk
Jun 17, 2022 https://github.com/coder/coder/pull/2478#pullrequestreview-1010908040
View reviewed changes https://github.com/coder/coder/pull/2478/files/fa3a3dbd82b02a3d8509aa809f09168df7f23851
Emyrkhttps://github.com/Emyrk
https://github.com/coder/coder/pull/2478#pullrequestreview-1010908040
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/2478
spikecurtishttps://github.com/spikecurtis
June 17, 2022 12:00https://github.com/coder/coder/pull/2478#commits-pushed-945eed2
https://github.com/spikecurtis
Add ut for fake database transactionshttps://github.com/coder/coder/pull/2478/commits/945eed20c57fdaecae59099f6d32e1b06f2671ab
945eed2https://github.com/coder/coder/pull/2478/commits/945eed20c57fdaecae59099f6d32e1b06f2671ab
https://github.com/spikecurtis
fix linthttps://github.com/coder/coder/pull/2478/commits/6299d0c2004dc8019283c5ba1dfd494ff65a93ef
6299d0chttps://github.com/coder/coder/pull/2478/commits/6299d0c2004dc8019283c5ba1dfd494ff65a93ef
https://github.com/spikecurtis
Merge branch 'main' of github.com:coder/coder into spike/2436_better_…https://github.com/coder/coder/pull/2478/commits/d7efec3bfb702800783cd68886ce2ececf7bede7
d7efec3https://github.com/coder/coder/pull/2478/commits/d7efec3bfb702800783cd68886ce2ececf7bede7
https://github.com/spikecurtis
Fix lint macOShttps://github.com/coder/coder/pull/2478/commits/7da91abcd3786de67a31b756307c8763822e78b9
7da91abhttps://github.com/coder/coder/pull/2478/commits/7da91abcd3786de67a31b756307c8763822e78b9
https://github.com/spikecurtis
spikecurtishttps://github.com/spikecurtis
0aa66b4https://github.com/coder/coder/commit/0aa66b4296b12ef7311488240c559f2ce750c2f5
Jun 17, 2022https://github.com/coder/coder/pull/2478#event-6831433961
https://github.com/spikecurtis
spikecurtishttps://github.com/spikecurtis
June 17, 2022 20:50https://github.com/coder/coder/pull/2478#event-6831434033
https://github.co/hiddenchars
https://github.com/coder/coder/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F2478
https://github.com/Emyrk
Emyrk https://github.com/Emyrk
https://github.com/coder/coder/pull/2478/files/fa3a3dbd82b02a3d8509aa809f09168df7f23851
Please reload this pagehttps://github.com/coder/coder/pull/2478
database race on create build / acquire job https://github.com/coder/coder/issues/2436
Please reload this pagehttps://github.com/coder/coder/pull/2478
https://github.com/spikecurtis
https://github.com/Emyrk
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.