| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:4e304727-35b3-4d44-1179-4805f4afab90 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E4B6:3CBB3E:1A86D9F:21C6483:6B01929E |
| html-safe-nonce | 0aa2a645fb2ba0c599f052baca7df4631b3265c146fb946df52430c5f5d93057 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNEI2OjNDQkIzRToxQTg2RDlGOjIxQzY0ODM6NkIwMTkyOUUiLCJ2aXNpdG9yX2lkIjoiNTU0NzM1NzQ4NjU4NTk4NTU4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | c9fe4dec2ac84782b3d180f819f7671e338e608ef7b3346d3c772a4dd9536466 |
| hovercard-subject-tag | pull_request:970900993 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/2478/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/03b8b33a0247edff9c3834c57ec029d4c86f018c9c4a0208aab081bff948837f/coder/coder/pull/2478 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/03b8b33a0247edff9c3834c57ec029d4c86f018c9c4a0208aab081bff948837f/coder/coder/pull/2478 |
| og:image:alt | Might fix #2436 entirely, but definitely will fix in the fake db case.
There are additional bugs lurking around basically every use of InTx() in our tests that this fixes, because until this PR, tr... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | spikecurtis |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/coder/coder git https://github.com/coder/coder.git |
| octolytics-dimension-user_id | 95932066 |
| octolytics-dimension-user_login | coder |
| octolytics-dimension-repository_id | 440752086 |
| octolytics-dimension-repository_nwo | coder/coder |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 440752086 |
| octolytics-dimension-repository_network_root_nwo | coder/coder |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/coder/coder/pull/2478#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F2478 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F2478 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder |
| Reload | https://github.com/coder/coder/pull/2478 |
| Reload | https://github.com/coder/coder/pull/2478 |
| Reload | https://github.com/coder/coder/pull/2478 |
| coder | https://github.com/coder |
| coder | https://github.com/coder/coder |
| Code | https://github.com/coder/coder |
| Issues320 (320) | https://github.com/coder/coder/issues |
| Pull requests470 (470) | https://github.com/coder/coder/pulls |
| Discussions | https://github.com/coder/coder/discussions |
| Actions | https://github.com/coder/coder/actions |
| Projects | https://github.com/coder/coder/projects |
| Security and quality49 (49) | https://github.com/coder/coder/security |
| Insights | https://github.com/coder/coder/insights |
| https://github.com/coder/coder |
| spikecurtis | https://github.com/spikecurtis |
| main | https://github.com/coder/coder/tree/main |
| spike/2436_better_fake_db_transaction_isolation | https://github.com/coder/coder/tree/spike/2436_better_fake_db_transaction_isolation |
| Conversation | https://github.com/coder/coder/pull/2478 |
| Commits5 (5) | https://github.com/coder/coder/pull/2478/commits |
| Checks | https://github.com/coder/coder/pull/2478/checks |
| Files changed | https://github.com/coder/coder/pull/2478/files |
| Lock the fake database during transactions | https://github.com/coder/coder/pull/2478#top |
| spikecurtis | https://github.com/spikecurtis |
| main | https://github.com/coder/coder/tree/main |
| spike/2436_better_fake_db_transaction_isolation | https://github.com/coder/coder/tree/spike/2436_better_fake_db_transaction_isolation |
|
| https://github.com/spikecurtis |
| spikecurtis | https://github.com/spikecurtis |
| Jun 17, 2022 | https://github.com/coder/coder/pull/2478#issue-1275349926 |
| #2436 | https://github.com/coder/coder/issues/2436 |
| Please reload this page | https://github.com/coder/coder/pull/2478 |
|
| https://github.com/spikecurtis |
| Lock the fake database during transactions | https://github.com/coder/coder/pull/2478/commits/fa3a3dbd82b02a3d8509aa809f09168df7f23851 |
| fa3a3db | https://github.com/coder/coder/pull/2478/commits/fa3a3dbd82b02a3d8509aa809f09168df7f23851 |
| https://github.com/spikecurtis |
| spikecurtis | https://github.com/spikecurtis |
| Emyrk | https://github.com/Emyrk |
| June 17, 2022 18:35 | https://github.com/coder/coder/pull/2478#event-6830872995 |
| https://github.com/spikecurtis |
| spikecurtis | https://github.com/spikecurtis |
|
Jun 17, 2022
| https://github.com/coder/coder/pull/2478#ref-pullrequest-1275315628 |
|
fake database locks during transactions
#2473
| https://github.com/coder/coder/pull/2473 |
| https://github.com/Emyrk |
| Emyrk | https://github.com/Emyrk |
|
Jun 17, 2022
| https://github.com/coder/coder/pull/2478#pullrequestreview-1010906141 |
|
View reviewed changes
| https://github.com/coder/coder/pull/2478/files/fa3a3dbd82b02a3d8509aa809f09168df7f23851 |
| coderd/database/databasefake/databasefake.go | https://github.com/coder/coder/pull/2478/files/fa3a3dbd82b02a3d8509aa809f09168df7f23851#diff-7d8285434c7381493f3ec8aa6c8671699af10be17b34acf10d576495f1de16f9 |
| Emyrk | https://github.com/Emyrk |
| Jun 17, 2022 | https://github.com/coder/coder/pull/2478#discussion_r900424225 |
| Please reload this page | https://github.com/coder/coder/pull/2478 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/2478 |
| https://github.com/Emyrk |
| Emyrk | https://github.com/Emyrk |
|
Jun 17, 2022
| https://github.com/coder/coder/pull/2478#pullrequestreview-1010908040 |
|
View reviewed changes
| https://github.com/coder/coder/pull/2478/files/fa3a3dbd82b02a3d8509aa809f09168df7f23851 |
| Emyrk | https://github.com/Emyrk |
| https://github.com/coder/coder/pull/2478#pullrequestreview-1010908040 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/2478 |
| spikecurtis | https://github.com/spikecurtis |
| June 17, 2022 12:00 | https://github.com/coder/coder/pull/2478#commits-pushed-945eed2 |
|
| https://github.com/spikecurtis |
| Add ut for fake database transactions | https://github.com/coder/coder/pull/2478/commits/945eed20c57fdaecae59099f6d32e1b06f2671ab |
| 945eed2 | https://github.com/coder/coder/pull/2478/commits/945eed20c57fdaecae59099f6d32e1b06f2671ab |
|
| https://github.com/spikecurtis |
| fix lint | https://github.com/coder/coder/pull/2478/commits/6299d0c2004dc8019283c5ba1dfd494ff65a93ef |
| 6299d0c | https://github.com/coder/coder/pull/2478/commits/6299d0c2004dc8019283c5ba1dfd494ff65a93ef |
|
| https://github.com/spikecurtis |
| Merge branch 'main' of github.com:coder/coder into spike/2436_better_… | https://github.com/coder/coder/pull/2478/commits/d7efec3bfb702800783cd68886ce2ececf7bede7 |
| d7efec3 | https://github.com/coder/coder/pull/2478/commits/d7efec3bfb702800783cd68886ce2ececf7bede7 |
|
| https://github.com/spikecurtis |
| Fix lint macOS | https://github.com/coder/coder/pull/2478/commits/7da91abcd3786de67a31b756307c8763822e78b9 |
| 7da91ab | https://github.com/coder/coder/pull/2478/commits/7da91abcd3786de67a31b756307c8763822e78b9 |
| https://github.com/spikecurtis |
| spikecurtis | https://github.com/spikecurtis |
| 0aa66b4 | https://github.com/coder/coder/commit/0aa66b4296b12ef7311488240c559f2ce750c2f5 |
| Jun 17, 2022 | https://github.com/coder/coder/pull/2478#event-6831433961 |
| https://github.com/spikecurtis |
| spikecurtis | https://github.com/spikecurtis |
| June 17, 2022 20:50 | https://github.com/coder/coder/pull/2478#event-6831434033 |
| https://github.co/hiddenchars |
| https://github.com/coder/coder/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F2478 |
|
| https://github.com/Emyrk |
|
Emyrk
| https://github.com/Emyrk |
|
| https://github.com/coder/coder/pull/2478/files/fa3a3dbd82b02a3d8509aa809f09168df7f23851 |
| Please reload this page | https://github.com/coder/coder/pull/2478 |
|
database race on create build / acquire job
| https://github.com/coder/coder/issues/2436 |
| Please reload this page | https://github.com/coder/coder/pull/2478 |
|
| https://github.com/spikecurtis |
|
| https://github.com/Emyrk |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |