René's URL Explorer Experiment


Title: fake database locks during transactions by spikecurtis · Pull Request #2473 · coder/coder · GitHub

Open Graph Title: fake database locks during transactions by spikecurtis · Pull Request #2473 · coder/coder

X Title: fake database locks during transactions by spikecurtis · Pull Request #2473 · coder/coder

Description: Secure environments for developers and their agents - fake database locks during transactions by spikecurtis · Pull Request #2473 · coder/coder

Open Graph Description: Might fix #2436 entirely, but definitely will fix in the fake db case. There are additional bugs lurking around basically every use of InTx() in our tests that this fixes, because until this PR, tr...

X Description: Might fix #2436 entirely, but definitely will fix in the fake db case. There are additional bugs lurking around basically every use of InTx() in our tests that this fixes, because until this PR, tr...

Opengraph URL: https://github.com/coder/coder/pull/2473

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:60e6ff4a-8c67-795b-33a3-a0c77395aa40
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9088:8AE25:2CD5A3:3B0C46:6B018FEC
html-safe-nonce2dd3ddfa2b48a8fdc2bb3eb7f7d4dcddbd24c908575345bba3233b0dd2f06a9f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDg4OjhBRTI1OjJDRDVBMzozQjBDNDY6NkIwMThGRUMiLCJ2aXNpdG9yX2lkIjoiMTYyMDE4NTA3NzQzNjc0Nzc1NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac392c54120892898337db5b8dc5ffc4608a64d290203ef5ca4c1e4730ff475044
hovercard-subject-tagpull_request:970870658
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/2473/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0133edfbc0bf45e2c060461e3480d2fc837f4f197ed18eeca8703c6121264a44/coder/coder/pull/2473
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0133edfbc0bf45e2c060461e3480d2fc837f4f197ed18eeca8703c6121264a44/coder/coder/pull/2473
og:image:altMight fix #2436 entirely, but definitely will fix in the fake db case. There are additional bugs lurking around basically every use of InTx() in our tests that this fixes, because until this PR, tr...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamespikecurtis
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/coder/coder/pull/2473#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F2473
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F2473
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/pull/2473
Reloadhttps://github.com/coder/coder/pull/2473
Reloadhttps://github.com/coder/coder/pull/2473
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
https://github.com/coder/coder
spikecurtishttps://github.com/spikecurtis
mainhttps://github.com/coder/coder/tree/main
spike/2436_fake_db_transaction_isolationhttps://github.com/coder/coder/tree/spike/2436_fake_db_transaction_isolation
Conversationhttps://github.com/coder/coder/pull/2473
Commits2 (2)https://github.com/coder/coder/pull/2473/commits
Checkshttps://github.com/coder/coder/pull/2473/checks
Files changedhttps://github.com/coder/coder/pull/2473/files
fake database locks during transactionshttps://github.com/coder/coder/pull/2473#top
spikecurtishttps://github.com/spikecurtis
mainhttps://github.com/coder/coder/tree/main
spike/2436_fake_db_transaction_isolationhttps://github.com/coder/coder/tree/spike/2436_fake_db_transaction_isolation
https://github.com/spikecurtis
spikecurtishttps://github.com/spikecurtis
Jun 17, 2022https://github.com/coder/coder/pull/2473#issue-1275315628
Please reload this pagehttps://github.com/coder/coder/pull/2473
#2436https://github.com/coder/coder/issues/2436
Please reload this pagehttps://github.com/coder/coder/pull/2473
https://github.com/spikecurtis
fake database locks during transactionshttps://github.com/coder/coder/pull/2473/commits/9e830f3b722fcc6ecae12439079a854ac9631a3d
9e830f3https://github.com/coder/coder/pull/2473/commits/9e830f3b722fcc6ecae12439079a854ac9631a3d
https://github.com/spikecurtis
spikecurtishttps://github.com/spikecurtis
June 17, 2022 17:51https://github.com/coder/coder/pull/2473#event-6830665927
https://github.com/spikecurtis
Merge branch 'main' of github.com:coder/coder into spike/2436_fake_db…https://github.com/coder/coder/pull/2473/commits/54fbfeb2589658866972236a55198355815f5cba
54fbfebhttps://github.com/coder/coder/pull/2473/commits/54fbfeb2589658866972236a55198355815f5cba
https://github.com/Emyrk
Emyrkhttps://github.com/Emyrk
Jun 17, 2022https://github.com/coder/coder/pull/2473#issuecomment-1159115487
Please reload this pagehttps://github.com/coder/coder/pull/2473
https://github.com/johnstcn
johnstcnhttps://github.com/johnstcn
Jun 17, 2022 https://github.com/coder/coder/pull/2473#pullrequestreview-1010867244
View reviewed changes https://github.com/coder/coder/pull/2473/files/54fbfeb2589658866972236a55198355815f5cba
johnstcnhttps://github.com/johnstcn
https://github.com/coder/coder/pull/2473#pullrequestreview-1010867244
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/2473
coderd/database/databasefake/reentrantlock.gohttps://github.com/coder/coder/pull/2473/files/54fbfeb2589658866972236a55198355815f5cba#diff-c80a4326c1dff5df1300a7bd9d7e3e71935cdd2a1418a929a0e7ab7872381ee2
johnstcnhttps://github.com/johnstcn
Jun 17, 2022https://github.com/coder/coder/pull/2473#discussion_r900396121
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/2473
coderd/database/databasefake/reentrantlock.gohttps://github.com/coder/coder/pull/2473/files/54fbfeb2589658866972236a55198355815f5cba#diff-c80a4326c1dff5df1300a7bd9d7e3e71935cdd2a1418a929a0e7ab7872381ee2
johnstcnhttps://github.com/johnstcn
Jun 17, 2022https://github.com/coder/coder/pull/2473#discussion_r900400028
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/2473
spikecurtishttps://github.com/spikecurtis
Jun 17, 2022https://github.com/coder/coder/pull/2473#discussion_r900411991
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/2473
https://github.com/johnstcn
johnstcnhttps://github.com/johnstcn
spikecurtishttps://github.com/spikecurtis
Jun 17, 2022https://github.com/coder/coder/pull/2473#event-6830734425
https://github.com/johnstcn
johnstcnhttps://github.com/johnstcn
June 17, 2022 18:06https://github.com/coder/coder/pull/2473#event-6830734744
https://github.com/Emyrk
Emyrkhttps://github.com/Emyrk
Jun 17, 2022https://github.com/coder/coder/pull/2473#issuecomment-1159120985
Please reload this pagehttps://github.com/coder/coder/pull/2473
https://github.com/deansheather
deansheatherhttps://github.com/deansheather
Jun 17, 2022 https://github.com/coder/coder/pull/2473#pullrequestreview-1010879092
View reviewed changes https://github.com/coder/coder/pull/2473/files/54fbfeb2589658866972236a55198355815f5cba
coderd/database/databasefake/reentrantlock.gohttps://github.com/coder/coder/pull/2473/files/54fbfeb2589658866972236a55198355815f5cba#diff-c80a4326c1dff5df1300a7bd9d7e3e71935cdd2a1418a929a0e7ab7872381ee2
deansheatherhttps://github.com/deansheather
Jun 17, 2022https://github.com/coder/coder/pull/2473#discussion_r900404645
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/2473
Emyrkhttps://github.com/Emyrk
Jun 17, 2022https://github.com/coder/coder/pull/2473#discussion_r900408028
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/2473
spikecurtishttps://github.com/spikecurtis
Jun 17, 2022https://github.com/coder/coder/pull/2473#discussion_r900411340
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/2473
Emyrkhttps://github.com/Emyrk
Jun 17, 2022https://github.com/coder/coder/pull/2473#discussion_r900413351
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#2470https://github.com/coder/coder/pull/2470
Please reload this pagehttps://github.com/coder/coder/pull/2473
https://github.com/dwahler
dwahlerhttps://github.com/dwahler
Jun 17, 2022https://github.com/coder/coder/pull/2473#issuecomment-1159123390
Please reload this pagehttps://github.com/coder/coder/pull/2473
https://github.com/Emyrk
Emyrkhttps://github.com/Emyrk
Jun 17, 2022https://github.com/coder/coder/pull/2473#issuecomment-1159126181
Please reload this pagehttps://github.com/coder/coder/pull/2473
https://github.com/spikecurtis
spikecurtishttps://github.com/spikecurtis
Jun 17, 2022https://github.com/coder/coder/pull/2473#issuecomment-1159138728
#2478https://github.com/coder/coder/pull/2478
@Emyrkhttps://github.com/Emyrk
Please reload this pagehttps://github.com/coder/coder/pull/2473
https://github.com/spikecurtis
spikecurtishttps://github.com/spikecurtis
Jun 17, 2022https://github.com/coder/coder/pull/2473#event-6830875353
https://github.com/spikecurtis
spikecurtishttps://github.com/spikecurtis
Jul 18, 2022 https://github.com/coder/coder/pull/2473#ref-issue-1275335970
Change the bulk of our tests to "true" unit tests, and kill the fake database #2476 https://github.com/coder/coder/issues/2476
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
February 4, 2023 20:05https://github.com/coder/coder/pull/2473#event-8439124560
https://github.co/hiddenchars
https://github.com/coder/coder/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F2473
https://github.com/johnstcn
johnstcn https://github.com/johnstcn
https://github.com/coder/coder/pull/2473/files/54fbfeb2589658866972236a55198355815f5cba
https://github.com/Emyrk
Emyrk https://github.com/Emyrk
https://github.com/coder/coder/pull/2473/files/54fbfeb2589658866972236a55198355815f5cba
https://github.com/deansheather
deansheather https://github.com/deansheather
https://github.com/coder/coder/pull/2473/files/54fbfeb2589658866972236a55198355815f5cba
Please reload this pagehttps://github.com/coder/coder/pull/2473
https://github.com/spikecurtis
spikecurtis https://github.com/spikecurtis
database race on create build / acquire job https://github.com/coder/coder/issues/2436
Please reload this pagehttps://github.com/coder/coder/pull/2473
https://github.com/spikecurtis
https://github.com/Emyrk
https://github.com/dwahler
https://github.com/johnstcn
https://github.com/deansheather
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.