René's URL Explorer Experiment


Title: fix: Avoid use of r.Context() after r.Hijack() by mafredri · Pull Request #1978 · coder/coder · GitHub

Open Graph Title: fix: Avoid use of r.Context() after r.Hijack() by mafredri · Pull Request #1978 · coder/coder

X Title: fix: Avoid use of r.Context() after r.Hijack() by mafredri · Pull Request #1978 · coder/coder

Description: This PR changes how we initialize websocket.NetConns so that we have a context that emits connection closure. Fixes #1508 fix: Fix goroutine leak by propagating websocket closure fix: Use of r.Context() in workspaceAgentDial fix: Use of rw and r.Context() in workspaceAgentListen fix: Use of r.Context() in workspaceAgentPTY This is version 2. Initially I implemented io.EOF closure propagation in coderd/turnconn.Conn, while I do think it may be a good idea, it's not necessary to fix #1508. I implemented it this way so that the fix can be utilized in the other handlers as well.

Open Graph Description: This PR changes how we initialize websocket.NetConns so that we have a context that emits connection closure. Fixes #1508 fix: Fix goroutine leak by propagating websocket closure fix: Use of r.Con...

X Description: This PR changes how we initialize websocket.NetConns so that we have a context that emits connection closure. Fixes #1508 fix: Fix goroutine leak by propagating websocket closure fix: Use of r.Con...

Opengraph URL: https://github.com/coder/coder/pull/1978

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:758843e5-6d82-42dd-956f-9ede596f8212
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDDC4:76F02:2483DDE:2EB1915:6B0181B7
html-safe-noncedcc1123a95163356245ddaf0b26f1a597f64ff60e39af8aef3e000e7e3f4b497
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEREM0Ojc2RjAyOjI0ODNEREU6MkVCMTkxNTo2QjAxODFCNyIsInZpc2l0b3JfaWQiOiIyNzQyMzQwMjkyNDg4Mjk4OTM1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac39f24cb20e4e01eaa901d11247e67738e2928068fd6eb76a89895d22dad4b413
hovercard-subject-tagpull_request:955867126
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/coder/coder/pull/1978/files
twitter:imagehttps://avatars.githubusercontent.com/u/147409?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/147409?s=400&v=4
og:image:altThis PR changes how we initialize websocket.NetConns so that we have a context that emits connection closure. Fixes #1508 fix: Fix goroutine leak by propagating websocket closure fix: Use of r.Con...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/coder/coder/pull/1978/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F1978%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F1978%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/pull/1978/files
Reloadhttps://github.com/coder/coder/pull/1978/files
Reloadhttps://github.com/coder/coder/pull/1978/files
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fcoder%2Fcoder%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fcoder%2Fcoder%2Fissues%2Fnew%2Fchoose
mafredrihttps://github.com/mafredri
mainhttps://github.com/coder/coder/tree/main
mafredri/fix-goroutine-leakhttps://github.com/coder/coder/tree/mafredri/fix-goroutine-leak
Conversation 8 https://github.com/coder/coder/pull/1978
Commits 6 https://github.com/coder/coder/pull/1978/commits
Checks 0 https://github.com/coder/coder/pull/1978/checks
Files changed https://github.com/coder/coder/pull/1978/files
Please reload this pagehttps://github.com/coder/coder/pull/1978/files
fix: Avoid use of r.Context() after r.Hijack() https://github.com/coder/coder/pull/1978/files#top
Show all changes 6 commits https://github.com/coder/coder/pull/1978/files
877959b fix: Fix goroutine leak by propagating websocket closure mafredri Jun 2, 2022 https://github.com/coder/coder/pull/1978/commits/877959bc15be9745535835bf22594a1cdbda81cd
0a354b6 fix: Use of r.Context() in workspaceAgentDial mafredri Jun 2, 2022 https://github.com/coder/coder/pull/1978/commits/0a354b6c63b38b0b9b0ec7709c36687fe2aff1bd
e0fb30c fix: Use of rw and r.Context() in workspaceAgentListen mafredri Jun 2, 2022 https://github.com/coder/coder/pull/1978/commits/e0fb30ca0ee1ea5b9f076ac736a41636734c02d2
e90a0c0 fix: Use of r.Context() in workspaceAgentPTY mafredri Jun 2, 2022 https://github.com/coder/coder/pull/1978/commits/e90a0c0c714792622a11985dbb5b287d705d1750
e0a2f8e chore: Fix PR comments mafredri Jun 2, 2022 https://github.com/coder/coder/pull/1978/commits/e0a2f8edf273cd26034d2e9fc838e9b02cfbf453
9e6727e fix: wsNetConn cancel on any error mafredri Jun 2, 2022 https://github.com/coder/coder/pull/1978/commits/9e6727e665c3684cf8fb65ab373083c50a1ea51f
Clear filters https://github.com/coder/coder/pull/1978/files
Please reload this pagehttps://github.com/coder/coder/pull/1978/files
Please reload this pagehttps://github.com/coder/coder/pull/1978/files
coderd/workspaceagents.gohttps://github.com/coder/coder/pull/1978/files#diff-e71d8c645ba64bced5cde8872ac613aba0975ff69969d6cc5c5a9721195d682d
View file https://github.com/coder/coder/blob/9e6727e665c3684cf8fb65ab373083c50a1ea51f/coderd/workspaceagents.go
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/1978/{{ revealButtonHref }}
https://github.com/coder/coder/pull/1978/files#diff-e71d8c645ba64bced5cde8872ac613aba0975ff69969d6cc5c5a9721195d682d
https://github.com/coder/coder/pull/1978/files#diff-e71d8c645ba64bced5cde8872ac613aba0975ff69969d6cc5c5a9721195d682d
https://github.com/coder/coder/pull/1978/files#diff-e71d8c645ba64bced5cde8872ac613aba0975ff69969d6cc5c5a9721195d682d
https://github.com/coder/coder/pull/1978/files#diff-e71d8c645ba64bced5cde8872ac613aba0975ff69969d6cc5c5a9721195d682d
https://github.com/coder/coder/pull/1978/files#diff-e71d8c645ba64bced5cde8872ac613aba0975ff69969d6cc5c5a9721195d682d
https://github.com/coder/coder/pull/1978/files#diff-e71d8c645ba64bced5cde8872ac613aba0975ff69969d6cc5c5a9721195d682d
https://github.com/coder/coder/pull/1978/files#diff-e71d8c645ba64bced5cde8872ac613aba0975ff69969d6cc5c5a9721195d682d
https://github.com/coder/coder/pull/1978/files#diff-e71d8c645ba64bced5cde8872ac613aba0975ff69969d6cc5c5a9721195d682d
https://github.com/coder/coder/pull/1978/files#diff-e71d8c645ba64bced5cde8872ac613aba0975ff69969d6cc5c5a9721195d682d
https://github.com/coder/coder/pull/1978/files#diff-e71d8c645ba64bced5cde8872ac613aba0975ff69969d6cc5c5a9721195d682d
https://github.com/coder/coder/pull/1978/files#diff-e71d8c645ba64bced5cde8872ac613aba0975ff69969d6cc5c5a9721195d682d
https://github.com/coder/coder/pull/1978/files#diff-e71d8c645ba64bced5cde8872ac613aba0975ff69969d6cc5c5a9721195d682d
Please reload this pagehttps://github.com/coder/coder/pull/1978/files
https://github.com/coder/coder/pull/1978/files#diff-e71d8c645ba64bced5cde8872ac613aba0975ff69969d6cc5c5a9721195d682d
https://github.com/coder/coder/pull/1978/files#diff-e71d8c645ba64bced5cde8872ac613aba0975ff69969d6cc5c5a9721195d682d
https://github.com/coder/coder/pull/1978/files#diff-e71d8c645ba64bced5cde8872ac613aba0975ff69969d6cc5c5a9721195d682d
https://github.com/coder/coder/pull/1978/files#diff-e71d8c645ba64bced5cde8872ac613aba0975ff69969d6cc5c5a9721195d682d
https://github.com/coder/coder/pull/1978/files#diff-e71d8c645ba64bced5cde8872ac613aba0975ff69969d6cc5c5a9721195d682d
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.