| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e879df7e-0f93-3c94-c895-3e1a6666a3c6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D79A:1148D3:213E505:2A6ED99:6B017A66 |
| html-safe-nonce | 09d9151bbc2385496dcb6f27de1d2178affff3015fceff9aca73725f95f9175d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENzlBOjExNDhEMzoyMTNFNTA1OjJBNkVEOTk6NkIwMTdBNjYiLCJ2aXNpdG9yX2lkIjoiMTg1MTc3NTQ5MDc2ODA3NTM2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | d3e9943d7954f0516f31434d2c673e92adaddceffcad2db6e623a43c818bb106 |
| hovercard-subject-tag | pull_request:955867126 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/1978/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/66b8c88731f8a9524dcc64524bf0633c35334514a602573d50397176c3827e24/coder/coder/pull/1978 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/66b8c88731f8a9524dcc64524bf0633c35334514a602573d50397176c3827e24/coder/coder/pull/1978 |
| og:image:alt | This PR changes how we initialize websocket.NetConns so that we have a context that emits connection closure.
Fixes #1508
fix: Fix goroutine leak by propagating websocket closure
fix: Use of r.Con... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mafredri |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/coder/coder git https://github.com/coder/coder.git |
| octolytics-dimension-user_id | 95932066 |
| octolytics-dimension-user_login | coder |
| octolytics-dimension-repository_id | 440752086 |
| octolytics-dimension-repository_nwo | coder/coder |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 440752086 |
| octolytics-dimension-repository_network_root_nwo | coder/coder |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/coder/coder/pull/1978#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F1978 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F1978 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder |
| Reload | https://github.com/coder/coder/pull/1978 |
| Reload | https://github.com/coder/coder/pull/1978 |
| Reload | https://github.com/coder/coder/pull/1978 |
| coder | https://github.com/coder |
| coder | https://github.com/coder/coder |
| Code | https://github.com/coder/coder |
| Issues320 (320) | https://github.com/coder/coder/issues |
| Pull requests470 (470) | https://github.com/coder/coder/pulls |
| Discussions | https://github.com/coder/coder/discussions |
| Actions | https://github.com/coder/coder/actions |
| Projects | https://github.com/coder/coder/projects |
| Security and quality49 (49) | https://github.com/coder/coder/security |
| Insights | https://github.com/coder/coder/insights |
| https://github.com/coder/coder |
| mafredri | https://github.com/mafredri |
| main | https://github.com/coder/coder/tree/main |
| mafredri/fix-goroutine-leak | https://github.com/coder/coder/tree/mafredri/fix-goroutine-leak |
| Conversation | https://github.com/coder/coder/pull/1978 |
| Commits6 (6) | https://github.com/coder/coder/pull/1978/commits |
| Checks | https://github.com/coder/coder/pull/1978/checks |
| Files changed | https://github.com/coder/coder/pull/1978/files |
| fix: Avoid use of r.Context() after r.Hijack() | https://github.com/coder/coder/pull/1978#top |
| mafredri | https://github.com/mafredri |
| main | https://github.com/coder/coder/tree/main |
| mafredri/fix-goroutine-leak | https://github.com/coder/coder/tree/mafredri/fix-goroutine-leak |
|
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| Jun 2, 2022 | https://github.com/coder/coder/pull/1978#issue-1258136592 |
| #1508 | https://github.com/coder/coder/issues/1508 |
| #1508 | https://github.com/coder/coder/issues/1508 |
| Please reload this page | https://github.com/coder/coder/pull/1978 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| Jun 2, 2022 | https://github.com/coder/coder/pull/1978#event-6728099412 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| June 2, 2022 12:47 | https://github.com/coder/coder/pull/1978#event-6728099482 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
|
Jun 2, 2022
| https://github.com/coder/coder/pull/1978#pullrequestreview-993486587 |
|
View reviewed changes
| https://github.com/coder/coder/pull/1978/files |
| coderd/workspaceagents.go | https://github.com/coder/coder/pull/1978/files#diff-e71d8c645ba64bced5cde8872ac613aba0975ff69969d6cc5c5a9721195d682d |
| Please reload this page | https://github.com/coder/coder/pull/1978 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
|
Jun 2, 2022
| https://github.com/coder/coder/pull/1978#pullrequestreview-993488778 |
|
View reviewed changes
| https://github.com/coder/coder/pull/1978/files |
| coderd/workspaceagents.go | https://github.com/coder/coder/pull/1978/files#diff-e71d8c645ba64bced5cde8872ac613aba0975ff69969d6cc5c5a9721195d682d |
| Please reload this page | https://github.com/coder/coder/pull/1978 |
| https://github.com/deansheather |
| deansheather | https://github.com/deansheather |
|
Jun 2, 2022
| https://github.com/coder/coder/pull/1978#pullrequestreview-993517196 |
|
View reviewed changes
| https://github.com/coder/coder/pull/1978/files |
| coderd/workspaceagents.go | https://github.com/coder/coder/pull/1978/files#diff-e71d8c645ba64bced5cde8872ac613aba0975ff69969d6cc5c5a9721195d682d |
| Please reload this page | https://github.com/coder/coder/pull/1978 |
| coderd/workspaceagents.go | https://github.com/coder/coder/pull/1978/files#diff-e71d8c645ba64bced5cde8872ac613aba0975ff69969d6cc5c5a9721195d682d |
| Please reload this page | https://github.com/coder/coder/pull/1978 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
|
Jun 2, 2022
| https://github.com/coder/coder/pull/1978#ref-pullrequest-1258349454 |
|
feat: Add support for pprof in coder agent
#1985
| https://github.com/coder/coder/pull/1985 |
| https://github.com/kylecarbs |
| kylecarbs | https://github.com/kylecarbs |
| Jun 2, 2022 | https://github.com/coder/coder/pull/1978#issuecomment-1145016193 |
| @mafredri | https://github.com/mafredri |
| Please reload this page | https://github.com/coder/coder/pull/1978 |
| mafredri | https://github.com/mafredri |
| June 3, 2022 12:28 | https://github.com/coder/coder/pull/1978#commits-pushed-877959b |
|
| https://github.com/mafredri |
| fix: Fix goroutine leak by propagating websocket closure | https://github.com/coder/coder/pull/1978/commits/877959bc15be9745535835bf22594a1cdbda81cd |
| 877959b | https://github.com/coder/coder/pull/1978/commits/877959bc15be9745535835bf22594a1cdbda81cd |
| #1508 | https://github.com/coder/coder/issues/1508 |
|
| https://github.com/mafredri |
| fix: Use of r.Context() in workspaceAgentDial | https://github.com/coder/coder/pull/1978/commits/0a354b6c63b38b0b9b0ec7709c36687fe2aff1bd |
| 0a354b6 | https://github.com/coder/coder/pull/1978/commits/0a354b6c63b38b0b9b0ec7709c36687fe2aff1bd |
|
| https://github.com/mafredri |
| fix: Use of rw and r.Context() in workspaceAgentListen | https://github.com/coder/coder/pull/1978/commits/e0fb30ca0ee1ea5b9f076ac736a41636734c02d2 |
| e0fb30c | https://github.com/coder/coder/pull/1978/commits/e0fb30ca0ee1ea5b9f076ac736a41636734c02d2 |
|
| https://github.com/mafredri |
| fix: Use of r.Context() in workspaceAgentPTY | https://github.com/coder/coder/pull/1978/commits/e90a0c0c714792622a11985dbb5b287d705d1750 |
| e90a0c0 | https://github.com/coder/coder/pull/1978/commits/e90a0c0c714792622a11985dbb5b287d705d1750 |
|
| https://github.com/mafredri |
| chore: Fix PR comments | https://github.com/coder/coder/pull/1978/commits/e0a2f8edf273cd26034d2e9fc838e9b02cfbf453 |
| e0a2f8e | https://github.com/coder/coder/pull/1978/commits/e0a2f8edf273cd26034d2e9fc838e9b02cfbf453 |
|
| https://github.com/mafredri |
| fix: wsNetConn cancel on any error | https://github.com/coder/coder/pull/1978/commits/9e6727e665c3684cf8fb65ab373083c50a1ea51f |
| 9e6727e | https://github.com/coder/coder/pull/1978/commits/9e6727e665c3684cf8fb65ab373083c50a1ea51f |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| force-pushed | https://github.com/coder/coder/compare/3f8c815b273ed35b52ddd33bec2bf225abdd674a..9e6727e665c3684cf8fb65ab373083c50a1ea51f |
| 3f8c815 | https://github.com/coder/coder/commit/3f8c815b273ed35b52ddd33bec2bf225abdd674a |
| 9e6727e | https://github.com/coder/coder/commit/9e6727e665c3684cf8fb65ab373083c50a1ea51f |
|
Compare
| https://github.com/coder/coder/compare/3f8c815b273ed35b52ddd33bec2bf225abdd674a..9e6727e665c3684cf8fb65ab373083c50a1ea51f |
| June 3, 2022 09:36 | https://github.com/coder/coder/pull/1978#event-6735040951 |
| https://github.com/johnstcn |
| johnstcn | https://github.com/johnstcn |
|
Jun 3, 2022
| https://github.com/coder/coder/pull/1978#pullrequestreview-994694225 |
|
View reviewed changes
| https://github.com/coder/coder/pull/1978/files/9e6727e665c3684cf8fb65ab373083c50a1ea51f |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| b4f5920 | https://github.com/coder/coder/commit/b4f5920df5d2bcea441d6f7572dd40df447dbadc |
| Jun 3, 2022 | https://github.com/coder/coder/pull/1978#event-6735118575 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| June 3, 2022 09:50 | https://github.com/coder/coder/pull/1978#event-6735118707 |
| https://github.co/hiddenchars |
| https://github.com/coder/coder/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F1978 |
|
| https://github.com/deansheather |
|
deansheather
| https://github.com/deansheather |
|
| https://github.com/coder/coder/pull/1978/files/f61c2ade77e715bbb34e0dafb0692f1ae72a6166 |
|
| https://github.com/johnstcn |
|
johnstcn
| https://github.com/johnstcn |
|
| https://github.com/coder/coder/pull/1978/files/9e6727e665c3684cf8fb65ab373083c50a1ea51f |
| Please reload this page | https://github.com/coder/coder/pull/1978 |
|
| https://github.com/mafredri |
|
mafredri
| https://github.com/mafredri |
|
Bug: Goroutine leak in coderd.(*api).workspaceAgentTurn
| https://github.com/coder/coder/issues/1508 |
| Please reload this page | https://github.com/coder/coder/pull/1978 |
|
| https://github.com/mafredri |
|
| https://github.com/kylecarbs |
|
| https://github.com/johnstcn |
|
| https://github.com/deansheather |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |