René's URL Explorer Experiment


Title: fix: Avoid use of r.Context() after r.Hijack() by mafredri · Pull Request #1978 · coder/coder · GitHub

Open Graph Title: fix: Avoid use of r.Context() after r.Hijack() by mafredri · Pull Request #1978 · coder/coder

X Title: fix: Avoid use of r.Context() after r.Hijack() by mafredri · Pull Request #1978 · coder/coder

Description: Secure environments for developers and their agents - fix: Avoid use of r.Context() after r.Hijack() by mafredri · Pull Request #1978 · coder/coder

Open Graph Description: This PR changes how we initialize websocket.NetConns so that we have a context that emits connection closure. Fixes #1508 fix: Fix goroutine leak by propagating websocket closure fix: Use of r.Con...

X Description: This PR changes how we initialize websocket.NetConns so that we have a context that emits connection closure. Fixes #1508 fix: Fix goroutine leak by propagating websocket closure fix: Use of r.Con...

Opengraph URL: https://github.com/coder/coder/pull/1978

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e879df7e-0f93-3c94-c895-3e1a6666a3c6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD79A:1148D3:213E505:2A6ED99:6B017A66
html-safe-nonce09d9151bbc2385496dcb6f27de1d2178affff3015fceff9aca73725f95f9175d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENzlBOjExNDhEMzoyMTNFNTA1OjJBNkVEOTk6NkIwMTdBNjYiLCJ2aXNpdG9yX2lkIjoiMTg1MTc3NTQ5MDc2ODA3NTM2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd3e9943d7954f0516f31434d2c673e92adaddceffcad2db6e623a43c818bb106
hovercard-subject-tagpull_request:955867126
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/1978/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/66b8c88731f8a9524dcc64524bf0633c35334514a602573d50397176c3827e24/coder/coder/pull/1978
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/66b8c88731f8a9524dcc64524bf0633c35334514a602573d50397176c3827e24/coder/coder/pull/1978
og:image:altThis PR changes how we initialize websocket.NetConns so that we have a context that emits connection closure. Fixes #1508 fix: Fix goroutine leak by propagating websocket closure fix: Use of r.Con...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemafredri
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/coder/coder/pull/1978#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F1978
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F1978
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/pull/1978
Reloadhttps://github.com/coder/coder/pull/1978
Reloadhttps://github.com/coder/coder/pull/1978
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
https://github.com/coder/coder
mafredrihttps://github.com/mafredri
mainhttps://github.com/coder/coder/tree/main
mafredri/fix-goroutine-leakhttps://github.com/coder/coder/tree/mafredri/fix-goroutine-leak
Conversationhttps://github.com/coder/coder/pull/1978
Commits6 (6)https://github.com/coder/coder/pull/1978/commits
Checkshttps://github.com/coder/coder/pull/1978/checks
Files changedhttps://github.com/coder/coder/pull/1978/files
fix: Avoid use of r.Context() after r.Hijack()https://github.com/coder/coder/pull/1978#top
mafredrihttps://github.com/mafredri
mainhttps://github.com/coder/coder/tree/main
mafredri/fix-goroutine-leakhttps://github.com/coder/coder/tree/mafredri/fix-goroutine-leak
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Jun 2, 2022https://github.com/coder/coder/pull/1978#issue-1258136592
#1508https://github.com/coder/coder/issues/1508
#1508https://github.com/coder/coder/issues/1508
Please reload this pagehttps://github.com/coder/coder/pull/1978
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Jun 2, 2022https://github.com/coder/coder/pull/1978#event-6728099412
https://github.com/mafredri
mafredrihttps://github.com/mafredri
June 2, 2022 12:47https://github.com/coder/coder/pull/1978#event-6728099482
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Jun 2, 2022 https://github.com/coder/coder/pull/1978#pullrequestreview-993486587
View reviewed changes https://github.com/coder/coder/pull/1978/files
coderd/workspaceagents.gohttps://github.com/coder/coder/pull/1978/files#diff-e71d8c645ba64bced5cde8872ac613aba0975ff69969d6cc5c5a9721195d682d
Please reload this pagehttps://github.com/coder/coder/pull/1978
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Jun 2, 2022 https://github.com/coder/coder/pull/1978#pullrequestreview-993488778
View reviewed changes https://github.com/coder/coder/pull/1978/files
coderd/workspaceagents.gohttps://github.com/coder/coder/pull/1978/files#diff-e71d8c645ba64bced5cde8872ac613aba0975ff69969d6cc5c5a9721195d682d
Please reload this pagehttps://github.com/coder/coder/pull/1978
https://github.com/deansheather
deansheatherhttps://github.com/deansheather
Jun 2, 2022 https://github.com/coder/coder/pull/1978#pullrequestreview-993517196
View reviewed changes https://github.com/coder/coder/pull/1978/files
coderd/workspaceagents.gohttps://github.com/coder/coder/pull/1978/files#diff-e71d8c645ba64bced5cde8872ac613aba0975ff69969d6cc5c5a9721195d682d
Please reload this pagehttps://github.com/coder/coder/pull/1978
coderd/workspaceagents.gohttps://github.com/coder/coder/pull/1978/files#diff-e71d8c645ba64bced5cde8872ac613aba0975ff69969d6cc5c5a9721195d682d
Please reload this pagehttps://github.com/coder/coder/pull/1978
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Jun 2, 2022 https://github.com/coder/coder/pull/1978#ref-pullrequest-1258349454
feat: Add support for pprof in coder agent #1985 https://github.com/coder/coder/pull/1985
https://github.com/kylecarbs
kylecarbshttps://github.com/kylecarbs
Jun 2, 2022https://github.com/coder/coder/pull/1978#issuecomment-1145016193
@mafredrihttps://github.com/mafredri
Please reload this pagehttps://github.com/coder/coder/pull/1978
mafredrihttps://github.com/mafredri
June 3, 2022 12:28https://github.com/coder/coder/pull/1978#commits-pushed-877959b
https://github.com/mafredri
fix: Fix goroutine leak by propagating websocket closurehttps://github.com/coder/coder/pull/1978/commits/877959bc15be9745535835bf22594a1cdbda81cd
877959bhttps://github.com/coder/coder/pull/1978/commits/877959bc15be9745535835bf22594a1cdbda81cd
#1508https://github.com/coder/coder/issues/1508
https://github.com/mafredri
fix: Use of r.Context() in workspaceAgentDialhttps://github.com/coder/coder/pull/1978/commits/0a354b6c63b38b0b9b0ec7709c36687fe2aff1bd
0a354b6https://github.com/coder/coder/pull/1978/commits/0a354b6c63b38b0b9b0ec7709c36687fe2aff1bd
https://github.com/mafredri
fix: Use of rw and r.Context() in workspaceAgentListenhttps://github.com/coder/coder/pull/1978/commits/e0fb30ca0ee1ea5b9f076ac736a41636734c02d2
e0fb30chttps://github.com/coder/coder/pull/1978/commits/e0fb30ca0ee1ea5b9f076ac736a41636734c02d2
https://github.com/mafredri
fix: Use of r.Context() in workspaceAgentPTYhttps://github.com/coder/coder/pull/1978/commits/e90a0c0c714792622a11985dbb5b287d705d1750
e90a0c0https://github.com/coder/coder/pull/1978/commits/e90a0c0c714792622a11985dbb5b287d705d1750
https://github.com/mafredri
chore: Fix PR commentshttps://github.com/coder/coder/pull/1978/commits/e0a2f8edf273cd26034d2e9fc838e9b02cfbf453
e0a2f8ehttps://github.com/coder/coder/pull/1978/commits/e0a2f8edf273cd26034d2e9fc838e9b02cfbf453
https://github.com/mafredri
fix: wsNetConn cancel on any errorhttps://github.com/coder/coder/pull/1978/commits/9e6727e665c3684cf8fb65ab373083c50a1ea51f
9e6727ehttps://github.com/coder/coder/pull/1978/commits/9e6727e665c3684cf8fb65ab373083c50a1ea51f
https://github.com/mafredri
mafredrihttps://github.com/mafredri
force-pushedhttps://github.com/coder/coder/compare/3f8c815b273ed35b52ddd33bec2bf225abdd674a..9e6727e665c3684cf8fb65ab373083c50a1ea51f
3f8c815https://github.com/coder/coder/commit/3f8c815b273ed35b52ddd33bec2bf225abdd674a
9e6727ehttps://github.com/coder/coder/commit/9e6727e665c3684cf8fb65ab373083c50a1ea51f
Compare https://github.com/coder/coder/compare/3f8c815b273ed35b52ddd33bec2bf225abdd674a..9e6727e665c3684cf8fb65ab373083c50a1ea51f
June 3, 2022 09:36https://github.com/coder/coder/pull/1978#event-6735040951
https://github.com/johnstcn
johnstcnhttps://github.com/johnstcn
Jun 3, 2022 https://github.com/coder/coder/pull/1978#pullrequestreview-994694225
View reviewed changes https://github.com/coder/coder/pull/1978/files/9e6727e665c3684cf8fb65ab373083c50a1ea51f
https://github.com/mafredri
mafredrihttps://github.com/mafredri
b4f5920https://github.com/coder/coder/commit/b4f5920df5d2bcea441d6f7572dd40df447dbadc
Jun 3, 2022https://github.com/coder/coder/pull/1978#event-6735118575
https://github.com/mafredri
mafredrihttps://github.com/mafredri
June 3, 2022 09:50https://github.com/coder/coder/pull/1978#event-6735118707
https://github.co/hiddenchars
https://github.com/coder/coder/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F1978
https://github.com/deansheather
deansheather https://github.com/deansheather
https://github.com/coder/coder/pull/1978/files/f61c2ade77e715bbb34e0dafb0692f1ae72a6166
https://github.com/johnstcn
johnstcn https://github.com/johnstcn
https://github.com/coder/coder/pull/1978/files/9e6727e665c3684cf8fb65ab373083c50a1ea51f
Please reload this pagehttps://github.com/coder/coder/pull/1978
https://github.com/mafredri
mafredri https://github.com/mafredri
Bug: Goroutine leak in coderd.(*api).workspaceAgentTurn https://github.com/coder/coder/issues/1508
Please reload this pagehttps://github.com/coder/coder/pull/1978
https://github.com/mafredri
https://github.com/kylecarbs
https://github.com/johnstcn
https://github.com/deansheather
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.