René's URL Explorer Experiment


Title: fix: derive running ws stop time from deadline by greyscaled · Pull Request #1920 · coder/coder · GitHub

Open Graph Title: fix: derive running ws stop time from deadline by greyscaled · Pull Request #1920 · coder/coder

X Title: fix: derive running ws stop time from deadline by greyscaled · Pull Request #1920 · coder/coder

Description: Summary: When a workspace is on, the remaining time until shutdown needs to be derived from the deadline timestamp, not implied from the TTL. A utility is function is added that answers the question if a workspace is on. Impact: This is a shared piece of logic in workspace scheduling presentations. In particular it unblocks work in 1779, or at least allows an implementation that shares details with the WorkspaceScheduleBanner. Notes: We could possibly instead return whether the workspace is "ON", "UNKNOWN", or "OFF". Maybe a future improvement for that could be made as the neds arrises.

Open Graph Description: Summary: When a workspace is on, the remaining time until shutdown needs to be derived from the deadline timestamp, not implied from the TTL. A utility is function is added that answers the questio...

X Description: Summary: When a workspace is on, the remaining time until shutdown needs to be derived from the deadline timestamp, not implied from the TTL. A utility is function is added that answers the questio...

Opengraph URL: https://github.com/coder/coder/pull/1920

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b7c23d61-aae0-3304-c7e6-1565e0f6437a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8690:399E4B:216EE9E:2C50773:6B017CD9
html-safe-nonce4bba4698602ffa01909dcbecd2d97644d22bb51bf1fb7ae993a66b16172e6b0b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NjkwOjM5OUU0QjoyMTZFRTlFOjJDNTA3NzM6NkIwMTdDRDkiLCJ2aXNpdG9yX2lkIjoiODQ0MzU1Mzc2MzIyNjEyMzQ4MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3c0742c9df76ee227ca54e909093361dc76e790e8fc85daf0b0cc6561f90a5e6
hovercard-subject-tagpull_request:952102564
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/coder/coder/pull/1920/files
twitter:imagehttps://avatars.githubusercontent.com/u/11184711?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/11184711?s=400&v=4
og:image:altSummary: When a workspace is on, the remaining time until shutdown needs to be derived from the deadline timestamp, not implied from the TTL. A utility is function is added that answers the questio...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/coder/coder/pull/1920/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F1920%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F1920%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/pull/1920/files
Reloadhttps://github.com/coder/coder/pull/1920/files
Reloadhttps://github.com/coder/coder/pull/1920/files
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fcoder%2Fcoder%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fcoder%2Fcoder%2Fissues%2Fnew%2Fchoose
greyscaledhttps://github.com/greyscaled
mainhttps://github.com/coder/coder/tree/main
vapurrmaid/gh-1779/workspace-shutdown-displayhttps://github.com/coder/coder/tree/vapurrmaid/gh-1779/workspace-shutdown-display
Conversation 4 https://github.com/coder/coder/pull/1920
Commits 11 https://github.com/coder/coder/pull/1920/commits
Checks 0 https://github.com/coder/coder/pull/1920/checks
Files changed https://github.com/coder/coder/pull/1920/files
Please reload this pagehttps://github.com/coder/coder/pull/1920/files
fix: derive running ws stop time from deadline https://github.com/coder/coder/pull/1920/files#top
Show all changes 11 commits https://github.com/coder/coder/pull/1920/files
a72b187 refactor: isWorkspaceOn utility greyscaled May 31, 2022 https://github.com/coder/coder/pull/1920/commits/a72b18798021524e8f91894789735d9c2fea8c54
24ccaee fix: derive running ws stop time from deadline greyscaled May 31, 2022 https://github.com/coder/coder/pull/1920/commits/24ccaeefea14604edc1fa1cf0fa98448208930c7
0f72a6d fixup! fix: derive running ws stop time from deadline greyscaled May 31, 2022 https://github.com/coder/coder/pull/1920/commits/0f72a6d05df663cb399dfdaf393efcca0fc4e502
c5c5f4f fixup! fix: derive running ws stop time from deadline greyscaled May 31, 2022 https://github.com/coder/coder/pull/1920/commits/c5c5f4fb26ac46cd7d73120a58cc634fbff323c1
11fe7f2 fixup! fix: derive running ws stop time from deadline greyscaled May 31, 2022 https://github.com/coder/coder/pull/1920/commits/11fe7f2d42eef431ce6c0e7b7528a8df57b00be8
538bbe8 Merge origin/main greyscaled May 31, 2022 https://github.com/coder/coder/pull/1920/commits/538bbe8ec32e2f84e813c0c0ed0e6aa2a5df8b67
5e6472d fixup! Merge origin/main greyscaled May 31, 2022 https://github.com/coder/coder/pull/1920/commits/5e6472d6da45b7ecc27d5ff1a620f458f61c6c7e
d0a9656 fixup! Merge origin/main greyscaled May 31, 2022 https://github.com/coder/coder/pull/1920/commits/d0a965636ff9011abf46eb5fb32bae13e65a7429
df54df0 Update stories greyscaled May 31, 2022 https://github.com/coder/coder/pull/1920/commits/df54df093b803654bc7c104ca8621dd85b38070b
f825f2d Merge origin/main greyscaled May 31, 2022 https://github.com/coder/coder/pull/1920/commits/f825f2ddaa27c9b589e984bbf856cd142218310f
6a48ea6 fixup! Merge origin/main greyscaled May 31, 2022 https://github.com/coder/coder/pull/1920/commits/6a48ea6e62a11b1f824aaa61eb8bc43a50d542d2
Clear filters https://github.com/coder/coder/pull/1920/files
Please reload this pagehttps://github.com/coder/coder/pull/1920/files
Please reload this pagehttps://github.com/coder/coder/pull/1920/files
Workspace.stories.tsx https://github.com/coder/coder/pull/1920/files#diff-3b101322b97d1e957656b42f004bd32942b25db1f40091aafb312b1872bfc685
WorkspaceSchedule.stories.tsx https://github.com/coder/coder/pull/1920/files#diff-6ff1751ede61038ba06481c12e1e62acb2ff33aba25af016f694cc625d7fa52a
WorkspaceSchedule.tsx https://github.com/coder/coder/pull/1920/files#diff-bf11aef458f6e1763b9c834ddd3434a971ccdedc9c3b131d64d442ed397a3336
WorkspaceScheduleBanner.test.tsx https://github.com/coder/coder/pull/1920/files#diff-bb0ab0868f7749af9b990d5366d0a57e35ff333ec0daf1baaeb15dacf93d7b83
WorkspaceScheduleBanner.tsx https://github.com/coder/coder/pull/1920/files#diff-d098628858b963fdd2349449d3d7680ae74667f3be4e918efde091cd9f207d6f
entities.ts https://github.com/coder/coder/pull/1920/files#diff-d9a272ec414617ffec44928252e3168e6a93df7cb4dff5a8a94f335f3abc3f53
workspace.test.ts https://github.com/coder/coder/pull/1920/files#diff-622a4202429d20529dba547c02e7570226ff5292e8bd8baaf78ce5766f76db2f
workspace.ts https://github.com/coder/coder/pull/1920/files#diff-46ce05d14402854a3999da903dcf3949351172316989f053196857f93fcc6d57
site/src/components/Workspace/Workspace.stories.tsxhttps://github.com/coder/coder/pull/1920/files#diff-3b101322b97d1e957656b42f004bd32942b25db1f40091aafb312b1872bfc685
View file https://github.com/coder/coder/blob/6a48ea6e62a11b1f824aaa61eb8bc43a50d542d2/site/src/components/Workspace/Workspace.stories.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/1920/{{ revealButtonHref }}
https://github.com/coder/coder/pull/1920/files#diff-3b101322b97d1e957656b42f004bd32942b25db1f40091aafb312b1872bfc685
site/src/components/WorkspaceSchedule/WorkspaceSchedule.stories.tsxhttps://github.com/coder/coder/pull/1920/files#diff-6ff1751ede61038ba06481c12e1e62acb2ff33aba25af016f694cc625d7fa52a
View file https://github.com/coder/coder/blob/6a48ea6e62a11b1f824aaa61eb8bc43a50d542d2/site/src/components/WorkspaceSchedule/WorkspaceSchedule.stories.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/1920/{{ revealButtonHref }}
https://github.com/coder/coder/pull/1920/files#diff-6ff1751ede61038ba06481c12e1e62acb2ff33aba25af016f694cc625d7fa52a
https://github.com/coder/coder/pull/1920/files#diff-6ff1751ede61038ba06481c12e1e62acb2ff33aba25af016f694cc625d7fa52a
https://github.com/coder/coder/pull/1920/files#diff-6ff1751ede61038ba06481c12e1e62acb2ff33aba25af016f694cc625d7fa52a
https://github.com/coder/coder/pull/1920/files#diff-6ff1751ede61038ba06481c12e1e62acb2ff33aba25af016f694cc625d7fa52a
https://github.com/coder/coder/pull/1920/files#diff-6ff1751ede61038ba06481c12e1e62acb2ff33aba25af016f694cc625d7fa52a
https://github.com/coder/coder/pull/1920/files#diff-6ff1751ede61038ba06481c12e1e62acb2ff33aba25af016f694cc625d7fa52a
site/src/components/WorkspaceSchedule/WorkspaceSchedule.tsxhttps://github.com/coder/coder/pull/1920/files#diff-bf11aef458f6e1763b9c834ddd3434a971ccdedc9c3b131d64d442ed397a3336
View file https://github.com/coder/coder/blob/6a48ea6e62a11b1f824aaa61eb8bc43a50d542d2/site/src/components/WorkspaceSchedule/WorkspaceSchedule.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/1920/{{ revealButtonHref }}
https://github.com/coder/coder/pull/1920/files#diff-bf11aef458f6e1763b9c834ddd3434a971ccdedc9c3b131d64d442ed397a3336
https://github.com/coder/coder/pull/1920/files#diff-bf11aef458f6e1763b9c834ddd3434a971ccdedc9c3b131d64d442ed397a3336
https://github.com/coder/coder/pull/1920/files#diff-bf11aef458f6e1763b9c834ddd3434a971ccdedc9c3b131d64d442ed397a3336
site/src/components/WorkspaceScheduleBanner/WorkspaceScheduleBanner.test.tsxhttps://github.com/coder/coder/pull/1920/files#diff-bb0ab0868f7749af9b990d5366d0a57e35ff333ec0daf1baaeb15dacf93d7b83
View file https://github.com/coder/coder/blob/6a48ea6e62a11b1f824aaa61eb8bc43a50d542d2/site/src/components/WorkspaceScheduleBanner/WorkspaceScheduleBanner.test.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/1920/{{ revealButtonHref }}
https://github.com/coder/coder/pull/1920/files#diff-bb0ab0868f7749af9b990d5366d0a57e35ff333ec0daf1baaeb15dacf93d7b83
https://github.com/coder/coder/pull/1920/files#diff-bb0ab0868f7749af9b990d5366d0a57e35ff333ec0daf1baaeb15dacf93d7b83
site/src/components/WorkspaceScheduleBanner/WorkspaceScheduleBanner.tsxhttps://github.com/coder/coder/pull/1920/files#diff-d098628858b963fdd2349449d3d7680ae74667f3be4e918efde091cd9f207d6f
View file https://github.com/coder/coder/blob/6a48ea6e62a11b1f824aaa61eb8bc43a50d542d2/site/src/components/WorkspaceScheduleBanner/WorkspaceScheduleBanner.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/1920/{{ revealButtonHref }}
https://github.com/coder/coder/pull/1920/files#diff-d098628858b963fdd2349449d3d7680ae74667f3be4e918efde091cd9f207d6f
https://github.com/coder/coder/pull/1920/files#diff-d098628858b963fdd2349449d3d7680ae74667f3be4e918efde091cd9f207d6f
https://github.com/coder/coder/pull/1920/files#diff-d098628858b963fdd2349449d3d7680ae74667f3be4e918efde091cd9f207d6f
site/src/testHelpers/entities.tshttps://github.com/coder/coder/pull/1920/files#diff-d9a272ec414617ffec44928252e3168e6a93df7cb4dff5a8a94f335f3abc3f53
View file https://github.com/coder/coder/blob/6a48ea6e62a11b1f824aaa61eb8bc43a50d542d2/site/src/testHelpers/entities.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/1920/{{ revealButtonHref }}
https://github.com/coder/coder/pull/1920/files#diff-d9a272ec414617ffec44928252e3168e6a93df7cb4dff5a8a94f335f3abc3f53
https://github.com/coder/coder/pull/1920/files#diff-d9a272ec414617ffec44928252e3168e6a93df7cb4dff5a8a94f335f3abc3f53
https://github.com/coder/coder/pull/1920/files#diff-d9a272ec414617ffec44928252e3168e6a93df7cb4dff5a8a94f335f3abc3f53
site/src/util/workspace.test.tshttps://github.com/coder/coder/pull/1920/files#diff-622a4202429d20529dba547c02e7570226ff5292e8bd8baaf78ce5766f76db2f
View file https://github.com/coder/coder/blob/6a48ea6e62a11b1f824aaa61eb8bc43a50d542d2/site/src/util/workspace.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/1920/{{ revealButtonHref }}
johnstcnhttps://github.com/johnstcn
May 31, 2022https://github.com/coder/coder/pull/1920/files#r885766825
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/1920/files
site/src/util/workspace.tshttps://github.com/coder/coder/pull/1920/files#diff-46ce05d14402854a3999da903dcf3949351172316989f053196857f93fcc6d57
View file https://github.com/coder/coder/blob/6a48ea6e62a11b1f824aaa61eb8bc43a50d542d2/site/src/util/workspace.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/1920/{{ revealButtonHref }}
https://github.com/coder/coder/pull/1920/files#diff-46ce05d14402854a3999da903dcf3949351172316989f053196857f93fcc6d57
https://github.com/coder/coder/pull/1920/files#diff-46ce05d14402854a3999da903dcf3949351172316989f053196857f93fcc6d57
johnstcnhttps://github.com/johnstcn
May 31, 2022https://github.com/coder/coder/pull/1920/files#r885783468
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/1920/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.