René's URL Explorer Experiment


Title: test: add test that we close stdin on SSH session close by spikecurtis · Pull Request #18711 · coder/coder · GitHub

Open Graph Title: test: add test that we close stdin on SSH session close by spikecurtis · Pull Request #18711 · coder/coder

X Title: test: add test that we close stdin on SSH session close by spikecurtis · Pull Request #18711 · coder/coder

Description: Secure environments for developers and their agents - test: add test that we close stdin on SSH session close by spikecurtis · Pull Request #18711 · coder/coder

Open Graph Description: closes #18519 Adds a unit test that verifies that we close the stdin to a non-TTY process when the SSH session connected to it exits. c.f. #18519 (comment) Validates that we match OpenSSH behavior.

X Description: closes #18519 Adds a unit test that verifies that we close the stdin to a non-TTY process when the SSH session connected to it exits. c.f. #18519 (comment) Validates that we match OpenSSH behavior.

Opengraph URL: https://github.com/coder/coder/pull/18711

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b5f5d14a-1b4f-b275-56eb-b777c1380127
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8B8C:27D3AD:2CEF2CB:390CFB3:6B01B416
html-safe-nonce5d79caabbd718f36105ace298a8620eb74a2b077a18f33ca2afa529c9ac0fd77
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QjhDOjI3RDNBRDoyQ0VGMkNCOjM5MENGQjM6NkIwMUI0MTYiLCJ2aXNpdG9yX2lkIjoiODE2NTYyMTk3MTMyNTkyNDM3NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca00d9718fe5cba9d30900d8036eb9508cf3ec371268ee8672b60cdc128bc1b8a
hovercard-subject-tagpull_request:2635223494
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/18711/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d540cebb57f04063b7aae551a617fb1e1cb063fae987de2fe07273deab30bb1f/coder/coder/pull/18711
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d540cebb57f04063b7aae551a617fb1e1cb063fae987de2fe07273deab30bb1f/coder/coder/pull/18711
og:image:altcloses #18519 Adds a unit test that verifies that we close the stdin to a non-TTY process when the SSH session connected to it exits. c.f. #18519 (comment) Validates that we match OpenSSH behavior.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamespikecurtis
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/coder/coder/pull/18711#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F18711
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F18711
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/pull/18711
Reloadhttps://github.com/coder/coder/pull/18711
Reloadhttps://github.com/coder/coder/pull/18711
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
https://github.com/coder/coder
spikecurtishttps://github.com/spikecurtis
mainhttps://github.com/coder/coder/tree/main
spike/18519-test-close-stdinhttps://github.com/coder/coder/tree/spike/18519-test-close-stdin
Conversationhttps://github.com/coder/coder/pull/18711
Commits1 (1)https://github.com/coder/coder/pull/18711/commits
Checkshttps://github.com/coder/coder/pull/18711/checks
Files changedhttps://github.com/coder/coder/pull/18711/files
test: add test that we close stdin on SSH session closehttps://github.com/coder/coder/pull/18711#top
spikecurtishttps://github.com/spikecurtis
mainhttps://github.com/coder/coder/tree/main
spike/18519-test-close-stdinhttps://github.com/coder/coder/tree/spike/18519-test-close-stdin
https://github.com/spikecurtis
spikecurtishttps://github.com/spikecurtis
Jul 2, 2025https://github.com/coder/coder/pull/18711#issue-3195650866
Please reload this pagehttps://github.com/coder/coder/pull/18711
#18519https://github.com/coder/coder/issues/18519
#18519 (comment)https://github.com/coder/coder/issues/18519#issuecomment-3027609871
Please reload this pagehttps://github.com/coder/coder/pull/18711
https://github.com/spikecurtis
https://github.com/apps/graphite-app
spikecurtishttps://github.com/spikecurtis
Jul 2, 2025https://github.com/coder/coder/pull/18711#issuecomment-3027596400
test: add test that we close stdin on SSH session close #18711https://github.com/coder/coder/pull/18711
https://app.graphite.dev/github/pr/coder/coder/18711?utm_source=stack-comment-icon
(View in Graphite)https://app.graphite.dev/github/pr/coder/coder/18711?utm_source=stack-comment-view-in-graphite
Graphitehttps://graphite.dev?utm-source=stack-comment
stackinghttps://stacking.dev/?utm_source=stack-comment
Please reload this pagehttps://github.com/coder/coder/pull/18711
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
spikecurtishttps://github.com/spikecurtis
Jul 2, 2025https://github.com/coder/coder/pull/18711#event-18430583296
https://github.com/spikecurtis
spikecurtishttps://github.com/spikecurtis
johnstcnhttps://github.com/johnstcn
mafredrihttps://github.com/mafredri
johnstcnhttps://github.com/johnstcn
July 2, 2025 12:02https://github.com/coder/coder/pull/18711#event-18430688481
https://github.com/spikecurtis
spikecurtishttps://github.com/spikecurtis
July 2, 2025 12:03https://github.com/coder/coder/pull/18711#event-18430699616
https://github.com/spikecurtis
spikecurtishttps://github.com/spikecurtis
force-pushedhttps://github.com/coder/coder/compare/8f0098ebb29c4f6a4988f16bb4b21c2328509e71..9c14eb85727cd4db116bdb967e4c6522978aecf5
8f0098ehttps://github.com/coder/coder/commit/8f0098ebb29c4f6a4988f16bb4b21c2328509e71
9c14eb8https://github.com/coder/coder/commit/9c14eb85727cd4db116bdb967e4c6522978aecf5
Compare https://github.com/coder/coder/compare/8f0098ebb29c4f6a4988f16bb4b21c2328509e71..9c14eb85727cd4db116bdb967e4c6522978aecf5
July 2, 2025 12:04https://github.com/coder/coder/pull/18711#event-18430720793
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Jul 2, 2025 https://github.com/coder/coder/pull/18711#pullrequestreview-2978883507
View reviewed changes https://github.com/coder/coder/pull/18711/files
https://github.com/johnstcn
johnstcnhttps://github.com/johnstcn
Jul 2, 2025 https://github.com/coder/coder/pull/18711#pullrequestreview-2978887431
View reviewed changes https://github.com/coder/coder/pull/18711/files
agent/agentssh/agentssh_test.gohttps://github.com/coder/coder/pull/18711/files#diff-5dc1411a84ebf7fcbc20350f2d9b44dd0391978f285eacc929ff1e377ff589ec
Please reload this pagehttps://github.com/coder/coder/pull/18711
https://github.com/spikecurtis
test: add test that we close stdin on SSH session closehttps://github.com/coder/coder/pull/18711/commits/2184b164e1be0aee4d315b7278c7609821e32eea
2184b16https://github.com/coder/coder/pull/18711/commits/2184b164e1be0aee4d315b7278c7609821e32eea
https://github.com/spikecurtis
spikecurtishttps://github.com/spikecurtis
force-pushedhttps://github.com/coder/coder/compare/9c14eb85727cd4db116bdb967e4c6522978aecf5..2184b164e1be0aee4d315b7278c7609821e32eea
9c14eb8https://github.com/coder/coder/commit/9c14eb85727cd4db116bdb967e4c6522978aecf5
2184b16https://github.com/coder/coder/commit/2184b164e1be0aee4d315b7278c7609821e32eea
Compare https://github.com/coder/coder/compare/9c14eb85727cd4db116bdb967e4c6522978aecf5..2184b164e1be0aee4d315b7278c7609821e32eea
July 2, 2025 12:09https://github.com/coder/coder/pull/18711#event-18430804129
https://github.com/spikecurtis
spikecurtishttps://github.com/spikecurtis
59c8b56https://github.com/coder/coder/commit/59c8b560fa0c6cc4a94f95d587e6816924b8203f
Jul 2, 2025https://github.com/coder/coder/pull/18711#event-18431032856
https://github.com/spikecurtis
https://github.com/apps/graphite-app
spikecurtishttps://github.com/spikecurtis
Jul 2, 2025https://github.com/coder/coder/pull/18711#issuecomment-3027675505
@spikecurtishttps://github.com/spikecurtis
Graphitehttps://app.graphite.dev/github/pr/coder/coder/18711
Please reload this pagehttps://github.com/coder/coder/pull/18711
https://github.com/spikecurtis
spikecurtishttps://github.com/spikecurtis
July 2, 2025 12:23https://github.com/coder/coder/pull/18711#event-18431033361
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jul 2, 2025https://github.com/coder/coder/pull/18711#event-18431035793
https://github.co/hiddenchars
https://github.com/coder/coder/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F18711
https://github.com/mafredri
mafredri https://github.com/mafredri
https://github.com/coder/coder/pull/18711/files/8f0098ebb29c4f6a4988f16bb4b21c2328509e71
https://github.com/johnstcn
johnstcn https://github.com/johnstcn
https://github.com/coder/coder/pull/18711/files/9c14eb85727cd4db116bdb967e4c6522978aecf5
Please reload this pagehttps://github.com/coder/coder/pull/18711
https://github.com/spikecurtis
spikecurtis https://github.com/spikecurtis
VS Code Desktop connection drops shortly after reconnecting https://github.com/coder/coder/issues/18519
Please reload this pagehttps://github.com/coder/coder/pull/18711
https://github.com/spikecurtis
https://github.com/mafredri
https://github.com/johnstcn
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.