René's URL Explorer Experiment


Title: fix: handle paths with spaces in Match exec clause of SSH config by spikecurtis · Pull Request #18266 · coder/coder · GitHub

Open Graph Title: fix: handle paths with spaces in Match exec clause of SSH config by spikecurtis · Pull Request #18266 · coder/coder

X Title: fix: handle paths with spaces in Match exec clause of SSH config by spikecurtis · Pull Request #18266 · coder/coder

Description: Secure environments for developers and their agents - fix: handle paths with spaces in Match exec clause of SSH config by spikecurtis · Pull Request #18266 · coder/coder

Open Graph Description: fixes #18199 Corrects handling of paths with spaces in the Match !exec clause we use to determine whether Coder Connect is running. This is handled differently than the ProxyCommand, so we have a d...

X Description: fixes #18199 Corrects handling of paths with spaces in the Match !exec clause we use to determine whether Coder Connect is running. This is handled differently than the ProxyCommand, so we have a d...

Opengraph URL: https://github.com/coder/coder/pull/18266

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:994dd14b-df54-9a7e-cf0e-c08cb49f57e6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB620:36A3E:2829C58:359939D:6B01B80A
html-safe-nonceee56681abe6daaf26729c6d2d3c703a2c8210f512eae6ab8385c9ffedc7ab698
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNjIwOjM2QTNFOjI4MjlDNTg6MzU5OTM5RDo2QjAxQjgwQSIsInZpc2l0b3JfaWQiOiI0MjQzNjYzMzc2NTczNjQyNzYzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3ad057ee951483ce4f82cef0b2c6da6fc9817b0a052869b6ae2e9772755bdc99
hovercard-subject-tagpull_request:2573124639
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/18266/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a4c94d333b9a47ab5b73c98c35234634c1ac721e5d03caad84ea44dfdf5da295/coder/coder/pull/18266
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a4c94d333b9a47ab5b73c98c35234634c1ac721e5d03caad84ea44dfdf5da295/coder/coder/pull/18266
og:image:altfixes #18199 Corrects handling of paths with spaces in the Match !exec clause we use to determine whether Coder Connect is running. This is handled differently than the ProxyCommand, so we have a d...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamespikecurtis
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/coder/coder/pull/18266#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F18266
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F18266
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/pull/18266
Reloadhttps://github.com/coder/coder/pull/18266
Reloadhttps://github.com/coder/coder/pull/18266
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
https://github.com/coder/coder
spikecurtishttps://github.com/spikecurtis
mainhttps://github.com/coder/coder/tree/main
spike/18199-path-with-spaceshttps://github.com/coder/coder/tree/spike/18199-path-with-spaces
Conversationhttps://github.com/coder/coder/pull/18266
Commits5 (5)https://github.com/coder/coder/pull/18266/commits
Checkshttps://github.com/coder/coder/pull/18266/checks
Files changedhttps://github.com/coder/coder/pull/18266/files
fix: handle paths with spaces in Match exec clause of SSH confighttps://github.com/coder/coder/pull/18266#top
spikecurtishttps://github.com/spikecurtis
mainhttps://github.com/coder/coder/tree/main
spike/18199-path-with-spaceshttps://github.com/coder/coder/tree/spike/18199-path-with-spaces
https://github.com/spikecurtis
spikecurtishttps://github.com/spikecurtis
Jun 6, 2025https://github.com/coder/coder/pull/18266#issue-3124375731
#18199https://github.com/coder/coder/issues/18199
Please reload this pagehttps://github.com/coder/coder/pull/18266
https://github.com/spikecurtis
spikecurtishttps://github.com/spikecurtis
Emyrkhttps://github.com/Emyrk
mafredrihttps://github.com/mafredri
June 6, 2025 10:34https://github.com/coder/coder/pull/18266#event-18020598226
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
spikecurtishttps://github.com/spikecurtis
Jun 6, 2025https://github.com/coder/coder/pull/18266#event-18020604086
spikecurtishttps://github.com/spikecurtis
June 6, 2025 14:34https://github.com/coder/coder/pull/18266#commits-pushed-0862dd0
https://github.com/spikecurtis
fix: fix handling coder path with spaces in config-sshhttps://github.com/coder/coder/pull/18266/commits/0862dd077ea8abd59fa107aba9f98832d5a312ac
0862dd0https://github.com/coder/coder/pull/18266/commits/0862dd077ea8abd59fa107aba9f98832d5a312ac
https://github.com/spikecurtis
add support for macOS & Linuxhttps://github.com/coder/coder/pull/18266/commits/c363edd337fe3f72911bcbcd2293b9223baae800
c363eddhttps://github.com/coder/coder/pull/18266/commits/c363edd337fe3f72911bcbcd2293b9223baae800
https://github.com/spikecurtis
add test, support backslasheshttps://github.com/coder/coder/pull/18266/commits/970b11522cf4dd49427fdb8cec9be9071d1e844c
970b115https://github.com/coder/coder/pull/18266/commits/970b11522cf4dd49427fdb8cec9be9071d1e844c
https://github.com/spikecurtis
fixup test on Windowshttps://github.com/coder/coder/pull/18266/commits/caee378e01d3780434dd6a06e162fc89f890ead5
caee378https://github.com/coder/coder/pull/18266/commits/caee378e01d3780434dd6a06e162fc89f890ead5
https://github.com/spikecurtis
spikecurtishttps://github.com/spikecurtis
force-pushedhttps://github.com/coder/coder/compare/6f0ac31e029a7e0634a6ac1fac175cb31c10400d..caee378e01d3780434dd6a06e162fc89f890ead5
6f0ac31https://github.com/coder/coder/commit/6f0ac31e029a7e0634a6ac1fac175cb31c10400d
caee378https://github.com/coder/coder/commit/caee378e01d3780434dd6a06e162fc89f890ead5
Compare https://github.com/coder/coder/compare/6f0ac31e029a7e0634a6ac1fac175cb31c10400d..caee378e01d3780434dd6a06e162fc89f890ead5
June 6, 2025 10:35https://github.com/coder/coder/pull/18266#event-18020612816
https://github.com/spikecurtis
no quotes on non-Windows eitherhttps://github.com/coder/coder/pull/18266/commits/09692025375e0b3d18ef7579ead5117f33afe145
0969202https://github.com/coder/coder/pull/18266/commits/09692025375e0b3d18ef7579ead5117f33afe145
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Jun 6, 2025 https://github.com/coder/coder/pull/18266#pullrequestreview-2904647063
View reviewed changes https://github.com/coder/coder/pull/18266/files/09692025375e0b3d18ef7579ead5117f33afe145
mafredrihttps://github.com/mafredri
https://github.com/coder/coder/pull/18266#pullrequestreview-2904647063
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/18266
cli/configssh_windows.gohttps://github.com/coder/coder/pull/18266/files/09692025375e0b3d18ef7579ead5117f33afe145#diff-3c2bcd963f44227ce220d30d1e849375341fbef088fc9199333b7312a55cf4cc
mafredrihttps://github.com/mafredri
Jun 6, 2025https://github.com/coder/coder/pull/18266#discussion_r2132026619
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/18266
spikecurtishttps://github.com/spikecurtis
Jun 6, 2025https://github.com/coder/coder/pull/18266#discussion_r2132127643
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/PowerShell/openssh-portable/blob/bdacf9868fe9e8024a5312861b7aaa6faba1821f/readconf.c#L544https://github.com/PowerShell/openssh-portable/blob/bdacf9868fe9e8024a5312861b7aaa6faba1821f/readconf.c#L544
https://learn.microsoft.com/en-us/cpp/c-language/system-function?view=msvc-170https://learn.microsoft.com/en-us/cpp/c-language/system-function?view=msvc-170
Please reload this pagehttps://github.com/coder/coder/pull/18266
cli/configssh_windows.gohttps://github.com/coder/coder/pull/18266/files/09692025375e0b3d18ef7579ead5117f33afe145#diff-3c2bcd963f44227ce220d30d1e849375341fbef088fc9199333b7312a55cf4cc
mafredrihttps://github.com/mafredri
Jun 6, 2025https://github.com/coder/coder/pull/18266#discussion_r2132027724
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/18266
https://github.com/spikecurtis
spikecurtishttps://github.com/spikecurtis
d47a53dhttps://github.com/coder/coder/commit/d47a53da825873f171f8227c172fe69787510700
Jun 6, 2025https://github.com/coder/coder/pull/18266#event-18022261253
https://github.com/spikecurtis
spikecurtishttps://github.com/spikecurtis
June 6, 2025 12:44https://github.com/coder/coder/pull/18266#event-18022261692
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jun 6, 2025https://github.com/coder/coder/pull/18266#event-18022264575
https://github.com/stirby
stirbyhttps://github.com/stirby
Jul 7, 2025https://github.com/coder/coder/pull/18266#issuecomment-3046300184
Please reload this pagehttps://github.com/coder/coder/pull/18266
https://github.co/hiddenchars
https://github.com/coder/coder/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F18266
https://github.com/mafredri
mafredri https://github.com/mafredri
https://github.com/coder/coder/pull/18266/files/09692025375e0b3d18ef7579ead5117f33afe145
https://github.com/Emyrk
Emyrk https://github.com/Emyrk
Please reload this pagehttps://github.com/coder/coder/pull/18266
https://github.com/spikecurtis
spikecurtis https://github.com/spikecurtis
bug: config-ssh writes bad Match exec clause on Windows https://github.com/coder/coder/issues/18199
Please reload this pagehttps://github.com/coder/coder/pull/18266
https://github.com/spikecurtis
https://github.com/stirby
https://github.com/mafredri
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.