René's URL Explorer Experiment


Title: fix: Close peer negotiate mutex if we haven't negotiated by kylecarbs · Pull Request #1774 · coder/coder · GitHub

Open Graph Title: fix: Close peer negotiate mutex if we haven't negotiated by kylecarbs · Pull Request #1774 · coder/coder

X Title: fix: Close peer negotiate mutex if we haven't negotiated by kylecarbs · Pull Request #1774 · coder/coder

Description: Secure environments for developers and their agents - fix: Close peer negotiate mutex if we haven't negotiated by kylecarbs · Pull Request #1774 · coder/coder

Open Graph Description: Closes #1706 and #1644. The sleep was taken out a while back due to the belief that it might be fixed upstream, but that turned out to not be true 😢.

X Description: Closes #1706 and #1644. The sleep was taken out a while back due to the belief that it might be fixed upstream, but that turned out to not be true 😢.

Opengraph URL: https://github.com/coder/coder/pull/1774

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:42d13946-337c-cca3-268f-fcba4496c4c7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id920A:FC5BE:238B3B9:2F2E8A0:6B019291
html-safe-nonceb26bed8822fc6c0b45bb73b033110ea5cc7c30b3f3db736abdef79192f5a055f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MjBBOkZDNUJFOjIzOEIzQjk6MkYyRThBMDo2QjAxOTI5MSIsInZpc2l0b3JfaWQiOiIxNTY3OTc1MTI4NTY5MDU3OTM3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc89a81a5db45cbbfee275438cf220c003ed6fa4f341a7253885890e32b0df074
hovercard-subject-tagpull_request:947828430
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/1774/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/21fa073f657cd7fd3ed28f20f4226666591360cb827b8430246dd4b2ffefec71/coder/coder/pull/1774
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/21fa073f657cd7fd3ed28f20f4226666591360cb827b8430246dd4b2ffefec71/coder/coder/pull/1774
og:image:altCloses #1706 and #1644. The sleep was taken out a while back due to the belief that it might be fixed upstream, but that turned out to not be true 😢.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamekylecarbs
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/coder/coder/pull/1774#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F1774
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F1774
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/pull/1774
Reloadhttps://github.com/coder/coder/pull/1774
Reloadhttps://github.com/coder/coder/pull/1774
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
https://github.com/coder/coder
kylecarbshttps://github.com/kylecarbs
mainhttps://github.com/coder/coder/tree/main
negotiatemutexhttps://github.com/coder/coder/tree/negotiatemutex
Conversationhttps://github.com/coder/coder/pull/1774
Commits2 (2)https://github.com/coder/coder/pull/1774/commits
Checkshttps://github.com/coder/coder/pull/1774/checks
Files changedhttps://github.com/coder/coder/pull/1774/files
fix: Close peer negotiate mutex if we haven't negotiatedhttps://github.com/coder/coder/pull/1774#top
kylecarbshttps://github.com/kylecarbs
mainhttps://github.com/coder/coder/tree/main
negotiatemutexhttps://github.com/coder/coder/tree/negotiatemutex
https://github.com/kylecarbs
kylecarbshttps://github.com/kylecarbs
May 26, 2022https://github.com/coder/coder/pull/1774#issue-1249054402
Please reload this pagehttps://github.com/coder/coder/pull/1774
#1706https://github.com/coder/coder/issues/1706
#1644https://github.com/coder/coder/issues/1644
Please reload this pagehttps://github.com/coder/coder/pull/1774
https://github.com/kylecarbs
kylecarbshttps://github.com/kylecarbs
coadlerhttps://github.com/coadler
May 26, 2022 03:36https://github.com/coder/coder/pull/1774#event-6682659957
https://github.com/kylecarbs
kylecarbshttps://github.com/kylecarbs
May 26, 2022 03:37https://github.com/coder/coder/pull/1774#event-6682660254
https://github.com/kylecarbs
kylecarbshttps://github.com/kylecarbs
May 26, 2022https://github.com/coder/coder/pull/1774#event-6682661998
https://github.com/kylecarbs
kylecarbshttps://github.com/kylecarbs
johnstcnhttps://github.com/johnstcn
May 26, 2022 03:48https://github.com/coder/coder/pull/1774#event-6682696915
https://github.com/johnstcn
johnstcnhttps://github.com/johnstcn
May 26, 2022 https://github.com/coder/coder/pull/1774#pullrequestreview-985961916
View reviewed changes https://github.com/coder/coder/pull/1774/files
johnstcnhttps://github.com/johnstcn
https://github.com/coder/coder/pull/1774#pullrequestreview-985961916
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/1774
peer/conn.gohttps://github.com/coder/coder/pull/1774/files#diff-05d8aea94ee183741805b2e04fa2b86a382e96ad856506b65cf068c674da53a3
johnstcnhttps://github.com/johnstcn
May 26, 2022https://github.com/coder/coder/pull/1774#discussion_r882489434
Please reload this pagehttps://github.com/coder/coder/pull/1774
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/1774
kylecarbshttps://github.com/kylecarbs
May 26, 2022https://github.com/coder/coder/pull/1774#discussion_r882681919
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/1774
https://github.com/deansheather
deansheatherhttps://github.com/deansheather
May 26, 2022 09:49https://github.com/coder/coder/pull/1774#event-6684347769
https://github.com/deansheather
deansheatherhttps://github.com/deansheather
May 26, 2022 https://github.com/coder/coder/pull/1774#pullrequestreview-986015340
View reviewed changes https://github.com/coder/coder/pull/1774/files
peer/conn.gohttps://github.com/coder/coder/pull/1774/files#diff-05d8aea94ee183741805b2e04fa2b86a382e96ad856506b65cf068c674da53a3
deansheatherhttps://github.com/deansheather
May 26, 2022https://github.com/coder/coder/pull/1774#discussion_r882527250
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/1774
kylecarbshttps://github.com/kylecarbs
May 26, 2022https://github.com/coder/coder/pull/1774#discussion_r882672657
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/coder/coder/runs/6603612719?check_suite_focus=true#step:9:107https://github.com/coder/coder/runs/6603612719?check_suite_focus=true#step:9:107
Please reload this pagehttps://github.com/coder/coder/pull/1774
kylecarbshttps://github.com/kylecarbs
May 26, 2022https://github.com/coder/coder/pull/1774#discussion_r882673158
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/1774
https://github.com/kylecarbs
fix: Close peer negotiate mutex if we haven't negotiatedhttps://github.com/coder/coder/pull/1774/commits/a7a1ec5fb6879240771aa9b0557dae45317deef3
a7a1ec5https://github.com/coder/coder/pull/1774/commits/a7a1ec5fb6879240771aa9b0557dae45317deef3
#1706https://github.com/coder/coder/issues/1706
#1644https://github.com/coder/coder/issues/1644
https://github.com/kylecarbs
kylecarbshttps://github.com/kylecarbs
force-pushedhttps://github.com/coder/coder/compare/c7ae085aabc198e255a807d7d156444e8971c7f8..a7a1ec5fb6879240771aa9b0557dae45317deef3
c7ae085https://github.com/coder/coder/commit/c7ae085aabc198e255a807d7d156444e8971c7f8
a7a1ec5https://github.com/coder/coder/commit/a7a1ec5fb6879240771aa9b0557dae45317deef3
Compare https://github.com/coder/coder/compare/c7ae085aabc198e255a807d7d156444e8971c7f8..a7a1ec5fb6879240771aa9b0557dae45317deef3
May 27, 2022 16:41https://github.com/coder/coder/pull/1774#event-6693797521
https://github.com/deansheather
deansheatherhttps://github.com/deansheather
May 27, 2022 https://github.com/coder/coder/pull/1774#pullrequestreview-987763210
View reviewed changes https://github.com/coder/coder/pull/1774/files
peer/conn.gohttps://github.com/coder/coder/pull/1774/files#diff-05d8aea94ee183741805b2e04fa2b86a382e96ad856506b65cf068c674da53a3
deansheatherhttps://github.com/deansheather
May 27, 2022https://github.com/coder/coder/pull/1774#discussion_r883778292
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/1774
kylecarbshttps://github.com/kylecarbs
May 27, 2022https://github.com/coder/coder/pull/1774#discussion_r883806173
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/1774
https://github.com/kylecarbs
Merge branch 'main' into negotiatemutexhttps://github.com/coder/coder/pull/1774/commits/98a81ba6d5c14f087713cb3445dde3b6d1e8c79a
98a81bahttps://github.com/coder/coder/pull/1774/commits/98a81ba6d5c14f087713cb3445dde3b6d1e8c79a
https://github.com/kylecarbs
kylecarbshttps://github.com/kylecarbs
force-pushedhttps://github.com/coder/coder/compare/5385c2cb284485b4a0db8a02321acb6d3bb8c420..98a81ba6d5c14f087713cb3445dde3b6d1e8c79a
5385c2chttps://github.com/coder/coder/commit/5385c2cb284485b4a0db8a02321acb6d3bb8c420
98a81bahttps://github.com/coder/coder/commit/98a81ba6d5c14f087713cb3445dde3b6d1e8c79a
Compare https://github.com/coder/coder/compare/5385c2cb284485b4a0db8a02321acb6d3bb8c420..98a81ba6d5c14f087713cb3445dde3b6d1e8c79a
May 27, 2022 17:24https://github.com/coder/coder/pull/1774#event-6694088129
https://github.com/kylecarbs
kylecarbshttps://github.com/kylecarbs
May 27, 2022 17:24https://github.com/coder/coder/pull/1774#event-6694089840
https://github.com/johnstcn
johnstcnhttps://github.com/johnstcn
May 27, 2022 https://github.com/coder/coder/pull/1774#pullrequestreview-987815422
View reviewed changes https://github.com/coder/coder/pull/1774/files/98a81ba6d5c14f087713cb3445dde3b6d1e8c79a
https://github.com/kylecarbs
kylecarbshttps://github.com/kylecarbs
984dc2bhttps://github.com/coder/coder/commit/984dc2bffded66e6e2e62facb86a34e0d9a5dd80
May 27, 2022https://github.com/coder/coder/pull/1774#event-6694242087
https://github.com/kylecarbs
kylecarbshttps://github.com/kylecarbs
May 27, 2022 17:34https://github.com/coder/coder/pull/1774#event-6694242256
https://github.com/johnstcn
johnstcnhttps://github.com/johnstcn
May 30, 2022 https://github.com/coder/coder/pull/1774#ref-issue-1243650531
flake: peer TestConn/Buffering #1644 https://github.com/coder/coder/issues/1644
https://github.co/hiddenchars
https://github.com/coder/coder/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F1774
https://github.com/johnstcn
johnstcn https://github.com/johnstcn
https://github.com/coder/coder/pull/1774/files/98a81ba6d5c14f087713cb3445dde3b6d1e8c79a
https://github.com/deansheather
deansheather https://github.com/deansheather
https://github.com/coder/coder/pull/1774/files/5385c2cb284485b4a0db8a02321acb6d3bb8c420
https://github.com/coadler
coadler https://github.com/coadler
Please reload this pagehttps://github.com/coder/coder/pull/1774
https://github.com/kylecarbs
kylecarbs https://github.com/kylecarbs
Bug: Agent test fails with goleak error https://github.com/coder/coder/issues/1706
Please reload this pagehttps://github.com/coder/coder/pull/1774
https://github.com/kylecarbs
https://github.com/johnstcn
https://github.com/deansheather
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.