| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:ccebaca5-ad6a-e742-7e4f-354075346f69 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A2FE:14ECB:20410C3:28F47E7:6B016EC7 |
| html-safe-nonce | 878f1e5a920b7c85136f990397db214a896bb9aff590af63e9ee329f2411175a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMkZFOjE0RUNCOjIwNDEwQzM6MjhGNDdFNzo2QjAxNkVDNyIsInZpc2l0b3JfaWQiOiIxMTM1MTQwMjAwMDYyNzQyMjE1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | be1091c63b28f207e551e078dd67100a76f2f91a79aa171bd694ef44d1a02cf1 |
| hovercard-subject-tag | pull_request:2487003444 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/17596/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/2410589608852afd96fa86a082b3d8fa74634e5698902150cf271f6d6162ff96/coder/coder/pull/17596 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2410589608852afd96fa86a082b3d8fa74634e5698902150cf271f6d6162ff96/coder/coder/pull/17596 |
| og:image:alt | Continues #15669
This PR introduces a partial fix for #15096; it allows operators to specify the CORS behavior on a per-coder_app level.
This change requires cors_behavior to be set on a given code... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Emyrk |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/coder/coder git https://github.com/coder/coder.git |
| octolytics-dimension-user_id | 95932066 |
| octolytics-dimension-user_login | coder |
| octolytics-dimension-repository_id | 440752086 |
| octolytics-dimension-repository_nwo | coder/coder |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 440752086 |
| octolytics-dimension-repository_network_root_nwo | coder/coder |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/coder/coder/pull/17596#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F17596 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F17596 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder |
| Reload | https://github.com/coder/coder/pull/17596 |
| Reload | https://github.com/coder/coder/pull/17596 |
| Reload | https://github.com/coder/coder/pull/17596 |
| coder | https://github.com/coder |
| coder | https://github.com/coder/coder |
| Code | https://github.com/coder/coder |
| Issues320 (320) | https://github.com/coder/coder/issues |
| Pull requests470 (470) | https://github.com/coder/coder/pulls |
| Discussions | https://github.com/coder/coder/discussions |
| Actions | https://github.com/coder/coder/actions |
| Projects | https://github.com/coder/coder/projects |
| Security and quality49 (49) | https://github.com/coder/coder/security |
| Insights | https://github.com/coder/coder/insights |
| https://github.com/coder/coder |
| Emyrk | https://github.com/Emyrk |
| main | https://github.com/coder/coder/tree/main |
| stevenmasley/cors | https://github.com/coder/coder/tree/stevenmasley/cors |
| Conversation | https://github.com/coder/coder/pull/17596 |
| Commits19 (19) | https://github.com/coder/coder/pull/17596/commits |
| Checks | https://github.com/coder/coder/pull/17596/checks |
| Files changed | https://github.com/coder/coder/pull/17596/files |
| feat: bypass built-in CORS handling for workspace apps | https://github.com/coder/coder/pull/17596#top |
| Emyrk | https://github.com/Emyrk |
| main | https://github.com/coder/coder/tree/main |
| stevenmasley/cors | https://github.com/coder/coder/tree/stevenmasley/cors |
|
| https://github.com/Emyrk |
| Emyrk | https://github.com/Emyrk |
| Apr 28, 2025 | https://github.com/coder/coder/pull/17596#issue-3026237171 |
| Please reload this page | https://github.com/coder/coder/pull/17596 |
| #15669 | https://github.com/coder/coder/pull/15669 |
| #15096 | https://github.com/coder/coder/issues/15096 |
| coder/terraform-provider-coder#309 | https://github.com/coder/terraform-provider-coder/pull/309 |
| port shares | https://coder.com/docs/admin/networking/port-forwarding#sharing-ports |
| Please reload this page | https://github.com/coder/coder/pull/17596 |
| dannykopping | https://github.com/dannykopping |
| November 28, 2024 12:04 | https://github.com/coder/coder/pull/17596#commits-pushed-0dc7ca3 |
|
| https://github.com/dannykopping |
| Working implementation | https://github.com/coder/coder/pull/17596/commits/0dc7ca368f34d22dcfbf1f75501da6561e25c084 |
| 0dc7ca3 | https://github.com/coder/coder/pull/17596/commits/0dc7ca368f34d22dcfbf1f75501da6561e25c084 |
|
| https://github.com/dannykopping |
| Rename CorsBehavior to CORSBehavior | https://github.com/coder/coder/pull/17596/commits/3c0e33aa997d53c40e8138bb8504892d248beb63 |
| 3c0e33a | https://github.com/coder/coder/pull/17596/commits/3c0e33aa997d53c40e8138bb8504892d248beb63 |
|
| https://github.com/dannykopping |
| Hard & simplify CORORS handling logic | https://github.com/coder/coder/pull/17596/commits/a4d3c8d29fe3ebff6dc04edfeb04e8e39ed0a519 |
| a4d3c8d | https://github.com/coder/coder/pull/17596/commits/a4d3c8d29fe3ebff6dc04edfeb04e8e39ed0a519 |
|
| https://github.com/dannykopping |
| Minor fixes | https://github.com/coder/coder/pull/17596/commits/873c3e45f5162374474f6a13af6f0e854a995e83 |
| 873c3e4 | https://github.com/coder/coder/pull/17596/commits/873c3e45f5162374474f6a13af6f0e854a995e83 |
|
| https://github.com/dannykopping |
| Appeasing the linter | https://github.com/coder/coder/pull/17596/commits/65f984f87cc33c7900cf4e820968ab37b4998db0 |
| 65f984f | https://github.com/coder/coder/pull/17596/commits/65f984f87cc33c7900cf4e820968ab37b4998db0 |
|
| https://github.com/dannykopping |
| Move type def to codersdk | https://github.com/coder/coder/pull/17596/commits/1f0b34c178bd759ba36ea66bc69388f8731f4925 |
| 1f0b34c | https://github.com/coder/coder/pull/17596/commits/1f0b34c178bd759ba36ea66bc69388f8731f4925 |
|
| https://github.com/dannykopping |
| Appease the linter, again | https://github.com/coder/coder/pull/17596/commits/5be547762bb9f8ad9be9d9b593b5ca6ed60f3ec8 |
| 5be5477 | https://github.com/coder/coder/pull/17596/commits/5be547762bb9f8ad9be9d9b593b5ca6ed60f3ec8 |
|
| https://github.com/dannykopping |
| Fix migration num | https://github.com/coder/coder/pull/17596/commits/ddbbaa948b9e288896d7e4643cfd028371a2397c |
| ddbbaa9 | https://github.com/coder/coder/pull/17596/commits/ddbbaa948b9e288896d7e4643cfd028371a2397c |
|
| https://github.com/dannykopping |
| Removing unnecessary header check | https://github.com/coder/coder/pull/17596/commits/63c1852d30bbad016c3a13ddc3752dff4685e42b |
| 63c1852 | https://github.com/coder/coder/pull/17596/commits/63c1852d30bbad016c3a13ddc3752dff4685e42b |
|
| https://github.com/dannykopping |
| Improve tests | https://github.com/coder/coder/pull/17596/commits/976cd78d90a878bb88fd5a1d7c9cdd3a08409d0e |
| 976cd78 | https://github.com/coder/coder/pull/17596/commits/976cd78d90a878bb88fd5a1d7c9cdd3a08409d0e |
|
| https://github.com/dannykopping |
| Merge branch 'main' of | https://github.com/coder/coder/pull/17596/commits/9f9068fff7a6e585eef81524ceb4ad9aaa830d1c |
| https://github.com/coder/coder | https://github.com/coder/coder |
| into dk/cors | https://github.com/coder/coder/pull/17596/commits/9f9068fff7a6e585eef81524ceb4ad9aaa830d1c |
| 9f9068f | https://github.com/coder/coder/pull/17596/commits/9f9068fff7a6e585eef81524ceb4ad9aaa830d1c |
|
| https://github.com/dannykopping |
| Comprehensive CORS test suite for both request & response | https://github.com/coder/coder/pull/17596/commits/3dc00e1dc58d50f0c033b9c63d79e8fda9afcbb4 |
| 3dc00e1 | https://github.com/coder/coder/pull/17596/commits/3dc00e1dc58d50f0c033b9c63d79e8fda9afcbb4 |
|
| https://github.com/Emyrk |
| Merge remote-tracking branch 'origin/main' into stevenmasley/cors | https://github.com/coder/coder/pull/17596/commits/5e1c6eb83b17e4038a1096afad6c8767fe1aa987 |
| 5e1c6eb | https://github.com/coder/coder/pull/17596/commits/5e1c6eb83b17e4038a1096afad6c8767fe1aa987 |
|
| https://github.com/Emyrk |
| make gen | https://github.com/coder/coder/pull/17596/commits/326696773b927745cfb67a811dd5d00336b0163e |
| 3266967 | https://github.com/coder/coder/pull/17596/commits/326696773b927745cfb67a811dd5d00336b0163e |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Emyrk | https://github.com/Emyrk |
| Apr 28, 2025 | https://github.com/coder/coder/pull/17596#event-17442542299 |
|
| https://github.com/Emyrk |
| formatting | https://github.com/coder/coder/pull/17596/commits/906562369a4df6fc1616e986065182bf6cc218a9 |
| 9065623 | https://github.com/coder/coder/pull/17596/commits/906562369a4df6fc1616e986065182bf6cc218a9 |
| https://github.com/Emyrk |
| Emyrk | https://github.com/Emyrk |
| Apr 28, 2025 | https://github.com/coder/coder/pull/17596#event-17442615184 |
|
| https://github.com/Emyrk |
| move cors to after app handling | https://github.com/coder/coder/pull/17596/commits/991d285a1f1e5f5ef4096fff64f8e70957ad6762 |
| 991d285 | https://github.com/coder/coder/pull/17596/commits/991d285a1f1e5f5ef4096fff64f8e70957ad6762 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Apr 29, 2025 | https://github.com/coder/coder/pull/17596#issuecomment-2837088596 |
| Please reload this page | https://github.com/coder/coder/pull/17596 |
| Emyrk | https://github.com/Emyrk |
| April 28, 2025 19:47 | https://github.com/coder/coder/pull/17596#commits-pushed-5ba7b82 |
|
| https://github.com/Emyrk |
| gen | https://github.com/coder/coder/pull/17596/commits/5ba7b823e1c6a260ce0ff6e077f8506ec387b57b |
| 5ba7b82 | https://github.com/coder/coder/pull/17596/commits/5ba7b823e1c6a260ce0ff6e077f8506ec387b57b |
|
| https://github.com/Emyrk |
| chore: work on template to test cors | https://github.com/coder/coder/pull/17596/commits/bc8cce381b835dead4e5ce4327d958bacbde6f24 |
| bc8cce3 | https://github.com/coder/coder/pull/17596/commits/bc8cce381b835dead4e5ce4327d958bacbde6f24 |
|
| https://github.com/Emyrk |
| chore: add template to test cors behavior | https://github.com/coder/coder/pull/17596/commits/de30a2952f210a2c9411b23dd648362db14d0447 |
| de30a29 | https://github.com/coder/coder/pull/17596/commits/de30a2952f210a2c9411b23dd648362db14d0447 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
stale
| https://github.com/coder/coder/issues?q=state%3Aopen%20label%3Astale |
| May 7, 2025 | https://github.com/coder/coder/pull/17596#event-17546694875 |
| https://github.com/f0ssel |
| f0ssel | https://github.com/f0ssel |
| cstyan | https://github.com/cstyan |
| cstyan | https://github.com/cstyan |
| May 8, 2025 14:38 | https://github.com/coder/coder/pull/17596#event-17575284241 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
stale
| https://github.com/coder/coder/issues?q=state%3Aopen%20label%3Astale |
| May 9, 2025 | https://github.com/coder/coder/pull/17596#event-17582378519 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
stale
| https://github.com/coder/coder/issues?q=state%3Aopen%20label%3Astale |
| May 16, 2025 | https://github.com/coder/coder/pull/17596#event-17680705025 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| May 19, 2025 | https://github.com/coder/coder/pull/17596#event-17705050227 |
| https://github.com/Emyrk |
| Emyrk | https://github.com/Emyrk |
| May 19, 2025 | https://github.com/coder/coder/pull/17596#event-17715580086 |
| https://github.com/Emyrk |
| Emyrk | https://github.com/Emyrk |
| spikecurtis | https://github.com/spikecurtis |
| code owner | https://github.com/coder/coder/blob/4e0fc6e17c987abd55f697cd1b1220fe71d2c1ec/CODEOWNERS#L8 |
| May 19, 2025 13:48 | https://github.com/coder/coder/pull/17596#event-17715580238 |
| https://github.com/Emyrk |
| Emyrk | https://github.com/Emyrk |
| johnstcn | https://github.com/johnstcn |
| code owner | https://github.com/coder/coder/blob/4e0fc6e17c987abd55f697cd1b1220fe71d2c1ec/CODEOWNERS#L8 |
| May 19, 2025 13:48 | https://github.com/coder/coder/pull/17596#event-17715580266 |
| https://github.com/Emyrk |
| Emyrk | https://github.com/Emyrk |
| May 19, 2025 | https://github.com/coder/coder/pull/17596#event-17715583930 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| May 19, 2025 | https://github.com/coder/coder/pull/17596#event-17715588342 |
| https://github.com/Emyrk |
| Emyrk | https://github.com/Emyrk |
| May 19, 2025 | https://github.com/coder/coder/pull/17596#issuecomment-2891105921 |
| Please reload this page | https://github.com/coder/coder/pull/17596 |
| https://github.com/Emyrk |
| Emyrk | https://github.com/Emyrk |
| johnstcn | https://github.com/johnstcn |
| spikecurtis | https://github.com/spikecurtis |
| May 19, 2025 13:48 | https://github.com/coder/coder/pull/17596#event-17715591609 |
| https://github.com/Emyrk |
| Emyrk | https://github.com/Emyrk |
| July 22, 2025 13:12 | https://github.com/coder/coder/pull/17596#event-18752203488 |
| https://github.co/hiddenchars |
| https://github.com/coder/coder/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F17596 |
| Please reload this page | https://github.com/coder/coder/pull/17596 |
|
| https://github.com/Emyrk |
|
Emyrk
| https://github.com/Emyrk |
|
stale
| https://github.com/coder/coder/issues?q=state%3Aopen%20label%3Astale |
| Please reload this page | https://github.com/coder/coder/pull/17596 |
|
| https://github.com/Emyrk |
|
| https://github.com/dannykopping |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |