| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:ca65380a-0e2d-5715-90ac-4fbf57a31975 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9396:22DB35:27130B9:31DCDA3:6B01869A |
| html-safe-nonce | d08ef52072b262e2855dfe060a4e14e0c216aad6949901d4eb24eeaa341e3825 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Mzk2OjIyREIzNToyNzEzMEI5OjMxRENEQTM6NkIwMTg2OUEiLCJ2aXNpdG9yX2lkIjoiOTQ0NTQ0NzE1OTczMjgwMjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 5de4dce43564e4940dd836c4ba0fce794c23758df037b415e30178a38ad58afd |
| hovercard-subject-tag | pull_request:2451188539 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/17336/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/dc13ff622811322d6ce3fbbc73536dfab61a05b1612c3d0ea6d0ede5189cd157/coder/coder/pull/17336 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/dc13ff622811322d6ce3fbbc73536dfab61a05b1612c3d0ea6d0ede5189cd157/coder/coder/pull/17336 |
| og:image:alt | Use the hostname suffix to set the DNS match domain when creating a Tailnet as part of the vpn Tunnel.
part of: #16828 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | spikecurtis |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/coder/coder git https://github.com/coder/coder.git |
| octolytics-dimension-user_id | 95932066 |
| octolytics-dimension-user_login | coder |
| octolytics-dimension-repository_id | 440752086 |
| octolytics-dimension-repository_nwo | coder/coder |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 440752086 |
| octolytics-dimension-repository_network_root_nwo | coder/coder |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/coder/coder/pull/17336#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F17336 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F17336 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder |
| Reload | https://github.com/coder/coder/pull/17336 |
| Reload | https://github.com/coder/coder/pull/17336 |
| Reload | https://github.com/coder/coder/pull/17336 |
| coder | https://github.com/coder |
| coder | https://github.com/coder/coder |
| Code | https://github.com/coder/coder |
| Issues320 (320) | https://github.com/coder/coder/issues |
| Pull requests470 (470) | https://github.com/coder/coder/pulls |
| Discussions | https://github.com/coder/coder/discussions |
| Actions | https://github.com/coder/coder/actions |
| Projects | https://github.com/coder/coder/projects |
| Security and quality49 (49) | https://github.com/coder/coder/security |
| Insights | https://github.com/coder/coder/insights |
| https://github.com/coder/coder |
| spikecurtis | https://github.com/spikecurtis |
| main | https://github.com/coder/coder/tree/main |
| spike/host-suffix/dns-match-domain | https://github.com/coder/coder/tree/spike/host-suffix/dns-match-domain |
| Conversation | https://github.com/coder/coder/pull/17336 |
| Commits1 (1) | https://github.com/coder/coder/pull/17336/commits |
| Checks | https://github.com/coder/coder/pull/17336/checks |
| Files changed | https://github.com/coder/coder/pull/17336/files |
| feat: add configurable DNS match domain for tailnet connections | https://github.com/coder/coder/pull/17336#top |
| spikecurtis | https://github.com/spikecurtis |
| main | https://github.com/coder/coder/tree/main |
| spike/host-suffix/dns-match-domain | https://github.com/coder/coder/tree/spike/host-suffix/dns-match-domain |
|
| https://github.com/spikecurtis |
| spikecurtis | https://github.com/spikecurtis |
| Apr 10, 2025 | https://github.com/coder/coder/pull/17336#issue-2985708155 |
| Please reload this page | https://github.com/coder/coder/pull/17336 |
| #16828 | https://github.com/coder/coder/issues/16828 |
| Please reload this page | https://github.com/coder/coder/pull/17336 |
|
feat: return hostname suffix on AgentConnectionInfo
#17334
| https://github.com/coder/coder/pull/17334 |
|
feat: vpn uses WorkspaceHostnameSuffix for DNS names
#17335
| https://github.com/coder/coder/pull/17335 |
| https://github.com/spikecurtis |
|
| https://github.com/apps/graphite-app |
| spikecurtis | https://github.com/spikecurtis |
| Apr 10, 2025 | https://github.com/coder/coder/pull/17336#issuecomment-2793037021 |
| Please reload this page | https://github.com/coder/coder/pull/17336 |
| feat: add configurable DNS match domain for tailnet connections #17336 | https://github.com/coder/coder/pull/17336 |
| https://app.graphite.dev/github/pr/coder/coder/17336?utm_source=stack-comment-icon |
| (View in Graphite) | https://app.graphite.dev/github/pr/coder/coder/17336?utm_source=stack-comment-view-in-graphite |
| feat: vpn uses WorkspaceHostnameSuffix for DNS names #17335 | https://github.com/coder/coder/pull/17335 |
| https://app.graphite.dev/github/pr/coder/coder/17335?utm_source=stack-comment-icon |
| feat: return hostname suffix on AgentConnectionInfo #17334 | https://github.com/coder/coder/pull/17334 |
| https://app.graphite.dev/github/pr/coder/coder/17334?utm_source=stack-comment-icon |
| Graphite | https://graphite.dev?utm-source=stack-comment |
| stacking | https://stacking.dev/?utm_source=stack-comment |
| Please reload this page | https://github.com/coder/coder/pull/17336 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| spikecurtis | https://github.com/spikecurtis |
| Apr 10, 2025 | https://github.com/coder/coder/pull/17336#event-17206639052 |
| https://github.com/spikecurtis |
| spikecurtis | https://github.com/spikecurtis |
| ethanndickson | https://github.com/ethanndickson |
| April 10, 2025 13:35 | https://github.com/coder/coder/pull/17336#event-17206724566 |
| https://github.com/spikecurtis |
| spikecurtis | https://github.com/spikecurtis |
| April 10, 2025 13:35 | https://github.com/coder/coder/pull/17336#event-17206731544 |
| https://github.com/spikecurtis |
| spikecurtis | https://github.com/spikecurtis |
| Apr 10, 2025 | https://github.com/coder/coder/pull/17336#event-17206734509 |
| https://github.com/ethanndickson |
| ethanndickson | https://github.com/ethanndickson |
|
Apr 11, 2025
| https://github.com/coder/coder/pull/17336#pullrequestreview-2758925293 |
|
View reviewed changes
| https://github.com/coder/coder/pull/17336/files |
| ethanndickson | https://github.com/ethanndickson |
| https://github.com/coder/coder/pull/17336#pullrequestreview-2758925293 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://private-user-images.githubusercontent.com/39577870/432571142-a4773c91-9e25-4cf2-aaf4-b4b217a98746.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3OTUyNjI0MDcsIm5iZiI6MTc5NTI2MjEwNywicGF0aCI6Ii8zOTU3Nzg3MC80MzI1NzExNDItYTQ3NzNjOTEtOWUyNS00Y2YyLWFhZjQtYjRiMjE3YTk4NzQ2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjExMjElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYxMTIxVDExNTUwN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWE3OTJmZTViZTk4MWFmYTUwNmE0ZGJjODNiYzYwNDc4ZDEyOWRhNmZlMTkzYTdiN2Q5MDRkNzNhNDliMGY0NzkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JnJlc3BvbnNlLWNvbnRlbnQtdHlwZT1pbWFnZSUyRnBuZyJ9.eMdiuSCecPuLcSb9lKHo7slQ-9ij3rbQLxl5RLZT12w |
| Please reload this page | https://github.com/coder/coder/pull/17336 |
| vpn/client.go | https://github.com/coder/coder/pull/17336/files#diff-d0738322f87fd5ef302e32c22b5d0ef0f21f0087c46290f5fdac507fb6b86483 |
| Please reload this page | https://github.com/coder/coder/pull/17336 |
| https://github.com/spikecurtis |
| spikecurtis | https://github.com/spikecurtis |
| force-pushed | https://github.com/coder/coder/compare/4011a789a9d3487dde3e07368733243b3d62457a..2c9815ad2c64f97c9c53ac1b2040a1d256618a92 |
| 4011a78 | https://github.com/coder/coder/commit/4011a789a9d3487dde3e07368733243b3d62457a |
| 2c9815a | https://github.com/coder/coder/commit/2c9815ad2c64f97c9c53ac1b2040a1d256618a92 |
|
Compare
| https://github.com/coder/coder/compare/4011a789a9d3487dde3e07368733243b3d62457a..2c9815ad2c64f97c9c53ac1b2040a1d256618a92 |
| April 11, 2025 08:55 | https://github.com/coder/coder/pull/17336#event-17220142399 |
| https://github.com/spikecurtis |
| spikecurtis | https://github.com/spikecurtis |
| force-pushed | https://github.com/coder/coder/compare/377e9eeffb7a22cf08cd7db784a6a0683a9b1555..a1d5db754006eb4923d54415abbe5a34e57a9294 |
| 377e9ee | https://github.com/coder/coder/commit/377e9eeffb7a22cf08cd7db784a6a0683a9b1555 |
| a1d5db7 | https://github.com/coder/coder/commit/a1d5db754006eb4923d54415abbe5a34e57a9294 |
|
Compare
| https://github.com/coder/coder/compare/377e9eeffb7a22cf08cd7db784a6a0683a9b1555..a1d5db754006eb4923d54415abbe5a34e57a9294 |
| April 11, 2025 09:10 | https://github.com/coder/coder/pull/17336#event-17220368643 |
| https://github.com/spikecurtis |
| spikecurtis | https://github.com/spikecurtis |
| force-pushed | https://github.com/coder/coder/compare/2c9815ad2c64f97c9c53ac1b2040a1d256618a92..07c5734c970555df8870c4d340eb4e5c5994abfc |
| 2c9815a | https://github.com/coder/coder/commit/2c9815ad2c64f97c9c53ac1b2040a1d256618a92 |
| 07c5734 | https://github.com/coder/coder/commit/07c5734c970555df8870c4d340eb4e5c5994abfc |
|
Compare
| https://github.com/coder/coder/compare/2c9815ad2c64f97c9c53ac1b2040a1d256618a92..07c5734c970555df8870c4d340eb4e5c5994abfc |
| April 11, 2025 09:10 | https://github.com/coder/coder/pull/17336#event-17220369287 |
| https://github.com/spikecurtis |
| spikecurtis | https://github.com/spikecurtis |
| April 11, 2025 09:24 | https://github.com/coder/coder/pull/17336#event-17220566384 |
| https://github.com/spikecurtis |
| spikecurtis | https://github.com/spikecurtis |
| force-pushed | https://github.com/coder/coder/compare/a1d5db754006eb4923d54415abbe5a34e57a9294..2c573dc0236d25f6a50137e9495f0659bbe52d32 |
| a1d5db7 | https://github.com/coder/coder/commit/a1d5db754006eb4923d54415abbe5a34e57a9294 |
| 2c573dc | https://github.com/coder/coder/commit/2c573dc0236d25f6a50137e9495f0659bbe52d32 |
|
Compare
| https://github.com/coder/coder/compare/a1d5db754006eb4923d54415abbe5a34e57a9294..2c573dc0236d25f6a50137e9495f0659bbe52d32 |
| April 11, 2025 09:24 | https://github.com/coder/coder/pull/17336#event-17220570030 |
| https://github.com/spikecurtis |
| spikecurtis | https://github.com/spikecurtis |
| force-pushed | https://github.com/coder/coder/compare/07c5734c970555df8870c4d340eb4e5c5994abfc..e2a439471d3a852403b08e397de14e87ea43a15b |
| 07c5734 | https://github.com/coder/coder/commit/07c5734c970555df8870c4d340eb4e5c5994abfc |
| e2a4394 | https://github.com/coder/coder/commit/e2a439471d3a852403b08e397de14e87ea43a15b |
|
Compare
| https://github.com/coder/coder/compare/07c5734c970555df8870c4d340eb4e5c5994abfc..e2a439471d3a852403b08e397de14e87ea43a15b |
| April 11, 2025 09:24 | https://github.com/coder/coder/pull/17336#event-17220570124 |
| https://github.com/apps/graphite-app |
| graphite-app | https://github.com/apps/graphite-app |
| April 11, 2025 09:25 | https://github.com/coder/coder/pull/17336#event-17220576971 |
| https://github.com/spikecurtis |
| spikecurtis | https://github.com/spikecurtis |
| force-pushed | https://github.com/coder/coder/compare/e2a439471d3a852403b08e397de14e87ea43a15b..f5d2c41e940a0c5cb6c68097e44b71634226d507 |
| e2a4394 | https://github.com/coder/coder/commit/e2a439471d3a852403b08e397de14e87ea43a15b |
| f5d2c41 | https://github.com/coder/coder/commit/f5d2c41e940a0c5cb6c68097e44b71634226d507 |
|
Compare
| https://github.com/coder/coder/compare/e2a439471d3a852403b08e397de14e87ea43a15b..f5d2c41e940a0c5cb6c68097e44b71634226d507 |
| April 11, 2025 09:25 | https://github.com/coder/coder/pull/17336#event-17220577822 |
|
| https://github.com/spikecurtis |
| feat: VPN sets DNS match domain using Hostname Suffix | https://github.com/coder/coder/pull/17336/commits/a66f0161d0a8f02ae77357c9090b7b68b13394ee |
| a66f016 | https://github.com/coder/coder/pull/17336/commits/a66f0161d0a8f02ae77357c9090b7b68b13394ee |
| https://github.com/spikecurtis |
| spikecurtis | https://github.com/spikecurtis |
| force-pushed | https://github.com/coder/coder/compare/f5d2c41e940a0c5cb6c68097e44b71634226d507..a66f0161d0a8f02ae77357c9090b7b68b13394ee |
| f5d2c41 | https://github.com/coder/coder/commit/f5d2c41e940a0c5cb6c68097e44b71634226d507 |
| a66f016 | https://github.com/coder/coder/commit/a66f0161d0a8f02ae77357c9090b7b68b13394ee |
|
Compare
| https://github.com/coder/coder/compare/f5d2c41e940a0c5cb6c68097e44b71634226d507..a66f0161d0a8f02ae77357c9090b7b68b13394ee |
| April 11, 2025 10:47 | https://github.com/coder/coder/pull/17336#event-17221668322 |
| https://github.com/spikecurtis |
| spikecurtis | https://github.com/spikecurtis |
| 9e2af3e | https://github.com/coder/coder/commit/9e2af3e1274cc0c7f4512e8b3aa5f82cc7e7b93a |
| Apr 11, 2025 | https://github.com/coder/coder/pull/17336#event-17221826496 |
| https://github.com/spikecurtis |
|
| https://github.com/apps/graphite-app |
| spikecurtis | https://github.com/spikecurtis |
| Apr 11, 2025 | https://github.com/coder/coder/pull/17336#issuecomment-2796578547 |
| Graphite | https://app.graphite.dev/github/pr/coder/coder/17336 |
| Please reload this page | https://github.com/coder/coder/pull/17336 |
| https://github.com/spikecurtis |
| spikecurtis | https://github.com/spikecurtis |
| April 11, 2025 11:00 | https://github.com/coder/coder/pull/17336#event-17221826831 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Apr 11, 2025 | https://github.com/coder/coder/pull/17336#event-17221828781 |
| https://github.co/hiddenchars |
| https://github.com/coder/coder/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F17336 |
|
| https://github.com/ethanndickson |
|
ethanndickson
| https://github.com/ethanndickson |
|
| https://github.com/coder/coder/pull/17336/files/4011a789a9d3487dde3e07368733243b3d62457a |
| Please reload this page | https://github.com/coder/coder/pull/17336 |
|
| https://github.com/spikecurtis |
|
spikecurtis
| https://github.com/spikecurtis |
| Please reload this page | https://github.com/coder/coder/pull/17336 |
|
| https://github.com/spikecurtis |
|
| https://github.com/ethanndickson |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |