René's URL Explorer Experiment


Title: fix(agent): ensure SSH server shutdown with process groups by mafredri · Pull Request #17227 · coder/coder · GitHub

Open Graph Title: fix(agent): ensure SSH server shutdown with process groups by mafredri · Pull Request #17227 · coder/coder

X Title: fix(agent): ensure SSH server shutdown with process groups by mafredri · Pull Request #17227 · coder/coder

Description: Secure environments for developers and their agents - fix(agent): ensure SSH server shutdown with process groups by mafredri · Pull Request #17227 · coder/coder

Open Graph Description: After closer inspection of logs mentioned in #17108, it looks like the "connecting to coderd" loop was a red herring and the final log line from (*agentssh.Server).Close is missing. PTY&#...

X Description: After closer inspection of logs mentioned in #17108, it looks like the "connecting to coderd" loop was a red herring and the final log line from (*agentssh.Server).Close is missin...

Opengraph URL: https://github.com/coder/coder/pull/17227

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:43287052-21df-6b77-0866-c51537c75c59
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idED92:29AEE8:27CDDE0:350A274:6B01AEF8
html-safe-nonce705053f0d3e353fb20b9170b42096cd3c4f40189bc978e57939c01bba3ee87d2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDkyOjI5QUVFODoyN0NEREUwOjM1MEEyNzQ6NkIwMUFFRjgiLCJ2aXNpdG9yX2lkIjoiNDUwODIxNDA5OTA3ODkxNzg4MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5c804c85ad06e946420f1531a877b632c88b1e1366d5d364994197938d252624
hovercard-subject-tagpull_request:2434477522
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/17227/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/18d59a10a182d6c90b6aee109d8ccc5cf8b6f4fc896067b60e29437e91a1d2fc/coder/coder/pull/17227
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/18d59a10a182d6c90b6aee109d8ccc5cf8b6f4fc896067b60e29437e91a1d2fc/coder/coder/pull/17227
og:image:altAfter closer inspection of logs mentioned in #17108, it looks like the "connecting to coderd" loop was a red herring and the final log line from (*agentssh.Server).Close is missing. PTY&#...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemafredri
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/coder/coder/pull/17227#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F17227
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F17227
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/pull/17227
Reloadhttps://github.com/coder/coder/pull/17227
Reloadhttps://github.com/coder/coder/pull/17227
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
https://github.com/coder/coder
mafredrihttps://github.com/mafredri
mainhttps://github.com/coder/coder/tree/main
mafredri/fix-agent-agentssh-close-blockhttps://github.com/coder/coder/tree/mafredri/fix-agent-agentssh-close-block
Conversationhttps://github.com/coder/coder/pull/17227
Commits4 (4)https://github.com/coder/coder/pull/17227/commits
Checkshttps://github.com/coder/coder/pull/17227/checks
Files changedhttps://github.com/coder/coder/pull/17227/files
fix(agent): ensure SSH server shutdown with process groupshttps://github.com/coder/coder/pull/17227#top
mafredrihttps://github.com/mafredri
mainhttps://github.com/coder/coder/tree/main
mafredri/fix-agent-agentssh-close-blockhttps://github.com/coder/coder/tree/mafredri/fix-agent-agentssh-close-block
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Apr 2, 2025https://github.com/coder/coder/pull/17227#issue-2966694892
Please reload this pagehttps://github.com/coder/coder/pull/17227
#17108https://github.com/coder/coder/issues/17108
#17108https://github.com/coder/coder/issues/17108
Please reload this pagehttps://github.com/coder/coder/pull/17227
https://github.com/mafredri
fix(agent): improve SSH server shutdown and continue after timeouthttps://github.com/coder/coder/pull/17227/commits/337dddf9e34a2231037b3acf939fcc64b7956b97
337dddfhttps://github.com/coder/coder/pull/17227/commits/337dddf9e34a2231037b3acf939fcc64b7956b97
#17108https://github.com/coder/coder/issues/17108
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
mafredrihttps://github.com/mafredri
Apr 2, 2025https://github.com/coder/coder/pull/17227#event-17095869097
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Apr 2, 2025 https://github.com/coder/coder/pull/17227#pullrequestreview-2736813834
View reviewed changes https://github.com/coder/coder/pull/17227/files/337dddf9e34a2231037b3acf939fcc64b7956b97
agent/agentssh/exec_other.gohttps://github.com/coder/coder/pull/17227/files/337dddf9e34a2231037b3acf939fcc64b7956b97#diff-03095fd3855c3963f338d1279bbf6140980eea53ae8657948749aa64d3a90a9e
mafredrihttps://github.com/mafredri
Apr 2, 2025https://github.com/coder/coder/pull/17227#discussion_r2025140228
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/17227
https://github.com/mafredri
mafredrihttps://github.com/mafredri
April 2, 2025 15:54https://github.com/coder/coder/pull/17227#event-17096849641
https://github.com/mafredri
mafredrihttps://github.com/mafredri
aslilachttps://github.com/aslilac
johnstcnhttps://github.com/johnstcn
spikecurtishttps://github.com/spikecurtis
April 2, 2025 15:54https://github.com/coder/coder/pull/17227#event-17096852015
https://github.com/johnstcn
johnstcnhttps://github.com/johnstcn
Apr 2, 2025 https://github.com/coder/coder/pull/17227#pullrequestreview-2736883128
View reviewed changes https://github.com/coder/coder/pull/17227/files/337dddf9e34a2231037b3acf939fcc64b7956b97
agent/agentssh/exec_windows.gohttps://github.com/coder/coder/pull/17227/files/337dddf9e34a2231037b3acf939fcc64b7956b97#diff-b62c29a2c3680b2098f857d77bb115c5995b144df79cb59279d757099eb5ce56
johnstcnhttps://github.com/johnstcn
Apr 2, 2025https://github.com/coder/coder/pull/17227#discussion_r2025180793
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/17227
agent/agentssh/exec_other.gohttps://github.com/coder/coder/pull/17227/files/337dddf9e34a2231037b3acf939fcc64b7956b97#diff-03095fd3855c3963f338d1279bbf6140980eea53ae8657948749aa64d3a90a9e
Please reload this pagehttps://github.com/coder/coder/pull/17227
agent/agentssh/agentssh.gohttps://github.com/coder/coder/pull/17227/files/337dddf9e34a2231037b3acf939fcc64b7956b97#diff-e2fb60d4b313fc2ad42c37ce065c0c880e04615b339a843e14892338d0bb4396
Please reload this pagehttps://github.com/coder/coder/pull/17227
agent/agentssh/agentssh.gohttps://github.com/coder/coder/pull/17227/files/337dddf9e34a2231037b3acf939fcc64b7956b97#diff-e2fb60d4b313fc2ad42c37ce065c0c880e04615b339a843e14892338d0bb4396
johnstcnhttps://github.com/johnstcn
Apr 2, 2025https://github.com/coder/coder/pull/17227#discussion_r2025192270
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/17227
agent/agentssh/agentssh.gohttps://github.com/coder/coder/pull/17227/files/337dddf9e34a2231037b3acf939fcc64b7956b97#diff-e2fb60d4b313fc2ad42c37ce065c0c880e04615b339a843e14892338d0bb4396
johnstcnhttps://github.com/johnstcn
Apr 2, 2025https://github.com/coder/coder/pull/17227#discussion_r2025192601
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/17227
agent/agentssh/agentssh.gohttps://github.com/coder/coder/pull/17227/files/337dddf9e34a2231037b3acf939fcc64b7956b97#diff-e2fb60d4b313fc2ad42c37ce065c0c880e04615b339a843e14892338d0bb4396
johnstcnhttps://github.com/johnstcn
Apr 2, 2025https://github.com/coder/coder/pull/17227#discussion_r2025192770
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/17227
agent/agent.gohttps://github.com/coder/coder/pull/17227/files/337dddf9e34a2231037b3acf939fcc64b7956b97#diff-62b6ad581fe3a3059ae8c85ef0f31dde4092bfdecfa7d6857c470bcacaa8cc8b
johnstcnhttps://github.com/johnstcn
Apr 2, 2025https://github.com/coder/coder/pull/17227#discussion_r2025198225
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/17227
mafredrihttps://github.com/mafredri
Apr 3, 2025https://github.com/coder/coder/pull/17227#discussion_r2026595518
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#6175https://github.com/coder/coder/issues/6175
Please reload this pagehttps://github.com/coder/coder/pull/17227
agent/agentssh/agentssh.gohttps://github.com/coder/coder/pull/17227/files/337dddf9e34a2231037b3acf939fcc64b7956b97#diff-e2fb60d4b313fc2ad42c37ce065c0c880e04615b339a843e14892338d0bb4396
johnstcnhttps://github.com/johnstcn
Apr 2, 2025https://github.com/coder/coder/pull/17227#discussion_r2025202788
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/17227
mafredrihttps://github.com/mafredri
Apr 3, 2025https://github.com/coder/coder/pull/17227#discussion_r2026597395
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/17227
agent/agentssh/agentssh.gohttps://github.com/coder/coder/pull/17227/files/337dddf9e34a2231037b3acf939fcc64b7956b97#diff-e2fb60d4b313fc2ad42c37ce065c0c880e04615b339a843e14892338d0bb4396
johnstcnhttps://github.com/johnstcn
Apr 2, 2025https://github.com/coder/coder/pull/17227#discussion_r2025203492
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/17227
mafredrihttps://github.com/mafredri
April 3, 2025 09:50https://github.com/coder/coder/pull/17227#commits-pushed-918f2dc
https://github.com/mafredri
fix pr feedbackhttps://github.com/coder/coder/pull/17227/commits/918f2dc49af3a5a5f13b2d7b3e2af56941ad9862
918f2dchttps://github.com/coder/coder/pull/17227/commits/918f2dc49af3a5a5f13b2d7b3e2af56941ad9862
https://github.com/mafredri
decrease ssh shutdown timeouthttps://github.com/coder/coder/pull/17227/commits/fd2c0d1bceb1c5959e8f0f21326d362e1786f22c
fd2c0d1https://github.com/coder/coder/pull/17227/commits/fd2c0d1bceb1c5959e8f0f21326d362e1786f22c
https://github.com/mafredri
fix shutdown dochttps://github.com/coder/coder/pull/17227/commits/9c3e874f404e402e95888c29e6581fba281dd72a
9c3e874https://github.com/coder/coder/pull/17227/commits/9c3e874f404e402e95888c29e6581fba281dd72a
https://github.com/johnstcn
johnstcnhttps://github.com/johnstcn
Apr 3, 2025 https://github.com/coder/coder/pull/17227#pullrequestreview-2739298658
View reviewed changes https://github.com/coder/coder/pull/17227/files/9c3e874f404e402e95888c29e6581fba281dd72a
https://github.com/mafredri
mafredrihttps://github.com/mafredri
b61f0abhttps://github.com/coder/coder/commit/b61f0ab958309a075bc56f57f47266a2d33475ff
Apr 3, 2025https://github.com/coder/coder/pull/17227#event-17113347027
https://github.com/mafredri
mafredrihttps://github.com/mafredri
April 3, 2025 13:01https://github.com/coder/coder/pull/17227#event-17113347514
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Apr 3, 2025https://github.com/coder/coder/pull/17227#event-17113349845
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Apr 3, 2025https://github.com/coder/coder/pull/17227#event-17113361045
https://github.co/hiddenchars
https://github.com/coder/coder/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F17227
https://github.com/johnstcn
johnstcn https://github.com/johnstcn
https://github.com/coder/coder/pull/17227/files/9c3e874f404e402e95888c29e6581fba281dd72a
https://github.com/spikecurtis
spikecurtis https://github.com/spikecurtis
https://github.com/aslilac
aslilac https://github.com/aslilac
Please reload this pagehttps://github.com/coder/coder/pull/17227
https://github.com/mafredri
mafredri https://github.com/mafredri
investigate why run_on_stop doesn't work consistently https://github.com/coder/coder/issues/17108
Please reload this pagehttps://github.com/coder/coder/pull/17227
https://github.com/mafredri
https://github.com/johnstcn
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.