René's URL Explorer Experiment


Title: fix: Guard against CLI cmd running after test exit by mafredri · Pull Request #1658 · coder/coder · GitHub

Open Graph Title: fix: Guard against CLI cmd running after test exit by mafredri · Pull Request #1658 · coder/coder

X Title: fix: Guard against CLI cmd running after test exit by mafredri · Pull Request #1658 · coder/coder

Description: Secure environments for developers and their agents - fix: Guard against CLI cmd running after test exit by mafredri · Pull Request #1658 · coder/coder

Open Graph Description: This PR fixes a few cases of command potentially running after test exit. The require on test object can result in data race.

X Description: This PR fixes a few cases of command potentially running after test exit. The require on test object can result in data race.

Opengraph URL: https://github.com/coder/coder/pull/1658

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0ffc1d6b-3804-18bd-eaea-7b171f1254db
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9DDC:96DDF:22FDAEC:2C4DCB6:6B01768C
html-safe-nonce3d816168dd3a1a0d524b12104d0986c9563a4e1e70aba4846cdcf1bb1839b17a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RERDOjk2RERGOjIyRkRBRUM6MkM0RENCNjo2QjAxNzY4QyIsInZpc2l0b3JfaWQiOiI2ODM4MDY0NTEwODkzMzg5NDUyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac8abf3684c24a0d433856270858d07045a0a3faa19c326d9bbbce7630070bd0d5
hovercard-subject-tagpull_request:944304357
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/1658/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/66fbf718a4c6cea9e5271d2c9d758355eedefbe1decc935fc8918ffc836a7191/coder/coder/pull/1658
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/66fbf718a4c6cea9e5271d2c9d758355eedefbe1decc935fc8918ffc836a7191/coder/coder/pull/1658
og:image:altThis PR fixes a few cases of command potentially running after test exit. The require on test object can result in data race.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemafredri
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/coder/coder/pull/1658#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F1658
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F1658
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/pull/1658
Reloadhttps://github.com/coder/coder/pull/1658
Reloadhttps://github.com/coder/coder/pull/1658
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
https://github.com/coder/coder
mafredrihttps://github.com/mafredri
mainhttps://github.com/coder/coder/tree/main
mafredri/fix-potential-cmd-running-after-test-exithttps://github.com/coder/coder/tree/mafredri/fix-potential-cmd-running-after-test-exit
Conversationhttps://github.com/coder/coder/pull/1658
Commits10 (10)https://github.com/coder/coder/pull/1658/commits
Checkshttps://github.com/coder/coder/pull/1658/checks
Files changedhttps://github.com/coder/coder/pull/1658/files
fix: Guard against CLI cmd running after test exithttps://github.com/coder/coder/pull/1658#top
mafredrihttps://github.com/mafredri
mainhttps://github.com/coder/coder/tree/main
mafredri/fix-potential-cmd-running-after-test-exithttps://github.com/coder/coder/tree/mafredri/fix-potential-cmd-running-after-test-exit
https://github.com/mafredri
mafredrihttps://github.com/mafredri
May 23, 2022https://github.com/coder/coder/pull/1658#issue-1245013501
Please reload this pagehttps://github.com/coder/coder/pull/1658
https://github.com/mafredri
fix: Guard against CLI cmd running after test exithttps://github.com/coder/coder/pull/1658/commits/97c3b066c3ca3ddeec7f754a0975cc1f9972453b
97c3b06https://github.com/coder/coder/pull/1658/commits/97c3b066c3ca3ddeec7f754a0975cc1f9972453b
https://github.com/mafredri
mafredrihttps://github.com/mafredri
May 23, 2022https://github.com/coder/coder/pull/1658#event-6660214109
https://github.com/mafredri
mafredrihttps://github.com/mafredri
johnstcnhttps://github.com/johnstcn
May 23, 2022 11:24https://github.com/coder/coder/pull/1658#event-6660214188
https://github.com/mafredri
Cancel contexthttps://github.com/coder/coder/pull/1658/commits/21da84554f9af26aeda703e4eef4507440befc8f
21da845https://github.com/coder/coder/pull/1658/commits/21da84554f9af26aeda703e4eef4507440befc8f
https://github.com/johnstcn
johnstcnhttps://github.com/johnstcn
May 23, 2022 https://github.com/coder/coder/pull/1658#pullrequestreview-981644804
View reviewed changes https://github.com/coder/coder/pull/1658/files/21da84554f9af26aeda703e4eef4507440befc8f
https://github.com/johnstcn
johnstcnhttps://github.com/johnstcn
May 23, 2022 https://github.com/coder/coder/pull/1658#ref-issue-1243336923
CI: test/go/postgres is flakey #1626 https://github.com/coder/coder/issues/1626
johnstcnhttps://github.com/johnstcn
May 23, 2022 13:24https://github.com/coder/coder/pull/1658#commits-pushed-53417bb
https://github.com/johnstcn
fix: cli: avoid calling t.FailNow in non-test-main goroutinehttps://github.com/coder/coder/pull/1658/commits/53417bb09aecdf9fcd682eb2d85051465ed0372f
53417bbhttps://github.com/coder/coder/pull/1658/commits/53417bb09aecdf9fcd682eb2d85051465ed0372f
https://github.com/johnstcn
fix: cli: server_test: avoid calling t.FailNow outside main goroutinehttps://github.com/coder/coder/pull/1658/commits/5530f2addaacf12fccf3d9d1c0c56c6274c93295
5530f2ahttps://github.com/coder/coder/pull/1658/commits/5530f2addaacf12fccf3d9d1c0c56c6274c93295
https://github.com/johnstcn
fix: cli: clitest_test: avoid calling t.FailNow outside main goroutinehttps://github.com/coder/coder/pull/1658/commits/4ea0ed787567d71c6d34494c14feb01b433f9cec
4ea0ed7https://github.com/coder/coder/pull/1658/commits/4ea0ed787567d71c6d34494c14feb01b433f9cec
https://github.com/johnstcn
fix: cli: list_test: avoid calling t.FailNow outside main goroutinehttps://github.com/coder/coder/pull/1658/commits/3998794b245071724c9805583bc3ab19a8bd6f5c
3998794https://github.com/coder/coder/pull/1658/commits/3998794b245071724c9805583bc3ab19a8bd6f5c
https://github.com/mafredri
Fix TestGitSSH t-after-exithttps://github.com/coder/coder/pull/1658/commits/6519ff8b5a5a5f24dc3db1daf9158ced57f054f6
6519ff8https://github.com/coder/coder/pull/1658/commits/6519ff8b5a5a5f24dc3db1daf9158ced57f054f6
https://github.com/mafredri
Fix TestGitSSH "too many authentication failures"https://github.com/coder/coder/pull/1658/commits/5c741f4d9116c33feec844cffadc203d203dd70a
5c741f4https://github.com/coder/coder/pull/1658/commits/5c741f4d9116c33feec844cffadc203d203dd70a
https://github.com/Emyrk
Emyrkhttps://github.com/Emyrk
May 23, 2022 https://github.com/coder/coder/pull/1658#pullrequestreview-981946184
View reviewed changes https://github.com/coder/coder/pull/1658/files/5c741f4d9116c33feec844cffadc203d203dd70a
johnstcnhttps://github.com/johnstcn
May 23, 2022 16:15https://github.com/coder/coder/pull/1658#commits-pushed-de6b5ed
https://github.com/johnstcn
chore: clitest: fix TestClihttps://github.com/coder/coder/pull/1658/commits/de6b5ed561659f0a194d8f28bad0437e4660acfe
de6b5edhttps://github.com/coder/coder/pull/1658/commits/de6b5ed561659f0a194d8f28bad0437e4660acfe
https://github.com/mafredri
chore: Simplify TestTemplateInithttps://github.com/coder/coder/pull/1658/commits/ed95609a2575166d279c51622deee2e0e70a4aa3
ed95609https://github.com/coder/coder/pull/1658/commits/ed95609a2575166d279c51622deee2e0e70a4aa3
https://github.com/mafredri
mafredrihttps://github.com/mafredri
c8ed213https://github.com/coder/coder/commit/c8ed2133470c5b0c957a3cec1c53a688a384a6b0
May 23, 2022https://github.com/coder/coder/pull/1658#event-6662881356
https://github.com/mafredri
mafredrihttps://github.com/mafredri
May 23, 2022 17:09https://github.com/coder/coder/pull/1658#event-6662881423
https://github.co/hiddenchars
https://github.com/coder/coder/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F1658
https://github.com/johnstcn
johnstcn https://github.com/johnstcn
https://github.com/coder/coder/pull/1658/files/21da84554f9af26aeda703e4eef4507440befc8f
https://github.com/Emyrk
Emyrk https://github.com/Emyrk
https://github.com/coder/coder/pull/1658/files/5c741f4d9116c33feec844cffadc203d203dd70a
Please reload this pagehttps://github.com/coder/coder/pull/1658
https://github.com/mafredri
mafredri https://github.com/mafredri
Please reload this pagehttps://github.com/coder/coder/pull/1658
https://github.com/mafredri
https://github.com/johnstcn
https://github.com/Emyrk
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.