| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:0ffc1d6b-3804-18bd-eaea-7b171f1254db |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9DDC:96DDF:22FDAEC:2C4DCB6:6B01768C |
| html-safe-nonce | 3d816168dd3a1a0d524b12104d0986c9563a4e1e70aba4846cdcf1bb1839b17a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RERDOjk2RERGOjIyRkRBRUM6MkM0RENCNjo2QjAxNzY4QyIsInZpc2l0b3JfaWQiOiI2ODM4MDY0NTEwODkzMzg5NDUyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 8abf3684c24a0d433856270858d07045a0a3faa19c326d9bbbce7630070bd0d5 |
| hovercard-subject-tag | pull_request:944304357 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/1658/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/66fbf718a4c6cea9e5271d2c9d758355eedefbe1decc935fc8918ffc836a7191/coder/coder/pull/1658 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/66fbf718a4c6cea9e5271d2c9d758355eedefbe1decc935fc8918ffc836a7191/coder/coder/pull/1658 |
| og:image:alt | This PR fixes a few cases of command potentially running after test exit. The require on test object can result in data race. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mafredri |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/coder/coder git https://github.com/coder/coder.git |
| octolytics-dimension-user_id | 95932066 |
| octolytics-dimension-user_login | coder |
| octolytics-dimension-repository_id | 440752086 |
| octolytics-dimension-repository_nwo | coder/coder |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 440752086 |
| octolytics-dimension-repository_network_root_nwo | coder/coder |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/coder/coder/pull/1658#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F1658 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F1658 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder |
| Reload | https://github.com/coder/coder/pull/1658 |
| Reload | https://github.com/coder/coder/pull/1658 |
| Reload | https://github.com/coder/coder/pull/1658 |
| coder | https://github.com/coder |
| coder | https://github.com/coder/coder |
| Code | https://github.com/coder/coder |
| Issues320 (320) | https://github.com/coder/coder/issues |
| Pull requests470 (470) | https://github.com/coder/coder/pulls |
| Discussions | https://github.com/coder/coder/discussions |
| Actions | https://github.com/coder/coder/actions |
| Projects | https://github.com/coder/coder/projects |
| Security and quality49 (49) | https://github.com/coder/coder/security |
| Insights | https://github.com/coder/coder/insights |
| https://github.com/coder/coder |
| mafredri | https://github.com/mafredri |
| main | https://github.com/coder/coder/tree/main |
| mafredri/fix-potential-cmd-running-after-test-exit | https://github.com/coder/coder/tree/mafredri/fix-potential-cmd-running-after-test-exit |
| Conversation | https://github.com/coder/coder/pull/1658 |
| Commits10 (10) | https://github.com/coder/coder/pull/1658/commits |
| Checks | https://github.com/coder/coder/pull/1658/checks |
| Files changed | https://github.com/coder/coder/pull/1658/files |
| fix: Guard against CLI cmd running after test exit | https://github.com/coder/coder/pull/1658#top |
| mafredri | https://github.com/mafredri |
| main | https://github.com/coder/coder/tree/main |
| mafredri/fix-potential-cmd-running-after-test-exit | https://github.com/coder/coder/tree/mafredri/fix-potential-cmd-running-after-test-exit |
|
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| May 23, 2022 | https://github.com/coder/coder/pull/1658#issue-1245013501 |
| Please reload this page | https://github.com/coder/coder/pull/1658 |
|
| https://github.com/mafredri |
| fix: Guard against CLI cmd running after test exit | https://github.com/coder/coder/pull/1658/commits/97c3b066c3ca3ddeec7f754a0975cc1f9972453b |
| 97c3b06 | https://github.com/coder/coder/pull/1658/commits/97c3b066c3ca3ddeec7f754a0975cc1f9972453b |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| May 23, 2022 | https://github.com/coder/coder/pull/1658#event-6660214109 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| johnstcn | https://github.com/johnstcn |
| May 23, 2022 11:24 | https://github.com/coder/coder/pull/1658#event-6660214188 |
|
| https://github.com/mafredri |
| Cancel context | https://github.com/coder/coder/pull/1658/commits/21da84554f9af26aeda703e4eef4507440befc8f |
| 21da845 | https://github.com/coder/coder/pull/1658/commits/21da84554f9af26aeda703e4eef4507440befc8f |
| https://github.com/johnstcn |
| johnstcn | https://github.com/johnstcn |
|
May 23, 2022
| https://github.com/coder/coder/pull/1658#pullrequestreview-981644804 |
|
View reviewed changes
| https://github.com/coder/coder/pull/1658/files/21da84554f9af26aeda703e4eef4507440befc8f |
| https://github.com/johnstcn |
| johnstcn | https://github.com/johnstcn |
|
May 23, 2022
| https://github.com/coder/coder/pull/1658#ref-issue-1243336923 |
|
CI: test/go/postgres is flakey
#1626
| https://github.com/coder/coder/issues/1626 |
| johnstcn | https://github.com/johnstcn |
| May 23, 2022 13:24 | https://github.com/coder/coder/pull/1658#commits-pushed-53417bb |
|
| https://github.com/johnstcn |
| fix: cli: avoid calling t.FailNow in non-test-main goroutine | https://github.com/coder/coder/pull/1658/commits/53417bb09aecdf9fcd682eb2d85051465ed0372f |
| 53417bb | https://github.com/coder/coder/pull/1658/commits/53417bb09aecdf9fcd682eb2d85051465ed0372f |
|
| https://github.com/johnstcn |
| fix: cli: server_test: avoid calling t.FailNow outside main goroutine | https://github.com/coder/coder/pull/1658/commits/5530f2addaacf12fccf3d9d1c0c56c6274c93295 |
| 5530f2a | https://github.com/coder/coder/pull/1658/commits/5530f2addaacf12fccf3d9d1c0c56c6274c93295 |
|
| https://github.com/johnstcn |
| fix: cli: clitest_test: avoid calling t.FailNow outside main goroutine | https://github.com/coder/coder/pull/1658/commits/4ea0ed787567d71c6d34494c14feb01b433f9cec |
| 4ea0ed7 | https://github.com/coder/coder/pull/1658/commits/4ea0ed787567d71c6d34494c14feb01b433f9cec |
|
| https://github.com/johnstcn |
| fix: cli: list_test: avoid calling t.FailNow outside main goroutine | https://github.com/coder/coder/pull/1658/commits/3998794b245071724c9805583bc3ab19a8bd6f5c |
| 3998794 | https://github.com/coder/coder/pull/1658/commits/3998794b245071724c9805583bc3ab19a8bd6f5c |
|
| https://github.com/mafredri |
| Fix TestGitSSH t-after-exit | https://github.com/coder/coder/pull/1658/commits/6519ff8b5a5a5f24dc3db1daf9158ced57f054f6 |
| 6519ff8 | https://github.com/coder/coder/pull/1658/commits/6519ff8b5a5a5f24dc3db1daf9158ced57f054f6 |
|
| https://github.com/mafredri |
| Fix TestGitSSH "too many authentication failures" | https://github.com/coder/coder/pull/1658/commits/5c741f4d9116c33feec844cffadc203d203dd70a |
| 5c741f4 | https://github.com/coder/coder/pull/1658/commits/5c741f4d9116c33feec844cffadc203d203dd70a |
| https://github.com/Emyrk |
| Emyrk | https://github.com/Emyrk |
|
May 23, 2022
| https://github.com/coder/coder/pull/1658#pullrequestreview-981946184 |
|
View reviewed changes
| https://github.com/coder/coder/pull/1658/files/5c741f4d9116c33feec844cffadc203d203dd70a |
| johnstcn | https://github.com/johnstcn |
| May 23, 2022 16:15 | https://github.com/coder/coder/pull/1658#commits-pushed-de6b5ed |
|
| https://github.com/johnstcn |
| chore: clitest: fix TestCli | https://github.com/coder/coder/pull/1658/commits/de6b5ed561659f0a194d8f28bad0437e4660acfe |
| de6b5ed | https://github.com/coder/coder/pull/1658/commits/de6b5ed561659f0a194d8f28bad0437e4660acfe |
|
| https://github.com/mafredri |
| chore: Simplify TestTemplateInit | https://github.com/coder/coder/pull/1658/commits/ed95609a2575166d279c51622deee2e0e70a4aa3 |
| ed95609 | https://github.com/coder/coder/pull/1658/commits/ed95609a2575166d279c51622deee2e0e70a4aa3 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| c8ed213 | https://github.com/coder/coder/commit/c8ed2133470c5b0c957a3cec1c53a688a384a6b0 |
| May 23, 2022 | https://github.com/coder/coder/pull/1658#event-6662881356 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| May 23, 2022 17:09 | https://github.com/coder/coder/pull/1658#event-6662881423 |
| https://github.co/hiddenchars |
| https://github.com/coder/coder/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F1658 |
|
| https://github.com/johnstcn |
|
johnstcn
| https://github.com/johnstcn |
|
| https://github.com/coder/coder/pull/1658/files/21da84554f9af26aeda703e4eef4507440befc8f |
|
| https://github.com/Emyrk |
|
Emyrk
| https://github.com/Emyrk |
|
| https://github.com/coder/coder/pull/1658/files/5c741f4d9116c33feec844cffadc203d203dd70a |
| Please reload this page | https://github.com/coder/coder/pull/1658 |
|
| https://github.com/mafredri |
|
mafredri
| https://github.com/mafredri |
| Please reload this page | https://github.com/coder/coder/pull/1658 |
|
| https://github.com/mafredri |
|
| https://github.com/johnstcn |
|
| https://github.com/Emyrk |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |