René's URL Explorer Experiment


Title: fix: Try to fix cli portforward test flakes by mafredri · Pull Request #1650 · coder/coder · GitHub

Open Graph Title: fix: Try to fix cli portforward test flakes by mafredri · Pull Request #1650 · coder/coder

X Title: fix: Try to fix cli portforward test flakes by mafredri · Pull Request #1650 · coder/coder

Description: Secure environments for developers and their agents - fix: Try to fix cli portforward test flakes by mafredri · Pull Request #1650 · coder/coder

Open Graph Description: This PR attempts to fix test flakes in the portforward subcommand. Guard against cmd running after test exit Guard against port-reuse due to parallel tests

X Description: This PR attempts to fix test flakes in the portforward subcommand. Guard against cmd running after test exit Guard against port-reuse due to parallel tests

Opengraph URL: https://github.com/coder/coder/pull/1650

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:34bfdf4c-71b3-01d5-032f-756a3c699f54
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9DC2:38C5CF:2689471:30E4E9B:6B01768A
html-safe-nonce140f2741720c05fa84266c66d5b5608d55b66705cf8c119ee2883689240c3f21
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5REMyOjM4QzVDRjoyNjg5NDcxOjMwRTRFOUI6NkIwMTc2OEEiLCJ2aXNpdG9yX2lkIjoiNDc4NDQyMzI4Njk3MDg3MzQ4MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac21581f8032b2bc35c34169496e5e1a5ccc5ee5aee7fb94b2712bae2e3caec9bd
hovercard-subject-tagpull_request:944282703
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/1650/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b0ae0bd92441430a660cb0eea5d61985f303d560cbe72c9d1a66364de942b9ec/coder/coder/pull/1650
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b0ae0bd92441430a660cb0eea5d61985f303d560cbe72c9d1a66364de942b9ec/coder/coder/pull/1650
og:image:altThis PR attempts to fix test flakes in the portforward subcommand. Guard against cmd running after test exit Guard against port-reuse due to parallel tests
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemafredri
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/coder/coder/pull/1650#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F1650
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F1650
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/pull/1650
Reloadhttps://github.com/coder/coder/pull/1650
Reloadhttps://github.com/coder/coder/pull/1650
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
https://github.com/coder/coder
mafredrihttps://github.com/mafredri
mainhttps://github.com/coder/coder/tree/main
mafredri/try-to-fix-cli-portforward-flakehttps://github.com/coder/coder/tree/mafredri/try-to-fix-cli-portforward-flake
Conversationhttps://github.com/coder/coder/pull/1650
Commits6 (6)https://github.com/coder/coder/pull/1650/commits
Checkshttps://github.com/coder/coder/pull/1650/checks
Files changedhttps://github.com/coder/coder/pull/1650/files
fix: Try to fix cli portforward test flakeshttps://github.com/coder/coder/pull/1650#top
mafredrihttps://github.com/mafredri
mainhttps://github.com/coder/coder/tree/main
mafredri/try-to-fix-cli-portforward-flakehttps://github.com/coder/coder/tree/mafredri/try-to-fix-cli-portforward-flake
https://github.com/mafredri
mafredrihttps://github.com/mafredri
May 23, 2022https://github.com/coder/coder/pull/1650#issue-1244989816
Please reload this pagehttps://github.com/coder/coder/pull/1650
Please reload this pagehttps://github.com/coder/coder/pull/1650
https://github.com/mafredri
mafredrihttps://github.com/mafredri
May 23, 2022https://github.com/coder/coder/pull/1650#event-6660090737
https://github.com/mafredri
mafredrihttps://github.com/mafredri
deansheatherhttps://github.com/deansheather
johnstcnhttps://github.com/johnstcn
May 23, 2022 11:06https://github.com/coder/coder/pull/1650#event-6660090806
https://github.com/johnstcn
johnstcnhttps://github.com/johnstcn
May 23, 2022 https://github.com/coder/coder/pull/1650#pullrequestreview-981631092
View reviewed changes https://github.com/coder/coder/pull/1650/files
https://github.com/johnstcn
johnstcnhttps://github.com/johnstcn
May 23, 2022 https://github.com/coder/coder/pull/1650#ref-issue-1243336923
CI: test/go/postgres is flakey #1626 https://github.com/coder/coder/issues/1626
mafredrihttps://github.com/mafredri
May 23, 2022 20:11https://github.com/coder/coder/pull/1650#commits-pushed-404616a
https://github.com/mafredri
fix: Try to fix cli portforward test flakeshttps://github.com/coder/coder/pull/1650/commits/404616aec78f7cd2b0cc287062662680ce916fe0
404616ahttps://github.com/coder/coder/pull/1650/commits/404616aec78f7cd2b0cc287062662680ce916fe0
https://github.com/mafredri
Restore linter commenthttps://github.com/coder/coder/pull/1650/commits/b4ec075b00504ca0ef0a897dd2c00ea51c3111de
b4ec075https://github.com/coder/coder/pull/1650/commits/b4ec075b00504ca0ef0a897dd2c00ea51c3111de
https://github.com/mafredri
mafredrihttps://github.com/mafredri
force-pushedhttps://github.com/coder/coder/compare/65a375e1a2b00748be5ee94f482b3b1a14ef85f4..63366b5d4bb0d6a6d2490f7e6a50331d6f8064ca
65a375ehttps://github.com/coder/coder/commit/65a375e1a2b00748be5ee94f482b3b1a14ef85f4
63366b5https://github.com/coder/coder/commit/63366b5d4bb0d6a6d2490f7e6a50331d6f8064ca
Compare https://github.com/coder/coder/compare/65a375e1a2b00748be5ee94f482b3b1a14ef85f4..63366b5d4bb0d6a6d2490f7e6a50331d6f8064ca
May 23, 2022 17:11https://github.com/coder/coder/pull/1650#event-6662889538
https://github.com/mafredri
Cancel contexthttps://github.com/coder/coder/pull/1650/commits/f0223ac3b5ca1858ed7d593bc9c0a2b2fb33007f
f0223achttps://github.com/coder/coder/pull/1650/commits/f0223ac3b5ca1858ed7d593bc9c0a2b2fb33007f
https://github.com/mafredri
mafredrihttps://github.com/mafredri
force-pushedhttps://github.com/coder/coder/compare/63366b5d4bb0d6a6d2490f7e6a50331d6f8064ca..f0223ac3b5ca1858ed7d593bc9c0a2b2fb33007f
63366b5https://github.com/coder/coder/commit/63366b5d4bb0d6a6d2490f7e6a50331d6f8064ca
f0223achttps://github.com/coder/coder/commit/f0223ac3b5ca1858ed7d593bc9c0a2b2fb33007f
Compare https://github.com/coder/coder/compare/63366b5d4bb0d6a6d2490f7e6a50331d6f8064ca..f0223ac3b5ca1858ed7d593bc9c0a2b2fb33007f
May 23, 2022 17:24https://github.com/coder/coder/pull/1650#event-6662964367
mafredrihttps://github.com/mafredri
May 23, 2022 20:43https://github.com/coder/coder/pull/1650#commits-pushed-f137169
https://github.com/mafredri
fix: Guard against agent exit outside test funchttps://github.com/coder/coder/pull/1650/commits/f137169fbda6e3cb7b28dae24b653d5b9e1bc40b
f137169https://github.com/coder/coder/pull/1650/commits/f137169fbda6e3cb7b28dae24b653d5b9e1bc40b
https://github.com/mafredri
fix: Improve test teardown in setupTestListener, cleanuphttps://github.com/coder/coder/pull/1650/commits/0259a190153e95423f080af3739f3ca5a85246c5
0259a19https://github.com/coder/coder/pull/1650/commits/0259a190153e95423f080af3739f3ca5a85246c5
https://github.com/mafredri
mafredrihttps://github.com/mafredri
force-pushedhttps://github.com/coder/coder/compare/81c25f3daf75605f7cb2178c8530ad6ad8463073..0259a190153e95423f080af3739f3ca5a85246c5
81c25f3https://github.com/coder/coder/commit/81c25f3daf75605f7cb2178c8530ad6ad8463073
0259a19https://github.com/coder/coder/commit/0259a190153e95423f080af3739f3ca5a85246c5
Compare https://github.com/coder/coder/compare/81c25f3daf75605f7cb2178c8530ad6ad8463073..0259a190153e95423f080af3739f3ca5a85246c5
May 23, 2022 20:33https://github.com/coder/coder/pull/1650#event-6663999931
https://github.com/deansheather
deansheatherhttps://github.com/deansheather
May 24, 2022 https://github.com/coder/coder/pull/1650#pullrequestreview-982745373
View reviewed changes https://github.com/coder/coder/pull/1650/files/0259a190153e95423f080af3739f3ca5a85246c5
deansheatherhttps://github.com/deansheather
https://github.com/coder/coder/pull/1650#pullrequestreview-982745373
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/1650
https://github.com/mafredri
Merge branch 'main' into mafredri/try-to-fix-cli-portforward-flakehttps://github.com/coder/coder/pull/1650/commits/302ecef5fcedbfb9c91b4dfdd12bf376452a2204
302ecefhttps://github.com/coder/coder/pull/1650/commits/302ecef5fcedbfb9c91b4dfdd12bf376452a2204
https://github.com/mafredri
mafredrihttps://github.com/mafredri
34b1e19https://github.com/coder/coder/commit/34b1e193384df098669bd4abc3a528594b0c4e7f
May 24, 2022https://github.com/coder/coder/pull/1650#event-6666825529
https://github.com/mafredri
mafredrihttps://github.com/mafredri
May 24, 2022 08:15https://github.com/coder/coder/pull/1650#event-6666825642
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Aug 12, 2022 https://github.com/coder/coder/pull/1650#ref-issue-1245773081
TestPortForward/UDP/TwoPorts test flake #1698 https://github.com/coder/coder/issues/1698
https://github.co/hiddenchars
https://github.com/coder/coder/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F1650
https://github.com/johnstcn
johnstcn https://github.com/johnstcn
https://github.com/coder/coder/pull/1650/files/65a375e1a2b00748be5ee94f482b3b1a14ef85f4
https://github.com/deansheather
deansheather https://github.com/deansheather
https://github.com/coder/coder/pull/1650/files/0259a190153e95423f080af3739f3ca5a85246c5
Please reload this pagehttps://github.com/coder/coder/pull/1650
https://github.com/mafredri
mafredri https://github.com/mafredri
Please reload this pagehttps://github.com/coder/coder/pull/1650
https://github.com/mafredri
https://github.com/johnstcn
https://github.com/deansheather
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.