| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:ba3a373b-a1c8-cc30-8744-b85ea3ce1994 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D3A2:3A73AA:1EA593E:26D4EF6:6B01A19C |
| html-safe-nonce | 13135f4ec7f1cf47d5dfb6a9f77277cdd914f07549270c2baf2c923b28b11500 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEM0EyOjNBNzNBQToxRUE1OTNFOjI2RDRFRjY6NkIwMUExOUMiLCJ2aXNpdG9yX2lkIjoiNTcxNDkwMzIzODQwNzQ2MzMyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | acae1deb5e04b24416cff8308424e7a6a2fdd844d589efd7e82a9397955b4797 |
| hovercard-subject-tag | pull_request:942918716 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/1629/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/3313f7e3c63f6d9598e9d2764626b54d9697e52b68dd0e379d1795992718972b/coder/coder/pull/1629 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3313f7e3c63f6d9598e9d2764626b54d9697e52b68dd0e379d1795992718972b/coder/coder/pull/1629 |
| og:image:alt | This (draft) PR adds a test that breaks ptytest with unconsumed output on Intel Macs.
This is left open to inform / opportunity to investigate.
To reproduce: go test ./pty/ptytest -v -run=TestPtyte... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mafredri |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/coder/coder git https://github.com/coder/coder.git |
| octolytics-dimension-user_id | 95932066 |
| octolytics-dimension-user_login | coder |
| octolytics-dimension-repository_id | 440752086 |
| octolytics-dimension-repository_nwo | coder/coder |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 440752086 |
| octolytics-dimension-repository_network_root_nwo | coder/coder |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/coder/coder/pull/1629#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F1629 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F1629 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder |
| Reload | https://github.com/coder/coder/pull/1629 |
| Reload | https://github.com/coder/coder/pull/1629 |
| Reload | https://github.com/coder/coder/pull/1629 |
| coder | https://github.com/coder |
| coder | https://github.com/coder/coder |
| Code | https://github.com/coder/coder |
| Issues320 (320) | https://github.com/coder/coder/issues |
| Pull requests470 (470) | https://github.com/coder/coder/pulls |
| Discussions | https://github.com/coder/coder/discussions |
| Actions | https://github.com/coder/coder/actions |
| Projects | https://github.com/coder/coder/projects |
| Security and quality49 (49) | https://github.com/coder/coder/security |
| Insights | https://github.com/coder/coder/insights |
| https://github.com/coder/coder |
| mafredri | https://github.com/mafredri |
| main | https://github.com/coder/coder/tree/main |
| mafredri/draft-ptytest-hangs-on-macos-when-output-is-not-consumed | https://github.com/coder/coder/tree/mafredri/draft-ptytest-hangs-on-macos-when-output-is-not-consumed |
| Conversation | https://github.com/coder/coder/pull/1629 |
| Commits7 (7) | https://github.com/coder/coder/pull/1629/commits |
| Checks | https://github.com/coder/coder/pull/1629/checks |
| Files changed | https://github.com/coder/coder/pull/1629/files |
| chore: Add (skipped) ptytest test that hangs on Intel Mac (and Windows) | https://github.com/coder/coder/pull/1629#top |
| mafredri | https://github.com/mafredri |
| main | https://github.com/coder/coder/tree/main |
| mafredri/draft-ptytest-hangs-on-macos-when-output-is-not-consumed | https://github.com/coder/coder/tree/mafredri/draft-ptytest-hangs-on-macos-when-output-is-not-consumed |
|
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| May 20, 2022 | https://github.com/coder/coder/pull/1629#issue-1243371453 |
| trace.txt | https://github.com/coder/coder/files/8741887/trace.txt |
| @Emyrk | https://github.com/Emyrk |
| Please reload this page | https://github.com/coder/coder/pull/1629 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| May 20, 2022 | https://github.com/coder/coder/pull/1629#issuecomment-1133105192 |
| #1591 | https://github.com/coder/coder/pull/1591 |
| Please reload this page | https://github.com/coder/coder/pull/1629 |
| https://github.com/ammario |
| ammario | https://github.com/ammario |
| Jun 7, 2022 | https://github.com/coder/coder/pull/1629#issuecomment-1148104979 |
| Please reload this page | https://github.com/coder/coder/pull/1629 |
| mafredri | https://github.com/mafredri |
| June 7, 2022 12:40 | https://github.com/coder/coder/pull/1629#commits-pushed-bf3a378 |
|
| https://github.com/mafredri |
| bug: Add test that breaks ptytest on Intel Mac | https://github.com/coder/coder/pull/1629/commits/bf3a378139c7a43955a82f7cfa321e1d8f6f272a |
| bf3a378 | https://github.com/coder/coder/pull/1629/commits/bf3a378139c7a43955a82f7cfa321e1d8f6f272a |
|
| https://github.com/mafredri |
| Simplify test, no need to output more than one line | https://github.com/coder/coder/pull/1629/commits/65f330410f86305df0c64baedf9280b5b3fbc52e |
| 65f3304 | https://github.com/coder/coder/pull/1629/commits/65f330410f86305df0c64baedf9280b5b3fbc52e |
|
| https://github.com/Emyrk |
|
| https://github.com/mafredri |
| Add test using cobra cmd | https://github.com/coder/coder/pull/1629/commits/638acb6f24d3a5a3b3a237b72bac97725247e735 |
| 638acb6 | https://github.com/coder/coder/pull/1629/commits/638acb6f24d3a5a3b3a237b72bac97725247e735 |
|
| https://github.com/mafredri |
| Create proper test to fully reproduce the issue on macOS | https://github.com/coder/coder/pull/1629/commits/7692c5d249acffa8ae46f41f28e72201d17207b0 |
| 7692c5d | https://github.com/coder/coder/pull/1629/commits/7692c5d249acffa8ae46f41f28e72201d17207b0 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| force-pushed | https://github.com/coder/coder/compare/ad76f646b570fe23b497d9c7c1b8633ddb9e0ee3..7692c5d249acffa8ae46f41f28e72201d17207b0 |
| ad76f64 | https://github.com/coder/coder/commit/ad76f646b570fe23b497d9c7c1b8633ddb9e0ee3 |
| 7692c5d | https://github.com/coder/coder/commit/7692c5d249acffa8ae46f41f28e72201d17207b0 |
|
Compare
| https://github.com/coder/coder/compare/ad76f646b570fe23b497d9c7c1b8633ddb9e0ee3..7692c5d249acffa8ae46f41f28e72201d17207b0 |
| June 7, 2022 09:57 | https://github.com/coder/coder/pull/1629#event-6759780187 |
|
| https://github.com/mafredri |
| Add large output | https://github.com/coder/coder/pull/1629/commits/034cfa64d6848da1a380864283f55763f84663e9 |
| 034cfa6 | https://github.com/coder/coder/pull/1629/commits/034cfa64d6848da1a380864283f55763f84663e9 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| force-pushed | https://github.com/coder/coder/compare/21bcca75115a688a3186d870948a36a3f0836405..034cfa64d6848da1a380864283f55763f84663e9 |
| 21bcca7 | https://github.com/coder/coder/commit/21bcca75115a688a3186d870948a36a3f0836405 |
| 034cfa6 | https://github.com/coder/coder/commit/034cfa64d6848da1a380864283f55763f84663e9 |
|
Compare
| https://github.com/coder/coder/compare/21bcca75115a688a3186d870948a36a3f0836405..034cfa64d6848da1a380864283f55763f84663e9 |
| June 7, 2022 10:03 | https://github.com/coder/coder/pull/1629#event-6759827736 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
|
Jun 7, 2022
| https://github.com/coder/coder/pull/1629#ref-issue-1263327001 |
|
Tests using Cobra with ptytest can hang on macOS (and Windows) unless the output is consumed
#2122
| https://github.com/coder/coder/issues/2122 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| June 7, 2022 13:44 | https://github.com/coder/coder/pull/1629#event-6761557349 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| Jun 7, 2022 | https://github.com/coder/coder/pull/1629#event-6761563527 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| Emyrk | https://github.com/Emyrk |
| June 7, 2022 13:45 | https://github.com/coder/coder/pull/1629#event-6761566537 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| Jun 7, 2022 | https://github.com/coder/coder/pull/1629#event-6761569759 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| Jun 7, 2022 | https://github.com/coder/coder/pull/1629#issuecomment-1148701636 |
| @ammario | https://github.com/ammario |
| #2122 | https://github.com/coder/coder/issues/2122 |
| Please reload this page | https://github.com/coder/coder/pull/1629 |
|
| https://github.com/mafredri |
| Skip failing tests on darwin and windows | https://github.com/coder/coder/pull/1629/commits/487f338fa4bd256640698934e9ed1fdf3567d1ad |
| 487f338 | https://github.com/coder/coder/pull/1629/commits/487f338fa4bd256640698934e9ed1fdf3567d1ad |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| force-pushed | https://github.com/coder/coder/compare/e7fad00900c027be08b92d1be43059be37e8470b..487f338fa4bd256640698934e9ed1fdf3567d1ad |
| e7fad00 | https://github.com/coder/coder/commit/e7fad00900c027be08b92d1be43059be37e8470b |
| 487f338 | https://github.com/coder/coder/commit/487f338fa4bd256640698934e9ed1fdf3567d1ad |
|
Compare
| https://github.com/coder/coder/compare/e7fad00900c027be08b92d1be43059be37e8470b..487f338fa4bd256640698934e9ed1fdf3567d1ad |
| June 7, 2022 13:48 | https://github.com/coder/coder/pull/1629#event-6761594916 |
|
| https://github.com/mafredri |
| chore: Write better skip message | https://github.com/coder/coder/pull/1629/commits/75b62969d43d04fc532656792f6232fcf741253b |
| 75b6296 | https://github.com/coder/coder/pull/1629/commits/75b62969d43d04fc532656792f6232fcf741253b |
| https://github.com/Emyrk |
| Emyrk | https://github.com/Emyrk |
|
Jun 7, 2022
| https://github.com/coder/coder/pull/1629#pullrequestreview-998223056 |
|
View reviewed changes
| https://github.com/coder/coder/pull/1629/files/75b62969d43d04fc532656792f6232fcf741253b |
| pty/ptytest/ptytest_test.go | https://github.com/coder/coder/pull/1629/files/75b62969d43d04fc532656792f6232fcf741253b#diff-6cab72b848eb50532e9a947a3d1ec605b94dadca33bd505b2b226301eeab23e8 |
| Please reload this page | https://github.com/coder/coder/pull/1629 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| Jun 7, 2022 | https://github.com/coder/coder/pull/1629#event-6761779075 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| 6da4810 | https://github.com/coder/coder/commit/6da4810a5e71c7273a07049fc9db587c2613ebe3 |
| Jun 7, 2022 | https://github.com/coder/coder/pull/1629#event-6761779139 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| June 7, 2022 14:08 | https://github.com/coder/coder/pull/1629#event-6761779247 |
| https://github.co/hiddenchars |
| https://github.com/coder/coder/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F1629 |
|
| https://github.com/Emyrk |
|
Emyrk
| https://github.com/Emyrk |
|
| https://github.com/coder/coder/pull/1629/files/75b62969d43d04fc532656792f6232fcf741253b |
| Please reload this page | https://github.com/coder/coder/pull/1629 |
| Please reload this page | https://github.com/coder/coder/pull/1629 |
|
| https://github.com/mafredri |
|
| https://github.com/ammario |
|
| https://github.com/Emyrk |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |