René's URL Explorer Experiment


Title: chore: Add (skipped) `ptytest` test that hangs on Intel Mac (and Windows) by mafredri · Pull Request #1629 · coder/coder · GitHub

Open Graph Title: chore: Add (skipped) `ptytest` test that hangs on Intel Mac (and Windows) by mafredri · Pull Request #1629 · coder/coder

X Title: chore: Add (skipped) `ptytest` test that hangs on Intel Mac (and Windows) by mafredri · Pull Request #1629 · coder/coder

Description: Secure environments for developers and their agents - chore: Add (skipped) `ptytest` test that hangs on Intel Mac (and Windows) by mafredri · Pull Request #1629 · coder/coder

Open Graph Description: This (draft) PR adds a test that breaks ptytest with unconsumed output on Intel Macs. This is left open to inform / opportunity to investigate. To reproduce: go test ./pty/ptytest -v -run=TestPtyte...

X Description: This (draft) PR adds a test that breaks ptytest with unconsumed output on Intel Macs. This is left open to inform / opportunity to investigate. To reproduce: go test ./pty/ptytest -v -run=TestPtyte...

Opengraph URL: https://github.com/coder/coder/pull/1629

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ba3a373b-a1c8-cc30-8744-b85ea3ce1994
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD3A2:3A73AA:1EA593E:26D4EF6:6B01A19C
html-safe-nonce13135f4ec7f1cf47d5dfb6a9f77277cdd914f07549270c2baf2c923b28b11500
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEM0EyOjNBNzNBQToxRUE1OTNFOjI2RDRFRjY6NkIwMUExOUMiLCJ2aXNpdG9yX2lkIjoiNTcxNDkwMzIzODQwNzQ2MzMyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacacae1deb5e04b24416cff8308424e7a6a2fdd844d589efd7e82a9397955b4797
hovercard-subject-tagpull_request:942918716
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/1629/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3313f7e3c63f6d9598e9d2764626b54d9697e52b68dd0e379d1795992718972b/coder/coder/pull/1629
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3313f7e3c63f6d9598e9d2764626b54d9697e52b68dd0e379d1795992718972b/coder/coder/pull/1629
og:image:altThis (draft) PR adds a test that breaks ptytest with unconsumed output on Intel Macs. This is left open to inform / opportunity to investigate. To reproduce: go test ./pty/ptytest -v -run=TestPtyte...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemafredri
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/coder/coder/pull/1629#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F1629
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F1629
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/pull/1629
Reloadhttps://github.com/coder/coder/pull/1629
Reloadhttps://github.com/coder/coder/pull/1629
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
https://github.com/coder/coder
mafredrihttps://github.com/mafredri
mainhttps://github.com/coder/coder/tree/main
mafredri/draft-ptytest-hangs-on-macos-when-output-is-not-consumedhttps://github.com/coder/coder/tree/mafredri/draft-ptytest-hangs-on-macos-when-output-is-not-consumed
Conversationhttps://github.com/coder/coder/pull/1629
Commits7 (7)https://github.com/coder/coder/pull/1629/commits
Checkshttps://github.com/coder/coder/pull/1629/checks
Files changedhttps://github.com/coder/coder/pull/1629/files
chore: Add (skipped) ptytest test that hangs on Intel Mac (and Windows)https://github.com/coder/coder/pull/1629#top
mafredrihttps://github.com/mafredri
mainhttps://github.com/coder/coder/tree/main
mafredri/draft-ptytest-hangs-on-macos-when-output-is-not-consumedhttps://github.com/coder/coder/tree/mafredri/draft-ptytest-hangs-on-macos-when-output-is-not-consumed
https://github.com/mafredri
mafredrihttps://github.com/mafredri
May 20, 2022https://github.com/coder/coder/pull/1629#issue-1243371453
trace.txthttps://github.com/coder/coder/files/8741887/trace.txt
@Emyrkhttps://github.com/Emyrk
Please reload this pagehttps://github.com/coder/coder/pull/1629
https://github.com/mafredri
mafredrihttps://github.com/mafredri
May 20, 2022https://github.com/coder/coder/pull/1629#issuecomment-1133105192
#1591https://github.com/coder/coder/pull/1591
Please reload this pagehttps://github.com/coder/coder/pull/1629
https://github.com/ammario
ammariohttps://github.com/ammario
Jun 7, 2022https://github.com/coder/coder/pull/1629#issuecomment-1148104979
Please reload this pagehttps://github.com/coder/coder/pull/1629
mafredrihttps://github.com/mafredri
June 7, 2022 12:40https://github.com/coder/coder/pull/1629#commits-pushed-bf3a378
https://github.com/mafredri
bug: Add test that breaks ptytest on Intel Machttps://github.com/coder/coder/pull/1629/commits/bf3a378139c7a43955a82f7cfa321e1d8f6f272a
bf3a378https://github.com/coder/coder/pull/1629/commits/bf3a378139c7a43955a82f7cfa321e1d8f6f272a
https://github.com/mafredri
Simplify test, no need to output more than one linehttps://github.com/coder/coder/pull/1629/commits/65f330410f86305df0c64baedf9280b5b3fbc52e
65f3304https://github.com/coder/coder/pull/1629/commits/65f330410f86305df0c64baedf9280b5b3fbc52e
https://github.com/Emyrk
https://github.com/mafredri
Add test using cobra cmdhttps://github.com/coder/coder/pull/1629/commits/638acb6f24d3a5a3b3a237b72bac97725247e735
638acb6https://github.com/coder/coder/pull/1629/commits/638acb6f24d3a5a3b3a237b72bac97725247e735
https://github.com/mafredri
Create proper test to fully reproduce the issue on macOShttps://github.com/coder/coder/pull/1629/commits/7692c5d249acffa8ae46f41f28e72201d17207b0
7692c5dhttps://github.com/coder/coder/pull/1629/commits/7692c5d249acffa8ae46f41f28e72201d17207b0
https://github.com/mafredri
mafredrihttps://github.com/mafredri
force-pushedhttps://github.com/coder/coder/compare/ad76f646b570fe23b497d9c7c1b8633ddb9e0ee3..7692c5d249acffa8ae46f41f28e72201d17207b0
ad76f64https://github.com/coder/coder/commit/ad76f646b570fe23b497d9c7c1b8633ddb9e0ee3
7692c5dhttps://github.com/coder/coder/commit/7692c5d249acffa8ae46f41f28e72201d17207b0
Compare https://github.com/coder/coder/compare/ad76f646b570fe23b497d9c7c1b8633ddb9e0ee3..7692c5d249acffa8ae46f41f28e72201d17207b0
June 7, 2022 09:57https://github.com/coder/coder/pull/1629#event-6759780187
https://github.com/mafredri
Add large outputhttps://github.com/coder/coder/pull/1629/commits/034cfa64d6848da1a380864283f55763f84663e9
034cfa6https://github.com/coder/coder/pull/1629/commits/034cfa64d6848da1a380864283f55763f84663e9
https://github.com/mafredri
mafredrihttps://github.com/mafredri
force-pushedhttps://github.com/coder/coder/compare/21bcca75115a688a3186d870948a36a3f0836405..034cfa64d6848da1a380864283f55763f84663e9
21bcca7https://github.com/coder/coder/commit/21bcca75115a688a3186d870948a36a3f0836405
034cfa6https://github.com/coder/coder/commit/034cfa64d6848da1a380864283f55763f84663e9
Compare https://github.com/coder/coder/compare/21bcca75115a688a3186d870948a36a3f0836405..034cfa64d6848da1a380864283f55763f84663e9
June 7, 2022 10:03https://github.com/coder/coder/pull/1629#event-6759827736
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Jun 7, 2022 https://github.com/coder/coder/pull/1629#ref-issue-1263327001
Tests using Cobra with ptytest can hang on macOS (and Windows) unless the output is consumed #2122 https://github.com/coder/coder/issues/2122
https://github.com/mafredri
mafredrihttps://github.com/mafredri
June 7, 2022 13:44https://github.com/coder/coder/pull/1629#event-6761557349
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Jun 7, 2022https://github.com/coder/coder/pull/1629#event-6761563527
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Emyrkhttps://github.com/Emyrk
June 7, 2022 13:45https://github.com/coder/coder/pull/1629#event-6761566537
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Jun 7, 2022https://github.com/coder/coder/pull/1629#event-6761569759
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Jun 7, 2022https://github.com/coder/coder/pull/1629#issuecomment-1148701636
@ammariohttps://github.com/ammario
#2122https://github.com/coder/coder/issues/2122
Please reload this pagehttps://github.com/coder/coder/pull/1629
https://github.com/mafredri
Skip failing tests on darwin and windowshttps://github.com/coder/coder/pull/1629/commits/487f338fa4bd256640698934e9ed1fdf3567d1ad
487f338https://github.com/coder/coder/pull/1629/commits/487f338fa4bd256640698934e9ed1fdf3567d1ad
https://github.com/mafredri
mafredrihttps://github.com/mafredri
force-pushedhttps://github.com/coder/coder/compare/e7fad00900c027be08b92d1be43059be37e8470b..487f338fa4bd256640698934e9ed1fdf3567d1ad
e7fad00https://github.com/coder/coder/commit/e7fad00900c027be08b92d1be43059be37e8470b
487f338https://github.com/coder/coder/commit/487f338fa4bd256640698934e9ed1fdf3567d1ad
Compare https://github.com/coder/coder/compare/e7fad00900c027be08b92d1be43059be37e8470b..487f338fa4bd256640698934e9ed1fdf3567d1ad
June 7, 2022 13:48https://github.com/coder/coder/pull/1629#event-6761594916
https://github.com/mafredri
chore: Write better skip messagehttps://github.com/coder/coder/pull/1629/commits/75b62969d43d04fc532656792f6232fcf741253b
75b6296https://github.com/coder/coder/pull/1629/commits/75b62969d43d04fc532656792f6232fcf741253b
https://github.com/Emyrk
Emyrkhttps://github.com/Emyrk
Jun 7, 2022 https://github.com/coder/coder/pull/1629#pullrequestreview-998223056
View reviewed changes https://github.com/coder/coder/pull/1629/files/75b62969d43d04fc532656792f6232fcf741253b
pty/ptytest/ptytest_test.gohttps://github.com/coder/coder/pull/1629/files/75b62969d43d04fc532656792f6232fcf741253b#diff-6cab72b848eb50532e9a947a3d1ec605b94dadca33bd505b2b226301eeab23e8
Please reload this pagehttps://github.com/coder/coder/pull/1629
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Jun 7, 2022https://github.com/coder/coder/pull/1629#event-6761779075
https://github.com/mafredri
mafredrihttps://github.com/mafredri
6da4810https://github.com/coder/coder/commit/6da4810a5e71c7273a07049fc9db587c2613ebe3
Jun 7, 2022https://github.com/coder/coder/pull/1629#event-6761779139
https://github.com/mafredri
mafredrihttps://github.com/mafredri
June 7, 2022 14:08https://github.com/coder/coder/pull/1629#event-6761779247
https://github.co/hiddenchars
https://github.com/coder/coder/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F1629
https://github.com/Emyrk
Emyrk https://github.com/Emyrk
https://github.com/coder/coder/pull/1629/files/75b62969d43d04fc532656792f6232fcf741253b
Please reload this pagehttps://github.com/coder/coder/pull/1629
Please reload this pagehttps://github.com/coder/coder/pull/1629
https://github.com/mafredri
https://github.com/ammario
https://github.com/Emyrk
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.