| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:522315c4-e2cf-dd0d-b584-f5881c33de75 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E908:A99C2:21FB20D:2B3C8B9:6B01633C |
| html-safe-nonce | f1b52ddddf0591302d9b90cedab5a8d455aedb63e1f38da83b5cea22e6579507 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTA4OkE5OUMyOjIxRkIyMEQ6MkIzQzhCOTo2QjAxNjMzQyIsInZpc2l0b3JfaWQiOiI2NjQyNzQ4ODY2MzM1NDY1NTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 248767377b9eee316da2a2045f303e5f117830bde6b5f3581d57c7fd9874e3e0 |
| hovercard-subject-tag | pull_request:2203029647 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/15669/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/6e3b848d6b31e63814edda0309e1eff0de5f1b784e285ff0c8e5b27cc7f89590/coder/coder/pull/15669 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6e3b848d6b31e63814edda0309e1eff0de5f1b784e285ff0c8e5b27cc7f89590/coder/coder/pull/15669 |
| og:image:alt | NOTE: this PR is blocked; we want to first introduce this feature to port shares, as it has transpired that that use-case is far more common. It would be awkward to get this PR into the next releas... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | dannykopping |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/coder/coder git https://github.com/coder/coder.git |
| octolytics-dimension-user_id | 95932066 |
| octolytics-dimension-user_login | coder |
| octolytics-dimension-repository_id | 440752086 |
| octolytics-dimension-repository_nwo | coder/coder |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 440752086 |
| octolytics-dimension-repository_network_root_nwo | coder/coder |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/coder/coder/pull/15669#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F15669 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F15669 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder |
| Reload | https://github.com/coder/coder/pull/15669 |
| Reload | https://github.com/coder/coder/pull/15669 |
| Reload | https://github.com/coder/coder/pull/15669 |
| coder | https://github.com/coder |
| coder | https://github.com/coder/coder |
| Code | https://github.com/coder/coder |
| Issues320 (320) | https://github.com/coder/coder/issues |
| Pull requests470 (470) | https://github.com/coder/coder/pulls |
| Discussions | https://github.com/coder/coder/discussions |
| Actions | https://github.com/coder/coder/actions |
| Projects | https://github.com/coder/coder/projects |
| Security and quality49 (49) | https://github.com/coder/coder/security |
| Insights | https://github.com/coder/coder/insights |
| https://github.com/coder/coder |
| dannykopping | https://github.com/dannykopping |
| main | https://github.com/coder/coder/tree/main |
| dk/cors | https://github.com/coder/coder/tree/dk/cors |
| Conversation | https://github.com/coder/coder/pull/15669 |
| Commits12 (12) | https://github.com/coder/coder/pull/15669/commits |
| Checks | https://github.com/coder/coder/pull/15669/checks |
| Files changed | https://github.com/coder/coder/pull/15669/files |
| feat: bypass built-in CORS handling for workspace apps | https://github.com/coder/coder/pull/15669#top |
| dannykopping | https://github.com/dannykopping |
| main | https://github.com/coder/coder/tree/main |
| dk/cors | https://github.com/coder/coder/tree/dk/cors |
|
| https://github.com/dannykopping |
| dannykopping | https://github.com/dannykopping |
| Nov 27, 2024 | https://github.com/coder/coder/pull/15669#issue-2697873490 |
| Please reload this page | https://github.com/coder/coder/pull/15669 |
| #15096 | https://github.com/coder/coder/issues/15096 |
| coder/terraform-provider-coder#309 | https://github.com/coder/terraform-provider-coder/pull/309 |
| port shares | https://coder.com/docs/admin/networking/port-forwarding#sharing-ports |
| Please reload this page | https://github.com/coder/coder/pull/15669 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| dannykopping | https://github.com/dannykopping |
| Nov 27, 2024 | https://github.com/coder/coder/pull/15669#event-15449817247 |
| https://github.com/dannykopping |
| dannykopping | https://github.com/dannykopping |
|
Nov 27, 2024
| https://github.com/coder/coder/pull/15669#pullrequestreview-2464483210 |
|
View reviewed changes
| https://github.com/coder/coder/pull/15669/files |
| coderd/workspaceapps/proxy.go | https://github.com/coder/coder/pull/15669/files#diff-8db7601b3eb4753c0d7cbea21538f61fdfe56c6d3d278b2b34da9a9ede9d064f |
| dannykopping | https://github.com/dannykopping |
| Nov 27, 2024 | https://github.com/coder/coder/pull/15669#discussion_r1860326875 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/15669 |
| https://github.com/dannykopping |
| dannykopping | https://github.com/dannykopping |
| force-pushed | https://github.com/coder/coder/compare/c5c74d11aa37d31613cf07569d8c6d7abbfce3e5..ec3bac67471e640639de719a7a1cb01e984568fa |
| c5c74d1 | https://github.com/coder/coder/commit/c5c74d11aa37d31613cf07569d8c6d7abbfce3e5 |
| ec3bac6 | https://github.com/coder/coder/commit/ec3bac67471e640639de719a7a1cb01e984568fa |
|
Compare
| https://github.com/coder/coder/compare/c5c74d11aa37d31613cf07569d8c6d7abbfce3e5..ec3bac67471e640639de719a7a1cb01e984568fa |
| November 27, 2024 12:11 | https://github.com/coder/coder/pull/15669#event-15451766670 |
| https://github.com/dannykopping |
| dannykopping | https://github.com/dannykopping |
|
Nov 27, 2024
| https://github.com/coder/coder/pull/15669#ref-issue-2589850983 |
|
Workspace applications CORS handling prevents external requests to apps
#15096
| https://github.com/coder/coder/issues/15096 |
| https://github.com/dannykopping |
| dannykopping | https://github.com/dannykopping |
| force-pushed | https://github.com/coder/coder/compare/4c6beb5461adaea2f5ea4330c1cfd3703faabb3c..f91f22016652ddee83074fc1abc1f2eab3b71530 |
| 4c6beb5 | https://github.com/coder/coder/commit/4c6beb5461adaea2f5ea4330c1cfd3703faabb3c |
| f91f220 | https://github.com/coder/coder/commit/f91f22016652ddee83074fc1abc1f2eab3b71530 |
|
Compare
| https://github.com/coder/coder/compare/4c6beb5461adaea2f5ea4330c1cfd3703faabb3c..f91f22016652ddee83074fc1abc1f2eab3b71530 |
| November 28, 2024 11:12 | https://github.com/coder/coder/pull/15669#event-15464028309 |
| dannykopping | https://github.com/dannykopping |
| November 28, 2024 12:04 | https://github.com/coder/coder/pull/15669#commits-pushed-0dc7ca3 |
|
| https://github.com/dannykopping |
| Working implementation | https://github.com/coder/coder/pull/15669/commits/0dc7ca368f34d22dcfbf1f75501da6561e25c084 |
| 0dc7ca3 | https://github.com/coder/coder/pull/15669/commits/0dc7ca368f34d22dcfbf1f75501da6561e25c084 |
|
| https://github.com/dannykopping |
| Rename CorsBehavior to CORSBehavior | https://github.com/coder/coder/pull/15669/commits/3c0e33aa997d53c40e8138bb8504892d248beb63 |
| 3c0e33a | https://github.com/coder/coder/pull/15669/commits/3c0e33aa997d53c40e8138bb8504892d248beb63 |
|
| https://github.com/dannykopping |
| Hard & simplify CORORS handling logic | https://github.com/coder/coder/pull/15669/commits/a4d3c8d29fe3ebff6dc04edfeb04e8e39ed0a519 |
| a4d3c8d | https://github.com/coder/coder/pull/15669/commits/a4d3c8d29fe3ebff6dc04edfeb04e8e39ed0a519 |
|
| https://github.com/dannykopping |
| Minor fixes | https://github.com/coder/coder/pull/15669/commits/873c3e45f5162374474f6a13af6f0e854a995e83 |
| 873c3e4 | https://github.com/coder/coder/pull/15669/commits/873c3e45f5162374474f6a13af6f0e854a995e83 |
|
| https://github.com/dannykopping |
| Appeasing the linter | https://github.com/coder/coder/pull/15669/commits/65f984f87cc33c7900cf4e820968ab37b4998db0 |
| 65f984f | https://github.com/coder/coder/pull/15669/commits/65f984f87cc33c7900cf4e820968ab37b4998db0 |
|
| https://github.com/dannykopping |
| Move type def to codersdk | https://github.com/coder/coder/pull/15669/commits/1f0b34c178bd759ba36ea66bc69388f8731f4925 |
| 1f0b34c | https://github.com/coder/coder/pull/15669/commits/1f0b34c178bd759ba36ea66bc69388f8731f4925 |
|
| https://github.com/dannykopping |
| Appease the linter, again | https://github.com/coder/coder/pull/15669/commits/5be547762bb9f8ad9be9d9b593b5ca6ed60f3ec8 |
| 5be5477 | https://github.com/coder/coder/pull/15669/commits/5be547762bb9f8ad9be9d9b593b5ca6ed60f3ec8 |
|
| https://github.com/dannykopping |
| Fix migration num | https://github.com/coder/coder/pull/15669/commits/ddbbaa948b9e288896d7e4643cfd028371a2397c |
| ddbbaa9 | https://github.com/coder/coder/pull/15669/commits/ddbbaa948b9e288896d7e4643cfd028371a2397c |
|
| https://github.com/dannykopping |
| Removing unnecessary header check | https://github.com/coder/coder/pull/15669/commits/63c1852d30bbad016c3a13ddc3752dff4685e42b |
| 63c1852 | https://github.com/coder/coder/pull/15669/commits/63c1852d30bbad016c3a13ddc3752dff4685e42b |
| https://github.com/dannykopping |
| dannykopping | https://github.com/dannykopping |
| force-pushed | https://github.com/coder/coder/compare/79ce3567862a530b8d79d1fee8a0f849370a1a49..63c1852d30bbad016c3a13ddc3752dff4685e42b |
| 79ce356 | https://github.com/coder/coder/commit/79ce3567862a530b8d79d1fee8a0f849370a1a49 |
| 63c1852 | https://github.com/coder/coder/commit/63c1852d30bbad016c3a13ddc3752dff4685e42b |
|
Compare
| https://github.com/coder/coder/compare/79ce3567862a530b8d79d1fee8a0f849370a1a49..63c1852d30bbad016c3a13ddc3752dff4685e42b |
| November 28, 2024 14:21 | https://github.com/coder/coder/pull/15669#event-15466252789 |
| https://github.com/dannykopping |
| dannykopping | https://github.com/dannykopping |
| Nov 28, 2024 | https://github.com/coder/coder/pull/15669#event-15466297774 |
| dannykopping | https://github.com/dannykopping |
| November 28, 2024 14:56 | https://github.com/coder/coder/pull/15669#commits-pushed-976cd78 |
|
| https://github.com/dannykopping |
| Improve tests | https://github.com/coder/coder/pull/15669/commits/976cd78d90a878bb88fd5a1d7c9cdd3a08409d0e |
| 976cd78 | https://github.com/coder/coder/pull/15669/commits/976cd78d90a878bb88fd5a1d7c9cdd3a08409d0e |
|
| https://github.com/dannykopping |
| Merge branch 'main' of | https://github.com/coder/coder/pull/15669/commits/9f9068fff7a6e585eef81524ceb4ad9aaa830d1c |
| https://github.com/coder/coder | https://github.com/coder/coder |
| into dk/cors | https://github.com/coder/coder/pull/15669/commits/9f9068fff7a6e585eef81524ceb4ad9aaa830d1c |
| 9f9068f | https://github.com/coder/coder/pull/15669/commits/9f9068fff7a6e585eef81524ceb4ad9aaa830d1c |
|
| https://github.com/dannykopping |
| Comprehensive CORS test suite for both request & response | https://github.com/coder/coder/pull/15669/commits/3dc00e1dc58d50f0c033b9c63d79e8fda9afcbb4 |
| 3dc00e1 | https://github.com/coder/coder/pull/15669/commits/3dc00e1dc58d50f0c033b9c63d79e8fda9afcbb4 |
|
feat: bypass built-in CORS handling for shared ports
#15684
| https://github.com/coder/coder/pull/15684 |
|
chore: add tests for default CORS behavior
#15685
| https://github.com/coder/coder/pull/15685 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
stale
| https://github.com/coder/coder/issues?q=state%3Aopen%20label%3Astale |
| Dec 6, 2024 | https://github.com/coder/coder/pull/15669#event-15552600052 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Dec 9, 2024 | https://github.com/coder/coder/pull/15669#event-15575215629 |
| https://github.com/dannykopping |
| dannykopping | https://github.com/dannykopping |
| Dec 9, 2024 | https://github.com/coder/coder/pull/15669#issuecomment-2527001477 |
| Please reload this page | https://github.com/coder/coder/pull/15669 |
| https://github.com/dannykopping |
| dannykopping | https://github.com/dannykopping |
| Dec 9, 2024 | https://github.com/coder/coder/pull/15669#event-15577707487 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
stale
| https://github.com/coder/coder/issues?q=state%3Aopen%20label%3Astale |
| Dec 10, 2024 | https://github.com/coder/coder/pull/15669#event-15592275718 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
stale
| https://github.com/coder/coder/issues?q=state%3Aopen%20label%3Astale |
| Dec 19, 2024 | https://github.com/coder/coder/pull/15669#event-15710202302 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Dec 22, 2024 | https://github.com/coder/coder/pull/15669#event-15740506254 |
| https://github.com/Emyrk |
| Emyrk | https://github.com/Emyrk |
|
Apr 28, 2025
| https://github.com/coder/coder/pull/15669#ref-pullrequest-3026237171 |
|
feat: bypass built-in CORS handling for workspace apps
#17596
| https://github.com/coder/coder/pull/17596 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| May 30, 2025 00:07 | https://github.com/coder/coder/pull/15669#event-17876746823 |
| https://github.com/cstyan |
| cstyan | https://github.com/cstyan |
|
Jul 9, 2025
| https://github.com/coder/coder/pull/15669#ref-pullrequest-3193695958 |
|
feat: allow bypassing current CORS magic based on template config
#18706
| https://github.com/coder/coder/pull/18706 |
| cstyan | https://github.com/cstyan |
|
Jul 30, 2025
| https://github.com/coder/coder/pull/15669#ref-commit-ffbfaf2 |
|
| https://github.com/cstyan |
| feat: allow bypassing current CORS magic based on template config ( | https://github.com/coder/coder/commit/ffbfaf2a6f3df72f51c2e417bb8c2bf2d745f7ea |
| #1… | https://github.com/coder/coder/pull/18706 |
| ffbfaf2 | https://github.com/coder/coder/commit/ffbfaf2a6f3df72f51c2e417bb8c2bf2d745f7ea |
| …8706 | https://github.com/coder/coder/pull/18706 |
| #15096 | https://github.com/coder/coder/issues/15096 |
| @dannykopping | https://github.com/dannykopping |
| @Emyrk | https://github.com/Emyrk |
| #15669 | https://github.com/coder/coder/pull/15669 |
| #15684 | https://github.com/coder/coder/pull/15684 |
| #17596 | https://github.com/coder/coder/pull/17596 |
| https://github.co/hiddenchars |
| https://github.com/coder/coder/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F15669 |
|
| https://github.com/spikecurtis |
|
spikecurtis
| https://github.com/spikecurtis |
|
| https://github.com/mafredri |
|
mafredri
| https://github.com/mafredri |
| Please reload this page | https://github.com/coder/coder/pull/15669 |
|
| https://github.com/dannykopping |
|
dannykopping
| https://github.com/dannykopping |
|
stale
| https://github.com/coder/coder/issues?q=state%3Aopen%20label%3Astale |
| Please reload this page | https://github.com/coder/coder/pull/15669 |
|
| https://github.com/dannykopping |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |