| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:ba3c60a6-a826-19b1-e7fe-862bdd86896f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EB24:19AA62:24102A8:2DCAF78:6B018455 |
| html-safe-nonce | f57641d7bdfde2792c7d8410eb9f78a3d2c0e33a340ae2d57b5a871c677891f3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQjI0OjE5QUE2MjoyNDEwMkE4OjJEQ0FGNzg6NkIwMTg0NTUiLCJ2aXNpdG9yX2lkIjoiOTA4MjA0NDY3MDg5NjM0MjEwMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | f14801931f1e4aac6de023016da15240d90702f42386f8a836b3db3839d429f5 |
| hovercard-subject-tag | pull_request:2008396882 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/14200/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/39f2a08cec3347c5b6409e179aba44829bf3133424abc3624a4de04cd59153e3/coder/coder/pull/14200 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/39f2a08cec3347c5b6409e179aba44829bf3133424abc3624a4de04cd59153e3/coder/coder/pull/14200 |
| og:image:alt | Fixes #13988. See the issue for background information.
This PR:
allows Group members to see they are part of the group
allows Group members to see the total count of that group's members even... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | hugodutka |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/coder/coder git https://github.com/coder/coder.git |
| octolytics-dimension-user_id | 95932066 |
| octolytics-dimension-user_login | coder |
| octolytics-dimension-repository_id | 440752086 |
| octolytics-dimension-repository_nwo | coder/coder |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 440752086 |
| octolytics-dimension-repository_network_root_nwo | coder/coder |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/coder/coder/pull/14200#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F14200 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F14200 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder |
| Reload | https://github.com/coder/coder/pull/14200 |
| Reload | https://github.com/coder/coder/pull/14200 |
| Reload | https://github.com/coder/coder/pull/14200 |
| coder | https://github.com/coder |
| coder | https://github.com/coder/coder |
| Code | https://github.com/coder/coder |
| Issues320 (320) | https://github.com/coder/coder/issues |
| Pull requests470 (470) | https://github.com/coder/coder/pulls |
| Discussions | https://github.com/coder/coder/discussions |
| Actions | https://github.com/coder/coder/actions |
| Projects | https://github.com/coder/coder/projects |
| Security and quality49 (49) | https://github.com/coder/coder/security |
| Insights | https://github.com/coder/coder/insights |
| https://github.com/coder/coder |
| Emyrk | https://github.com/Emyrk |
| coder:main | https://github.com/coder/coder/tree/main |
| hugodutka:hugodutka/13988-group-member-read-permissions | https://github.com/hugodutka/coder/tree/hugodutka/13988-group-member-read-permissions |
| Conversation | https://github.com/coder/coder/pull/14200 |
| Commits24 (24) | https://github.com/coder/coder/pull/14200/commits |
| Checks | https://github.com/coder/coder/pull/14200/checks |
| Files changed | https://github.com/coder/coder/pull/14200/files |
| fix: allow group members to read group information | https://github.com/coder/coder/pull/14200#top |
| Emyrk | https://github.com/Emyrk |
| coder:main | https://github.com/coder/coder/tree/main |
| hugodutka:hugodutka/13988-group-member-read-permissions | https://github.com/hugodutka/coder/tree/hugodutka/13988-group-member-read-permissions |
|
| https://github.com/hugodutka |
| hugodutka | https://github.com/hugodutka |
| Aug 7, 2024 | https://github.com/coder/coder/pull/14200#issue-2453426540 |
| #13988 | https://github.com/coder/coder/issues/13988 |
| Please reload this page | https://github.com/coder/coder/pull/14200 |
| https://github.com/apps/cdr-bot |
| cdr-bot | https://github.com/apps/cdr-bot |
|
community
| https://github.com/coder/coder/issues?q=state%3Aopen%20label%3Acommunity |
| Aug 7, 2024 | https://github.com/coder/coder/pull/14200#event-13792106711 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| hugodutka | https://github.com/hugodutka |
| Aug 7, 2024 | https://github.com/coder/coder/pull/14200#event-13792108748 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Aug 7, 2024 | https://github.com/coder/coder/pull/14200#issuecomment-2273415368 |
| Please reload this page | https://github.com/coder/coder/pull/14200 |
| Please reload this page | https://github.com/coder/coder/pull/14200 |
| https://github.com/hugodutka |
| hugodutka | https://github.com/hugodutka |
| Aug 7, 2024 | https://github.com/coder/coder/pull/14200#issuecomment-2273420184 |
| Please reload this page | https://github.com/coder/coder/pull/14200 |
| cdrcommunity | https://github.com/cdrcommunity |
|
Aug 7, 2024
| https://github.com/coder/coder/pull/14200#ref-commit-6cfda9d |
|
| https://github.com/cdrcommunity |
| @hugodutka | https://github.com/hugodutka |
| has signed the CLA in | https://github.com/coder/cla/commit/6cfda9d11a20b0ab7d5366406f567ff177b934c3 |
| coder/coder#14200 | https://github.com/coder/coder/pull/14200 |
| 6cfda9d | https://github.com/coder/cla/commit/6cfda9d11a20b0ab7d5366406f567ff177b934c3 |
| https://github.com/Emyrk |
| Emyrk | https://github.com/Emyrk |
|
Aug 7, 2024
| https://github.com/coder/coder/pull/14200#pullrequestreview-2226214189 |
|
View reviewed changes
| https://github.com/coder/coder/pull/14200/files |
| Emyrk | https://github.com/Emyrk |
| https://github.com/coder/coder/pull/14200#pullrequestreview-2226214189 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://github.com/coder/coder/blob/main/coderd/database/sqlc.yaml#L77-L78 | https://github.com/coder/coder/blob/main/coderd/database/sqlc.yaml#L77-L78 |
| https://github.com/coder/coder/pull/13858/files | https://github.com/coder/coder/pull/13858/files |
| #14065 | https://github.com/coder/coder/pull/14065 |
| Please reload this page | https://github.com/coder/coder/pull/14200 |
| coderd/database/modelmethods.go | https://github.com/coder/coder/pull/14200/files#diff-9b7b281eff82445a14d67250af5555130ea829cd86d6a3f85cac99bfe72d63dc |
| Please reload this page | https://github.com/coder/coder/pull/14200 |
| codersdk/groups.go | https://github.com/coder/coder/pull/14200/files#diff-b18953a9b64b5e1a1447dfb943a72f1240e37634bbcbe76b97a053d457950cab |
| Please reload this page | https://github.com/coder/coder/pull/14200 |
| enterprise/coderd/coderd.go | https://github.com/coder/coder/pull/14200/files#diff-825bb7ea00a8dbe478aa6c0da271ef5ca7a62bf7d21fdc2889352b66e95ac46f |
| Please reload this page | https://github.com/coder/coder/pull/14200 |
| https://github.com/johnstcn |
| johnstcn | https://github.com/johnstcn |
|
Aug 8, 2024
| https://github.com/coder/coder/pull/14200#pullrequestreview-2227172196 |
|
View reviewed changes
| https://github.com/coder/coder/pull/14200/files |
| enterprise/coderd/groups.go | https://github.com/coder/coder/pull/14200/files#diff-65adc057d2ac768e23f0f0c4c88891a50f6d51db15bfc992a99adc638c886564 |
| Please reload this page | https://github.com/coder/coder/pull/14200 |
| https://github.com/hugodutka |
| hugodutka | https://github.com/hugodutka |
| Aug 8, 2024 | https://github.com/coder/coder/pull/14200#issuecomment-2275719159 |
| @Emyrk | https://github.com/Emyrk |
| InsertGroupMember | https://github.com/hugodutka/coder/blob/91ced7b77147d75c2fd6c39e19980c82b321e9a5/coderd/database/dbauthz/dbauthz.go#L2614 |
| DeleteGroupMemberFromGroup | https://github.com/hugodutka/coder/blob/91ced7b77147d75c2fd6c39e19980c82b321e9a5/coderd/database/dbauthz/dbauthz.go#L976 |
| Please reload this page | https://github.com/coder/coder/pull/14200 |
| https://github.com/Emyrk |
| Emyrk | https://github.com/Emyrk |
| Aug 8, 2024 | https://github.com/coder/coder/pull/14200#issuecomment-2275925004 |
| @Emyrk | https://github.com/Emyrk |
| InsertGroupMember | https://github.com/hugodutka/coder/blob/91ced7b77147d75c2fd6c39e19980c82b321e9a5/coderd/database/dbauthz/dbauthz.go#L2614 |
| DeleteGroupMemberFromGroup | https://github.com/hugodutka/coder/blob/91ced7b77147d75c2fd6c39e19980c82b321e9a5/coderd/database/dbauthz/dbauthz.go#L976 |
| users | https://github.com/hugodutka/coder/blob/91ced7b77147d75c2fd6c39e19980c82b321e9a5/coderd/database/dbauthz/dbauthz.go#L2179-L2186 |
| Please reload this page | https://github.com/coder/coder/pull/14200 |
| https://github.com/hugodutka |
| hugodutka | https://github.com/hugodutka |
| force-pushed | https://github.com/coder/coder/compare/3930c6b32ae53f90a09bd066010d354fab0c3534..e07e1d9e4e1a242fddb6b3cc35e81bdf4bb3b697 |
| 3930c6b | https://github.com/coder/coder/commit/3930c6b32ae53f90a09bd066010d354fab0c3534 |
| e07e1d9 | https://github.com/coder/coder/commit/e07e1d9e4e1a242fddb6b3cc35e81bdf4bb3b697 |
|
Compare
| https://github.com/coder/coder/compare/3930c6b32ae53f90a09bd066010d354fab0c3534..e07e1d9e4e1a242fddb6b3cc35e81bdf4bb3b697 |
| August 9, 2024 17:38 | https://github.com/coder/coder/pull/14200#event-13823860976 |
| https://github.com/hugodutka |
| hugodutka | https://github.com/hugodutka |
| Aug 9, 2024 | https://github.com/coder/coder/pull/14200#issuecomment-2278441412 |
| Please reload this page | https://github.com/coder/coder/pull/14200 |
| @Emyrk | https://github.com/Emyrk |
| Please reload this page | https://github.com/coder/coder/pull/14200 |
| https://github.com/Emyrk |
| Emyrk | https://github.com/Emyrk |
|
Aug 9, 2024
| https://github.com/coder/coder/pull/14200#pullrequestreview-2230866185 |
|
View reviewed changes
| https://github.com/coder/coder/pull/14200/files |
| Emyrk | https://github.com/Emyrk |
| https://github.com/coder/coder/pull/14200#pullrequestreview-2230866185 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #14223 | https://github.com/coder/coder/pull/14223 |
| Please reload this page | https://github.com/coder/coder/pull/14200 |
| coderd/database/migrations/000242_group_members_view.up.sql | https://github.com/coder/coder/pull/14200/files#diff-29811171e5796a54771ab5725e11a4f3b422dbf6c3365e8b05d070b7e1137c60 |
| Emyrk | https://github.com/Emyrk |
| Aug 9, 2024 | https://github.com/coder/coder/pull/14200#discussion_r1712003371 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://private-user-images.githubusercontent.com/5446298/356722393-8b4aa947-829c-4f32-930b-fdd952b23db2.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3OTUyNjE4MjcsIm5iZiI6MTc5NTI2MTUyNywicGF0aCI6Ii81NDQ2Mjk4LzM1NjcyMjM5My04YjRhYTk0Ny04MjljLTRmMzItOTMwYi1mZGQ5NTJiMjNkYjIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI2MTEyMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNjExMjFUMTE0NTI3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NjY5NTY1NmFjNWFjZTU5MmQ1YTY5ZDIzNTE0NzVjOGRhNDM2YWQyMzU1N2MxZDQyZDJiMmZlMzUwZjYwZTI0OSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmcmVzcG9uc2UtY29udGVudC10eXBlPWltYWdlJTJGcG5nIn0.9ld1sN8Jvd4Os-twUZIOwyphG0VA806e-dKIkYBEP0A |
| Please reload this page | https://github.com/coder/coder/pull/14200 |
| coderd/database/modelmethods.go | https://github.com/coder/coder/pull/14200/files#diff-9b7b281eff82445a14d67250af5555130ea829cd86d6a3f85cac99bfe72d63dc |
| Please reload this page | https://github.com/coder/coder/pull/14200 |
| coderd/database/dbmem/dbmem.go | https://github.com/coder/coder/pull/14200/files#diff-f3e0e4382affffaed8cce6d7c5b37168276ad7f554f476faa49ff34e2918b657 |
| Emyrk | https://github.com/Emyrk |
| Aug 9, 2024 | https://github.com/coder/coder/pull/14200#discussion_r1712163230 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/14200 |
| https://github.com/hugodutka |
| hugodutka | https://github.com/hugodutka |
| force-pushed | https://github.com/coder/coder/compare/e07e1d9e4e1a242fddb6b3cc35e81bdf4bb3b697..49297b2d9f39942f9b8c1e27dfdb046a34f518bd |
| e07e1d9 | https://github.com/coder/coder/commit/e07e1d9e4e1a242fddb6b3cc35e81bdf4bb3b697 |
| 49297b2 | https://github.com/coder/coder/commit/49297b2d9f39942f9b8c1e27dfdb046a34f518bd |
|
Compare
| https://github.com/coder/coder/compare/e07e1d9e4e1a242fddb6b3cc35e81bdf4bb3b697..49297b2d9f39942f9b8c1e27dfdb046a34f518bd |
| August 12, 2024 11:44 | https://github.com/coder/coder/pull/14200#event-13847104202 |
| https://github.com/Emyrk |
| Emyrk | https://github.com/Emyrk |
| Aug 12, 2024 | https://github.com/coder/coder/pull/14200#issuecomment-2284018529 |
| coder/coderd/database/dbauthz/groupsauth_test.go | https://github.com/coder/coder/blob/8af8c77e2a9eb1abd20f8070fbf22a04a853f88e/coderd/database/dbauthz/groupsauth_test.go#L114-L130 |
| 8af8c77 | https://github.com/coder/coder/commit/8af8c77e2a9eb1abd20f8070fbf22a04a853f88e |
| Please reload this page | https://github.com/coder/coder/pull/14200 |
| https://github.com/Emyrk |
| Emyrk | https://github.com/Emyrk |
|
Aug 12, 2024
| https://github.com/coder/coder/pull/14200#ref-issue-2454394569 |
|
Account settings page currently lists the current groups a user is in. Should either replace, or include which organizations
#14213
| https://github.com/coder/coder/issues/14213 |
| hugodutka | https://github.com/hugodutka |
| August 12, 2024 19:34 | https://github.com/coder/coder/pull/14200#commits-pushed-2c6d037 |
|
| https://github.com/hugodutka |
| - allow group members to read basic Group info | https://github.com/coder/coder/pull/14200/commits/2c6d037ceba5495a96ee4615edfec6ea53461589 |
| 2c6d037 | https://github.com/coder/coder/pull/14200/commits/2c6d037ceba5495a96ee4615edfec6ea53461589 |
|
| https://github.com/hugodutka |
| rename ReducedGroup.member_count to ReducedGroup.total_member_count | https://github.com/coder/coder/pull/14200/commits/2409072260ce1f472a9b2279e292e0b668eff1d6 |
| 2409072 | https://github.com/coder/coder/pull/14200/commits/2409072260ce1f472a9b2279e292e0b668eff1d6 |
|
| https://github.com/hugodutka |
| use the reduced groups for user endpoint on the AccountPage | https://github.com/coder/coder/pull/14200/commits/5391c1505c3513dff9a4408c9b6c1dbd4003b698 |
| 5391c15 | https://github.com/coder/coder/pull/14200/commits/5391c1505c3513dff9a4408c9b6c1dbd4003b698 |
|
| https://github.com/hugodutka |
| rename UserWithGroupAndOrgID to GroupMemberRBACHelper | https://github.com/coder/coder/pull/14200/commits/5fcc218413847c0d8d99e108f03a827b89cfee8e |
| 5fcc218 | https://github.com/coder/coder/pull/14200/commits/5fcc218413847c0d8d99e108f03a827b89cfee8e |
|
| https://github.com/hugodutka |
| add the group_members_expanded db view | https://github.com/coder/coder/pull/14200/commits/2878c218bdf5f99d53fee032d689298221da7639 |
| 2878c21 | https://github.com/coder/coder/pull/14200/commits/2878c218bdf5f99d53fee032d689298221da7639 |
|
| https://github.com/hugodutka |
| add comment on migration | https://github.com/coder/coder/pull/14200/commits/3aa2a237321d35a33bd7d6d7b4d1ca6e890fa58b |
| 3aa2a23 | https://github.com/coder/coder/pull/14200/commits/3aa2a237321d35a33bd7d6d7b4d1ca6e890fa58b |
|
| https://github.com/hugodutka |
| rewrite group member queries to use the group_members_expanded view | https://github.com/coder/coder/pull/14200/commits/e428d4066757176d6f77eba2366b94ab55e80ff4 |
| e428d40 | https://github.com/coder/coder/pull/14200/commits/e428d4066757176d6f77eba2366b94ab55e80ff4 |
|
| https://github.com/hugodutka |
| add the RBAC ResourceGroupMember and add it to relevant roles | https://github.com/coder/coder/pull/14200/commits/13ca3a9290e5b97efeff147a2b110217818a48f9 |
| 13ca3a9 | https://github.com/coder/coder/pull/14200/commits/13ca3a9290e5b97efeff147a2b110217818a48f9 |
|
| https://github.com/hugodutka |
| rewrite GetGroupMembersByGroupID permission checks | https://github.com/coder/coder/pull/14200/commits/1027d9f58f6bfb3290e2529a2b7cbf2ffcae5caf |
| 1027d9f | https://github.com/coder/coder/pull/14200/commits/1027d9f58f6bfb3290e2529a2b7cbf2ffcae5caf |
|
| https://github.com/hugodutka |
| - make the GroupMember type contain all user fields | https://github.com/coder/coder/pull/14200/commits/0aea7f8821ff9d432dcc8bae72a1fb9d89c2ea29 |
| 0aea7f8 | https://github.com/coder/coder/pull/14200/commits/0aea7f8821ff9d432dcc8bae72a1fb9d89c2ea29 |
|
| https://github.com/hugodutka |
| simplify RBAC check on group member count | https://github.com/coder/coder/pull/14200/commits/e5c5f3f8a9e03591bb45cd48a10e7d58ae95d1e1 |
| e5c5f3f | https://github.com/coder/coder/pull/14200/commits/e5c5f3f8a9e03591bb45cd48a10e7d58ae95d1e1 |
|
| https://github.com/hugodutka |
| add the MemberTotalCount field to codersdk.Group | https://github.com/coder/coder/pull/14200/commits/16e95d014e5160cf92475c8a3db30323a06482f5 |
| 16e95d0 | https://github.com/coder/coder/pull/14200/commits/16e95d014e5160cf92475c8a3db30323a06482f5 |
|
| https://github.com/hugodutka |
| remove the reduced groups endpoint, revert frontend to use the groups… | https://github.com/coder/coder/pull/14200/commits/d3b4d7cfb9b8dd58223597df08dc082a49b05d21 |
| d3b4d7c | https://github.com/coder/coder/pull/14200/commits/d3b4d7cfb9b8dd58223597df08dc082a49b05d21 |
| hugodutka | https://github.com/hugodutka |
| August 12, 2024 19:34 | https://github.com/coder/coder/pull/14200#commits-pushed-b06f943 |
|
| https://github.com/hugodutka |
| revert "simplify RBAC check on group member count" - new query didn't… | https://github.com/coder/coder/pull/14200/commits/b06f943bd8c76a5440f7e613e0421b33fba5808b |
| b06f943 | https://github.com/coder/coder/pull/14200/commits/b06f943bd8c76a5440f7e613e0421b33fba5808b |
|
| https://github.com/hugodutka |
| display group.total_member_count instead of group.members.length … | https://github.com/coder/coder/pull/14200/commits/4a658743615a4b92c8a55a64f260dea3ae4c2793 |
| 4a65874 | https://github.com/coder/coder/pull/14200/commits/4a658743615a4b92c8a55a64f260dea3ae4c2793 |
|
| https://github.com/hugodutka |
| adjust total_member_count on MockGroup | https://github.com/coder/coder/pull/14200/commits/1f4dcc791a79fa7df504fa5605f7686ca1e4522d |
| 1f4dcc7 | https://github.com/coder/coder/pull/14200/commits/1f4dcc791a79fa7df504fa5605f7686ca1e4522d |
|
| https://github.com/hugodutka |
| fixes after rebase | https://github.com/coder/coder/pull/14200/commits/f1513e0e4c62a4c958575c0de6a82c4f2fc45f65 |
| f1513e0 | https://github.com/coder/coder/pull/14200/commits/f1513e0e4c62a4c958575c0de6a82c4f2fc45f65 |
|
| https://github.com/hugodutka |
| simplify RBAC check on GetGroupMembersCountByGroupID | https://github.com/coder/coder/pull/14200/commits/9ef0e0d5b51a0a2bde91901425c48329ec58e1e3 |
| 9ef0e0d | https://github.com/coder/coder/pull/14200/commits/9ef0e0d5b51a0a2bde91901425c48329ec58e1e3 |
|
| https://github.com/hugodutka |
| fix tests | https://github.com/coder/coder/pull/14200/commits/7627933034e292159b4e0df95be48e705c2f265a |
| 7627933 | https://github.com/coder/coder/pull/14200/commits/7627933034e292159b4e0df95be48e705c2f265a |
|
| https://github.com/hugodutka |
| resolve lint error | https://github.com/coder/coder/pull/14200/commits/1080b29d32b05577e8e4ab0ad1c36bbde3393014 |
| 1080b29 | https://github.com/coder/coder/pull/14200/commits/1080b29d32b05577e8e4ab0ad1c36bbde3393014 |
| https://github.com/hugodutka |
| hugodutka | https://github.com/hugodutka |
| force-pushed | https://github.com/coder/coder/compare/6d469d5f4e4d6c2c35fc6e7db25c2735cc9852b7..1080b29d32b05577e8e4ab0ad1c36bbde3393014 |
| 6d469d5 | https://github.com/coder/coder/commit/6d469d5f4e4d6c2c35fc6e7db25c2735cc9852b7 |
| 1080b29 | https://github.com/coder/coder/commit/1080b29d32b05577e8e4ab0ad1c36bbde3393014 |
|
Compare
| https://github.com/coder/coder/compare/6d469d5f4e4d6c2c35fc6e7db25c2735cc9852b7..1080b29d32b05577e8e4ab0ad1c36bbde3393014 |
| August 12, 2024 19:34 | https://github.com/coder/coder/pull/14200#event-13853847668 |
| hugodutka | https://github.com/hugodutka |
| August 12, 2024 20:11 | https://github.com/coder/coder/pull/14200#commits-pushed-19486da |
|
| https://github.com/hugodutka |
| update the groupsauth test to work with new group member permissions | https://github.com/coder/coder/pull/14200/commits/19486da8d710e772d4309c55869acfdc3a88444d |
| 19486da | https://github.com/coder/coder/pull/14200/commits/19486da8d710e772d4309c55869acfdc3a88444d |
|
| https://github.com/hugodutka |
| fix a mistake in test | https://github.com/coder/coder/pull/14200/commits/5373dd7d69f7d96f4aa18f6487389ea7fe86cd58 |
| 5373dd7 | https://github.com/coder/coder/pull/14200/commits/5373dd7d69f7d96f4aa18f6487389ea7fe86cd58 |
| https://github.com/hugodutka |
| hugodutka | https://github.com/hugodutka |
| Aug 12, 2024 | https://github.com/coder/coder/pull/14200#issuecomment-2284844625 |
| @Emyrk | https://github.com/Emyrk |
| Please reload this page | https://github.com/coder/coder/pull/14200 |
| https://github.com/Emyrk |
| Emyrk | https://github.com/Emyrk |
|
Aug 13, 2024
| https://github.com/coder/coder/pull/14200#pullrequestreview-2234204258 |
|
View reviewed changes
| https://github.com/coder/coder/pull/14200/files/5373dd7d69f7d96f4aa18f6487389ea7fe86cd58 |
| Emyrk | https://github.com/Emyrk |
| Please reload this page | https://github.com/coder/coder/pull/14200 |
| https://github.com/coder/coder/pull/14200#pullrequestreview-2234204258 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @hugodutka | https://github.com/hugodutka |
| group_members_expanded | https://github.com/coder/coder/blob/5373dd7d69f7d96f4aa18f6487389ea7fe86cd58/coderd/database/migrations/000242_group_members_view.up.sql#L11-L30 |
| #14213 | https://github.com/coder/coder/issues/14213 |
| Please reload this page | https://github.com/coder/coder/pull/14200 |
| coderd/database/dbgen/dbgen.go | https://github.com/coder/coder/pull/14200/files/5373dd7d69f7d96f4aa18f6487389ea7fe86cd58#diff-92f52d4b046f067db8464b8668167ea0c03e2f84d4e1d709e080641d494802de |
| Please reload this page | https://github.com/coder/coder/pull/14200 |
| coderd/database/dbmem/dbmem.go | https://github.com/coder/coder/pull/14200/files/5373dd7d69f7d96f4aa18f6487389ea7fe86cd58#diff-f3e0e4382affffaed8cce6d7c5b37168276ad7f554f476faa49ff34e2918b657 |
| Please reload this page | https://github.com/coder/coder/pull/14200 |
| coderd/database/modelmethods.go | https://github.com/coder/coder/pull/14200/files/5373dd7d69f7d96f4aa18f6487389ea7fe86cd58#diff-9b7b281eff82445a14d67250af5555130ea829cd86d6a3f85cac99bfe72d63dc |
| Emyrk | https://github.com/Emyrk |
| Aug 13, 2024 | https://github.com/coder/coder/pull/14200#discussion_r1714490146 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/14200 |
| coderd/rbac/roles_test.go | https://github.com/coder/coder/pull/14200/files/5373dd7d69f7d96f4aa18f6487389ea7fe86cd58#diff-b2b8b67ccf07b18411f3eb99c561912798bd3c06f2149cb3f1af76cbd08f4d44 |
| Emyrk | https://github.com/Emyrk |
| Aug 13, 2024 | https://github.com/coder/coder/pull/14200#discussion_r1714490524 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/14200 |
| hugodutka | https://github.com/hugodutka |
| August 13, 2024 08:39 | https://github.com/coder/coder/pull/14200#commits-pushed-08646da |
|
| https://github.com/hugodutka |
| make ErrUserDeleted private | https://github.com/coder/coder/pull/14200/commits/08646da3a8fefbb9e4512a2bae90ff43b8bb885a |
| 08646da | https://github.com/coder/coder/pull/14200/commits/08646da3a8fefbb9e4512a2bae90ff43b8bb885a |
|
| https://github.com/hugodutka |
| dbgen.GroupMember now fails when a supplied user or group doesn't e… | https://github.com/coder/coder/pull/14200/commits/4ec6adb680d9e667fbf3aa1053b79782ba8e7db3 |
| 4ec6adb | https://github.com/coder/coder/pull/14200/commits/4ec6adb680d9e667fbf3aa1053b79782ba8e7db3 |
| https://github.com/hugodutka |
| hugodutka | https://github.com/hugodutka |
| Aug 13, 2024 | https://github.com/coder/coder/pull/14200#issuecomment-2285698268 |
| @Emyrk | https://github.com/Emyrk |
| Please reload this page | https://github.com/coder/coder/pull/14200 |
| https://github.com/Emyrk |
| Emyrk | https://github.com/Emyrk |
|
Aug 13, 2024
| https://github.com/coder/coder/pull/14200#pullrequestreview-2235682274 |
|
View reviewed changes
| https://github.com/coder/coder/pull/14200/files/4ec6adb680d9e667fbf3aa1053b79782ba8e7db3 |
| Emyrk | https://github.com/Emyrk |
| https://github.com/coder/coder/pull/14200#pullrequestreview-2235682274 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/14200 |
| https://github.com/Emyrk |
| Emyrk | https://github.com/Emyrk |
| 6f9b1a3 | https://github.com/coder/coder/commit/6f9b1a39f456fbaa0ba64742a37cf4d6a0281f09 |
| Aug 13, 2024 | https://github.com/coder/coder/pull/14200#event-13864387056 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Aug 13, 2024 | https://github.com/coder/coder/pull/14200#event-13864390362 |
| https://github.co/hiddenchars |
| https://github.com/coder/coder/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F14200 |
|
| https://github.com/johnstcn |
|
johnstcn
| https://github.com/johnstcn |
|
| https://github.com/coder/coder/pull/14200/files/91ced7b77147d75c2fd6c39e19980c82b321e9a5 |
|
| https://github.com/Emyrk |
|
Emyrk
| https://github.com/Emyrk |
|
| https://github.com/coder/coder/pull/14200/files/4ec6adb680d9e667fbf3aa1053b79782ba8e7db3 |
| Please reload this page | https://github.com/coder/coder/pull/14200 |
|
| https://github.com/hugodutka |
|
hugodutka
| https://github.com/hugodutka |
|
community
| https://github.com/coder/coder/issues?q=state%3Aopen%20label%3Acommunity |
|
Users who only have role "Member" are not part of the "Everyone" group
| https://github.com/coder/coder/issues/13988 |
| Please reload this page | https://github.com/coder/coder/pull/14200 |
|
| https://github.com/hugodutka |
|
| https://github.com/Emyrk |
|
| https://github.com/johnstcn |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |