René's URL Explorer Experiment


Title: fix: Remove microsecond wait in peer.(*Channel) by kylecarbs · Pull Request #1270 · coder/coder · GitHub

Open Graph Title: fix: Remove microsecond wait in peer.(*Channel) by kylecarbs · Pull Request #1270 · coder/coder

X Title: fix: Remove microsecond wait in peer.(*Channel) by kylecarbs · Pull Request #1270 · coder/coder

Description: Secure environments for developers and their agents - fix: Remove microsecond wait in peer.(*Channel) by kylecarbs · Pull Request #1270 · coder/coder

Open Graph Description: This was implemented when our WebRTC code was much less hardened. It's likely this was a cause of some other problem. Closes #1076.

X Description: This was implemented when our WebRTC code was much less hardened. It's likely this was a cause of some other problem. Closes #1076.

Opengraph URL: https://github.com/coder/coder/pull/1270

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9e5440f6-25f7-a391-4420-039cb7b7d502
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idED96:38C5CF:25B09DC:2FD377F:6B0171B8
html-safe-nonce3a1fdd3413b99e0449fe238f1a1575e23c1ebc79aea12492f6b713b06bdb017d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDk2OjM4QzVDRjoyNUIwOURDOjJGRDM3N0Y6NkIwMTcxQjgiLCJ2aXNpdG9yX2lkIjoiNDYxNDMyNzYzMTI2ODExNDg3MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacbff6d0347ac231624a7f0bfba7a50a49e11beb5f614174e975cab99e13d3f3c0
hovercard-subject-tagpull_request:926602820
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/1270/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e63828fafdb1fcb97ee25c714ffc4877151bd9e6f25084a70519f1c5b10bcf49/coder/coder/pull/1270
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e63828fafdb1fcb97ee25c714ffc4877151bd9e6f25084a70519f1c5b10bcf49/coder/coder/pull/1270
og:image:altThis was implemented when our WebRTC code was much less hardened. It's likely this was a cause of some other problem. Closes #1076.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamekylecarbs
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/coder/coder/pull/1270#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F1270
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F1270
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/pull/1270
Reloadhttps://github.com/coder/coder/pull/1270
Reloadhttps://github.com/coder/coder/pull/1270
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
https://github.com/coder/coder
kylecarbshttps://github.com/kylecarbs
mainhttps://github.com/coder/coder/tree/main
peerracehttps://github.com/coder/coder/tree/peerrace
Conversationhttps://github.com/coder/coder/pull/1270
Commits1 (1)https://github.com/coder/coder/pull/1270/commits
Checkshttps://github.com/coder/coder/pull/1270/checks
Files changedhttps://github.com/coder/coder/pull/1270/files
fix: Remove microsecond wait in peer.(*Channel)https://github.com/coder/coder/pull/1270#top
kylecarbshttps://github.com/kylecarbs
mainhttps://github.com/coder/coder/tree/main
peerracehttps://github.com/coder/coder/tree/peerrace
https://github.com/kylecarbs
kylecarbshttps://github.com/kylecarbs
May 3, 2022https://github.com/coder/coder/pull/1270#issue-1224141072
#1076https://github.com/coder/coder/issues/1076
Please reload this pagehttps://github.com/coder/coder/pull/1270
https://github.com/kylecarbs
fix: Remove microsecond wait in peer.(*Channel)https://github.com/coder/coder/pull/1270/commits/815ef0baf3f1e5d5a8373842a235450acaed69fe
815ef0bhttps://github.com/coder/coder/pull/1270/commits/815ef0baf3f1e5d5a8373842a235450acaed69fe
#1076https://github.com/coder/coder/issues/1076
https://github.com/kylecarbs
kylecarbshttps://github.com/kylecarbs
coadlerhttps://github.com/coadler
May 3, 2022 13:55https://github.com/coder/coder/pull/1270#event-6540947516
https://github.com/kylecarbs
kylecarbshttps://github.com/kylecarbs
May 3, 2022https://github.com/coder/coder/pull/1270#event-6540947550
https://github.com/coadler
coadlerhttps://github.com/coadler
May 3, 2022 https://github.com/coder/coder/pull/1270#pullrequestreview-960429650
View reviewed changes https://github.com/coder/coder/pull/1270/files/815ef0baf3f1e5d5a8373842a235450acaed69fe
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
May 3, 2022https://github.com/coder/coder/pull/1270#issuecomment-1116132694
Please reload this pagehttps://github.com/coder/coder/pull/1270
Codecovhttps://codecov.io/gh/coder/coder/pull/1270?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=coder
#1270https://codecov.io/gh/coder/coder/pull/1270?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=coder
815ef0bhttps://github.com/coder/coder/commit/815ef0baf3f1e5d5a8373842a235450acaed69fe
mainhttps://codecov.io/gh/coder/coder/commit/5dcaf940b6f7f7615ded24709f40d0d3805a25fd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=coder
5dcaf94https://github.com/coder/coder/commit/5dcaf940b6f7f7615ded24709f40d0d3805a25fd
Impacted Fileshttps://codecov.io/gh/coder/coder/pull/1270?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=coder
peer/channel.gohttps://codecov.io/gh/coder/coder/pull/1270/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=coder#diff-cGVlci9jaGFubmVsLmdv
cli/configssh.gohttps://codecov.io/gh/coder/coder/pull/1270/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=coder#diff-Y2xpL2NvbmZpZ3NzaC5nbw==
peerbroker/dial.gohttps://codecov.io/gh/coder/coder/pull/1270/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=coder#diff-cGVlcmJyb2tlci9kaWFsLmdv
codersdk/provisionerdaemons.gohttps://codecov.io/gh/coder/coder/pull/1270/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=coder#diff-Y29kZXJzZGsvcHJvdmlzaW9uZXJkYWVtb25zLmdv
pty/ptytest/ptytest.gohttps://codecov.io/gh/coder/coder/pull/1270/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=coder#diff-cHR5L3B0eXRlc3QvcHR5dGVzdC5nbw==
peer/conn.gohttps://codecov.io/gh/coder/coder/pull/1270/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=coder#diff-cGVlci9jb25uLmdv
cli/templateinit.gohttps://codecov.io/gh/coder/coder/pull/1270/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=coder#diff-Y2xpL3RlbXBsYXRlaW5pdC5nbw==
agent/agent.gohttps://codecov.io/gh/coder/coder/pull/1270/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=coder#diff-YWdlbnQvYWdlbnQuZ28=
provisionerd/provisionerd.gohttps://codecov.io/gh/coder/coder/pull/1270/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=coder#diff-cHJvdmlzaW9uZXJkL3Byb3Zpc2lvbmVyZC5nbw==
provisioner/echo/serve.gohttps://codecov.io/gh/coder/coder/pull/1270/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=coder#diff-cHJvdmlzaW9uZXIvZWNoby9zZXJ2ZS5nbw==
14 morehttps://codecov.io/gh/coder/coder/pull/1270/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=coder
Continue to review full report at Codecovhttps://codecov.io/gh/coder/coder/pull/1270?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=coder
Click here to learn morehttps://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=coder
Codecovhttps://codecov.io/gh/coder/coder/pull/1270?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=coder
5dcaf94...815ef0bhttps://codecov.io/gh/coder/coder/pull/1270?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=coder
comment docshttps://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=coder
Please reload this pagehttps://github.com/coder/coder/pull/1270
https://github.com/kylecarbs
kylecarbshttps://github.com/kylecarbs
May 3, 2022 13:59https://github.com/coder/coder/pull/1270#event-6540980796
https://github.com/kylecarbs
kylecarbshttps://github.com/kylecarbs
60aa40ahttps://github.com/coder/coder/commit/60aa40a56f586fac90ee4c9c326f1584a1447ead
May 3, 2022https://github.com/coder/coder/pull/1270#event-6540991828
https://github.com/kylecarbs
kylecarbshttps://github.com/kylecarbs
May 3, 2022 14:01https://github.com/coder/coder/pull/1270#event-6540991984
https://github.com/misskniss
missknisshttps://github.com/misskniss
V2 BETA https://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22V2%20BETA%22
May 15, 2022https://github.com/coder/coder/pull/1270#event-6610735508
https://github.com/misskniss
missknisshttps://github.com/misskniss
V2 Betahttps://github.com/coder/coder/milestone/4
May 15, 2022https://github.com/coder/coder/pull/1270#event-6610736150
https://github.co/hiddenchars
https://github.com/coder/coder/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F1270
https://github.com/coadler
coadler https://github.com/coadler
https://github.com/coder/coder/pull/1270/files/815ef0baf3f1e5d5a8373842a235450acaed69fe
Please reload this pagehttps://github.com/coder/coder/pull/1270
https://github.com/kylecarbs
kylecarbs https://github.com/kylecarbs
V2 Beta https://github.com/coder/coder/milestone/4
Chore: Address race condition in channel.go https://github.com/coder/coder/issues/1076
Please reload this pagehttps://github.com/coder/coder/pull/1270
https://github.com/kylecarbs
https://github.com/coadler
https://github.com/misskniss
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.