René's URL Explorer Experiment


Title: Refactor coder agent SSH server for better process and connection control · Issue #6177 · coder/coder · GitHub

Open Graph Title: Refactor coder agent SSH server for better process and connection control · Issue #6177 · coder/coder

X Title: Refactor coder agent SSH server for better process and connection control · Issue #6177 · coder/coder

Description: This is, in part, to better support shutdown_scripts as part of #4677 and #6139. But improved user experience is also a big factor. Problem: Even though the coder agent initiates a graceful shutdown, the SSH connections are abruptly clos...

Open Graph Description: This is, in part, to better support shutdown_scripts as part of #4677 and #6139. But improved user experience is also a big factor. Problem: Even though the coder agent initiates a graceful shutdow...

X Description: This is, in part, to better support shutdown_scripts as part of #4677 and #6139. But improved user experience is also a big factor. Problem: Even though the coder agent initiates a graceful shutdow...

Opengraph URL: https://github.com/coder/coder/issues/6177

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Refactor coder agent SSH server for better process and connection control","articleBody":"This is, in part, to better support `shutdown_scripts` as part of #4677 and #6139. But improved user experience is also a big factor.\r\n\r\n**Problem:** Even though the coder agent initiates a graceful shutdown, the SSH connections are abruptly closed leaving SSH clients hanging. Similarly any process started inside an SSH session will be left running (e.g. `sleep 1000 &`) after the SSH server is closed.\r\n\r\nTo improve upon this, we need to:\r\n\r\n- [ ] ~~For all active sessions with TTYs, print a message that the workspace is closing~~\r\n\t- Let's defer this, see https://github.com/coder/coder/issues/6177#issuecomment-1471324332\r\n- [x] https://github.com/coder/coder/pull/7027\r\n- [ ] Send an interrupt (e.g. `SIGHUP`) to the commands/shells started via SSH\r\n\t- [ ] Wait for processes to exit (for some amount of time)\r\n\t- [ ] Sens `SIGKILL` to the remaining processes\r\n- [ ] Stop accepting new SSH connections (potentially allow `--debug` or similar flag overrides)\r\n- [ ] Do not run `shutdown_script` until the above is complete\r\n- [x] https://github.com/coder/coder/pull/7004\r\n\r\n~~I think it would make sense to refactor SSH functionality for the agent as a separate package, e.g. `agentssh` or `agent/sshd`.~~ See list above.\r\n\r\nFuture work/ideas:\r\n\r\n- Consider forking/forkexec `coder agent` to manage new SSH connections\r\n\t- This could allow the coder agent to be updated without terminating active connections","author":{"url":"https://github.com/mafredri","@type":"Person","name":"mafredri"},"datePublished":"2023-02-13T12:45:22Z","url":"https://github.com/coder/coder/issues/6177"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:dc92b234-271a-a5a5-5eff-ef9ee5b8ba12
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id9D08:3CBB3E:1C0E402:23BE6CF:6B019BBE
html-safe-nonceb9773a3081029bbf35cdadb8074f3f08195d771bfb1fe2b480dcee37d7e13e7e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RDA4OjNDQkIzRToxQzBFNDAyOjIzQkU2Q0Y6NkIwMTlCQkUiLCJ2aXNpdG9yX2lkIjoiNjI2NjE4MTgxMTQ3NTQyMjE0MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacceea213a2070fd6fc6f5f87efbc95031b5c5546ccbedd814ae242a2a9a4868fe
hovercard-subject-tagissue:1582286589
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/coder/coder/6177/issue_layout
twitter:imagehttps://opengraph.githubassets.com/e6610f004b6dc2ec0c6a3824c86ffb8f064c3c4f086360e582deed2490687972/coder/coder/issues/6177
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e6610f004b6dc2ec0c6a3824c86ffb8f064c3c4f086360e582deed2490687972/coder/coder/issues/6177
og:image:altThis is, in part, to better support shutdown_scripts as part of #4677 and #6139. But improved user experience is also a big factor. Problem: Even though the coder agent initiates a graceful shutdow...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemafredri
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/coder/coder/issues/6177#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fissues%2F6177
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fissues%2F6177
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/issues/6177
Reloadhttps://github.com/coder/coder/issues/6177
Reloadhttps://github.com/coder/coder/issues/6177
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
https://github.com/coder/coder
New issuehttps://github.com/login?return_to=https://github.com/coder/coder/issues/6177
New issuehttps://github.com/login?return_to=https://github.com/coder/coder/issues/6177
Refactor coder agent SSH server for better process and connection controlhttps://github.com/coder/coder/issues/6177#top
https://github.com/mafredri
cliArea: CLIhttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22cli%22
staleThis issue is like stale bread.https://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22stale%22
https://github.com/mafredri
mafredrihttps://github.com/mafredri
on Feb 13, 2023https://github.com/coder/coder/issues/6177#issue-1582286589
#4677https://github.com/coder/coder/issues/4677
#6139https://github.com/coder/coder/pull/6139
Refactor coder agent SSH server for better process and connection control #6177 (comment)https://github.com/coder/coder/issues/6177#issuecomment-1471324332
feat(agentssh): Gracefully close SSH sessions on Close #7027https://github.com/coder/coder/pull/7027
refactor(agent): Move SSH server into agentssh package #7004https://github.com/coder/coder/pull/7004
mafredrihttps://github.com/mafredri
featurehttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22feature%22
cliArea: CLIhttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22cli%22
on Feb 13, 2023https://github.com/coder/coder/issues/6177#event-8504063222
mafredrihttps://github.com/mafredri
on Feb 13, 2023https://github.com/coder/coder/issues/6177#event-8507140699
https://github.com/spikecurtis
spikecurtishttps://github.com/spikecurtis
on Mar 16, 2023https://github.com/coder/coder/issues/6177#issuecomment-1471324332
mafredrihttps://github.com/mafredri
on Apr 4, 2023https://github.com/coder/coder/issues/6177#event-8925366176
refactor(agent): Move SSH server into agentssh packagehttps://github.com/coder/coder/commit/37adb622eb7519b4cd275c0f2658bf2df96423d6
37adb62https://github.com/coder/coder/commit/37adb622eb7519b4cd275c0f2658bf2df96423d6
refactor(agent): Move SSH server into agentssh package (#7004)https://github.com/coder/coder/commit/0224426e5bb4d6d42ca093045f84e31015217fb8
#7004https://github.com/coder/coder/pull/7004
0224426https://github.com/coder/coder/commit/0224426e5bb4d6d42ca093045f84e31015217fb8
feat(agentssh): Gracefully close SSH sessions on Closehttps://github.com/coder/coder/commit/6a5d5c6e3ac32e32a1fbae349afe4beaf3d11002
6a5d5c6https://github.com/coder/coder/commit/6a5d5c6e3ac32e32a1fbae349afe4beaf3d11002
feat(agentssh): Gracefully close SSH sessions on Close (#7027)https://github.com/coder/coder/commit/aa660e0631cfd862775ef7f1dd31c1e7a5b69250
#7027https://github.com/coder/coder/pull/7027
aa660e0https://github.com/coder/coder/commit/aa660e0631cfd862775ef7f1dd31c1e7a5b69250
github-actionshttps://github.com/apps/github-actions
staleThis issue is like stale bread.https://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22stale%22
on Jul 6, 2023https://github.com/coder/coder/issues/6177#event-9737753726
github-actionshttps://github.com/apps/github-actions
not plannedhttps://github.com/coder/coder/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Anot-planned
on Jul 14, 2023https://github.com/coder/coder/issues/6177#event-9816527284
Sign up for freehttps://github.com/signup?return_to=https://github.com/coder/coder/issues/6177
Sign in to commenthttps://github.com/login?return_to=https://github.com/coder/coder/issues/6177
mafredrihttps://github.com/mafredri
cliArea: CLIhttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22cli%22
staleThis issue is like stale bread.https://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22stale%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.