René's URL Explorer Experiment


Title: Change agent startup script behavior from being never-ending to indicating the workspace is ready on end · Issue #5749 · coder/coder · GitHub

Open Graph Title: Change agent startup script behavior from being never-ending to indicating the workspace is ready on end · Issue #5749 · coder/coder

X Title: Change agent startup script behavior from being never-ending to indicating the workspace is ready on end · Issue #5749 · coder/coder

Description: A new requirement came up in relation to #2957. We need a way to discern between a workspace being ready and not. This is also relevant for vscode-coder where we might start a workspace for a user and want to wait for it to become ready....

Open Graph Description: A new requirement came up in relation to #2957. We need a way to discern between a workspace being ready and not. This is also relevant for vscode-coder where we might start a workspace for a user ...

X Description: A new requirement came up in relation to #2957. We need a way to discern between a workspace being ready and not. This is also relevant for vscode-coder where we might start a workspace for a user ...

Opengraph URL: https://github.com/coder/coder/issues/5749

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Change agent startup script behavior from being never-ending to indicating the workspace is ready on end","articleBody":"A new requirement came up in relation to #2957. We need a way to discern between a workspace being ready and not. This is also relevant for [`vscode-coder`](https://github.com/coder/vscode-coder) where we might start a workspace for a user and want to wait for it to become ready.\r\n\r\nThis requirement has also come up in #5171.\r\n\r\nAfter discussing with @kylecarbs potential implementation, we came up with the following proposal:\r\n\r\n- [x] Introduce new property describing workspace agent state, `WorkspaceAgentLifecycle`: (`created`,) `starting`, `start_timeout`, `start_error`, `ready`, (`stopping`, `stop_timeout`, `stop_error`, `stopped`)\r\n  https://github.com/coder/coder/pull/5785\r\n\t- This property describes the current state of the agent and is independent of status (which describes the connection status), it can be thought of as a lifecycle status / readyness status\r\n\t- And additional `created` state could be added to indicate an initial state of the agent, before it has reported it's initial state\r\n\t- Example usage of state:\r\n\t\t- If state is `starting`, keep users waiting e.g. during `ssh coder.workspace` (loading indicator)\r\n\t\t- If state is `start_timeout`, show users a warning\r\n\t\t- If startup script exits with non-zero status, the `start_error` state lets us direct users towards inspecting the startup log (#2957)\r\n- [x] Introduce a new provider parameter `coder_agent.startup_script_timeout` with a default value (say 5min) (`shutdown_script_timeout` for #5171)\r\n  https://github.com/coder/terraform-provider-coder/pull/84\r\n\t- This is a soft-timeout after which we _warn_\r\n\t- [x] Show warning in dashboard\r\n\thttps://github.com/coder/coder/pull/5835\r\n\thttps://github.com/coder/coder/pull/5850\r\n\t- [ ] Show warning in CLI, e.g. when SSH:ing into the workspace\r\n\t**NOTE:** Not applicable until **Final steps**\r\n\tPartially handled by: https://github.com/coder/coder/pull/5851\r\n- [x] Introduce a new provider parameter `coder_agent.delay_login_until_ready`\r\n\thttps://github.com/coder/terraform-provider-coder/pull/84\r\n\t- This will delay logins until agent is ready, will default to false and changed to true in a future release\r\n\t- [ ] Delay login in web Terminal\r\n\t- [x] Delay login in `coder ssh`\r\n\thttps://github.com/coder/coder/pull/5851\r\n\t- [x] Delay login in `ssh` (`coder config-ssh`)\r\n\thttps://github.com/coder/coder/pull/5851\r\n\t- [x] Add `--skip-delay-login-until-ready` flag\r\n\thttps://github.com/coder/coder/pull/5851\r\n- [x] Add example(s) with non-blocking startup scripts\r\n  https://github.com/coder/coder/pull/5880\r\n\t- Consider `/etc/init.d/svc start`, `nohup /path/to/svc &`, \"fake systemd\", etc.\r\n- [x] Add documentation for troubleshooting agent lifecycles\r\n  https://github.com/coder/coder/pull/5877\r\n\r\n**Final steps:**\r\n- [ ] Create a breaking PR:\r\n\t- [ ] Revert https://github.com/coder/coder/pull/5850 to show agents with timed out startup scripts by default\r\n\r\nWe will focus on implementing the start-states first, stop will come later.\r\n\r\n","author":{"url":"https://github.com/mafredri","@type":"Person","name":"mafredri"},"datePublished":"2023-01-17T16:57:43Z","url":"https://github.com/coder/coder/issues/5749"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:6e599091-77e4-33ea-43d7-fe95eb9fa2ad
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idAF96:E3C4F:23CD9D9:2DA2F5F:6B018A7D
html-safe-noncebe2bac4ce8ea1eaec1b3dbdfbfd6d95689d69b98bc02f29b29d178031c899e0d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjk2OkUzQzRGOjIzQ0Q5RDk6MkRBMkY1Rjo2QjAxOEE3RCIsInZpc2l0b3JfaWQiOiI1MTU0ODc5MjAxMzkxNzc0MzM0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac9429f9124d1a81033fec38922fc1cec5942b8ffac446baf9c4243f776d7a47a2
hovercard-subject-tagissue:1536723838
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/coder/coder/5749/issue_layout
twitter:imagehttps://opengraph.githubassets.com/4bade35885c4cf035ab290c05297b6d3ba837407bc44d32f469458b7f3097f45/coder/coder/issues/5749
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4bade35885c4cf035ab290c05297b6d3ba837407bc44d32f469458b7f3097f45/coder/coder/issues/5749
og:image:altA new requirement came up in relation to #2957. We need a way to discern between a workspace being ready and not. This is also relevant for vscode-coder where we might start a workspace for a user ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemafredri
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/coder/coder/issues/5749#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fissues%2F5749
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fissues%2F5749
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/issues/5749
Reloadhttps://github.com/coder/coder/issues/5749
Reloadhttps://github.com/coder/coder/issues/5749
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
https://github.com/coder/coder
New issuehttps://github.com/login?return_to=https://github.com/coder/coder/issues/5749
New issuehttps://github.com/login?return_to=https://github.com/coder/coder/issues/5749
Change agent startup script behavior from being never-ending to indicating the workspace is ready on endhttps://github.com/coder/coder/issues/5749#top
apiArea: HTTP APIhttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22api%22
cliArea: CLIhttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22cli%22
staleThis issue is like stale bread.https://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22stale%22
https://github.com/mafredri
mafredrihttps://github.com/mafredri
on Jan 17, 2023https://github.com/coder/coder/issues/5749#issue-1536723838
#2957https://github.com/coder/coder/issues/2957
vscode-coderhttps://github.com/coder/vscode-coder
#5171https://github.com/coder/coder/pull/5171
@kylecarbshttps://github.com/kylecarbs
feat: Add workspace agent lifecycle state reporting #5785https://github.com/coder/coder/pull/5785
Add startup logs to build log UI #2957https://github.com/coder/coder/issues/2957
feat: Add support for shutdown_script #5171https://github.com/coder/coder/pull/5171
feat: Add startup_script_timeout and delay_login_until_ready terraform-provider-coder#84https://github.com/coder/terraform-provider-coder/pull/84
refactor(site): update agent status to include the lifecycle #5835https://github.com/coder/coder/pull/5835
fix(site): Hide agent lifecycle unless opted in via delay_login_until_ready #5850https://github.com/coder/coder/pull/5850
feat(cli): Add support for delay_login_until_ready #5851https://github.com/coder/coder/pull/5851
feat: Add startup_script_timeout and delay_login_until_ready terraform-provider-coder#84https://github.com/coder/terraform-provider-coder/pull/84
feat(cli): Add support for delay_login_until_ready #5851https://github.com/coder/coder/pull/5851
feat(cli): Add support for delay_login_until_ready #5851https://github.com/coder/coder/pull/5851
feat(cli): Add support for delay_login_until_ready #5851https://github.com/coder/coder/pull/5851
chore(examples): Add login_before_ready and startup_script_timeout #5880https://github.com/coder/coder/pull/5880
docs: Document agent readiness issues (startup script) #5877https://github.com/coder/coder/pull/5877
fix(site): Hide agent lifecycle unless opted in via delay_login_until_ready #5850https://github.com/coder/coder/pull/5850
mafredrihttps://github.com/mafredri
enhancementhttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22enhancement%22
apiArea: HTTP APIhttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22api%22
cliArea: CLIhttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22cli%22
on Jan 17, 2023https://github.com/coder/coder/issues/5749#event-8247736955
https://github.com/bpmct
bpmcthttps://github.com/bpmct
on Jan 17, 2023https://github.com/coder/coder/issues/5749#issuecomment-1385864835
https://github.com/kylecarbs
kylecarbshttps://github.com/kylecarbs
on Jan 17, 2023https://github.com/coder/coder/issues/5749#issuecomment-1385873873
@bpmcthttps://github.com/bpmct
https://github.com/mafredri
mafredrihttps://github.com/mafredri
on Jan 17, 2023https://github.com/coder/coder/issues/5749#issuecomment-1385876448
https://github.com/kylecarbs
kylecarbshttps://github.com/kylecarbs
on Jan 17, 2023https://github.com/coder/coder/issues/5749#issuecomment-1385877505
@mafredrihttps://github.com/mafredri
mafredrihttps://github.com/mafredri
on Jan 18, 2023https://github.com/coder/coder/issues/5749#event-8255621557
feat: Add `startup_script_timeout` and `allow_login_before_ready`https://github.com/coder/terraform-provider-coder/commit/add1d31c06344bdd08f0e2d95a5f5649cd6a9929
add1d31https://github.com/coder/terraform-provider-coder/commit/add1d31c06344bdd08f0e2d95a5f5649cd6a9929
https://github.com/mtojek
mtojekhttps://github.com/mtojek
on Jan 19, 2023https://github.com/coder/coder/issues/5749#issuecomment-1396656853
https://github.com/mafredri
mafredrihttps://github.com/mafredri
on Jan 19, 2023https://github.com/coder/coder/issues/5749#issuecomment-1396685381
@mtojekhttps://github.com/mtojek
#5785https://github.com/coder/coder/pull/5785
mafredrihttps://github.com/mafredri
on Jan 23, 2023https://github.com/coder/coder/issues/5749#event-8334184865
feat: Add `startup_script_timeout` and `delay_login_until_ready` (#84)https://github.com/coder/terraform-provider-coder/commit/038574990201f82114bbd6347653d8fd2d23dd04
#84https://github.com/coder/terraform-provider-coder/pull/84
0385749https://github.com/coder/terraform-provider-coder/commit/038574990201f82114bbd6347653d8fd2d23dd04
fix(site): Hide agent lifecycle unless opted in via `delay_login_unti…https://github.com/coder/coder/commit/5c5ddc6b23e17f44b427aee67bd1fd87e11b9e21
5c5ddc6https://github.com/coder/coder/commit/5c5ddc6b23e17f44b427aee67bd1fd87e11b9e21
feat(cli): Add support for `delay_login_until_ready`https://github.com/coder/coder/commit/7004c5d4c86f291e7837e259fb7e31e7f092b4a0
7004c5dhttps://github.com/coder/coder/commit/7004c5d4c86f291e7837e259fb7e31e7f092b4a0
docs: Document agent startup (script) issueshttps://github.com/coder/coder/commit/39b78d7db3cd3b41de159003259383142d1d79e4
39b78d7https://github.com/coder/coder/commit/39b78d7db3cd3b41de159003259383142d1d79e4
docs: Document agent readiness issues (startup script) (#5877)https://github.com/coder/coder/commit/90c4d5d28abeb0b16a456d280dccd0cee4c9028c
#5877https://github.com/coder/coder/pull/5877
90c4d5dhttps://github.com/coder/coder/commit/90c4d5d28abeb0b16a456d280dccd0cee4c9028c
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
on Apr 28, 2023https://github.com/coder/coder/issues/5749#issuecomment-1526798871
github-actionshttps://github.com/apps/github-actions
staleThis issue is like stale bread.https://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22stale%22
on Apr 28, 2023https://github.com/coder/coder/issues/5749#event-9119754878
github-actionshttps://github.com/apps/github-actions
not plannedhttps://github.com/coder/coder/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Anot-planned
on May 6, 2023https://github.com/coder/coder/issues/5749#event-9181136734
DanielleMaywoodhttps://github.com/DanielleMaywood
on Sep 5, 2024https://github.com/coder/coder/issues/5749#event-14145884621
feat: Add `startup_script_timeout` and `delay_login_until_ready` (#84)https://github.com/coder/terraform-provider-coder/commit/300624312a458798d9d0fe96aace440e693cbee3
#84https://github.com/coder/terraform-provider-coder/pull/84
3006243https://github.com/coder/terraform-provider-coder/commit/300624312a458798d9d0fe96aace440e693cbee3
Sign up for freehttps://github.com/signup?return_to=https://github.com/coder/coder/issues/5749
Sign in to commenthttps://github.com/login?return_to=https://github.com/coder/coder/issues/5749
apiArea: HTTP APIhttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22api%22
cliArea: CLIhttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22cli%22
staleThis issue is like stale bread.https://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22stale%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.