Title: Refactor `coder server` shutdown procedure and allow `TestServer` tests to pass `goleaks` detection · Issue #3245 · coder/coder · GitHub
Open Graph Title: Refactor `coder server` shutdown procedure and allow `TestServer` tests to pass `goleaks` detection · Issue #3245 · coder/coder
X Title: Refactor `coder server` shutdown procedure and allow `TestServer` tests to pass `goleaks` detection · Issue #3245 · coder/coder
Description: Currently there are multiple ways in which the Coder server can exit and not all of them go through the same shutdown procedure. There are also cases where an error in one of the steps results skipping some of the shutdown steps. There a...
Open Graph Description: Currently there are multiple ways in which the Coder server can exit and not all of them go through the same shutdown procedure. There are also cases where an error in one of the steps results skip...
X Description: Currently there are multiple ways in which the Coder server can exit and not all of them go through the same shutdown procedure. There are also cases where an error in one of the steps results skip...
Opengraph URL: https://github.com/coder/coder/issues/3245
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Refactor `coder server` shutdown procedure and allow `TestServer` tests to pass `goleaks` detection","articleBody":"Currently there are multiple ways in which the Coder server can exit and not all of them go through the same shutdown procedure. There are also cases where an error in one of the steps results skipping some of the shutdown steps.\r\n\r\nThere are also certain services started where context propagation is not guaranteed to trigger, depending on which error shut down the server.\r\n\r\nWe should standardize the server shutdown procedure and ensure that all `TestServer` cases pass `goleaks`.","author":{"url":"https://github.com/mafredri","@type":"Person","name":"mafredri"},"datePublished":"2022-07-27T12:33:12Z","url":"https://github.com/coder/coder/issues/3245"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:e1b1c4c0-bfa9-1ed7-7504-8a3e1ba85c52 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B3D6:11EACE:1FE5379:2A8E273:6B017C02 |
| html-safe-nonce | c8f190f056993d3d288f3aad650b061c5829b2ba293b57b49653f296a038608a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCM0Q2OjExRUFDRToxRkU1Mzc5OjJBOEUyNzM6NkIwMTdDMDIiLCJ2aXNpdG9yX2lkIjoiMzk4NTM4MTA5MDExNzM4NTIxOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | a2591feccfa9d4f93531c2998d95a6e7a63b662358635f0af29bf5e7b4028a97 |
| hovercard-subject-tag | issue:1319497643 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/coder/coder/3245/issue_layout |
| twitter:image | https://opengraph.githubassets.com/df16b0795c539a7fd9e165c6085b3f1c7ec930386c82e9798ea1719c169dc2a7/coder/coder/issues/3245 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/df16b0795c539a7fd9e165c6085b3f1c7ec930386c82e9798ea1719c169dc2a7/coder/coder/issues/3245 |
| og:image:alt | Currently there are multiple ways in which the Coder server can exit and not all of them go through the same shutdown procedure. There are also cases where an error in one of the steps results skip... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mafredri |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/coder/coder git https://github.com/coder/coder.git |
| octolytics-dimension-user_id | 95932066 |
| octolytics-dimension-user_login | coder |
| octolytics-dimension-repository_id | 440752086 |
| octolytics-dimension-repository_nwo | coder/coder |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 440752086 |
| octolytics-dimension-repository_network_root_nwo | coder/coder |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width