Title: rbac: verify compiled SQL queries honor implicit ACL handling from `RBACObject()` · Issue #25982 · coder/coder · GitHub
Open Graph Title: rbac: verify compiled SQL queries honor implicit ACL handling from `RBACObject()` · Issue #25982 · coder/coder
X Title: rbac: verify compiled SQL queries honor implicit ACL handling from `RBACObject()` · Issue #25982 · coder/coder
Description: Follow-up from PR #25929 review thread on the "Intentionally omitted" block in OrgWorkspaceAccessMemberPerms: Mention this ACL is implicit in the RBACObject() method. We need an issue to track this for any compiled SQL queries. Review #1...
Open Graph Description: Follow-up from PR #25929 review thread on the "Intentionally omitted" block in OrgWorkspaceAccessMemberPerms: Mention this ACL is implicit in the RBACObject() method. We need an issue to track this...
X Description: Follow-up from PR #25929 review thread on the "Intentionally omitted" block in OrgWorkspaceAccessMemberPerms: Mention this ACL is implicit in the RBACObject() method. We need an issue to ...
Opengraph URL: https://github.com/coder/coder/issues/25982
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"rbac: verify compiled SQL queries honor implicit ACL handling from `RBACObject()`","articleBody":"Follow-up from PR #25929 review thread on the `\"Intentionally omitted\"` block in `OrgWorkspaceAccessMemberPerms`:\n\n> Mention this ACL is implicit in the `RBACObject()` method.\n>\n> We need an issue to track this for any compiled SQL queries.\n> Review https://github.com/coder/coder/pull/14200 maybe when making that issue.\n\n## Context\n\nFor resources like `Group` and `Template`, member-scope access is not granted by a Member-level perm in any role. Instead, it falls out of the ACL applied implicitly by the resource's `RBACObject()` method, e.g. `Group.RBACObject()` populates `GroupACL`, and the in-memory authorizer's ACL path then matches \"this user is in a group with read on this object\".\n\nThis works for the in-memory authorization path (Rego policy evaluation against a hydrated `RBACObject`). It is unclear whether the regosql-compiled SQL queries (the `AuthorizedQuery`/`prepared` path used to filter list queries directly in Postgres) apply the same ACL logic for every resource type. If a compiled query path skips the implicit-ACL handling, a list endpoint could either over- or under-filter relative to the in-memory authorizer.\n\nThe canonical example to study is #14200 (group members reading their own groups + reduced member counts), which added the ACL-driven \"groups I'm in\" read path. Verify each compiled-SQL list query for `Group`, `Template`, and any other ACL-backed resource exercises the same ACL rule that `RBACObject()` injects.\n\n## Suggested scope\n\n- Audit `coderd/rbac/regosql/...` and the compiled query paths for `Group`, `Template`, and any other resource whose member access depends on ACL rather than `WithOwner(...)`.\n- For each, confirm the compiled SQL applies the same `acl_user_list` / `acl_group_list` semantics as the Rego policy.\n- Add regression tests where coverage is missing.\n\n---\n\n\u003csub>Filed by Coder Agents on behalf of @Emyrk.\u003c/sub>","author":{"url":"https://github.com/Emyrk","@type":"Person","name":"Emyrk"},"datePublished":"2026-06-02T14:28:37Z","url":"https://github.com/coder/coder/issues/25982"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:b55c80af-286d-d4f4-7b19-e2aac1adfc41 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D9B8:3A4875:205671D:2B0916F:6B017F2A |
| html-safe-nonce | 7eb6ef80bc36f210a88cc242c5c82aa24871b26ff58aabc8055faeac5edae0cd |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOUI4OjNBNDg3NToyMDU2NzFEOjJCMDkxNkY6NkIwMTdGMkEiLCJ2aXNpdG9yX2lkIjoiNzI3NjAzMzU0Nzc5MzUyODc0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 3fbb3a87ca4ce839cb2905a4e9f92ab3ffcc328a26ab12a1d40aa4391ce0391b |
| hovercard-subject-tag | issue:4572318264 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/coder/coder/25982/issue_layout |
| twitter:image | https://opengraph.githubassets.com/af1d45bf82737e94db5ced7047900cf7631e03768863d9b8483808049997b884/coder/coder/issues/25982 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/af1d45bf82737e94db5ced7047900cf7631e03768863d9b8483808049997b884/coder/coder/issues/25982 |
| og:image:alt | Follow-up from PR #25929 review thread on the "Intentionally omitted" block in OrgWorkspaceAccessMemberPerms: Mention this ACL is implicit in the RBACObject() method. We need an issue to track this... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Emyrk |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/coder/coder git https://github.com/coder/coder.git |
| octolytics-dimension-user_id | 95932066 |
| octolytics-dimension-user_login | coder |
| octolytics-dimension-repository_id | 440752086 |
| octolytics-dimension-repository_nwo | coder/coder |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 440752086 |
| octolytics-dimension-repository_network_root_nwo | coder/coder |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width