René's URL Explorer Experiment


Title: dbcrypt: `cliutil` has no test coverage for `Rotate`/`Decrypt`/`Delete` · Issue #25389 · coder/coder · GitHub

Open Graph Title: dbcrypt: `cliutil` has no test coverage for `Rotate`/`Decrypt`/`Delete` · Issue #25389 · coder/coder

X Title: dbcrypt: `cliutil` has no test coverage for `Rotate`/`Decrypt`/`Delete` · Issue #25389 · coder/coder

Description: Context enterprise/dbcrypt/cliutil.go exposes three functions used by coder server dbcrypt {rotate,decrypt,delete}: Rotate — re-encrypts every dbcrypt-managed column with the new primary cipher and revokes old keys. Decrypt — clears ever...

Open Graph Description: Context enterprise/dbcrypt/cliutil.go exposes three functions used by coder server dbcrypt {rotate,decrypt,delete}: Rotate — re-encrypts every dbcrypt-managed column with the new primary cipher and...

X Description: Context enterprise/dbcrypt/cliutil.go exposes three functions used by coder server dbcrypt {rotate,decrypt,delete}: Rotate — re-encrypts every dbcrypt-managed column with the new primary cipher and...

Opengraph URL: https://github.com/coder/coder/issues/25389

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"dbcrypt: `cliutil` has no test coverage for `Rotate`/`Decrypt`/`Delete`","articleBody":"## Context\n\n`enterprise/dbcrypt/cliutil.go` exposes three functions used by `coder server dbcrypt {rotate,decrypt,delete}`:\n\n* `Rotate` — re-encrypts every dbcrypt-managed column with the new primary cipher and revokes old keys.\n* `Decrypt` — clears every `*_key_id` reference so all keys can be revoked.\n* `Delete` — wipes (or nulls) encrypted columns via a single SQL transaction, then revokes every active key.\n\nThese functions are the only interface for migrating encryption state at the operator level. They currently have **zero test coverage**. Bugs land silently and only surface in production — coder/coder#25381 is one such bug.\n\n## Why this matters\n\nEach function walks every dbcrypt-managed table and is load-bearing for both onboarding (encrypt previously-plaintext rows) and offboarding (revoke keys without violating FK constraints to `dbcrypt_keys`). Every new encrypted column adds:\n\n* a loop in `Rotate`\n* a loop in `Decrypt`\n* a clause in `sqlDeleteEncryptedUserTokens`\n\nMissing any of these is an FK-revoke failure waiting to happen, and nothing catches it today.\n\n## Proposal\n\nAdd `enterprise/dbcrypt/cliutil_test.go` with regression tests for every encrypted column, organized around the three failure modes:\n\n* `Rotate` re-encrypts live + soft-deleted rows so the previous key can be revoked.\n* `Decrypt` clears `*_key_id` on live + soft-deleted rows.\n* `Delete` (via `sqlDeleteEncryptedUserTokens`) wipes the right rows / columns.\n\nTables to cover (as of May 2026):\n\n* `user_links`, `external_auth_links`\n* `user_chat_provider_keys`, `user_secrets`\n* `chat_providers`\n* `ai_providers`, `ai_provider_keys`\n* `crypto_keys` (gap from coder/coder#25381)\n* `mcp_server_configs`, `mcp_server_user_tokens` (gap from coder/coder#25381)\n\nBranch `dk/aibridge-providers-dbcrypt` briefly carried `TestRotateAIProviders`, `TestRotateAIProviderKeys`, `TestDecryptAIProviders`, and `TestDeleteAIProviders` in `cliutil_test.go`. Those were dropped pending this broader effort but are worth recovering from git history (added in `dcdf9cffd9`, removed in the subsequent commit on that branch) as a starting template.\n\n## Related\n\n* coder/coder#25381 — concrete instance: `crypto_keys`, `mcp_server_configs`, `mcp_server_user_tokens` are silently missing from `Decrypt`/`Rotate` today.","author":{"url":"https://github.com/dannykopping","@type":"Person","name":"dannykopping"},"datePublished":"2026-05-15T12:37:22Z","url":"https://github.com/coder/coder/issues/25389"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:ada32d71-8b84-7729-7c22-2e5842c5fd14
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idADC8:11EACE:1BB45E3:24EEFCF:6B015FCF
html-safe-nonce3226f00bd3c63098eb37f11a30febd21455c9eadfeefe82ce73e204c89b1367d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBREM4OjExRUFDRToxQkI0NUUzOjI0RUVGQ0Y6NkIwMTVGQ0YiLCJ2aXNpdG9yX2lkIjoiNTEwNjExNjIwODU5MjI0ODc4MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac96d56c999a6f04d323de46b3e556bb0afaf68a13461dc2ccc87a658b6de748aa
hovercard-subject-tagissue:4453945162
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/coder/coder/25389/issue_layout
twitter:imagehttps://opengraph.githubassets.com/5240657a435fd42e7d19f9fab24c042500481d80a93b73f465e79b0ffd4f1b15/coder/coder/issues/25389
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5240657a435fd42e7d19f9fab24c042500481d80a93b73f465e79b0ffd4f1b15/coder/coder/issues/25389
og:image:altContext enterprise/dbcrypt/cliutil.go exposes three functions used by coder server dbcrypt {rotate,decrypt,delete}: Rotate — re-encrypts every dbcrypt-managed column with the new primary cipher and...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedannykopping
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/coder/coder/issues/25389#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fissues%2F25389
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fissues%2F25389
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/issues/25389
Reloadhttps://github.com/coder/coder/issues/25389
Reloadhttps://github.com/coder/coder/issues/25389
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
https://github.com/coder/coder
New issuehttps://github.com/login?return_to=https://github.com/coder/coder/issues/25389
New issuehttps://github.com/login?return_to=https://github.com/coder/coder/issues/25389
dbcrypt: cliutil has no test coverage for Rotate/Decrypt/Deletehttps://github.com/coder/coder/issues/25389#top
https://github.com/BobbyHo
https://github.com/dannykopping
dannykoppinghttps://github.com/dannykopping
on May 15, 2026https://github.com/coder/coder/issues/25389#issue-4453945162
#25381https://github.com/coder/coder/issues/25381
dbcrypt: Decrypt/Rotate miss several tables, causing FK violation on revoke #25381https://github.com/coder/coder/issues/25381
dbcrypt: Decrypt/Rotate miss several tables, causing FK violation on revoke #25381https://github.com/coder/coder/issues/25381
dbcrypt: Decrypt/Rotate miss several tables, causing FK violation on revoke #25381https://github.com/coder/coder/issues/25381
BobbyHohttps://github.com/BobbyHo
on Jul 2, 2026https://github.com/coder/coder/issues/25389#event-27485207628
BobbyHohttps://github.com/BobbyHo
on Jul 7, 2026https://github.com/coder/coder/issues/25389#event-27669615033
test(enterprise/dbcrypt): add Rotate/Decrypt/Delete regression tests (#…https://github.com/coder/coder/commit/90861ffa75ddb6036476af3f084ecc270a22801d
#…https://github.com/coder/coder/pull/26979
90861ffhttps://github.com/coder/coder/commit/90861ffa75ddb6036476af3f084ecc270a22801d
https://github.com/BobbyHo
BobbyHohttps://github.com/BobbyHo
on Jul 7, 2026https://github.com/coder/coder/issues/25389#issuecomment-4905097561
#26979https://github.com/coder/coder/pull/26979
BobbyHohttps://github.com/BobbyHo
completedhttps://github.com/coder/coder/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Jul 7, 2026https://github.com/coder/coder/issues/25389#event-27669878087
Sign up for freehttps://github.com/signup?return_to=https://github.com/coder/coder/issues/25389
Sign in to commenthttps://github.com/login?return_to=https://github.com/coder/coder/issues/25389
BobbyHohttps://github.com/BobbyHo
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.