Title: dbcrypt: `cliutil` has no test coverage for `Rotate`/`Decrypt`/`Delete` · Issue #25389 · coder/coder · GitHub
Open Graph Title: dbcrypt: `cliutil` has no test coverage for `Rotate`/`Decrypt`/`Delete` · Issue #25389 · coder/coder
X Title: dbcrypt: `cliutil` has no test coverage for `Rotate`/`Decrypt`/`Delete` · Issue #25389 · coder/coder
Description: Context enterprise/dbcrypt/cliutil.go exposes three functions used by coder server dbcrypt {rotate,decrypt,delete}: Rotate — re-encrypts every dbcrypt-managed column with the new primary cipher and revokes old keys. Decrypt — clears ever...
Open Graph Description: Context enterprise/dbcrypt/cliutil.go exposes three functions used by coder server dbcrypt {rotate,decrypt,delete}: Rotate — re-encrypts every dbcrypt-managed column with the new primary cipher and...
X Description: Context enterprise/dbcrypt/cliutil.go exposes three functions used by coder server dbcrypt {rotate,decrypt,delete}: Rotate — re-encrypts every dbcrypt-managed column with the new primary cipher and...
Opengraph URL: https://github.com/coder/coder/issues/25389
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"dbcrypt: `cliutil` has no test coverage for `Rotate`/`Decrypt`/`Delete`","articleBody":"## Context\n\n`enterprise/dbcrypt/cliutil.go` exposes three functions used by `coder server dbcrypt {rotate,decrypt,delete}`:\n\n* `Rotate` — re-encrypts every dbcrypt-managed column with the new primary cipher and revokes old keys.\n* `Decrypt` — clears every `*_key_id` reference so all keys can be revoked.\n* `Delete` — wipes (or nulls) encrypted columns via a single SQL transaction, then revokes every active key.\n\nThese functions are the only interface for migrating encryption state at the operator level. They currently have **zero test coverage**. Bugs land silently and only surface in production — coder/coder#25381 is one such bug.\n\n## Why this matters\n\nEach function walks every dbcrypt-managed table and is load-bearing for both onboarding (encrypt previously-plaintext rows) and offboarding (revoke keys without violating FK constraints to `dbcrypt_keys`). Every new encrypted column adds:\n\n* a loop in `Rotate`\n* a loop in `Decrypt`\n* a clause in `sqlDeleteEncryptedUserTokens`\n\nMissing any of these is an FK-revoke failure waiting to happen, and nothing catches it today.\n\n## Proposal\n\nAdd `enterprise/dbcrypt/cliutil_test.go` with regression tests for every encrypted column, organized around the three failure modes:\n\n* `Rotate` re-encrypts live + soft-deleted rows so the previous key can be revoked.\n* `Decrypt` clears `*_key_id` on live + soft-deleted rows.\n* `Delete` (via `sqlDeleteEncryptedUserTokens`) wipes the right rows / columns.\n\nTables to cover (as of May 2026):\n\n* `user_links`, `external_auth_links`\n* `user_chat_provider_keys`, `user_secrets`\n* `chat_providers`\n* `ai_providers`, `ai_provider_keys`\n* `crypto_keys` (gap from coder/coder#25381)\n* `mcp_server_configs`, `mcp_server_user_tokens` (gap from coder/coder#25381)\n\nBranch `dk/aibridge-providers-dbcrypt` briefly carried `TestRotateAIProviders`, `TestRotateAIProviderKeys`, `TestDecryptAIProviders`, and `TestDeleteAIProviders` in `cliutil_test.go`. Those were dropped pending this broader effort but are worth recovering from git history (added in `dcdf9cffd9`, removed in the subsequent commit on that branch) as a starting template.\n\n## Related\n\n* coder/coder#25381 — concrete instance: `crypto_keys`, `mcp_server_configs`, `mcp_server_user_tokens` are silently missing from `Decrypt`/`Rotate` today.","author":{"url":"https://github.com/dannykopping","@type":"Person","name":"dannykopping"},"datePublished":"2026-05-15T12:37:22Z","url":"https://github.com/coder/coder/issues/25389"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:ada32d71-8b84-7729-7c22-2e5842c5fd14 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | ADC8:11EACE:1BB45E3:24EEFCF:6B015FCF |
| html-safe-nonce | 3226f00bd3c63098eb37f11a30febd21455c9eadfeefe82ce73e204c89b1367d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBREM4OjExRUFDRToxQkI0NUUzOjI0RUVGQ0Y6NkIwMTVGQ0YiLCJ2aXNpdG9yX2lkIjoiNTEwNjExNjIwODU5MjI0ODc4MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 96d56c999a6f04d323de46b3e556bb0afaf68a13461dc2ccc87a658b6de748aa |
| hovercard-subject-tag | issue:4453945162 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/coder/coder/25389/issue_layout |
| twitter:image | https://opengraph.githubassets.com/5240657a435fd42e7d19f9fab24c042500481d80a93b73f465e79b0ffd4f1b15/coder/coder/issues/25389 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5240657a435fd42e7d19f9fab24c042500481d80a93b73f465e79b0ffd4f1b15/coder/coder/issues/25389 |
| og:image:alt | Context enterprise/dbcrypt/cliutil.go exposes three functions used by coder server dbcrypt {rotate,decrypt,delete}: Rotate — re-encrypts every dbcrypt-managed column with the new primary cipher and... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | dannykopping |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/coder/coder git https://github.com/coder/coder.git |
| octolytics-dimension-user_id | 95932066 |
| octolytics-dimension-user_login | coder |
| octolytics-dimension-repository_id | 440752086 |
| octolytics-dimension-repository_nwo | coder/coder |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 440752086 |
| octolytics-dimension-repository_network_root_nwo | coder/coder |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width