René's URL Explorer Experiment


Title: Tests using Cobra with `ptytest` can hang on macOS (and Windows) unless the output is consumed · Issue #2122 · coder/coder · GitHub

Open Graph Title: Tests using Cobra with `ptytest` can hang on macOS (and Windows) unless the output is consumed · Issue #2122 · coder/coder

X Title: Tests using Cobra with `ptytest` can hang on macOS (and Windows) unless the output is consumed · Issue #2122 · coder/coder

Description: Unless ptytest output is consumed, a test can hang if a command outputs more than 1024 bytes (at least on macOS). There are two ways to work around this issue: Consume the output via pty.ExpectMatch() (ensure no more than 1024 bytes are ...

Open Graph Description: Unless ptytest output is consumed, a test can hang if a command outputs more than 1024 bytes (at least on macOS). There are two ways to work around this issue: Consume the output via pty.ExpectMatc...

X Description: Unless ptytest output is consumed, a test can hang if a command outputs more than 1024 bytes (at least on macOS). There are two ways to work around this issue: Consume the output via pty.ExpectMatc...

Opengraph URL: https://github.com/coder/coder/issues/2122

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Tests using Cobra with `ptytest` can hang on macOS (and Windows) unless the output is consumed","articleBody":"Unless `ptytest` output is consumed, a test can hang if a command outputs more than `1024` bytes (at least on macOS).\r\n\r\nThere are two ways to work around this issue:\r\n1. Consume the output via `pty.ExpectMatch()` (ensure no more than 1024 bytes are left unread)\r\n2. Use `cmd.SetOut(io.Discard)` instead\r\n\r\nSince using `ptytest` is a common pattern in our tests, it'd be a good idea to rewrite it so that a hang is not possible.\r\n\r\nUnless there's a bug to be fixed in underlying libraries, or changes to how ptys are configured, the most robust way to fix this would be for `ptytest` to buffer/consume _all_ command output, irregardless of a call to `ExpectMatch`.\r\n\r\nA reproduction of this bug exists as a test in https://github.com/coder/coder/pull/1629 (and will be merged in and skipped on macOS and Windows).","author":{"url":"https://github.com/mafredri","@type":"Person","name":"mafredri"},"datePublished":"2022-06-07T13:42:40Z","url":"https://github.com/coder/coder/issues/2122"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:d7b537e7-fecb-183f-0b76-36dc7e077cde
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA378:3E4205:211225C:2C34470:6B018A71
html-safe-noncec12aeed67a39793a6188ab28c5e2800373b7053455bfb402ccb6d82da9d3e9b9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMzc4OjNFNDIwNToyMTEyMjVDOjJDMzQ0NzA6NkIwMThBNzEiLCJ2aXNpdG9yX2lkIjoiNzUyMjM0MjQ5Mjk0ODIzNjkxMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb3d56a99d0bfa31c865d405ab12fc28752a78fe48589e8f7fea1b0aeba19d1a9
hovercard-subject-tagissue:1263327001
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/coder/coder/2122/issue_layout
twitter:imagehttps://opengraph.githubassets.com/d02749fe2c92d9c822f51fa7af347606deb589fb2656db6865d01fcab0bdd065/coder/coder/issues/2122
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d02749fe2c92d9c822f51fa7af347606deb589fb2656db6865d01fcab0bdd065/coder/coder/issues/2122
og:image:altUnless ptytest output is consumed, a test can hang if a command outputs more than 1024 bytes (at least on macOS). There are two ways to work around this issue: Consume the output via pty.ExpectMatc...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemafredri
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/coder/coder/issues/2122#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fissues%2F2122
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fissues%2F2122
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/issues/2122
Reloadhttps://github.com/coder/coder/issues/2122
Reloadhttps://github.com/coder/coder/issues/2122
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
https://github.com/coder/coder
New issuehttps://github.com/login?return_to=https://github.com/coder/coder/issues/2122
New issuehttps://github.com/login?return_to=https://github.com/coder/coder/issues/2122
#3170https://github.com/coder/coder/pull/3170
Tests using Cobra with ptytest can hang on macOS (and Windows) unless the output is consumedhttps://github.com/coder/coder/issues/2122#top
#3170https://github.com/coder/coder/pull/3170
apiArea: HTTP APIhttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22api%22
siteArea: frontend dashboardhttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22site%22
https://github.com/mafredri
mafredrihttps://github.com/mafredri
on Jun 7, 2022https://github.com/coder/coder/issues/2122#issue-1263327001
#1629https://github.com/coder/coder/pull/1629
mafredrihttps://github.com/mafredri
needs groominghttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22needs%20grooming%22
on Jun 7, 2022https://github.com/coder/coder/issues/2122#event-6761539164
kylecarbshttps://github.com/kylecarbs
on Jun 7, 2022https://github.com/coder/coder/issues/2122#event-6761807624
kylecarbshttps://github.com/kylecarbs
bughttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22bug%22
on Jun 7, 2022https://github.com/coder/coder/issues/2122#event-6761808295
https://github.com/kylecarbs
kylecarbshttps://github.com/kylecarbs
on Jun 7, 2022https://github.com/coder/coder/issues/2122#issuecomment-1148731110
@mafredrihttps://github.com/mafredri
missknisshttps://github.com/misskniss
apiArea: HTTP APIhttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22api%22
siteArea: frontend dashboardhttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22site%22
on Jun 14, 2022https://github.com/coder/coder/issues/2122#event-6800961479
mafredrihttps://github.com/mafredri
on Jul 20, 2022https://github.com/coder/coder/issues/2122#event-7030904759
fix: Improve TestSSH reliability on macOShttps://github.com/coder/coder/commit/370b08cafe6a25870ec09264acf38ee71532bbb9
370b08chttps://github.com/coder/coder/commit/370b08cafe6a25870ec09264acf38ee71532bbb9
fix: Improve TestSSH reliability on macOS (#3067)https://github.com/coder/coder/commit/4fde5366beb68207f00e32732b3ffe408d6ecf31
#3067https://github.com/coder/coder/pull/3067
4fde536https://github.com/coder/coder/commit/4fde5366beb68207f00e32732b3ffe408d6ecf31
fix: Rewrite ptytest to buffer stdouthttps://github.com/coder/coder/commit/ffda8cde08e668ac5a5caf9b84ee2091b32846bd
ffda8cdhttps://github.com/coder/coder/commit/ffda8cde08e668ac5a5caf9b84ee2091b32846bd
mafredrihttps://github.com/mafredri
completedhttps://github.com/coder/coder/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#3170https://github.com/coder/coder/pull/3170
on Jul 25, 2022https://github.com/coder/coder/issues/2122#event-7058269959
mafredrihttps://github.com/mafredri
on Jul 25, 2022https://github.com/coder/coder/issues/2122#event-7058269980
fix: Rewrite ptytest to buffer stdout (#3170)https://github.com/coder/coder/commit/92a95fbd5f0486992dc98f04e761eea91c5b81a1
#3170https://github.com/coder/coder/pull/3170
https://docs.github.com/articles/closing-issues-via-commit-messages
92a95fbhttps://github.com/coder/coder/commit/92a95fbd5f0486992dc98f04e761eea91c5b81a1
mafredrihttps://github.com/mafredri
on Aug 3, 2022https://github.com/coder/coder/issues/2122#event-7117315570
fix: Skip waiting for exit output in SSH testhttps://github.com/coder/coder/commit/5453efba48b2f33d192ed2f74d97f29e0d169499
5453efbhttps://github.com/coder/coder/commit/5453efba48b2f33d192ed2f74d97f29e0d169499
fix: Skip waiting for exit output in SSH test (#3368)https://github.com/coder/coder/commit/9a023dd63b63f72b2653cbc2d1fb37ca8763db03
#3368https://github.com/coder/coder/pull/3368
9a023ddhttps://github.com/coder/coder/commit/9a023dd63b63f72b2653cbc2d1fb37ca8763db03
Sign up for freehttps://github.com/signup?return_to=https://github.com/coder/coder/issues/2122
Sign in to commenthttps://github.com/login?return_to=https://github.com/coder/coder/issues/2122
apiArea: HTTP APIhttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22api%22
siteArea: frontend dashboardhttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22site%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.