Title: Conform ResetPasswordDialog design with ConfirmDialog · Issue #2034 · coder/coder · GitHub
Open Graph Title: Conform ResetPasswordDialog design with ConfirmDialog · Issue #2034 · coder/coder
X Title: Conform ResetPasswordDialog design with ConfirmDialog · Issue #2034 · coder/coder
Description: What is your suggestion? Currently ResetPasswordDialog has its own component, whereas we have a better more generalized ConfirmDialog component. The suggestion is to use the ConfirmDialog component to create the reset password dialog box...
Open Graph Description: What is your suggestion? Currently ResetPasswordDialog has its own component, whereas we have a better more generalized ConfirmDialog component. The suggestion is to use the ConfirmDialog component...
X Description: What is your suggestion? Currently ResetPasswordDialog has its own component, whereas we have a better more generalized ConfirmDialog component. The suggestion is to use the ConfirmDialog component...
Opengraph URL: https://github.com/coder/coder/issues/2034
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Conform ResetPasswordDialog design with ConfirmDialog","articleBody":"## What is your suggestion?\r\nCurrently `ResetPasswordDialog` has its own component, whereas we have a better more generalized `ConfirmDialog` component. The suggestion is to use the `ConfirmDialog` component to create the reset password dialog box.\r\n\r\n## Why do you want this feature?\r\nBetter code structure, removing anti-patterns of keeping two different components doing the same thing. This will also keep the same styles for both types of dialogs.\r\n\r\nCurrently, they look slightly different:\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n## Are there any workarounds to get this functionality today?\r\nYes, the component exists and works fine.\r\n\r\n## Are you interested in submitting a PR for this?\r\nYes","author":{"url":"https://github.com/AbhineetJain","@type":"Person","name":"AbhineetJain"},"datePublished":"2022-06-03T16:30:09Z","url":"https://github.com/coder/coder/issues/2034"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:52e892a7-93e1-b203-f7c9-30592ff6ac40 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9046:DA744:1D308F8:273A1D0:6B0176B7 |
| html-safe-nonce | 1e9884b56706749911b3d348b607855c87c23fdc482ffeede69fc27340c4514c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDQ2OkRBNzQ0OjFEMzA4Rjg6MjczQTFEMDo2QjAxNzZCNyIsInZpc2l0b3JfaWQiOiI2MzM0NzA5NjM4MTgwNzMwNTUxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 31499dd437bb739574e57284967f8023efad9612ae6bc7551e9578163c702db3 |
| hovercard-subject-tag | issue:1260122261 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/coder/coder/2034/issue_layout |
| twitter:image | https://opengraph.githubassets.com/f7cefef2414d0557e615b85c82ee184ebf142c9ed0f2fbf5179ba243cfa1db40/coder/coder/issues/2034 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f7cefef2414d0557e615b85c82ee184ebf142c9ed0f2fbf5179ba243cfa1db40/coder/coder/issues/2034 |
| og:image:alt | What is your suggestion? Currently ResetPasswordDialog has its own component, whereas we have a better more generalized ConfirmDialog component. The suggestion is to use the ConfirmDialog component... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | AbhineetJain |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/coder/coder git https://github.com/coder/coder.git |
| octolytics-dimension-user_id | 95932066 |
| octolytics-dimension-user_login | coder |
| octolytics-dimension-repository_id | 440752086 |
| octolytics-dimension-repository_nwo | coder/coder |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 440752086 |
| octolytics-dimension-repository_network_root_nwo | coder/coder |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width