René's URL Explorer Experiment


Title: `coder show` incorrectly shows permanent resources as ephemeral. · Issue #1937 · coder/coder · GitHub

Open Graph Title: `coder show` incorrectly shows permanent resources as ephemeral. · Issue #1937 · coder/coder

X Title: `coder show` incorrectly shows permanent resources as ephemeral. · Issue #1937 · coder/coder

Description: OS Information OS: macOS Browser (if applicable): Architecture: coder --version: Coder v0.6.0-devel+56ec53d0 Steps to Reproduce Create a workspace with persistent resources (e.g. docker example with volume) coder show Expected cod...

Open Graph Description: OS Information OS: macOS Browser (if applicable): Architecture: coder --version: Coder v0.6.0-devel+56ec53d0 Steps to Reproduce Create a workspace with persistent resources (e.g. docker example wit...

X Description: OS Information OS: macOS Browser (if applicable): Architecture: coder --version: Coder v0.6.0-devel+56ec53d0 Steps to Reproduce Create a workspace with persistent resources (e.g. docker example wit...

Opengraph URL: https://github.com/coder/coder/issues/1937

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`coder show` incorrectly shows permanent resources as ephemeral.","articleBody":"## OS Information\r\n\r\n- OS: macOS\r\n- Browser (if applicable): \r\n- Architecture:\r\n- `coder --version`: Coder v0.6.0-devel+56ec53d0\r\n\r\n## Steps to Reproduce\r\n\r\n1. Create a workspace with persistent resources (e.g. docker example with volume)\r\n2. `coder show \u003cname>`\r\n\r\n## Expected\r\n\r\n`coder show` should list resources as permanent\r\n\r\n## Actual\r\n\r\n```\r\n% coder show test\r\n┌─────────────────────────────────────────────────────────────────┐\r\n│ RESOURCE                    STATUS             ACCESS           │\r\n├─────────────────────────────────────────────────────────────────┤\r\n│ docker_container.workspace  ephemeral                           │\r\n│ └─ dev (linux, armv7)       ⦾ connecting [7s]   coder ssh test  │\r\n├─────────────────────────────────────────────────────────────────┤\r\n│ docker_volume.home_volume   ephemeral                           │\r\n└─────────────────────────────────────────────────────────────────┘\r\n```\r\n\r\n## Logs\r\n\r\n## Screenshot\r\n\r\n\u003c!-- Ideally provide a screenshot, gif, video or screen recording. -->\r\n\r\n## Notes\r\n\r\nWhat's going on here is that `coder show` is getting the resources for most recent build, which will only include resources at the most recent transition.  Meanwhile, the CLI code derives the status of ephemeral / permanent based on whether there is a resource included for the stop transition.  Since we only get start resources when querying the start job, the resources are always listed as ephemeral.  You can see this clearly by stopping the workspace and then calling `coder show` again:\r\n\r\n```\r\n% coder show test\r\n┌───────────────────────────────────────────────┐\r\n│ RESOURCE                   STATUS      ACCESS │\r\n├───────────────────────────────────────────────┤\r\n│ docker_volume.home_volume  persistent         │\r\n└───────────────────────────────────────────────┘\r\n```\r\n\r\nMore generally, I'm not sure \"status\" is the right word for ephemeral vs permanent, as typically object status implies something that can change.\r\n\r\nFinally, when we call `coder show`, I think users are going to be interested in not just whether the resource _would_ remain if the workspace were stopped (ephemeral vs permanent), but whether the resource _presently exists_.\r\n\r\n## Implementation notes:\r\nOptions\r\n1. Get out of the idea of predicting ephemeral vs persistent. Coder show just shows you what the current resources are\r\n2. Fix the identification of ephemeral vs persistent based on the templates \r\n3. Really fix this by rerunning the dry tunes every time the parameters for the workspace are changed. \r\n4. have `--dryrun` option and do the computation at that time. This would have the impact of not being 'predictive' in terms of ephemeral vs persistent. (separate ticket / feature)\r\n\r\n### Decision: Option 1\r\n\r\n## AC\r\ncoder show does not show a status anymore - only the current resources\r\ncoder template create only shows the start resources\r\ntests for the above\r\n\r\n","author":{"url":"https://github.com/spikecurtis","@type":"Person","name":"spikecurtis"},"datePublished":"2022-05-31T23:37:40Z","url":"https://github.com/coder/coder/issues/1937"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:00249997-c35b-df4d-770a-018ed55e6989
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idEB32:3DD488:1C98231:24456BF:6B015BC8
html-safe-nonce20f4282aab441143a174da3b923cc13f9467554b477d7287bd760d1d89fef845
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQjMyOjNERDQ4ODoxQzk4MjMxOjI0NDU2QkY6NkIwMTVCQzgiLCJ2aXNpdG9yX2lkIjoiMjIwNTM1NjQwOTk2MzUwMjUzNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5e7e3291fb373246030fec6fc4a4cb05ba1c7720f6ed0025b60ec3d78fcb4c62
hovercard-subject-tagissue:1254532998
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/coder/coder/1937/issue_layout
twitter:imagehttps://opengraph.githubassets.com/60fc634580b74b1099cdd5673c4b278a4caee88a2a70d2edbbb2df141df828ae/coder/coder/issues/1937
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/60fc634580b74b1099cdd5673c4b278a4caee88a2a70d2edbbb2df141df828ae/coder/coder/issues/1937
og:image:altOS Information OS: macOS Browser (if applicable): Architecture: coder --version: Coder v0.6.0-devel+56ec53d0 Steps to Reproduce Create a workspace with persistent resources (e.g. docker example wit...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamespikecurtis
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/coder/coder/issues/1937#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fissues%2F1937
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fissues%2F1937
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/issues/1937
Reloadhttps://github.com/coder/coder/issues/1937
Reloadhttps://github.com/coder/coder/issues/1937
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
https://github.com/coder/coder
New issuehttps://github.com/login?return_to=https://github.com/coder/coder/issues/1937
New issuehttps://github.com/login?return_to=https://github.com/coder/coder/issues/1937
#2333https://github.com/coder/coder/pull/2333
coder show incorrectly shows permanent resources as ephemeral.https://github.com/coder/coder/issues/1937#top
#2333https://github.com/coder/coder/pull/2333
https://github.com/spikecurtis
apiArea: HTTP APIhttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22api%22
cliArea: CLIhttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22cli%22
Community MVPhttps://github.com/coder/coder/milestone/2
https://github.com/spikecurtis
spikecurtishttps://github.com/spikecurtis
on May 31, 2022https://github.com/coder/coder/issues/1937#issue-1254532998
spikecurtishttps://github.com/spikecurtis
bug 🐛https://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22bug%20%3Abug%3A%22
needs grooming 🪒https://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22needs%20grooming%20%3Arazor%3A%22
on May 31, 2022https://github.com/coder/coder/issues/1937#event-6713753734
https://github.com/spikecurtis
spikecurtishttps://github.com/spikecurtis
on May 31, 2022https://github.com/coder/coder/issues/1937#issuecomment-1142763828
https://github.com/spikecurtis
spikecurtishttps://github.com/spikecurtis
on May 31, 2022https://github.com/coder/coder/issues/1937#issuecomment-1142769949
#1732https://github.com/coder/coder/pull/1732
https://github.com/kylecarbs
kylecarbshttps://github.com/kylecarbs
on Jun 1, 2022https://github.com/coder/coder/issues/1937#issuecomment-1142931883
missknisshttps://github.com/misskniss
apiArea: HTTP APIhttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22api%22
cliArea: CLIhttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22cli%22
on Jun 1, 2022https://github.com/coder/coder/issues/1937#event-6715013559
ammariohttps://github.com/ammario
Community MVPhttps://github.com/coder/coder/milestone/2
on Jun 3, 2022https://github.com/coder/coder/issues/1937#event-6737824563
missknisshttps://github.com/misskniss
Community MVP 🏁https://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22Community%20MVP%20%3Acheckered_flag%3A%22
on Jun 3, 2022https://github.com/coder/coder/issues/1937#event-6737852406
kylecarbshttps://github.com/kylecarbs
on Jun 7, 2022https://github.com/coder/coder/issues/1937#event-6757238727
missknisshttps://github.com/misskniss
needs groominghttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22needs%20grooming%22
on Jun 7, 2022https://github.com/coder/coder/issues/1937#event-6763129445
spikecurtishttps://github.com/spikecurtis
on Jun 14, 2022https://github.com/coder/coder/issues/1937#event-6806637496
spikecurtishttps://github.com/spikecurtis
completedhttps://github.com/coder/coder/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#2333https://github.com/coder/coder/pull/2333
on Jun 16, 2022https://github.com/coder/coder/issues/1937#event-6823251991
Sign up for freehttps://github.com/signup?return_to=https://github.com/coder/coder/issues/1937
Sign in to commenthttps://github.com/login?return_to=https://github.com/coder/coder/issues/1937
spikecurtishttps://github.com/spikecurtis
apiArea: HTTP APIhttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22api%22
cliArea: CLIhttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22cli%22
Community MVPhttps://github.com/coder/coder/milestone/2
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.