René's URL Explorer Experiment


Title: Bug: CLI Incorrect Quote Handling in ProxyCommand on Windows · Issue #18503 · coder/coder · GitHub

Open Graph Title: Bug: CLI Incorrect Quote Handling in ProxyCommand on Windows · Issue #18503 · coder/coder

X Title: Bug: CLI Incorrect Quote Handling in ProxyCommand on Windows · Issue #18503 · coder/coder

Description: Summary The coder config-ssh command generates SSH configuration with incorrect quote handling on Windows, causing SSH connection failures due to malformed syntax. This does not happen on Mac/Linux since the executable is not wrapped Env...

Open Graph Description: Summary The coder config-ssh command generates SSH configuration with incorrect quote handling on Windows, causing SSH connection failures due to malformed syntax. This does not happen on Mac/Linux...

X Description: Summary The coder config-ssh command generates SSH configuration with incorrect quote handling on Windows, causing SSH connection failures due to malformed syntax. This does not happen on Mac/Linux...

Opengraph URL: https://github.com/coder/coder/issues/18503

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Bug: CLI Incorrect Quote Handling in ProxyCommand on Windows","articleBody":"## Summary\n\nThe `coder config-ssh` command generates SSH configuration with incorrect quote handling on Windows, causing SSH connection failures due to malformed syntax.\n\nThis does not happen on Mac/Linux since the executable is not wrapped\n\n## Environment\n\n- **OS**: Windows\n- **Coder Version**: 1.22, 1.23 (confirmed, likely affects other versions)\n- **Installation Method**: WinGet (via `C:\\Users\\[USER]\\AppData\\Local\\Microsoft\\WinGet\\Links\\coder.exe`)\n\n## Problem Description\n\nWhen running `coder config-ssh`, the generated SSH configuration contains nested double quotes that are invalid in SSH config syntax, causing SSH to fail with parsing errors.\n\n### Generated Configuration (Incorrect)\n```ssh\nHost *.coder\n        ConnectTimeout=0\n        StrictHostKeyChecking=no\n        UserKnownHostsFile=/dev/null\n        LogLevel ERROR\n\nMatch host *.coder !exec \"\"C:\\Users\\[USER]\\AppData\\Local\\Microsoft\\WinGet\\Links\\coder.exe\" connect exists %h\"\n        ProxyCommand \"C:\\Users\\[USER]\\AppData\\Local\\Microsoft\\WinGet\\Links\\coder.exe\" --global-config \"C:\\Users\\[USER]\\AppData\\Roaming\\coderv2\" ssh --stdio --hostname-suffix coder %h\n# ------------END-CODER------------\n```\n\n### Error Output\n```\nC:\\Users\\[USER]\\.ssh>ssh coder.magenta-chipmunk-80.main\nMissing Match criteria for exec\nC:\\\\Users\\\\[USER]/.ssh/config line 29: Bad Match condition\nC:\\\\Users\\\\[USER]/.ssh/config: terminating, 1 bad configuration options\n```\n\n## Root Cause\n\nThe issue is related to improper quote handling where nested double quotes are not properly escaped or alternated with single quotes\n. In the `Match` directive, the `!exec` command contains double quotes within an already double-quoted parameter, creating invalid syntax.\n\n## Expected Behavior\n\nThe generated SSH configuration should use proper quote alternation to avoid nested quote conflicts.\n\n### Correct Configuration (Should Generate)\n```ssh\nHost *.coder\n        ConnectTimeout=0\n        StrictHostKeyChecking=no\n        UserKnownHostsFile=/dev/null\n        LogLevel ERROR\n\nMatch host *.coder !exec \"'C:\\Users\\[USER]\\AppData\\Local\\Microsoft\\WinGet\\Links\\coder.exe' connect exists %h\"\n        ProxyCommand \"C:\\Users\\[USER]\\AppData\\Local\\Microsoft\\WinGet\\Links\\coder.exe\" --global-config \"C:\\Users\\[USER]\\AppData\\Roaming\\coderv2\" ssh --stdio --hostname-suffix coder %h\n# ------------END-CODER------------\n```\n\n## Current Workaround\n\nManually edit the `.ssh/config` file and replace the inner double quotes with single quotes:\n\n**Change from:**\n```\nMatch host *.coder !exec \"\"C:\\Users\\[USER]\\AppData\\Local\\Microsoft\\WinGet\\Links\\coder.exe\" connect exists %h\"\n```\n\n**Change to:**\n```\nMatch host *.coder !exec \"'C:\\Users\\[USER]\\AppData\\Local\\Microsoft\\WinGet\\Links\\coder.exe' connect exists %h\"\n```\n\n## Impact\n\nThis bug prevents users from connecting to Coder workspaces via SSH on Windows systems, requiring manual configuration file editing after each `coder config-ssh` run.\n\n## Suggested Fix\n\nThe CLI should implement proper quote handling logic for Windows paths:\n\n1. **Use single quotes for inner quotes** when the outer context uses double quotes\n2. **Detect Windows paths** (containing `:\\` or spaces) and apply appropriate quoting strategy\n3. **Consider using single quotes for the entire command** when no variable expansion is needed\n\n## Related Information\n\n- The `--coder-binary-path` option allows specifying the absolute path to the coder binary used in ProxyCommand\n\n- SSH ProxyCommand parameter configuration is a common source of quoting issues\n\n- Similar quote handling issues have been reported in other SSH tooling\n\n## Additional Context\n\nThis issue specifically affects Windows installations where the coder binary path contains spaces (common with WinGet installations in `AppData\\Local\\Microsoft\\WinGet\\Links\\`). The SSH configuration parser strictly requires proper quote nesting, and the current implementation generates syntactically invalid configurations.\n","author":{"url":"https://github.com/bjornrobertsson","@type":"Person","name":"bjornrobertsson"},"datePublished":"2025-06-23T15:05:15Z","url":"https://github.com/coder/coder/issues/18503"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:9cb76b9d-786b-ea7f-fd99-f2c23c16787c
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idDED2:363D8E:312C87A:3E5FF65:6B01B4E4
html-safe-nonced5f6afbc7735c9be20bd183c671d94233d3399ba030a42fed79cb95cf799b8f9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERUQyOjM2M0Q4RTozMTJDODdBOjNFNUZGNjU6NkIwMUI0RTQiLCJ2aXNpdG9yX2lkIjoiNzUzNzc2Mzc4MzQ3NzkzMzI4NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd5dea499f1c0b1e5e90ffc8bceaedbc0c7c333b8157c369a929a9e5ee4ad4bb5
hovercard-subject-tagissue:3168537621
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/coder/coder/18503/issue_layout
twitter:imagehttps://opengraph.githubassets.com/fec1cfa8f8ea754b6f8368839707fdb6b68944ffcc6d62ef9358894649c05e6e/coder/coder/issues/18503
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/fec1cfa8f8ea754b6f8368839707fdb6b68944ffcc6d62ef9358894649c05e6e/coder/coder/issues/18503
og:image:altSummary The coder config-ssh command generates SSH configuration with incorrect quote handling on Windows, causing SSH connection failures due to malformed syntax. This does not happen on Mac/Linux...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebjornrobertsson
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/coder/coder/issues/18503#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fissues%2F18503
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fissues%2F18503
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/issues/18503
Reloadhttps://github.com/coder/coder/issues/18503
Reloadhttps://github.com/coder/coder/issues/18503
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
https://github.com/coder/coder
New issuehttps://github.com/login?return_to=https://github.com/coder/coder/issues/18503
New issuehttps://github.com/login?return_to=https://github.com/coder/coder/issues/18503
Bughttps://github.com/coder/coder/issues?q=type:"Bug"
Bug: CLI Incorrect Quote Handling in ProxyCommand on Windowshttps://github.com/coder/coder/issues/18503#top
cliArea: CLIhttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22cli%22
https://github.com/bjornrobertsson
bjornrobertssonhttps://github.com/bjornrobertsson
on Jun 23, 2025https://github.com/coder/coder/issues/18503#issue-3168537621
bjornrobertssonhttps://github.com/bjornrobertsson
Bughttps://github.com/coder/coder/issues?q=type:"Bug"
on Jun 23, 2025https://github.com/coder/coder/issues/18503#event-18275823653
bjornrobertssonhttps://github.com/bjornrobertsson
cliArea: CLIhttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22cli%22
on Jun 23, 2025https://github.com/coder/coder/issues/18503#event-18275827302
johnstcnhttps://github.com/johnstcn
customer-reportedDO NOT USE. Instead, add to the project and fill in "Customer".https://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22customer-reported%22
on Jun 23, 2025https://github.com/coder/coder/issues/18503#event-18275877695
matifalihttps://github.com/matifali
customer-reportedDO NOT USE. Instead, add to the project and fill in "Customer".https://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22customer-reported%22
on Jun 23, 2025https://github.com/coder/coder/issues/18503#event-18276634235
https://github.com/mafredri
mafredrihttps://github.com/mafredri
on Jun 23, 2025https://github.com/coder/coder/issues/18503#issuecomment-2997067004
@bjornrobertssonhttps://github.com/bjornrobertsson
#18199https://github.com/coder/coder/issues/18199
#18266https://github.com/coder/coder/pull/18266
https://github.com/spikecurtis
spikecurtishttps://github.com/spikecurtis
on Jun 23, 2025https://github.com/coder/coder/issues/18503#issuecomment-2997243822
#18199https://github.com/coder/coder/issues/18199
spikecurtishttps://github.com/spikecurtis
completedhttps://github.com/coder/coder/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Jun 23, 2025https://github.com/coder/coder/issues/18503#event-18277871646
spikecurtishttps://github.com/spikecurtis
on Jun 23, 2025https://github.com/coder/coder/issues/18503#event-18277873947
spikecurtishttps://github.com/spikecurtis
duplicatehttps://github.com/coder/coder/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Aduplicate
on Jun 23, 2025https://github.com/coder/coder/issues/18503#event-18277875677
matifalihttps://github.com/matifali
not plannedhttps://github.com/coder/coder/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Anot-planned
on Jun 23, 2025https://github.com/coder/coder/issues/18503#event-18279501037
matifalihttps://github.com/matifali
duplicatehttps://github.com/coder/coder/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Aduplicate
bug: config-ssh writes bad Match exec clause on Windows #18199https://github.com/coder/coder/issues/18199
on Jun 23, 2025https://github.com/coder/coder/issues/18503#event-18279502550
Sign up for freehttps://github.com/signup?return_to=https://github.com/coder/coder/issues/18503
Sign in to commenthttps://github.com/login?return_to=https://github.com/coder/coder/issues/18503
cliArea: CLIhttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22cli%22
Bughttps://github.com/coder/coder/issues?q=type:"Bug"
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.