René's URL Explorer Experiment


Title: investigate why `run_on_stop` doesn't work consistently · Issue #17108 · coder/coder · GitHub

Open Graph Title: investigate why `run_on_stop` doesn't work consistently · Issue #17108 · coder/coder

X Title: investigate why `run_on_stop` doesn't work consistently · Issue #17108 · coder/coder

Description: while working on #16660, I was unable to get a shutdown script to ever run. that's bad! we should figure out why agents aren't runnning shutdown scripts and fix it. when we do, we should move the make clean of the aforementioned pr into ...

Open Graph Description: while working on #16660, I was unable to get a shutdown script to ever run. that's bad! we should figure out why agents aren't runnning shutdown scripts and fix it. when we do, we should move the m...

X Description: while working on #16660, I was unable to get a shutdown script to ever run. that's bad! we should figure out why agents aren't runnning shutdown scripts and fix it. when we do, we should mo...

Opengraph URL: https://github.com/coder/coder/issues/17108

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"investigate why `run_on_stop` doesn't work consistently","articleBody":"while working on https://github.com/coder/coder/pull/16660, I was unable to get a shutdown script to ever run. that's bad!\n\nwe should figure out why agents aren't runnning shutdown scripts and fix it.\n\nwhen we do, we should move the `make clean` of the aforementioned pr into a shutdown script.","author":{"url":"https://github.com/aslilac","@type":"Person","name":"aslilac"},"datePublished":"2025-02-24T18:29:35Z","url":"https://github.com/coder/coder/issues/17108"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:48c8e16d-f690-94d4-b650-ad4ebf870c7f
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id83B4:296654:27045F8:340BEFF:6B01AC71
html-safe-nonce37dde003390464c767c11ad05ea5028ebab3800b1108352d91deb73b13ffe63c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4M0I0OjI5NjY1NDoyNzA0NUY4OjM0MEJFRkY6NkIwMUFDNzEiLCJ2aXNpdG9yX2lkIjoiNTQyMzkxMzIxMjYyNDA4ODE3NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac432f9cda08763124edbac2693a854c4e534c1cef42a41923a435909ab2e5b63a
hovercard-subject-tagissue:2949148823
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/coder/coder/17108/issue_layout
twitter:imagehttps://opengraph.githubassets.com/9040a2e6bf0f489bfebef183347016f4321d894f3f08a12e327f1ed207dec114/coder/coder/issues/17108
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9040a2e6bf0f489bfebef183347016f4321d894f3f08a12e327f1ed207dec114/coder/coder/issues/17108
og:image:altwhile working on #16660, I was unable to get a shutdown script to ever run. that's bad! we should figure out why agents aren't runnning shutdown scripts and fix it. when we do, we should move the m...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaslilac
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/coder/coder/issues/17108#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fissues%2F17108
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fissues%2F17108
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/issues/17108
Reloadhttps://github.com/coder/coder/issues/17108
Reloadhttps://github.com/coder/coder/issues/17108
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
https://github.com/coder/coder
New issuehttps://github.com/login?return_to=https://github.com/coder/coder/issues/17108
New issuehttps://github.com/login?return_to=https://github.com/coder/coder/issues/17108
Bughttps://github.com/coder/coder/issues?q=type:"Bug"
#17227https://github.com/coder/coder/pull/17227
investigate why run_on_stop doesn't work consistentlyhttps://github.com/coder/coder/issues/17108#top
#17227https://github.com/coder/coder/pull/17227
https://github.com/mafredri
https://github.com/aslilac
aslilachttps://github.com/aslilac
on Feb 24, 2025https://github.com/coder/coder/issues/17108#issue-2949148823
#16660https://github.com/coder/coder/pull/16660
matifalihttps://github.com/matifali
Bughttps://github.com/coder/coder/issues?q=type:"Bug"
on Feb 27, 2025https://github.com/coder/coder/issues/17108#event-16990200363
https://github.com/matifali
matifalihttps://github.com/matifali
on Feb 27, 2025https://github.com/coder/coder/issues/17108#issuecomment-2753982293
https://discord.com/channels/747933592273027093/1329720357472567296/1329720357472567296https://discord.com/channels/747933592273027093/1329720357472567296/1329720357472567296
aslilachttps://github.com/aslilac
on Feb 27, 2025https://github.com/coder/coder/issues/17108#event-16990200376
matifalihttps://github.com/matifali
coder/internalhttps://github.com/coder/internal
on Mar 26, 2025https://github.com/coder/coder/issues/17108#event-16990200610
matifalihttps://github.com/matifali
Bughttps://github.com/coder/coder/issues?q=type:"Bug"
on Mar 26, 2025https://github.com/coder/coder/issues/17108#event-16990200788
https://github.com/mafredri
mafredrihttps://github.com/mafredri
on Mar 26, 2025https://github.com/coder/coder/issues/17108#issuecomment-2753987512
@aslilachttps://github.com/aslilac
#6174https://github.com/coder/coder/issues/6174
#6175https://github.com/coder/coder/issues/6175
https://github.com/aslilac
aslilachttps://github.com/aslilac
on Mar 26, 2025https://github.com/coder/coder/issues/17108#issuecomment-2754915876
https://github.com/mafredri
mafredrihttps://github.com/mafredri
on Mar 26, 2025https://github.com/coder/coder/issues/17108#issuecomment-2754934536
#17110https://github.com/coder/coder/pull/17110
https://github.com/mafredri
mafredrihttps://github.com/mafredri
on Apr 1, 2025https://github.com/coder/coder/issues/17108#issuecomment-2769004154
@aslilachttps://github.com/aslilac
@spikecurtishttps://github.com/spikecurtis
#6175https://github.com/coder/coder/issues/6175
mafredrihttps://github.com/mafredri
mafredrihttps://github.com/mafredri
aslilachttps://github.com/aslilac
on Apr 2, 2025https://github.com/coder/coder/issues/17108#event-17089698178
mafredrihttps://github.com/mafredri
on Apr 2, 2025https://github.com/coder/coder/issues/17108#event-17095863467
fix(agent): improve SSH server shutdown and continue after timeouthttps://github.com/coder/coder/commit/337dddf9e34a2231037b3acf939fcc64b7956b97
https://docs.github.com/articles/closing-issues-via-commit-messages
337dddfhttps://github.com/coder/coder/commit/337dddf9e34a2231037b3acf939fcc64b7956b97
mafredrihttps://github.com/mafredri
completedhttps://github.com/coder/coder/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#17227https://github.com/coder/coder/pull/17227
on Apr 3, 2025https://github.com/coder/coder/issues/17108#event-17113347328
mafredrihttps://github.com/mafredri
on Apr 3, 2025https://github.com/coder/coder/issues/17108#event-17113347340
fix(agent): ensure SSH server shutdown with process groups (#17227)https://github.com/coder/coder/commit/b61f0ab958309a075bc56f57f47266a2d33475ff
#17227https://github.com/coder/coder/pull/17227
https://docs.github.com/articles/closing-issues-via-commit-messages
b61f0abhttps://github.com/coder/coder/commit/b61f0ab958309a075bc56f57f47266a2d33475ff
Sign up for freehttps://github.com/signup?return_to=https://github.com/coder/coder/issues/17108
Sign in to commenthttps://github.com/login?return_to=https://github.com/coder/coder/issues/17108
mafredrihttps://github.com/mafredri
Bughttps://github.com/coder/coder/issues?q=type:"Bug"
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.