René's URL Explorer Experiment


Title: Codersdk/ts: migrate workspace ttl to ttl_ms · Issue #1707 · coder/coder · GitHub

Open Graph Title: Codersdk/ts: migrate workspace ttl to ttl_ms · Issue #1707 · coder/coder

X Title: Codersdk/ts: migrate workspace ttl to ttl_ms · Issue #1707 · coder/coder

Description: TL;DR make all TTL references in codersdk be milliseconds instead of nanoseconds. Initially when defining the external API for workspace time-to-live (TTL), I simply passed through the Golang time.Duration object as an int64. This is a n...

Open Graph Description: TL;DR make all TTL references in codersdk be milliseconds instead of nanoseconds. Initially when defining the external API for workspace time-to-live (TTL), I simply passed through the Golang time....

X Description: TL;DR make all TTL references in codersdk be milliseconds instead of nanoseconds. Initially when defining the external API for workspace time-to-live (TTL), I simply passed through the Golang time....

Opengraph URL: https://github.com/coder/coder/issues/1707

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Codersdk/ts: migrate workspace ttl to ttl_ms ","articleBody":"TL;DR make all `TTL` references in `codersdk` be milliseconds instead of nanoseconds.\r\n\r\nInitially when defining the external API for workspace time-to-live (TTL), I simply passed through the Golang `time.Duration` object as an `int64`. This is a _nanosecond_ timestamp, which means that the typescript UI needs to multiply/divide any timestamps by 1 million.\r\n\r\nThis is a potential source of future time-bugs (the worst kind of bugs), so it would make sense to align the typescript API with what JS/TS generally uses for timestamps (milliseconds).\r\n\r\n\r\n```\r\nremark (non-blocking): in a follow-up PR, I think it could make sense to migrate `ttl` to `ttl_ms` in externally-facing API types so that we don't accidentally multiply by a million one way or another. Milliseconds seems to be the accepted unit of time in the TS/JS world.\r\n```\r\n_Originally posted by @johnstcn in https://github.com/coder/coder/pull/1701#discussion_r880316837_","author":{"url":"https://github.com/johnstcn","@type":"Person","name":"johnstcn"},"datePublished":"2022-05-24T14:57:26Z","url":"https://github.com/coder/coder/issues/1707"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:777d23df-22f3-a314-61ea-c434f3f94dac
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id84B6:14ECB:1E8D1D3:26C89EF:6B016472
html-safe-nonce39ce8aab2beb2f82a6f16c267e6f6c7ae9975390c0a7ae9ff4d40cab7a41eaef
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NEI2OjE0RUNCOjFFOEQxRDM6MjZDODlFRjo2QjAxNjQ3MiIsInZpc2l0b3JfaWQiOiI5MTM0OTc3NjIxNjczNzMxMTg2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac63e6c16d2a6577a2724d8ab827a9242cf6d7b9ca9adb348a7c2f9ad75d5477bd
hovercard-subject-tagissue:1246690649
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/coder/coder/1707/issue_layout
twitter:imagehttps://opengraph.githubassets.com/3eddcbbc84b60b87a39767d47b333a1f5cdf6427e234324d692895c5159ea70a/coder/coder/issues/1707
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3eddcbbc84b60b87a39767d47b333a1f5cdf6427e234324d692895c5159ea70a/coder/coder/issues/1707
og:image:altTL;DR make all TTL references in codersdk be milliseconds instead of nanoseconds. Initially when defining the external API for workspace time-to-live (TTL), I simply passed through the Golang time....
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejohnstcn
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/coder/coder/issues/1707#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fissues%2F1707
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fissues%2F1707
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/issues/1707
Reloadhttps://github.com/coder/coder/issues/1707
Reloadhttps://github.com/coder/coder/issues/1707
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
https://github.com/coder/coder
New issuehttps://github.com/login?return_to=https://github.com/coder/coder/issues/1707
New issuehttps://github.com/login?return_to=https://github.com/coder/coder/issues/1707
Codersdk/ts: migrate workspace ttl to ttl_ms https://github.com/coder/coder/issues/1707#top
apiArea: HTTP APIhttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22api%22
staleThis issue is like stale bread.https://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22stale%22
https://github.com/johnstcn
johnstcnhttps://github.com/johnstcn
on May 24, 2022https://github.com/coder/coder/issues/1707#issue-1246690649
@johnstcnhttps://github.com/johnstcn
#1701 (comment)https://github.com/coder/coder/pull/1701#discussion_r880316837
johnstcnhttps://github.com/johnstcn
regression-prevention 🧷https://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22regression-prevention%20%3Asafety_pin%3A%22
apiArea: HTTP APIhttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22api%22
brainbreak 🧠https://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22brainbreak%20%3Abrain%3A%22
needs grooming 🪒https://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22needs%20grooming%20%3Arazor%3A%22
brainbreak 🧠https://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22brainbreak%20%3Abrain%3A%22
on May 24, 2022https://github.com/coder/coder/issues/1707#event-6669899929
kylecarbshttps://github.com/kylecarbs
on Jun 7, 2022https://github.com/coder/coder/issues/1707#event-6757282814
kylecarbshttps://github.com/kylecarbs
chorehttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22chore%22
on Jun 7, 2022https://github.com/coder/coder/issues/1707#event-6757282825
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
on Aug 7, 2022https://github.com/coder/coder/issues/1707#issuecomment-1207302100
github-actionshttps://github.com/apps/github-actions
staleThis issue is like stale bread.https://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22stale%22
on Aug 7, 2022https://github.com/coder/coder/issues/1707#event-7141537986
github-actionshttps://github.com/apps/github-actions
completedhttps://github.com/coder/coder/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Aug 15, 2022https://github.com/coder/coder/issues/1707#event-7185370082
johnstcnhttps://github.com/johnstcn
on Aug 15, 2022https://github.com/coder/coder/issues/1707#event-7187256713
johnstcnhttps://github.com/johnstcn
staleThis issue is like stale bread.https://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22stale%22
on Aug 15, 2022https://github.com/coder/coder/issues/1707#event-7187257538
kylecarbshttps://github.com/kylecarbs
needs groominghttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22needs%20grooming%22
on Aug 22, 2022https://github.com/coder/coder/issues/1707#event-7236651525
bpmcthttps://github.com/bpmct
debthttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22debt%22
on Sep 21, 2022https://github.com/coder/coder/issues/1707#event-7427232131
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
on Nov 21, 2022https://github.com/coder/coder/issues/1707#issuecomment-1321286462
github-actionshttps://github.com/apps/github-actions
staleThis issue is like stale bread.https://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22stale%22
on Nov 21, 2022https://github.com/coder/coder/issues/1707#event-7852470809
github-actionshttps://github.com/apps/github-actions
not plannedhttps://github.com/coder/coder/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Anot-planned
on Nov 29, 2022https://github.com/coder/coder/issues/1707#event-7907826809
Sign up for freehttps://github.com/signup?return_to=https://github.com/coder/coder/issues/1707
Sign in to commenthttps://github.com/login?return_to=https://github.com/coder/coder/issues/1707
apiArea: HTTP APIhttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22api%22
staleThis issue is like stale bread.https://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22stale%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.