René's URL Explorer Experiment


Title: Bug: Goroutine leak in `coderd.(*api).workspaceAgentTurn` · Issue #1508 · coder/coder · GitHub

Open Graph Title: Bug: Goroutine leak in `coderd.(*api).workspaceAgentTurn` · Issue #1508 · coder/coder

X Title: Bug: Goroutine leak in `coderd.(*api).workspaceAgentTurn` · Issue #1508 · coder/coder

Description: There seems to be a goroutine leak in coderd.(*api).workspaceAgentTurn. This could be seen as two bugs: Goroutine leak Use of (*http.Request).Context() after Hijack in more than one place Steps to Reproduce Enable pprof for coder server ...

Open Graph Description: There seems to be a goroutine leak in coderd.(*api).workspaceAgentTurn. This could be seen as two bugs: Goroutine leak Use of (*http.Request).Context() after Hijack in more than one place Steps to ...

X Description: There seems to be a goroutine leak in coderd.(*api).workspaceAgentTurn. This could be seen as two bugs: Goroutine leak Use of (*http.Request).Context() after Hijack in more than one place Steps to ...

Opengraph URL: https://github.com/coder/coder/issues/1508

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Bug: Goroutine leak in `coderd.(*api).workspaceAgentTurn`","articleBody":"There seems to be a goroutine leak in `coderd.(*api).workspaceAgentTurn`.\r\n\r\nThis could be seen as two bugs:\r\n\r\n1. Goroutine leak\r\n2. Use of `(*http.Request).Context()` after `Hijack` in more than one place\r\n\r\n## Steps to Reproduce\r\n\r\n0. Enable pprof for coder server\r\n1. `coder ssh dev`\r\n3. `ctlr+d`\r\n4. Goto 1\r\n5. Check pprof (`go tool pprof -http=:8080 http://localhost:6060/debug/pprof/goroutine`)\r\n\r\nThe leak is in part due to reliance on the `http.Request` context and use of websockets. The underlying websocket library calls `(*http.Request).Hijack` which disables context propagation.\r\n\r\nThis happens here: https://github.com/coder/coder/blob/668a6712e62a839a193544e431552744520b05df/coderd/workspaceagents.go#L304\r\n\r\nAnd the following contexts will not cancel until the http handler completes:\r\nhttps://github.com/coder/coder/blob/668a6712e62a839a193544e431552744520b05df/coderd/workspaceagents.go#L316\r\n\r\nhttps://github.com/coder/coder/blob/668a6712e62a839a193544e431552744520b05df/coderd/workspaceagents.go#L320\r\n\r\nWe must avoid using `r.Context()` after hijack, unless we are using it with the expectation that the http handler will exit (at which point the context will complete).\r\n\r\nI'm unfamiliar with the [`pion/turn`](https://github.com/pion/turn) package, but another factor could be wrt how it handles connection closure, perhaps it does not propagate as we expect since we're not calling `wsConn.Close()` due to context reliance?\r\n\r\n---\r\n\r\nSimilar reliance on request context after hijack is done elsewhere, we should rethink all of them. Example:\r\n\r\nhttps://github.com/coder/coder/blob/668a6712e62a839a193544e431552744520b05df/coderd/workspaceagents.go#L155","author":{"url":"https://github.com/mafredri","@type":"Person","name":"mafredri"},"datePublished":"2022-05-17T13:08:09Z","url":"https://github.com/coder/coder/issues/1508"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:6996a30f-a7d9-7534-a7c6-3e4cca3c05f6
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id9B78:14700E:21FCE14:2B0FE18:6B0176C2
html-safe-nonce8852ecb701ae728f370f1fa9caababebbb03011511812822a3f28d01474e81f5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Qjc4OjE0NzAwRToyMUZDRTE0OjJCMEZFMTg6NkIwMTc2QzIiLCJ2aXNpdG9yX2lkIjoiNzExMzkwNDQxNzQ5NzI0OTQ3NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac46112c89ae85befb6f815f74f24f59daf9837365b91f7716fc6032773010ecc2
hovercard-subject-tagissue:1238616415
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/coder/coder/1508/issue_layout
twitter:imagehttps://opengraph.githubassets.com/446ad9ef1fd3f4f15c4bff6f3fb032c907b7657144af79289e00623528a5b842/coder/coder/issues/1508
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/446ad9ef1fd3f4f15c4bff6f3fb032c907b7657144af79289e00623528a5b842/coder/coder/issues/1508
og:image:altThere seems to be a goroutine leak in coderd.(*api).workspaceAgentTurn. This could be seen as two bugs: Goroutine leak Use of (*http.Request).Context() after Hijack in more than one place Steps to ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemafredri
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/coder/coder/issues/1508#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fissues%2F1508
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fissues%2F1508
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/issues/1508
Reloadhttps://github.com/coder/coder/issues/1508
Reloadhttps://github.com/coder/coder/issues/1508
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
https://github.com/coder/coder
New issuehttps://github.com/login?return_to=https://github.com/coder/coder/issues/1508
New issuehttps://github.com/login?return_to=https://github.com/coder/coder/issues/1508
#1978https://github.com/coder/coder/pull/1978
Bug: Goroutine leak in coderd.(*api).workspaceAgentTurnhttps://github.com/coder/coder/issues/1508#top
#1978https://github.com/coder/coder/pull/1978
https://github.com/mafredri
apiArea: HTTP APIhttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22api%22
Community MVPhttps://github.com/coder/coder/milestone/2
https://github.com/mafredri
mafredrihttps://github.com/mafredri
on May 17, 2022https://github.com/coder/coder/issues/1508#issue-1238616415
coder/coderd/workspaceagents.gohttps://github.com/coder/coder/blob/668a6712e62a839a193544e431552744520b05df/coderd/workspaceagents.go#L304
668a671https://github.com/coder/coder/commit/668a6712e62a839a193544e431552744520b05df
coder/coderd/workspaceagents.gohttps://github.com/coder/coder/blob/668a6712e62a839a193544e431552744520b05df/coderd/workspaceagents.go#L316
668a671https://github.com/coder/coder/commit/668a6712e62a839a193544e431552744520b05df
coder/coderd/workspaceagents.gohttps://github.com/coder/coder/blob/668a6712e62a839a193544e431552744520b05df/coderd/workspaceagents.go#L320
668a671https://github.com/coder/coder/commit/668a6712e62a839a193544e431552744520b05df
pion/turnhttps://github.com/pion/turn
coder/coderd/workspaceagents.gohttps://github.com/coder/coder/blob/668a6712e62a839a193544e431552744520b05df/coderd/workspaceagents.go#L155
668a671https://github.com/coder/coder/commit/668a6712e62a839a193544e431552744520b05df
mafredrihttps://github.com/mafredri
bug 🐛https://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22bug%20%3Abug%3A%22
needs grooming 🪒https://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22needs%20grooming%20%3Arazor%3A%22
apiArea: HTTP APIhttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22api%22
on May 17, 2022https://github.com/coder/coder/issues/1508#event-6624335873
https://github.com/kylecarbs
kylecarbshttps://github.com/kylecarbs
on May 17, 2022https://github.com/coder/coder/issues/1508#issuecomment-1128889915
https://github.com/tjcran
tjcranhttps://github.com/tjcran
on May 30, 2022https://github.com/coder/coder/issues/1508#issuecomment-1141535874
@mafredrihttps://github.com/mafredri
https://github.com/ketang
ketanghttps://github.com/ketang
on May 31, 2022https://github.com/coder/coder/issues/1508#issuecomment-1141548011
https://github.com/mafredri
mafredrihttps://github.com/mafredri
on May 31, 2022https://github.com/coder/coder/issues/1508#issuecomment-1141955243
@tjcranhttps://github.com/tjcran
@ketanghttps://github.com/ketang
https://github.com/tjcran
tjcranhttps://github.com/tjcran
on Jun 1, 2022https://github.com/coder/coder/issues/1508#issuecomment-1143674621
@tjcranhttps://github.com/tjcran
@mafredrihttps://github.com/mafredri
tjcranhttps://github.com/tjcran
Community MVPhttps://github.com/coder/coder/milestone/2
on Jun 1, 2022https://github.com/coder/coder/issues/1508#event-6719568541
tjcranhttps://github.com/tjcran
Community MVP 🏁https://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22Community%20MVP%20%3Acheckered_flag%3A%22
on Jun 1, 2022https://github.com/coder/coder/issues/1508#event-6719570772
mafredrihttps://github.com/mafredri
on Jun 1, 2022https://github.com/coder/coder/issues/1508#event-6721686007
mafredrihttps://github.com/mafredri
completedhttps://github.com/coder/coder/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#1978https://github.com/coder/coder/pull/1978
on Jun 3, 2022https://github.com/coder/coder/issues/1508#event-6735118614
missknisshttps://github.com/misskniss
needs groominghttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22needs%20grooming%22
on Jun 14, 2022https://github.com/coder/coder/issues/1508#event-6800489086
Sign up for freehttps://github.com/signup?return_to=https://github.com/coder/coder/issues/1508
Sign in to commenthttps://github.com/login?return_to=https://github.com/coder/coder/issues/1508
mafredrihttps://github.com/mafredri
apiArea: HTTP APIhttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22api%22
Community MVPhttps://github.com/coder/coder/milestone/2
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.