René's URL Explorer Experiment


Title: Bug: race conditions in creating workspace_builds · Issue #1366 · coder/coder · GitHub

Open Graph Title: Bug: race conditions in creating workspace_builds · Issue #1366 · coder/coder

X Title: Bug: race conditions in creating workspace_builds · Issue #1366 · coder/coder

Description: OS Information OS: n/a Browser (if applicable): Architecture: coder --version: Coder v0.5.4-devel+d847d2b Spotted while reading code Steps to Reproduce execute "start" on a workspace from two clients simultaneously Expected one succeeds,...

Open Graph Description: OS Information OS: n/a Browser (if applicable): Architecture: coder --version: Coder v0.5.4-devel+d847d2b Spotted while reading code Steps to Reproduce execute "start" on a workspace from two clien...

X Description: OS Information OS: n/a Browser (if applicable): Architecture: coder --version: Coder v0.5.4-devel+d847d2b Spotted while reading code Steps to Reproduce execute "start" on a workspace from...

Opengraph URL: https://github.com/coder/coder/issues/1366

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Bug: race conditions in creating workspace_builds ","articleBody":"## OS Information\r\n\r\n- OS: n/a\r\n- Browser (if applicable): \r\n- Architecture:\r\n- `coder --version`: Coder v0.5.4-devel+d847d2b\r\n\r\nSpotted while reading code\r\n\r\n## Steps to Reproduce\r\n\r\n1. execute \"start\" on a workspace from two clients simultaneously\r\n\r\n## Expected\r\n\r\none succeeds, other fails\r\n\r\n## Actual\r\n\r\nsometimes, both can succeed\r\n\r\n## Logs\r\n\r\n## Screenshot\r\n\r\n\u003c!-- Ideally provide a screenshot, gif, video or screen recording. -->\r\n\r\n## Notes\r\n\r\nThe issue is that coderd reads the DB to find the previous build, then later updates that build while adding a new build.  The build could be updated and no longer be the latest during this time.  What is needed is either:\r\n\r\n1. A query that finds and updates the latest build as well as adds the new build in a single transaction.  This requires all \"is this an allowed transition\" logic to be build into the query.\r\n2. Start and hold open a transaction while doing multiple queries: reading the latest build, checking for errors, and finally writing the new build.\r\n\r\n\r\n","author":{"url":"https://github.com/spikecurtis","@type":"Person","name":"spikecurtis"},"datePublished":"2022-05-10T17:15:51Z","url":"https://github.com/coder/coder/issues/1366"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:646ec2f4-ddad-c130-aece-b385828de2de
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idBCF8:3F4253:298369A:37504B1:6B01BC76
html-safe-nonce2743f002c3e1bfa1c1442513d4de7ece485c0b4ca269e0a874e77dda62384f69
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQ0Y4OjNGNDI1MzoyOTgzNjlBOjM3NTA0QjE6NkIwMUJDNzYiLCJ2aXNpdG9yX2lkIjoiMjM0MzA3OTE5MjA1NDMxNjE1MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacccb71ec2a52372f09d48d0c316489ca7d3fe6f39bdd5830c7e97bb2565f8497a
hovercard-subject-tagissue:1231460970
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/coder/coder/1366/issue_layout
twitter:imagehttps://opengraph.githubassets.com/0135ec37218d2ab3d834961b5c03d67d8b82f43318dc9b6767922e328f372310/coder/coder/issues/1366
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0135ec37218d2ab3d834961b5c03d67d8b82f43318dc9b6767922e328f372310/coder/coder/issues/1366
og:image:altOS Information OS: n/a Browser (if applicable): Architecture: coder --version: Coder v0.5.4-devel+d847d2b Spotted while reading code Steps to Reproduce execute "start" on a workspace from two clien...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamespikecurtis
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/coder/coder/issues/1366#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fissues%2F1366
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fissues%2F1366
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/issues/1366
Reloadhttps://github.com/coder/coder/issues/1366
Reloadhttps://github.com/coder/coder/issues/1366
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
https://github.com/coder/coder
New issuehttps://github.com/login?return_to=https://github.com/coder/coder/issues/1366
New issuehttps://github.com/login?return_to=https://github.com/coder/coder/issues/1366
#1534https://github.com/coder/coder/pull/1534
Bug: race conditions in creating workspace_builds https://github.com/coder/coder/issues/1366#top
#1534https://github.com/coder/coder/pull/1534
https://github.com/spikecurtis
apiArea: HTTP APIhttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22api%22
Community MVPhttps://github.com/coder/coder/milestone/2
https://github.com/spikecurtis
spikecurtishttps://github.com/spikecurtis
on May 10, 2022https://github.com/coder/coder/issues/1366#issue-1231460970
spikecurtishttps://github.com/spikecurtis
bug 🐛https://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22bug%20%3Abug%3A%22
apiArea: HTTP APIhttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22api%22
needs grooming 🪒https://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22needs%20grooming%20%3Arazor%3A%22
on May 10, 2022https://github.com/coder/coder/issues/1366#event-6583816039
missknisshttps://github.com/misskniss
needs grooming 🪒https://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22needs%20grooming%20%3Arazor%3A%22
needs grooming 🪒https://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22needs%20grooming%20%3Arazor%3A%22
on May 12, 2022https://github.com/coder/coder/issues/1366#event-6595271539
tjcranhttps://github.com/tjcran
Community MVPhttps://github.com/coder/coder/milestone/2
Enterprise MVP https://github.com/coder/coder/milestone/5
on May 16, 2022https://github.com/coder/coder/issues/1366#event-6612821007
tjcranhttps://github.com/tjcran
Enterprise MVP 🏁https://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22Enterprise%20MVP%20%3Acheckered_flag%3A%22
needs grooming 🪒https://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22needs%20grooming%20%3Arazor%3A%22
on May 16, 2022https://github.com/coder/coder/issues/1366#event-6612822116
https://github.com/tjcran
tjcranhttps://github.com/tjcran
on May 16, 2022https://github.com/coder/coder/issues/1366#issuecomment-1127199391
spikecurtishttps://github.com/spikecurtis
completedhttps://github.com/coder/coder/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#1534https://github.com/coder/coder/pull/1534
on May 18, 2022https://github.com/coder/coder/issues/1366#event-6633944260
missknisshttps://github.com/misskniss
spikecurtishttps://github.com/spikecurtis
on Jun 3, 2022https://github.com/coder/coder/issues/1366#event-6733202620
missknisshttps://github.com/misskniss
Enterprise MVP https://github.com/coder/coder/milestone/5
Community MVPhttps://github.com/coder/coder/milestone/2
on Jun 3, 2022https://github.com/coder/coder/issues/1366#event-6733204657
missknisshttps://github.com/misskniss
Community MVP 🏁https://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22Community%20MVP%20%3Acheckered_flag%3A%22
on Jun 3, 2022https://github.com/coder/coder/issues/1366#event-6733273028
Sign up for freehttps://github.com/signup?return_to=https://github.com/coder/coder/issues/1366
Sign in to commenthttps://github.com/login?return_to=https://github.com/coder/coder/issues/1366
spikecurtishttps://github.com/spikecurtis
apiArea: HTTP APIhttps://github.com/coder/coder/issues?q=state%3Aopen%20label%3A%22api%22
Community MVPhttps://github.com/coder/coder/milestone/2
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.