René's URL Explorer Experiment


Title: Fix false booleans in config file being parsed as true by harshbhx · Pull Request #8053 · coder/code-server · GitHub

Open Graph Title: Fix false booleans in config file being parsed as true by harshbhx · Pull Request #8053 · coder/code-server

X Title: Fix false booleans in config file being parsed as true by harshbhx · Pull Request #8053 · coder/code-server

Description: Fixes #8049 Summary Boolean options set to false in config.yaml were being treated as true. This PR makes parse() ignore booleans whose value is false, the same way it already ignores optional strings set to false. Problem parseConfigFile() turns each config entry into a CLI-style flag (src/node/cli.ts#L815-L824): config.yaml Generated flag enable-remote-storage: true --enable-remote-storage enable-remote-storage: false --enable-remote-storage=false parse() then sets any boolean option it sees to true, without looking at the value (src/node/cli.ts#L438-L441): if (option.type === "boolean") { ;(args[key] as boolean) = true continue } So writing false in the config file silently does the opposite of what the user asked. This affects every boolean option, for example disable-telemetry, disable-update-check, disable-workspace-trust and enable-remote-storage (the case reported in #7914). Solution Skip the assignment when a boolean's value is "false": if (option.type === "boolean") { // Booleans set to false (for example `--flag=false`, which is also how // false values from the config file are passed in) are ignored. if (value !== "false") { ;(args[key] as boolean) = true } continue } Why this approach It follows existing behavior: optional strings set to false are already ignored in the same function (#L460), and there's a test for it (--cert=false → {}). The fix lives in the shared parser rather than only in parseConfigFile(), so --flag=false on the command line now works too instead of enabling the flag. Leaving the key unset (rather than setting it to false) keeps the existing merge semantics between the config file and CLI args untouched. Changes File Change src/node/cli.ts Ignore boolean options whose value is false (+5 / −1) test/unit/node/cli.test.ts Two new unit tests (+13) Before / After config.yaml: disable-telemetry: false disable-update-check: true Parsed result Before { "disable-telemetry": true, "disable-update-check": true } ❌ After { "disable-update-check": true } ✅ How to test Add enable-remote-storage: false (or any boolean option set to false) to ~/.config/code-server/config.yaml. Start code-server without overriding that option on the command line. Before: the option is enabled. After: it stays disabled. Optionally, run code-server --disable-telemetry=false and confirm telemetry is no longer disabled. Testing done should ignore booleans set to false: parse(["--disable-telemetry=false"]) returns {}. should parse booleans set to false in the config file: a config with one false and one true boolean only keeps the true one. Both new tests fail without the fix and pass with it. Full unit suite: 347 / 347 passed (npm run test:unit). Prettier, ESLint and tsc --noEmit are clean. Not tested end to end in a running code-server instance (the change is limited to argument parsing, which the unit tests cover directly). Notes for reviewers Behavior change: anyone who has some-flag: false in their config and was (unknowingly) relying on it being enabled will now get it disabled, which is what their config says. I'd consider this a bug fix, but it may be worth a changelog note. The commit is signed, as required by the contributing guide.

Open Graph Description: Fixes #8049 Summary Boolean options set to false in config.yaml were being treated as true. This PR makes parse() ignore booleans whose value is false, the same way it already ignores optional stri...

X Description: Fixes #8049 Summary Boolean options set to false in config.yaml were being treated as true. This PR makes parse() ignore booleans whose value is false, the same way it already ignores optional stri...

Opengraph URL: https://github.com/coder/code-server/pull/8053

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:24d302c6-0cb6-7d48-417e-f2fa9bf423dd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD688:2463BD:2F71403:3C9AFE9:6B01B8B1
html-safe-nonce2321daa28e94922e39cac6ccec589650ec1b13f273efd497a3ef758d6945e1ba
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENjg4OjI0NjNCRDoyRjcxNDAzOjNDOUFGRTk6NkIwMUI4QjEiLCJ2aXNpdG9yX2lkIjoiNDU5ODYwMTM2MzcwMDY5MzE2OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4514e4e0e20607add94120eb9315cb659e462722d97464e011a42eba70b455e9
hovercard-subject-tagpull_request:4849121778
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/coder/code-server/pull/8053/files
twitter:imagehttps://avatars.githubusercontent.com/u/155092207?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/155092207?s=400&v=4
og:image:altFixes #8049 Summary Boolean options set to false in config.yaml were being treated as true. This PR makes parse() ignore booleans whose value is false, the same way it already ignores optional stri...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/coder/code-server git https://github.com/coder/code-server.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id172953845
octolytics-dimension-repository_nwocoder/code-server
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id172953845
octolytics-dimension-repository_network_root_nwocoder/code-server
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/coder/code-server/pull/8053/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcode-server%2Fpull%2F8053%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcode-server%2Fpull%2F8053%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=coder%2Fcode-server
Reloadhttps://github.com/coder/code-server/pull/8053/files
Reloadhttps://github.com/coder/code-server/pull/8053/files
Reloadhttps://github.com/coder/code-server/pull/8053/files
coderhttps://github.com/coder
code-serverhttps://github.com/coder/code-server
Codehttps://github.com/coder/code-server
Issues147 (147)https://github.com/coder/code-server/issues
Pull requests17 (17)https://github.com/coder/code-server/pulls
Discussionshttps://github.com/coder/code-server/discussions
Actionshttps://github.com/coder/code-server/actions
Projectshttps://github.com/coder/code-server/projects
Security and quality3 (3)https://github.com/coder/code-server/security
Insightshttps://github.com/coder/code-server/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fcoder%2Fcode-server%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fcoder%2Fcode-server%2Fissues%2Fnew%2Fchoose
code-asherhttps://github.com/code-asher
coder:mainhttps://github.com/coder/code-server/tree/main
harshbhx:fix/8049-config-false-booleanshttps://github.com/harshbhx/code-server/tree/fix/8049-config-false-booleans
Conversation 2 https://github.com/coder/code-server/pull/8053
Commits 1 https://github.com/coder/code-server/pull/8053/commits
Checks 13 https://github.com/coder/code-server/pull/8053/checks
Files changed https://github.com/coder/code-server/pull/8053/files
Please reload this pagehttps://github.com/coder/code-server/pull/8053/files
Fix false booleans in config file being parsed as true https://github.com/coder/code-server/pull/8053/files#top
Show all changes 1 commit https://github.com/coder/code-server/pull/8053/files
858aec2 Fix false booleans in config file being parsed as true harshbhx Oct 13, 2026 https://github.com/coder/code-server/pull/8053/commits/858aec28210c34d9cefda5685f34d6c9a48c3d0c
Clear filters https://github.com/coder/code-server/pull/8053/files
Please reload this pagehttps://github.com/coder/code-server/pull/8053/files
Please reload this pagehttps://github.com/coder/code-server/pull/8053/files
cli.ts https://github.com/coder/code-server/pull/8053/files#diff-e1f89aee8992fa7022cc43adb93042f9bbb4b223f0d6cd0e70719cf4b795afa4
cli.test.ts https://github.com/coder/code-server/pull/8053/files#diff-259502f3217ff57aa0efe8405a96d85558f638b6a1a27a3f772f7dda96ddc8f2
https://github.com/coder/code-server/blob/main/.github/CODEOWNERS#L1
src/node/cli.tshttps://github.com/coder/code-server/pull/8053/files#diff-e1f89aee8992fa7022cc43adb93042f9bbb4b223f0d6cd0e70719cf4b795afa4
View file https://github.com/harshbhx/code-server/blob/858aec28210c34d9cefda5685f34d6c9a48c3d0c/src/node/cli.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/code-server/pull/8053/{{ revealButtonHref }}
https://github.com/coder/code-server/pull/8053/files#diff-e1f89aee8992fa7022cc43adb93042f9bbb4b223f0d6cd0e70719cf4b795afa4
https://github.com/coder/code-server/pull/8053/files#diff-e1f89aee8992fa7022cc43adb93042f9bbb4b223f0d6cd0e70719cf4b795afa4
https://github.com/coder/code-server/blob/main/.github/CODEOWNERS#L1
test/unit/node/cli.test.tshttps://github.com/coder/code-server/pull/8053/files#diff-259502f3217ff57aa0efe8405a96d85558f638b6a1a27a3f772f7dda96ddc8f2
View file https://github.com/harshbhx/code-server/blob/858aec28210c34d9cefda5685f34d6c9a48c3d0c/test/unit/node/cli.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/code-server/pull/8053/{{ revealButtonHref }}
https://github.com/coder/code-server/pull/8053/files#diff-259502f3217ff57aa0efe8405a96d85558f638b6a1a27a3f772f7dda96ddc8f2
https://github.com/coder/code-server/pull/8053/files#diff-259502f3217ff57aa0efe8405a96d85558f638b6a1a27a3f772f7dda96ddc8f2
Please reload this pagehttps://github.com/coder/code-server/pull/8053/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.