René's URL Explorer Experiment


Title: fix: re-enable skipped Heart tests and make non-asserting checks assert by voidmatcha · Pull Request #7845 · coder/code-server · GitHub

Open Graph Title: fix: re-enable skipped Heart tests and make non-asserting checks assert by voidmatcha · Pull Request #7845 · coder/code-server

X Title: fix: re-enable skipped Heart tests and make non-asserting checks assert by voidmatcha · Pull Request #7845 · coder/code-server

Description: This PR fixes test checks that cannot fail: it.only committed in #7539 (test/unit/node/heart.test.ts): silently skipped the other 8 Heart tests in CI for the past 7 months. One of them stopped passing while disabled (its rejection handler runs on the microtask queue, after the assertion), re-enabled and repaired with a microtask drain. expect() with no matcher (login.test.ts, 4×): asserted nothing; the error-message tests passed whether or not the message rendered. Dangling locator (extensions.test.ts): await page.getByText(...) with no assertion. One-shot page.isVisible() reads (downloads/uploads/github/codeServer, 16×): returns immediately with no auto-retry; converted to web-first assertions: - expect(await codeServerPage.page.isVisible("text=Show Local")).toBe(false) + await expect(codeServerPage.page.locator("text=Show Local")).not.toBeVisible() No assertions were removed and no behavior added. Every change strengthens an existing check. Verification: ./ci/dev/test-unit.sh test/unit/node/heart.test.ts - 9/9 pass; tsc --noEmit + repo ESLint clean on changed files. The Playwright e2e suite was not run locally (requires a full code-server build), the e2e changes are mechanical assertion-form conversions. Happy to iterate if CI surfaces anything. Found while reviewing the test suite with e2e-skills/e2e-reviewer, which flags committed .only leaks, one-shot visibility reads, and matcher-less expect() calls.

Open Graph Description: This PR fixes test checks that cannot fail: it.only committed in #7539 (test/unit/node/heart.test.ts): silently skipped the other 8 Heart tests in CI for the past 7 months. One of them stopped pas...

X Description: This PR fixes test checks that cannot fail: it.only committed in #7539 (test/unit/node/heart.test.ts): silently skipped the other 8 Heart tests in CI for the past 7 months. One of them stopped pas...

Opengraph URL: https://github.com/coder/code-server/pull/7845

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5325ffdc-aa97-cee7-1814-a7d2530429df
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id97DE:1F65:1D5F80C:2559523:6B01B8CA
html-safe-noncea0f88264c285dbca5118509dae8ec0bbb982aea41cf23ecf7a3391af0ce0499e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5N0RFOjFGNjU6MUQ1RjgwQzoyNTU5NTIzOjZCMDFCOENBIiwidmlzaXRvcl9pZCI6IjY1ODkyNzc4OTQ2MTc0NDY2MDIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac60fc635f56f6b07c5128245163e591dabee78807830d797ab6415f0492f095d5
hovercard-subject-tagpull_request:3848517638
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/coder/code-server/pull/7845/files
twitter:imagehttps://avatars.githubusercontent.com/u/16266103?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/16266103?s=400&v=4
og:image:altThis PR fixes test checks that cannot fail: it.only committed in #7539 (test/unit/node/heart.test.ts): silently skipped the other 8 Heart tests in CI for the past 7 months. One of them stopped pas...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/coder/code-server git https://github.com/coder/code-server.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id172953845
octolytics-dimension-repository_nwocoder/code-server
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id172953845
octolytics-dimension-repository_network_root_nwocoder/code-server
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/coder/code-server/pull/7845/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcode-server%2Fpull%2F7845%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcode-server%2Fpull%2F7845%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=coder%2Fcode-server
Reloadhttps://github.com/coder/code-server/pull/7845/files
Reloadhttps://github.com/coder/code-server/pull/7845/files
Reloadhttps://github.com/coder/code-server/pull/7845/files
coderhttps://github.com/coder
code-serverhttps://github.com/coder/code-server
Codehttps://github.com/coder/code-server
Issues147 (147)https://github.com/coder/code-server/issues
Pull requests17 (17)https://github.com/coder/code-server/pulls
Discussionshttps://github.com/coder/code-server/discussions
Actionshttps://github.com/coder/code-server/actions
Projectshttps://github.com/coder/code-server/projects
Security and quality3 (3)https://github.com/coder/code-server/security
Insightshttps://github.com/coder/code-server/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fcoder%2Fcode-server%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fcoder%2Fcode-server%2Fissues%2Fnew%2Fchoose
code-asherhttps://github.com/code-asher
coder:mainhttps://github.com/coder/code-server/tree/main
voidmatcha:fix/e2e-non-asserting-checkshttps://github.com/voidmatcha/code-server/tree/fix/e2e-non-asserting-checks
Conversation 3 https://github.com/coder/code-server/pull/7845
Commits 2 https://github.com/coder/code-server/pull/7845/commits
Checks 12 https://github.com/coder/code-server/pull/7845/checks
Files changed https://github.com/coder/code-server/pull/7845/files
Please reload this pagehttps://github.com/coder/code-server/pull/7845/files
fix: re-enable skipped Heart tests and make non-asserting checks assert https://github.com/coder/code-server/pull/7845/files#top
Show all changes 2 commits https://github.com/coder/code-server/pull/7845/files
ec595ea fix: re-enable skipped Heart tests and make non-asserting checks assert voidmatcha Jun 11, 2026 https://github.com/coder/code-server/pull/7845/commits/ec595ea2752c0ddb6426ad9e09f500037302bf3d
e9b15b2 test: repair never-passable login tests and tighten the timer flush voidmatcha Jun 12, 2026 https://github.com/coder/code-server/pull/7845/commits/e9b15b232cc3b8aad0d550e7f0646559c02dd0fa
Clear filters https://github.com/coder/code-server/pull/7845/files
Please reload this pagehttps://github.com/coder/code-server/pull/7845/files
Please reload this pagehttps://github.com/coder/code-server/pull/7845/files
codeServer.test.ts https://github.com/coder/code-server/pull/7845/files#diff-a460c5263dbfde4538ffff9faaebb47b490e0b5ec9a23a955c9244dc3f9026a3
downloads.test.ts https://github.com/coder/code-server/pull/7845/files#diff-2a481d33c0cf1ba4695bb3817a8d0ae3fcdeac2cbadbea5285b4cfb819713f02
extensions.test.ts https://github.com/coder/code-server/pull/7845/files#diff-9e97b686b1f5f63a003043a3b6349a978cae07fd0d65144f49b0324536e94628
github.test.ts https://github.com/coder/code-server/pull/7845/files#diff-5a3bbfeab7d7efb08e9935283f8f4db29bf73c56cdeca787af3344de0302eb3d
login.test.ts https://github.com/coder/code-server/pull/7845/files#diff-c0e739eb293dc0a512b8abe27c27884ed23e591b23075fa4b7cb1fc53d6fde13
uploads.test.ts https://github.com/coder/code-server/pull/7845/files#diff-aabe283d76697e83752387d9865fc6350d387f3643471da95065de4af036890c
heart.test.ts https://github.com/coder/code-server/pull/7845/files#diff-209330cadcf86c6dda745c2cfcb29c1c7c5d9d80fbf4ef38b2b1356d81155cde
https://github.com/coder/code-server/blob/main/.github/CODEOWNERS#L1
test/e2e/codeServer.test.tshttps://github.com/coder/code-server/pull/7845/files#diff-a460c5263dbfde4538ffff9faaebb47b490e0b5ec9a23a955c9244dc3f9026a3
View file https://github.com/voidmatcha/code-server/blob/e9b15b232cc3b8aad0d550e7f0646559c02dd0fa/test/e2e/codeServer.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/code-server/pull/7845/{{ revealButtonHref }}
https://github.com/coder/code-server/pull/7845/files#diff-a460c5263dbfde4538ffff9faaebb47b490e0b5ec9a23a955c9244dc3f9026a3
https://github.com/coder/code-server/pull/7845/files#diff-a460c5263dbfde4538ffff9faaebb47b490e0b5ec9a23a955c9244dc3f9026a3
https://github.com/coder/code-server/blob/main/.github/CODEOWNERS#L1
test/e2e/downloads.test.tshttps://github.com/coder/code-server/pull/7845/files#diff-2a481d33c0cf1ba4695bb3817a8d0ae3fcdeac2cbadbea5285b4cfb819713f02
View file https://github.com/voidmatcha/code-server/blob/e9b15b232cc3b8aad0d550e7f0646559c02dd0fa/test/e2e/downloads.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/code-server/pull/7845/{{ revealButtonHref }}
https://github.com/coder/code-server/pull/7845/files#diff-2a481d33c0cf1ba4695bb3817a8d0ae3fcdeac2cbadbea5285b4cfb819713f02
https://github.com/coder/code-server/pull/7845/files#diff-2a481d33c0cf1ba4695bb3817a8d0ae3fcdeac2cbadbea5285b4cfb819713f02
https://github.com/coder/code-server/pull/7845/files#diff-2a481d33c0cf1ba4695bb3817a8d0ae3fcdeac2cbadbea5285b4cfb819713f02
https://github.com/coder/code-server/pull/7845/files#diff-2a481d33c0cf1ba4695bb3817a8d0ae3fcdeac2cbadbea5285b4cfb819713f02
https://github.com/coder/code-server/pull/7845/files#diff-2a481d33c0cf1ba4695bb3817a8d0ae3fcdeac2cbadbea5285b4cfb819713f02
https://github.com/coder/code-server/pull/7845/files#diff-2a481d33c0cf1ba4695bb3817a8d0ae3fcdeac2cbadbea5285b4cfb819713f02
https://github.com/coder/code-server/blob/main/.github/CODEOWNERS#L1
test/e2e/extensions.test.tshttps://github.com/coder/code-server/pull/7845/files#diff-9e97b686b1f5f63a003043a3b6349a978cae07fd0d65144f49b0324536e94628
View file https://github.com/voidmatcha/code-server/blob/e9b15b232cc3b8aad0d550e7f0646559c02dd0fa/test/e2e/extensions.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/code-server/pull/7845/{{ revealButtonHref }}
https://github.com/coder/code-server/pull/7845/files#diff-9e97b686b1f5f63a003043a3b6349a978cae07fd0d65144f49b0324536e94628
https://github.com/coder/code-server/pull/7845/files#diff-9e97b686b1f5f63a003043a3b6349a978cae07fd0d65144f49b0324536e94628
https://github.com/coder/code-server/blob/main/.github/CODEOWNERS#L1
test/e2e/github.test.tshttps://github.com/coder/code-server/pull/7845/files#diff-5a3bbfeab7d7efb08e9935283f8f4db29bf73c56cdeca787af3344de0302eb3d
View file https://github.com/voidmatcha/code-server/blob/e9b15b232cc3b8aad0d550e7f0646559c02dd0fa/test/e2e/github.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/code-server/pull/7845/{{ revealButtonHref }}
https://github.com/coder/code-server/pull/7845/files#diff-5a3bbfeab7d7efb08e9935283f8f4db29bf73c56cdeca787af3344de0302eb3d
https://github.com/coder/code-server/pull/7845/files#diff-5a3bbfeab7d7efb08e9935283f8f4db29bf73c56cdeca787af3344de0302eb3d
https://github.com/coder/code-server/pull/7845/files#diff-5a3bbfeab7d7efb08e9935283f8f4db29bf73c56cdeca787af3344de0302eb3d
https://github.com/coder/code-server/blob/main/.github/CODEOWNERS#L1
test/e2e/login.test.tshttps://github.com/coder/code-server/pull/7845/files#diff-c0e739eb293dc0a512b8abe27c27884ed23e591b23075fa4b7cb1fc53d6fde13
View file https://github.com/voidmatcha/code-server/blob/e9b15b232cc3b8aad0d550e7f0646559c02dd0fa/test/e2e/login.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/code-server/pull/7845/{{ revealButtonHref }}
https://github.com/coder/code-server/pull/7845/files#diff-c0e739eb293dc0a512b8abe27c27884ed23e591b23075fa4b7cb1fc53d6fde13
https://github.com/coder/code-server/pull/7845/files#diff-c0e739eb293dc0a512b8abe27c27884ed23e591b23075fa4b7cb1fc53d6fde13
https://github.com/coder/code-server/blob/main/.github/CODEOWNERS#L1
test/e2e/uploads.test.tshttps://github.com/coder/code-server/pull/7845/files#diff-aabe283d76697e83752387d9865fc6350d387f3643471da95065de4af036890c
View file https://github.com/voidmatcha/code-server/blob/e9b15b232cc3b8aad0d550e7f0646559c02dd0fa/test/e2e/uploads.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/code-server/pull/7845/{{ revealButtonHref }}
https://github.com/coder/code-server/pull/7845/files#diff-aabe283d76697e83752387d9865fc6350d387f3643471da95065de4af036890c
https://github.com/coder/code-server/pull/7845/files#diff-aabe283d76697e83752387d9865fc6350d387f3643471da95065de4af036890c
https://github.com/coder/code-server/blob/main/.github/CODEOWNERS#L1
test/unit/node/heart.test.tshttps://github.com/coder/code-server/pull/7845/files#diff-209330cadcf86c6dda745c2cfcb29c1c7c5d9d80fbf4ef38b2b1356d81155cde
View file https://github.com/voidmatcha/code-server/blob/e9b15b232cc3b8aad0d550e7f0646559c02dd0fa/test/unit/node/heart.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/code-server/pull/7845/{{ revealButtonHref }}
https://github.com/coder/code-server/pull/7845/files#diff-209330cadcf86c6dda745c2cfcb29c1c7c5d9d80fbf4ef38b2b1356d81155cde
https://github.com/coder/code-server/pull/7845/files#diff-209330cadcf86c6dda745c2cfcb29c1c7c5d9d80fbf4ef38b2b1356d81155cde
https://github.com/coder/code-server/pull/7845/files#diff-209330cadcf86c6dda745c2cfcb29c1c7c5d9d80fbf4ef38b2b1356d81155cde
https://github.com/coder/code-server/pull/7845/files#diff-209330cadcf86c6dda745c2cfcb29c1c7c5d9d80fbf4ef38b2b1356d81155cde
Please reload this pagehttps://github.com/coder/code-server/pull/7845/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.