René's URL Explorer Experiment


Title: fix: invoking code-server in integrated terminal by code-asher · Pull Request #5360 · coder/code-server · GitHub

Open Graph Title: fix: invoking code-server in integrated terminal by code-asher · Pull Request #5360 · coder/code-server

X Title: fix: invoking code-server in integrated terminal by code-asher · Pull Request #5360 · coder/code-server

Description: Fixes #5335 This fixes the path to Node in upstream's scripts then links the right one based on the platform. There is also some removal of duplicate code where we symlink the asar twice; turns out we do not need this since the standalone release runs yarn which will run the postinstall which will add the link. If anyone wishes to test manually open up the integrated terminal and run code-server . You can try things like code-server --wait as well which should work. Possibly in a separate PR we should think about using the same for external terminals then remove our bespoke code. Thanks to @fritterhoff for linking to where this happens, made this very easy to fix! Fixes #2110 Follow-up TODOs open issue for external terminal usage (aka --wait outside code-server)

Open Graph Description: Fixes #5335 This fixes the path to Node in upstream's scripts then links the right one based on the platform. There is also some removal of duplicate code where we symlink the asar twice; turns...

X Description: Fixes #5335 This fixes the path to Node in upstream's scripts then links the right one based on the platform. There is also some removal of duplicate code where we symlink the asar twice; t...

Opengraph URL: https://github.com/coder/code-server/pull/5360

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:74eafe3f-4417-7ffe-e453-689e5df91da5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9402:38C5CF:3399ACD:416BB4D:6B01BB9A
html-safe-nonce69c3be1a8006265235776e21bb21c77e1a92634f5d7dcde709feadb48eb7ef6a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDAyOjM4QzVDRjozMzk5QUNEOjQxNkJCNEQ6NkIwMUJCOUEiLCJ2aXNpdG9yX2lkIjoiNjM0MTQwMjE5Nzk1NTI5NjE1NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac386667031d4432d60fa53b7ba01bf91f30cf971de06e30da089dadef4f35a0fa
hovercard-subject-tagpull_request:1002978418
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/coder/code-server/pull/5360/files
twitter:imagehttps://avatars.githubusercontent.com/u/45609798?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/45609798?s=400&v=4
og:image:altFixes #5335 This fixes the path to Node in upstream's scripts then links the right one based on the platform. There is also some removal of duplicate code where we symlink the asar twice; turns...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/coder/code-server git https://github.com/coder/code-server.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id172953845
octolytics-dimension-repository_nwocoder/code-server
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id172953845
octolytics-dimension-repository_network_root_nwocoder/code-server
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/coder/code-server/pull/5360/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcode-server%2Fpull%2F5360%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcode-server%2Fpull%2F5360%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=coder%2Fcode-server
Reloadhttps://github.com/coder/code-server/pull/5360/files
Reloadhttps://github.com/coder/code-server/pull/5360/files
Reloadhttps://github.com/coder/code-server/pull/5360/files
coderhttps://github.com/coder
code-serverhttps://github.com/coder/code-server
Codehttps://github.com/coder/code-server
Issues147 (147)https://github.com/coder/code-server/issues
Pull requests17 (17)https://github.com/coder/code-server/pulls
Discussionshttps://github.com/coder/code-server/discussions
Actionshttps://github.com/coder/code-server/actions
Projectshttps://github.com/coder/code-server/projects
Security and quality3 (3)https://github.com/coder/code-server/security
Insightshttps://github.com/coder/code-server/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fcoder%2Fcode-server%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fcoder%2Fcode-server%2Fissues%2Fnew%2Fchoose
code-asherhttps://github.com/code-asher
coder:mainhttps://github.com/coder/code-server/tree/main
code-asher:code-server-pathhttps://github.com/code-asher/code-server/tree/code-server-path
Conversation 25 https://github.com/coder/code-server/pull/5360
Commits 15 https://github.com/coder/code-server/pull/5360/commits
Checks 0 https://github.com/coder/code-server/pull/5360/checks
Files changed https://github.com/coder/code-server/pull/5360/files
Please reload this pagehttps://github.com/coder/code-server/pull/5360/files
fix: invoking code-server in integrated terminal https://github.com/coder/code-server/pull/5360/files#top
Show all changes 15 commits https://github.com/coder/code-server/pull/5360/files
ad00544 Include bin scripts for all platforms code-asher Aug 1, 2022 https://github.com/coder/code-server/pull/5360/commits/ad00544ed77258e28231085b6482e1dfe1cbad54
974170b Improve OS detection code-asher Aug 1, 2022 https://github.com/coder/code-server/pull/5360/commits/974170b64791d30f029c41f2f24ab9a6c34c9bf5
0b9d8d0 Remove duplicate asar symlink code-asher Aug 1, 2022 https://github.com/coder/code-server/pull/5360/commits/0b9d8d0f5c6e03b23f0ac4432c061eb98f1314e1
5276809 Add symlinks to bin scripts code-asher Aug 1, 2022 https://github.com/coder/code-server/pull/5360/commits/527680905c817c22ba7a9d2e56abe8ade37cf3d2
7c2c7d7 Add test for opening a file from the terminal code-asher Aug 1, 2022 https://github.com/coder/code-server/pull/5360/commits/7c2c7d74856c8cbd5da6c84ab29598ce0ce87569
73982c9 Add global Playwright timeout code-asher Aug 1, 2022 https://github.com/coder/code-server/pull/5360/commits/73982c95ecb2eaade662c508518d4d1cdcef1149
a5d2200 Make sed work on macOS code-asher Aug 1, 2022 https://github.com/coder/code-server/pull/5360/commits/a5d2200510878e1ea92251d83c8a2598538da565
b732bf9 Add back wait for load state code-asher Aug 1, 2022 https://github.com/coder/code-server/pull/5360/commits/b732bf9dbfb16ae431d4ae0cb354bf5ba376096e
43225a3 Fix Node path in bin scripts code-asher Aug 1, 2022 https://github.com/coder/code-server/pull/5360/commits/43225a37bad04a37ebf2af735fbf0e0ec59e80fe
8c2096f Disable shellcheck expansion error code-asher Aug 1, 2022 https://github.com/coder/code-server/pull/5360/commits/8c2096f13a2008b2d19b63345f21e90985ab994b
44bd6ff Make scripts executable code-asher Aug 1, 2022 https://github.com/coder/code-server/pull/5360/commits/44bd6ff87a96408240a6a91f06251d6a02e0b7aa
4a00441 Remove .bak files created by sed code-asher Aug 2, 2022 https://github.com/coder/code-server/pull/5360/commits/4a00441eecafe82db6fd9af2f302b461eb5073f7
602f8d4 Include Code build script in cache hash code-asher Aug 2, 2022 https://github.com/coder/code-server/pull/5360/commits/602f8d4dd791ae3a7effc1c3638429d6bdb61001
b62191a Make sure the terminal opens code-asher Aug 2, 2022 https://github.com/coder/code-server/pull/5360/commits/b62191a6f3d0e77347814f603832b41dd8736852
8e03cbb Merge branch 'main' into code-server-path code-asher Aug 4, 2022 https://github.com/coder/code-server/pull/5360/commits/8e03cbb5d7346a4f23e5b603a3d82450d92825f3
Clear filters https://github.com/coder/code-server/pull/5360/files
Please reload this pagehttps://github.com/coder/code-server/pull/5360/files
Please reload this pagehttps://github.com/coder/code-server/pull/5360/files
ci.yaml https://github.com/coder/code-server/pull/5360/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
build-release.sh https://github.com/coder/code-server/pull/5360/files#diff-471375dd1b99488272fffd0471bbd64b79dfd813b8d5b631b0f072a8ca40fcaa
build-standalone-release.sh https://github.com/coder/code-server/pull/5360/files#diff-a6ebb1d512b2009ce829afc99a92783a38370c34664349a7f99e979be66ef2f0
build-vscode.sh https://github.com/coder/code-server/pull/5360/files#diff-93f053aec8e2e7985456f12dc1a73ddf3cd37d15f1c006f5f46034cbb4647e0c
npm-postinstall.sh https://github.com/coder/code-server/pull/5360/files#diff-9efc23615796709119daa0db0050a3b67205c9c8ee6d23a2ef635a88958ae777
lib.sh https://github.com/coder/code-server/pull/5360/files#diff-5781b689fff4dffc3504fd0d86b150c7a9c2287e8c69a368c4094380436cde95
publish-npm.sh https://github.com/coder/code-server/pull/5360/files#diff-35b2d9d119d7db2d1b9f81c5d6067d74b2991cc1763e6805a49d312a538f7113
CodeServer.ts https://github.com/coder/code-server/pull/5360/files#diff-919759731061eddd8522c53c0651f7328e5030d138e0c0e1005936f33aaf53e7
terminal.test.ts https://github.com/coder/code-server/pull/5360/files#diff-57ef5082257832f79be218bb8f3a598ed99dc469b8d49bb59b9ea3748c788a8d
https://github.com/coder/code-server/blob/main/.github/CODEOWNERS#L1
.github/workflows/ci.yamlhttps://github.com/coder/code-server/pull/5360/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
View file https://github.com/code-asher/code-server/blob/8e03cbb5d7346a4f23e5b603a3d82450d92825f3/.github/workflows/ci.yaml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/code-server/pull/5360/{{ revealButtonHref }}
https://github.com/coder/code-server/pull/5360/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
https://github.com/coder/code-server/pull/5360/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
https://github.com/coder/code-server/pull/5360/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
https://github.com/coder/code-server/pull/5360/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
https://github.com/coder/code-server/blob/main/.github/CODEOWNERS#L1
ci/build/build-release.shhttps://github.com/coder/code-server/pull/5360/files#diff-471375dd1b99488272fffd0471bbd64b79dfd813b8d5b631b0f072a8ca40fcaa
View file https://github.com/code-asher/code-server/blob/8e03cbb5d7346a4f23e5b603a3d82450d92825f3/ci/build/build-release.sh
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/code-server/pull/5360/{{ revealButtonHref }}
https://github.com/coder/code-server/pull/5360/files#diff-471375dd1b99488272fffd0471bbd64b79dfd813b8d5b631b0f072a8ca40fcaa
https://github.com/coder/code-server/blob/main/.github/CODEOWNERS#L1
ci/build/build-standalone-release.shhttps://github.com/coder/code-server/pull/5360/files#diff-a6ebb1d512b2009ce829afc99a92783a38370c34664349a7f99e979be66ef2f0
View file https://github.com/code-asher/code-server/blob/8e03cbb5d7346a4f23e5b603a3d82450d92825f3/ci/build/build-standalone-release.sh
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/code-server/pull/5360/{{ revealButtonHref }}
https://github.com/coder/code-server/pull/5360/files#diff-a6ebb1d512b2009ce829afc99a92783a38370c34664349a7f99e979be66ef2f0
https://github.com/coder/code-server/blob/main/.github/CODEOWNERS#L1
ci/build/build-vscode.shhttps://github.com/coder/code-server/pull/5360/files#diff-93f053aec8e2e7985456f12dc1a73ddf3cd37d15f1c006f5f46034cbb4647e0c
View file https://github.com/code-asher/code-server/blob/8e03cbb5d7346a4f23e5b603a3d82450d92825f3/ci/build/build-vscode.sh
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/code-server/pull/5360/{{ revealButtonHref }}
https://github.com/coder/code-server/pull/5360/files#diff-93f053aec8e2e7985456f12dc1a73ddf3cd37d15f1c006f5f46034cbb4647e0c
https://github.com/coder/code-server/pull/5360/files#diff-93f053aec8e2e7985456f12dc1a73ddf3cd37d15f1c006f5f46034cbb4647e0c
https://github.com/coder/code-server/pull/5360/files#diff-93f053aec8e2e7985456f12dc1a73ddf3cd37d15f1c006f5f46034cbb4647e0c
https://github.com/coder/code-server/blob/main/.github/CODEOWNERS#L1
ci/build/npm-postinstall.shhttps://github.com/coder/code-server/pull/5360/files#diff-9efc23615796709119daa0db0050a3b67205c9c8ee6d23a2ef635a88958ae777
View file https://github.com/code-asher/code-server/blob/8e03cbb5d7346a4f23e5b603a3d82450d92825f3/ci/build/npm-postinstall.sh
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/code-server/pull/5360/{{ revealButtonHref }}
https://github.com/coder/code-server/pull/5360/files#diff-9efc23615796709119daa0db0050a3b67205c9c8ee6d23a2ef635a88958ae777
https://github.com/coder/code-server/pull/5360/files#diff-9efc23615796709119daa0db0050a3b67205c9c8ee6d23a2ef635a88958ae777
https://github.com/coder/code-server/pull/5360/files#diff-9efc23615796709119daa0db0050a3b67205c9c8ee6d23a2ef635a88958ae777
https://github.com/coder/code-server/pull/5360/files#diff-9efc23615796709119daa0db0050a3b67205c9c8ee6d23a2ef635a88958ae777
https://github.com/coder/code-server/blob/main/.github/CODEOWNERS#L1
ci/lib.shhttps://github.com/coder/code-server/pull/5360/files#diff-5781b689fff4dffc3504fd0d86b150c7a9c2287e8c69a368c4094380436cde95
View file https://github.com/code-asher/code-server/blob/8e03cbb5d7346a4f23e5b603a3d82450d92825f3/ci/lib.sh
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/code-server/pull/5360/{{ revealButtonHref }}
https://github.com/coder/code-server/pull/5360/files#diff-5781b689fff4dffc3504fd0d86b150c7a9c2287e8c69a368c4094380436cde95
https://github.com/coder/code-server/pull/5360/files#diff-5781b689fff4dffc3504fd0d86b150c7a9c2287e8c69a368c4094380436cde95
https://github.com/coder/code-server/pull/5360/files#diff-5781b689fff4dffc3504fd0d86b150c7a9c2287e8c69a368c4094380436cde95
https://github.com/coder/code-server/blob/main/.github/CODEOWNERS#L1
ci/steps/publish-npm.shhttps://github.com/coder/code-server/pull/5360/files#diff-35b2d9d119d7db2d1b9f81c5d6067d74b2991cc1763e6805a49d312a538f7113
View file https://github.com/code-asher/code-server/blob/8e03cbb5d7346a4f23e5b603a3d82450d92825f3/ci/steps/publish-npm.sh
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/code-server/pull/5360/{{ revealButtonHref }}
https://github.com/coder/code-server/pull/5360/files#diff-35b2d9d119d7db2d1b9f81c5d6067d74b2991cc1763e6805a49d312a538f7113
https://github.com/coder/code-server/pull/5360/files#diff-35b2d9d119d7db2d1b9f81c5d6067d74b2991cc1763e6805a49d312a538f7113
https://github.com/coder/code-server/blob/main/.github/CODEOWNERS#L1
test/e2e/models/CodeServer.tshttps://github.com/coder/code-server/pull/5360/files#diff-919759731061eddd8522c53c0651f7328e5030d138e0c0e1005936f33aaf53e7
View file https://github.com/code-asher/code-server/blob/8e03cbb5d7346a4f23e5b603a3d82450d92825f3/test/e2e/models/CodeServer.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/code-server/pull/5360/{{ revealButtonHref }}
https://github.com/coder/code-server/pull/5360/files#diff-919759731061eddd8522c53c0651f7328e5030d138e0c0e1005936f33aaf53e7
https://github.com/coder/code-server/pull/5360/files#diff-919759731061eddd8522c53c0651f7328e5030d138e0c0e1005936f33aaf53e7
https://github.com/coder/code-server/pull/5360/files#diff-919759731061eddd8522c53c0651f7328e5030d138e0c0e1005936f33aaf53e7
https://github.com/coder/code-server/pull/5360/files#diff-919759731061eddd8522c53c0651f7328e5030d138e0c0e1005936f33aaf53e7
Please reload this pagehttps://github.com/coder/code-server/pull/5360/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.