René's URL Explorer Experiment


Title: fix(terminal): use window.location to work when served NOT on root path by jsjoeio · Pull Request #5332 · coder/code-server · GitHub

Open Graph Title: fix(terminal): use window.location to work when served NOT on root path by jsjoeio · Pull Request #5332 · coder/code-server

X Title: fix(terminal): use window.location to work when served NOT on root path by jsjoeio · Pull Request #5332 · coder/code-server

Description: VS Code in the browser. Contribute to coder/code-server development by creating an account on GitHub.

Open Graph Description: Description We made a change in workbench-dev.html but forgot to make it in workbench.html. This fixes the Integrated Terminal to work when code-server is served NOT on the root path (i.e. accessed...

X Description: Description We made a change in workbench-dev.html but forgot to make it in workbench.html. This fixes the Integrated Terminal to work when code-server is served NOT on the root path (i.e. accessed...

Opengraph URL: https://github.com/coder/code-server/pull/5332

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9335f123-1adb-f3c8-ce1c-4650b3581bb9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8944:1F2B:3A3D4B:4E3CEF:6B019890
html-safe-nonce933fdca378a0d1952a51cb1094e6904e73157ea9cda9b66f3829679da5ccd379
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTQ0OjFGMkI6M0EzRDRCOjRFM0NFRjo2QjAxOTg5MCIsInZpc2l0b3JfaWQiOiIxMzEzMTA1MDAwMzU1OTYwOTc2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1e74ba7cfb640a0e8cdc96d87b391a8a50532c583cee90d9eba4e3c6ca781e66
hovercard-subject-tagpull_request:993661722
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/code-server/5332/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b3852d717018c65ef746691795f17bff83ddf4e8d400ce41897bed194dff4116/coder/code-server/pull/5332
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b3852d717018c65ef746691795f17bff83ddf4e8d400ce41897bed194dff4116/coder/code-server/pull/5332
og:image:altDescription We made a change in workbench-dev.html but forgot to make it in workbench.html. This fixes the Integrated Terminal to work when code-server is served NOT on the root path (i.e. accessed...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejsjoeio
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/coder/code-server git https://github.com/coder/code-server.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id172953845
octolytics-dimension-repository_nwocoder/code-server
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id172953845
octolytics-dimension-repository_network_root_nwocoder/code-server
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/coder/code-server/pull/5332#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcode-server%2Fpull%2F5332
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcode-server%2Fpull%2F5332
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcode-server
Reloadhttps://github.com/coder/code-server/pull/5332
Reloadhttps://github.com/coder/code-server/pull/5332
Reloadhttps://github.com/coder/code-server/pull/5332
coderhttps://github.com/coder
code-serverhttps://github.com/coder/code-server
Codehttps://github.com/coder/code-server
Issues147 (147)https://github.com/coder/code-server/issues
Pull requests17 (17)https://github.com/coder/code-server/pulls
Discussionshttps://github.com/coder/code-server/discussions
Actionshttps://github.com/coder/code-server/actions
Projectshttps://github.com/coder/code-server/projects
Security and quality3 (3)https://github.com/coder/code-server/security
Insightshttps://github.com/coder/code-server/insights
https://github.com/coder/code-server
jsjoeiohttps://github.com/jsjoeio
mainhttps://github.com/coder/code-server/tree/main
jsjoeio/fix-terminalhttps://github.com/coder/code-server/tree/jsjoeio/fix-terminal
Conversationhttps://github.com/coder/code-server/pull/5332
Commits1 (1)https://github.com/coder/code-server/pull/5332/commits
Checkshttps://github.com/coder/code-server/pull/5332/checks
Files changedhttps://github.com/coder/code-server/pull/5332/files
fix(terminal): use window.location to work when served NOT on root pathhttps://github.com/coder/code-server/pull/5332#top
jsjoeiohttps://github.com/jsjoeio
mainhttps://github.com/coder/code-server/tree/main
jsjoeio/fix-terminalhttps://github.com/coder/code-server/tree/jsjoeio/fix-terminal
https://github.com/jsjoeio
jsjoeiohttps://github.com/jsjoeio
Jul 11, 2022https://github.com/coder/code-server/pull/5332#issue-1301340476
Please reload this pagehttps://github.com/coder/code-server/pull/5332
#5321https://github.com/coder/code-server/issues/5321
Please reload this pagehttps://github.com/coder/code-server/pull/5332
https://github.com/jsjoeio
jsjoeiohttps://github.com/jsjoeio
Jul 11, 2022https://github.com/coder/code-server/pull/5332#event-6973305934
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jul 11, 2022https://github.com/coder/code-server/pull/5332#issuecomment-1181046564
Please reload this pagehttps://github.com/coder/code-server/pull/5332
#5332https://github.com/coder/code-server/pull/5332
https://coder.com/docs/code-server/319c5cchttps://coder.com/docs/code-server/319c5cc
eadad9fhttps://github.com/coder/code-server/commit/eadad9f0127de1ba40d18265ead296295bc3adfe
https://github.com/coder/code-server/actions/runs/2667032711https://github.com/coder/code-server/actions/runs/2667032711
Please reload this pagehttps://github.com/coder/code-server/pull/5332
https://github.com/jsjoeio
jsjoeiohttps://github.com/jsjoeio
bug https://github.com/coder/code-server/issues?q=state%3Aopen%20label%3Abug
Jul 11, 2022https://github.com/coder/code-server/pull/5332#event-6973306350
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Jul 11, 2022https://github.com/coder/code-server/pull/5332#issuecomment-1181081777
Please reload this pagehttps://github.com/coder/code-server/pull/5332
Codecovhttps://codecov.io/gh/coder/code-server/pull/5332?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=coder
#5332https://codecov.io/gh/coder/code-server/pull/5332?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=coder
eadad9fhttps://github.com/coder/code-server/commit/eadad9f0127de1ba40d18265ead296295bc3adfe
mainhttps://codecov.io/gh/coder/code-server/commit/9ad0d9e6ad1c8835d2eacf06992723a1cf69d3c0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=coder
9ad0d9ehttps://github.com/coder/code-server/commit/9ad0d9e6ad1c8835d2eacf06992723a1cf69d3c0
https://codecov.io/gh/coder/code-server/pull/5332?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=coder
Continue to review full report at Codecovhttps://codecov.io/gh/coder/code-server/pull/5332?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=coder
Click here to learn morehttps://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=coder
Codecovhttps://codecov.io/gh/coder/code-server/pull/5332?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=coder
9ad0d9e...eadad9fhttps://codecov.io/gh/coder/code-server/pull/5332?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=coder
comment docshttps://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=coder
Please reload this pagehttps://github.com/coder/code-server/pull/5332
https://github.com/jsjoeio
jsjoeiohttps://github.com/jsjoeio
July 11, 2022 23:33https://github.com/coder/code-server/pull/5332#event-6973368452
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jul 11, 2022https://github.com/coder/code-server/pull/5332#issuecomment-1181084014
Please reload this pagehttps://github.com/coder/code-server/pull/5332
#5332https://github.com/coder/code-server/pull/5332
eadad9fhttps://github.com/coder/code-server/commit/eadad9f0127de1ba40d18265ead296295bc3adfe
Please reload this pagehttps://github.com/coder/code-server/pull/5332
https://github.com/jsjoeio
jsjoeiohttps://github.com/jsjoeio
force-pushedhttps://github.com/coder/code-server/compare/0e5df6426d55c7f47697d186d6c128501025316f..2b339bcf4a9c9841c8bd4ab78e1d8f62ab4e5328
0e5df64https://github.com/coder/code-server/commit/0e5df6426d55c7f47697d186d6c128501025316f
2b339bchttps://github.com/coder/code-server/commit/2b339bcf4a9c9841c8bd4ab78e1d8f62ab4e5328
Compare https://github.com/coder/code-server/compare/0e5df6426d55c7f47697d186d6c128501025316f..2b339bcf4a9c9841c8bd4ab78e1d8f62ab4e5328
July 13, 2022 23:49https://github.com/coder/code-server/pull/5332#event-6989869957
https://github.com/jsjoeio
fix(workbench): use window.location without originhttps://github.com/coder/code-server/pull/5332/commits/eadad9f0127de1ba40d18265ead296295bc3adfe
eadad9fhttps://github.com/coder/code-server/pull/5332/commits/eadad9f0127de1ba40d18265ead296295bc3adfe
https://github.com/jsjoeio
jsjoeiohttps://github.com/jsjoeio
force-pushedhttps://github.com/coder/code-server/compare/2b339bcf4a9c9841c8bd4ab78e1d8f62ab4e5328..eadad9f0127de1ba40d18265ead296295bc3adfe
2b339bchttps://github.com/coder/code-server/commit/2b339bcf4a9c9841c8bd4ab78e1d8f62ab4e5328
eadad9fhttps://github.com/coder/code-server/commit/eadad9f0127de1ba40d18265ead296295bc3adfe
Compare https://github.com/coder/code-server/compare/2b339bcf4a9c9841c8bd4ab78e1d8f62ab4e5328..eadad9f0127de1ba40d18265ead296295bc3adfe
July 13, 2022 23:52https://github.com/coder/code-server/pull/5332#event-6989877715
https://github.com/jsjoeio
jsjoeiohttps://github.com/jsjoeio
Jul 13, 2022https://github.com/coder/code-server/pull/5332#event-6989883180
https://github.com/oxy
oxyhttps://github.com/oxy
Jul 13, 2022 https://github.com/coder/code-server/pull/5332#pullrequestreview-1038096933
View reviewed changes https://github.com/coder/code-server/pull/5332/files/eadad9f0127de1ba40d18265ead296295bc3adfe
oxyhttps://github.com/oxy
https://github.com/coder/code-server/pull/5332#pullrequestreview-1038096933
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/code-server/pull/5332
https://github.com/jsjoeio
jsjoeiohttps://github.com/jsjoeio
July 13, 2022 23:57https://github.com/coder/code-server/pull/5332#event-6989891524
https://github.com/jsjoeio
jsjoeiohttps://github.com/jsjoeio
July 13, 2022 23:57https://github.com/coder/code-server/pull/5332#event-6989891562
https://github.com/jsjoeio
jsjoeiohttps://github.com/jsjoeio
July 14, 2022 00:08https://github.com/coder/code-server/pull/5332#event-6989927188
https://github.com/code-asher
code-asherhttps://github.com/code-asher
Jul 14, 2022 https://github.com/coder/code-server/pull/5332#pullrequestreview-1039061593
View reviewed changes https://github.com/coder/code-server/pull/5332/files/eadad9f0127de1ba40d18265ead296295bc3adfe
code-asherhttps://github.com/code-asher
https://github.com/coder/code-server/pull/5332#pullrequestreview-1039061593
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/code-server/pull/5332
https://github.com/jsjoeio
jsjoeiohttps://github.com/jsjoeio
Jul 14, 2022https://github.com/coder/code-server/pull/5332#issuecomment-1184644551
https://user-images.githubusercontent.com/3806031/179030768-77998550-e9c6-463f-aa42-05865d577b66.png
Please reload this pagehttps://github.com/coder/code-server/pull/5332
https://github.com/jsjoeio
jsjoeiohttps://github.com/jsjoeio
f79b38dhttps://github.com/coder/code-server/commit/f79b38d25a8beb977e627499b9e108b148ee1563
Jul 14, 2022https://github.com/coder/code-server/pull/5332#event-6995676587
https://github.com/jsjoeio
jsjoeiohttps://github.com/jsjoeio
July 14, 2022 16:25https://github.com/coder/code-server/pull/5332#event-6995676732
Bug in v0.7.6 a494489: inconsistency of code-server terminal loading. coder/coder#2845 https://github.com/coder/coder/issues/2845
[Bug]: Terminal not working #5218 https://github.com/coder/code-server/issues/5218
https://github.com/consideRatio
consideRatiohttps://github.com/consideRatio
Jul 18, 2022 https://github.com/coder/code-server/pull/5332#ref-issue-1305659861
[Bug]: Code highlighting working abnormally in 4.5.0 #5343 https://github.com/coder/code-server/issues/5343
jsjoeiohttps://github.com/jsjoeio
https://github.co/hiddenchars
https://github.com/coder/code-server/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcode-server%2Fpull%2F5332
https://github.com/code-asher
code-asher https://github.com/code-asher
https://github.com/coder/code-server/pull/5332/files/eadad9f0127de1ba40d18265ead296295bc3adfe
https://github.com/oxy
oxy https://github.com/oxy
https://github.com/coder/code-server/pull/5332/files/eadad9f0127de1ba40d18265ead296295bc3adfe
Please reload this pagehttps://github.com/coder/code-server/pull/5332
https://github.com/jsjoeio
jsjoeio https://github.com/jsjoeio
bug https://github.com/coder/code-server/issues?q=state%3Aopen%20label%3Abug
[Bug]: terminal not working when your web base_path is not / https://github.com/coder/code-server/issues/5321
Please reload this pagehttps://github.com/coder/code-server/pull/5332
https://github.com/jsjoeio
https://github.com/oxy
https://github.com/code-asher
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.