René's URL Explorer Experiment


Title: refactor: remove folder/workspace from vsCodeCliArgs by jsjoeio · Pull Request #4932 · coder/code-server · GitHub

Open Graph Title: refactor: remove folder/workspace from vsCodeCliArgs by jsjoeio · Pull Request #4932 · coder/code-server

X Title: refactor: remove folder/workspace from vsCodeCliArgs by jsjoeio · Pull Request #4932 · coder/code-server

Description: Since we handle this in the vscode.ts route, we no longer need to pass it to VS Code as a CLI arg since it's deprecated on that side. This adds logic to our vscode route handler to handle both folder and workspace paths passed in via the CLI Fixes an issue related to coder/vscode#45 Blocked by coder/vscode#49

Open Graph Description: Since we handle this in the vscode.ts route, we no longer need to pass it to VS Code as a CLI arg since it's deprecated on that side. This adds logic to our vscode route handler to handle both ...

X Description: Since we handle this in the vscode.ts route, we no longer need to pass it to VS Code as a CLI arg since it's deprecated on that side. This adds logic to our vscode route handler to handle b...

Opengraph URL: https://github.com/coder/code-server/pull/4932

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0fdead87-2479-6497-475a-58a6131208ed
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB54C:3E4205:2C79ABF:3B789BF:6B01D506
html-safe-nonce2cd574ab53a068b97a79042468c8b91f51d8b26bc7743c16bcdada160173bd4e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNTRDOjNFNDIwNToyQzc5QUJGOjNCNzg5QkY6NkIwMUQ1MDYiLCJ2aXNpdG9yX2lkIjoiMjUzMTk0NTI0NjQxMDAwMzcxOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace721d320e0f553402bc2fc33646172a89a76e9a7528809add27b58328a234195
hovercard-subject-tagpull_request:868318641
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/coder/code-server/pull/4932/files
twitter:imagehttps://avatars.githubusercontent.com/u/3806031?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3806031?s=400&v=4
og:image:altSince we handle this in the vscode.ts route, we no longer need to pass it to VS Code as a CLI arg since it's deprecated on that side. This adds logic to our vscode route handler to handle both ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/coder/code-server git https://github.com/coder/code-server.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id172953845
octolytics-dimension-repository_nwocoder/code-server
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id172953845
octolytics-dimension-repository_network_root_nwocoder/code-server
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/coder/code-server/pull/4932/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcode-server%2Fpull%2F4932%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcode-server%2Fpull%2F4932%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=coder%2Fcode-server
Reloadhttps://github.com/coder/code-server/pull/4932/files
Reloadhttps://github.com/coder/code-server/pull/4932/files
Reloadhttps://github.com/coder/code-server/pull/4932/files
coderhttps://github.com/coder
code-serverhttps://github.com/coder/code-server
Codehttps://github.com/coder/code-server
Issues147 (147)https://github.com/coder/code-server/issues
Pull requests17 (17)https://github.com/coder/code-server/pulls
Discussionshttps://github.com/coder/code-server/discussions
Actionshttps://github.com/coder/code-server/actions
Projectshttps://github.com/coder/code-server/projects
Security and quality3 (3)https://github.com/coder/code-server/security
Insightshttps://github.com/coder/code-server/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fcoder%2Fcode-server%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fcoder%2Fcode-server%2Fissues%2Fnew%2Fchoose
jsjoeiohttps://github.com/jsjoeio
mainhttps://github.com/coder/code-server/tree/main
jsjoeio/fix-folder-workspace-cli-argshttps://github.com/coder/code-server/tree/jsjoeio/fix-folder-workspace-cli-args
Conversation 25 https://github.com/coder/code-server/pull/4932
Commits 14 https://github.com/coder/code-server/pull/4932/commits
Checks 0 https://github.com/coder/code-server/pull/4932/checks
Files changed https://github.com/coder/code-server/pull/4932/files
Please reload this pagehttps://github.com/coder/code-server/pull/4932/files
refactor: remove folder/workspace from vsCodeCliArgs https://github.com/coder/code-server/pull/4932/files#top
Show all changes 14 commits https://github.com/coder/code-server/pull/4932/files
29ca762 refactor: remove folder/workspace from vsCodeCliArgs jsjoeio Mar 1, 2022 https://github.com/coder/code-server/pull/4932/commits/29ca7625f94d7ea2ebb9234f045c3bd12815fe79
69498e9 feat(vscode): redirect to folder from cli jsjoeio Mar 1, 2022 https://github.com/coder/code-server/pull/4932/commits/69498e93fdafca0eec96fc56fed6a08e99711c5a
9da0264 Update src/node/routes/vscode.ts jsjoeio Mar 2, 2022 https://github.com/coder/code-server/pull/4932/commits/9da026464cfe8216470d8428a1e0e09ddea3087b
2784009 fixup!: update _: type jsjoeio Mar 2, 2022 https://github.com/coder/code-server/pull/4932/commits/27840094fa8f75b645706572509429dcade1b810
4e2cf54 fixup!: move vars to lower if block jsjoeio Mar 2, 2022 https://github.com/coder/code-server/pull/4932/commits/4e2cf5442f1f09399d4dbc985308ff68c3b92619
1856c6c fixup!: share redirect block jsjoeio Mar 2, 2022 https://github.com/coder/code-server/pull/4932/commits/1856c6c4815b8069685cbc5bbd389cae55711731
7a6731e fixup!: mmove req.query.ew block into if jsjoeio Mar 2, 2022 https://github.com/coder/code-server/pull/4932/commits/7a6731ea42abb0d5eb749b026e35bd1da19c74a5
d906da9 fixup!: refactor vscode tests jsjoeio Mar 2, 2022 https://github.com/coder/code-server/pull/4932/commits/d906da991758c116fdf3421666688fe758d88616
36183d9 refactor: make vscode.ts logic easier to read jsjoeio Mar 2, 2022 https://github.com/coder/code-server/pull/4932/commits/36183d97d057b38957684250c7830eb83bfc6fa7
02ed52c fixup!: fix broken tests and clean up logic jsjoeio Mar 2, 2022 https://github.com/coder/code-server/pull/4932/commits/02ed52cda3bdf55687c237599b70dfb6018fef37
c6f5ade chore: upgrade vscode version jsjoeio Mar 2, 2022 https://github.com/coder/code-server/pull/4932/commits/c6f5adecc19d31a6aec969a8582d2f3cbcb0795f
4ffd923 fixup!: delete unnecessary if closed block jsjoeio Mar 2, 2022 https://github.com/coder/code-server/pull/4932/commits/4ffd9234c799f08f3862a3d2b46fde639526dd5b
477b731 Update src/node/routes/vscode.ts jsjoeio Mar 2, 2022 https://github.com/coder/code-server/pull/4932/commits/477b731433d34ff2f9e7633cb44d16a5201fc060
8162fba fixup!: rename to FOLDER_OR_WORKSPACE_WAS_CLOSED jsjoeio Mar 2, 2022 https://github.com/coder/code-server/pull/4932/commits/8162fba8525c41c866537d8e849d5ce707ea37e8
Clear filters https://github.com/coder/code-server/pull/4932/files
Please reload this pagehttps://github.com/coder/code-server/pull/4932/files
Please reload this pagehttps://github.com/coder/code-server/pull/4932/files
cli.ts https://github.com/coder/code-server/pull/4932/files#diff-e1f89aee8992fa7022cc43adb93042f9bbb4b223f0d6cd0e70719cf4b795afa4
vscode.ts https://github.com/coder/code-server/pull/4932/files#diff-5fbe57eda7a212ceb1db215bdd957812629b6e3f6722a80d8b0abac4b53e8dc6
cli.test.ts https://github.com/coder/code-server/pull/4932/files#diff-259502f3217ff57aa0efe8405a96d85558f638b6a1a27a3f772f7dda96ddc8f2
vscode.test.ts https://github.com/coder/code-server/pull/4932/files#diff-aaad0cad2994038bef4f1ec1644b8d303d59b537e90c01c05022ea3f986e8560
package.json https://github.com/coder/code-server/pull/4932/files#diff-a46b982087dc529e4032ee496078773fb0f5cf061739b7b7862e79bb266616de
yarn.lock https://github.com/coder/code-server/pull/4932/files#diff-7743183f5b9de5bbe12a85f91164a96a8818fb26d5223fd4fc0e75c3b61e1836
https://github.com/coder/code-server/blob/main/.github/CODEOWNERS#L1
src/node/cli.tshttps://github.com/coder/code-server/pull/4932/files#diff-e1f89aee8992fa7022cc43adb93042f9bbb4b223f0d6cd0e70719cf4b795afa4
View file https://github.com/coder/code-server/blob/8162fba8525c41c866537d8e849d5ce707ea37e8/src/node/cli.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/code-server/pull/4932/{{ revealButtonHref }}
https://github.com/coder/code-server/pull/4932/files#diff-e1f89aee8992fa7022cc43adb93042f9bbb4b223f0d6cd0e70719cf4b795afa4
https://github.com/coder/code-server/pull/4932/files#diff-e1f89aee8992fa7022cc43adb93042f9bbb4b223f0d6cd0e70719cf4b795afa4
https://github.com/coder/code-server/pull/4932/files#diff-e1f89aee8992fa7022cc43adb93042f9bbb4b223f0d6cd0e70719cf4b795afa4
https://github.com/coder/code-server/pull/4932/files#diff-e1f89aee8992fa7022cc43adb93042f9bbb4b223f0d6cd0e70719cf4b795afa4
https://github.com/coder/code-server/pull/4932/files#diff-e1f89aee8992fa7022cc43adb93042f9bbb4b223f0d6cd0e70719cf4b795afa4
Please reload this pagehttps://github.com/coder/code-server/pull/4932/files
https://github.com/coder/code-server/pull/4932/files#diff-e1f89aee8992fa7022cc43adb93042f9bbb4b223f0d6cd0e70719cf4b795afa4
https://github.com/coder/code-server/blob/main/.github/CODEOWNERS#L1
src/node/routes/vscode.tshttps://github.com/coder/code-server/pull/4932/files#diff-5fbe57eda7a212ceb1db215bdd957812629b6e3f6722a80d8b0abac4b53e8dc6
View file https://github.com/coder/code-server/blob/8162fba8525c41c866537d8e849d5ce707ea37e8/src/node/routes/vscode.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/code-server/pull/4932/{{ revealButtonHref }}
https://github.com/coder/code-server/pull/4932/files#diff-5fbe57eda7a212ceb1db215bdd957812629b6e3f6722a80d8b0abac4b53e8dc6
https://github.com/coder/code-server/pull/4932/files#diff-5fbe57eda7a212ceb1db215bdd957812629b6e3f6722a80d8b0abac4b53e8dc6
https://github.com/coder/code-server/pull/4932/files#diff-5fbe57eda7a212ceb1db215bdd957812629b6e3f6722a80d8b0abac4b53e8dc6
https://github.com/coder/code-server/blob/main/.github/CODEOWNERS#L1
test/unit/node/cli.test.tshttps://github.com/coder/code-server/pull/4932/files#diff-259502f3217ff57aa0efe8405a96d85558f638b6a1a27a3f772f7dda96ddc8f2
View file https://github.com/coder/code-server/blob/8162fba8525c41c866537d8e849d5ce707ea37e8/test/unit/node/cli.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/code-server/pull/4932/{{ revealButtonHref }}
https://github.com/coder/code-server/pull/4932/files#diff-259502f3217ff57aa0efe8405a96d85558f638b6a1a27a3f772f7dda96ddc8f2
https://github.com/coder/code-server/pull/4932/files#diff-259502f3217ff57aa0efe8405a96d85558f638b6a1a27a3f772f7dda96ddc8f2
https://github.com/coder/code-server/pull/4932/files#diff-259502f3217ff57aa0efe8405a96d85558f638b6a1a27a3f772f7dda96ddc8f2
https://github.com/coder/code-server/blob/main/.github/CODEOWNERS#L1
test/unit/node/routes/vscode.test.tshttps://github.com/coder/code-server/pull/4932/files#diff-aaad0cad2994038bef4f1ec1644b8d303d59b537e90c01c05022ea3f986e8560
View file https://github.com/coder/code-server/blob/8162fba8525c41c866537d8e849d5ce707ea37e8/test/unit/node/routes/vscode.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/code-server/pull/4932/{{ revealButtonHref }}
https://github.com/coder/code-server/pull/4932/files#diff-aaad0cad2994038bef4f1ec1644b8d303d59b537e90c01c05022ea3f986e8560
https://github.com/coder/code-server/pull/4932/files#diff-aaad0cad2994038bef4f1ec1644b8d303d59b537e90c01c05022ea3f986e8560
Please reload this pagehttps://github.com/coder/code-server/pull/4932/files
https://github.com/coder/code-server/pull/4932/files#diff-aaad0cad2994038bef4f1ec1644b8d303d59b537e90c01c05022ea3f986e8560
https://github.com/coder/code-server/pull/4932/files#diff-aaad0cad2994038bef4f1ec1644b8d303d59b537e90c01c05022ea3f986e8560
https://github.com/coder/code-server/pull/4932/files#diff-aaad0cad2994038bef4f1ec1644b8d303d59b537e90c01c05022ea3f986e8560
https://github.com/coder/code-server/blob/main/.github/CODEOWNERS#L1
vendor/package.jsonhttps://github.com/coder/code-server/pull/4932/files#diff-a46b982087dc529e4032ee496078773fb0f5cf061739b7b7862e79bb266616de
View file https://github.com/coder/code-server/blob/8162fba8525c41c866537d8e849d5ce707ea37e8/vendor/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/code-server/pull/4932/{{ revealButtonHref }}
https://github.com/coder/code-server/pull/4932/files#diff-a46b982087dc529e4032ee496078773fb0f5cf061739b7b7862e79bb266616de
https://github.com/coder/code-server/blob/main/.github/CODEOWNERS#L1
vendor/yarn.lockhttps://github.com/coder/code-server/pull/4932/files#diff-7743183f5b9de5bbe12a85f91164a96a8818fb26d5223fd4fc0e75c3b61e1836
View file https://github.com/coder/code-server/blob/8162fba8525c41c866537d8e849d5ce707ea37e8/vendor/yarn.lock
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/code-server/pull/4932/{{ revealButtonHref }}
https://github.com/coder/code-server/pull/4932/files#diff-7743183f5b9de5bbe12a85f91164a96a8818fb26d5223fd4fc0e75c3b61e1836
https://github.com/coder/code-server/pull/4932/files#diff-7743183f5b9de5bbe12a85f91164a96a8818fb26d5223fd4fc0e75c3b61e1836
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.