René's URL Explorer Experiment


Title: refactor: migrate from argon2 -> @node-rs/argon2 by jsjoeio · Pull Request #4733 · coder/code-server · GitHub

Open Graph Title: refactor: migrate from argon2 -> @node-rs/argon2 by jsjoeio · Pull Request #4733 · coder/code-server

X Title: refactor: migrate from argon2 -> @node-rs/argon2 by jsjoeio · Pull Request #4733 · coder/code-server

Description: This migrates our hashing password implementation from using argon2 to @node-rs/argon2. Fixes #4422 How to Test Wait for CI to finish Download release-packages from Artifacts Unzip and then run cd into release-packages Run tar -xzf code-server* based on your arch Generate an argon2 password or use this one: "$argon2i$v=19$m=4096,t=3,p=1$cecR+o8tshB6mKzPBUG7fw$w2XFt+Ezn+CjRGTwptsjH3yj72htGLhMc3WdPs7wIOk" (equals "password") edit your config.yaml and add hashed-password: "$argon2i$v=19$m=4096,t=3,p=1$cecR+o8tshB6mKzPBUG7fw$w2XFt+Ezn+CjRGTwptsjH3yj72htGLhMc3WdPs7wIOk" Run ./code-server*/bin/code-server Login with password: "password" Everything should work Tested on macos @jsjoeio linux @jsjoeio Termux @jsjoeio Raspberry Pi @im-coder-lg Notes At first, I ran into some issues with tests because I was overriding process.platform and that caused issues with any test files that required @node-rs/argon2. @code-asher had a good idea to fix this: refactor getEnvPaths() to pass in process.platform. That fixed it. Resources https://crates.io/crates/argon2 https://github.com/napi-rs/node-rs/tree/main/packages/argon2 #4422 (comment)

Open Graph Description: This migrates our hashing password implementation from using argon2 to @node-rs/argon2. Fixes #4422 How to Test Wait for CI to finish Download release-packages from Artifacts Unzip and then run cd...

X Description: This migrates our hashing password implementation from using argon2 to @node-rs/argon2. Fixes #4422 How to Test Wait for CI to finish Download release-packages from Artifacts Unzip and then run cd...

Opengraph URL: https://github.com/coder/code-server/pull/4733

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:595e8780-4ded-10ad-bf32-c1fe1876a7e0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBB1C:62F48:68849A:8A947C:6B01D6E5
html-safe-nonce7d963ca14afeb4c99c580a86b105bfebb1b541e116d51a0abd5a47f8ec45dea0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQjFDOjYyRjQ4OjY4ODQ5QTo4QTk0N0M6NkIwMUQ2RTUiLCJ2aXNpdG9yX2lkIjoiODIwNTUxOTU4MDM5NTg1MzU0MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5bedaa536a4b5e4d2841e36073bc818c735ef3bd0401fb25634aee6a8d4fbcf5
hovercard-subject-tagpull_request:820111387
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/coder/code-server/pull/4733/files
twitter:imagehttps://avatars.githubusercontent.com/u/3806031?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3806031?s=400&v=4
og:image:altThis migrates our hashing password implementation from using argon2 to @node-rs/argon2. Fixes #4422 How to Test Wait for CI to finish Download release-packages from Artifacts Unzip and then run cd...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/coder/code-server git https://github.com/coder/code-server.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id172953845
octolytics-dimension-repository_nwocoder/code-server
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id172953845
octolytics-dimension-repository_network_root_nwocoder/code-server
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/coder/code-server/pull/4733/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcode-server%2Fpull%2F4733%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcode-server%2Fpull%2F4733%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=coder%2Fcode-server
Reloadhttps://github.com/coder/code-server/pull/4733/files
Reloadhttps://github.com/coder/code-server/pull/4733/files
Reloadhttps://github.com/coder/code-server/pull/4733/files
coderhttps://github.com/coder
code-serverhttps://github.com/coder/code-server
Codehttps://github.com/coder/code-server
Issues147 (147)https://github.com/coder/code-server/issues
Pull requests17 (17)https://github.com/coder/code-server/pulls
Discussionshttps://github.com/coder/code-server/discussions
Actionshttps://github.com/coder/code-server/actions
Projectshttps://github.com/coder/code-server/projects
Security and quality3 (3)https://github.com/coder/code-server/security
Insightshttps://github.com/coder/code-server/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fcoder%2Fcode-server%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fcoder%2Fcode-server%2Fissues%2Fnew%2Fchoose
jsjoeiohttps://github.com/jsjoeio
mainhttps://github.com/coder/code-server/tree/main
jsjoeio-argon-changehttps://github.com/coder/code-server/tree/jsjoeio-argon-change
Conversation 43 https://github.com/coder/code-server/pull/4733
Commits 5 https://github.com/coder/code-server/pull/4733/commits
Checks 0 https://github.com/coder/code-server/pull/4733/checks
Files changed https://github.com/coder/code-server/pull/4733/files
Please reload this pagehttps://github.com/coder/code-server/pull/4733/files
refactor: migrate from argon2 -> @node-rs/argon2 https://github.com/coder/code-server/pull/4733/files#top
Show all changes 5 commits https://github.com/coder/code-server/pull/4733/files
029f8f9 chore(deps): replace argon2 w/@node-rs/argon2 jsjoeio Jan 12, 2022 https://github.com/coder/code-server/pull/4733/commits/029f8f920a44801afc3d0994b7d3b950ff97749d
1a8b422 refactor: clean up hashPassword functions jsjoeio Jan 12, 2022 https://github.com/coder/code-server/pull/4733/commits/1a8b422587de5a4d327af2183907119d69160f87
7b0c05e refactor(util): pass in process.platform jsjoeio Jan 12, 2022 https://github.com/coder/code-server/pull/4733/commits/7b0c05ea0a82bcb8ca1f1e1adf188a039c3bf4c9
0a5039d fix: use correct settings for test-extension jsjoeio Jan 13, 2022 https://github.com/coder/code-server/pull/4733/commits/0a5039dd0e8a4c4fefb3ba5997246e3685e18c68
c02b98a Merge branch 'main' into jsjoeio-argon-change jsjoeio Jan 18, 2022 https://github.com/coder/code-server/pull/4733/commits/c02b98afce2a2ab5fa46f5f6b0361bd99d31ad99
Clear filters https://github.com/coder/code-server/pull/4733/files
Please reload this pagehttps://github.com/coder/code-server/pull/4733/files
Please reload this pagehttps://github.com/coder/code-server/pull/4733/files
build-standalone-release.sh https://github.com/coder/code-server/pull/4733/files#diff-a6ebb1d512b2009ce829afc99a92783a38370c34664349a7f99e979be66ef2f0
npm-postinstall.sh https://github.com/coder/code-server/pull/4733/files#diff-9efc23615796709119daa0db0050a3b67205c9c8ee6d23a2ef635a88958ae777
package.json https://github.com/coder/code-server/pull/4733/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
util.ts https://github.com/coder/code-server/pull/4733/files#diff-8e0c46b152f3d9710115bb467980a690ffa07d39a4666db284f393c759f67168
package.json https://github.com/coder/code-server/pull/4733/files#diff-0688ea97822df369dc3c5507ba251e1a23794eebc086667d8767413813bf0307
tsconfig.json https://github.com/coder/code-server/pull/4733/files#diff-451c60a36aecf0b6ccd10d603f83b8f6f657b205bc89d370d4b34b80bab7c99d
package.json https://github.com/coder/code-server/pull/4733/files#diff-b9188cc104c28fc06ff913ef07a9fa1a038b3f4de944a86c32f85fe3df17efaf
util.test.ts https://github.com/coder/code-server/pull/4733/files#diff-881b3614113f118dc48372c43448a3b5ab3a414b59f9c60cc310839104de4758
yarn.lock https://github.com/coder/code-server/pull/4733/files#diff-98400b7a479d9032e004587308381f9fadc2e106243cb988c2258ba67ca2ede4
yarn.lock https://github.com/coder/code-server/pull/4733/files#diff-51e4f558fae534656963876761c95b83b6ef5da5103c4adef6768219ed76c2de
https://github.com/coder/code-server/blob/main/.github/CODEOWNERS#L1
ci/build/build-standalone-release.shhttps://github.com/coder/code-server/pull/4733/files#diff-a6ebb1d512b2009ce829afc99a92783a38370c34664349a7f99e979be66ef2f0
View file https://github.com/coder/code-server/blob/c02b98afce2a2ab5fa46f5f6b0361bd99d31ad99/ci/build/build-standalone-release.sh
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/code-server/pull/4733/{{ revealButtonHref }}
https://github.com/coder/code-server/pull/4733/files#diff-a6ebb1d512b2009ce829afc99a92783a38370c34664349a7f99e979be66ef2f0
https://github.com/coder/code-server/blob/main/.github/CODEOWNERS#L1
ci/build/npm-postinstall.shhttps://github.com/coder/code-server/pull/4733/files#diff-9efc23615796709119daa0db0050a3b67205c9c8ee6d23a2ef635a88958ae777
View file https://github.com/coder/code-server/blob/c02b98afce2a2ab5fa46f5f6b0361bd99d31ad99/ci/build/npm-postinstall.sh
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/code-server/pull/4733/{{ revealButtonHref }}
https://github.com/coder/code-server/pull/4733/files#diff-9efc23615796709119daa0db0050a3b67205c9c8ee6d23a2ef635a88958ae777
https://github.com/coder/code-server/pull/4733/files#diff-9efc23615796709119daa0db0050a3b67205c9c8ee6d23a2ef635a88958ae777
https://github.com/coder/code-server/blob/main/.github/CODEOWNERS#L1
package.jsonhttps://github.com/coder/code-server/pull/4733/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
View file https://github.com/coder/code-server/blob/c02b98afce2a2ab5fa46f5f6b0361bd99d31ad99/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/code-server/pull/4733/{{ revealButtonHref }}
https://github.com/coder/code-server/pull/4733/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
https://github.com/coder/code-server/pull/4733/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
https://github.com/coder/code-server/blob/main/.github/CODEOWNERS#L1
src/node/util.tshttps://github.com/coder/code-server/pull/4733/files#diff-8e0c46b152f3d9710115bb467980a690ffa07d39a4666db284f393c759f67168
View file https://github.com/coder/code-server/blob/c02b98afce2a2ab5fa46f5f6b0361bd99d31ad99/src/node/util.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/code-server/pull/4733/{{ revealButtonHref }}
https://github.com/coder/code-server/pull/4733/files#diff-8e0c46b152f3d9710115bb467980a690ffa07d39a4666db284f393c759f67168
https://github.com/coder/code-server/pull/4733/files#diff-8e0c46b152f3d9710115bb467980a690ffa07d39a4666db284f393c759f67168
Please reload this pagehttps://github.com/coder/code-server/pull/4733/files
https://github.com/coder/code-server/pull/4733/files#diff-8e0c46b152f3d9710115bb467980a690ffa07d39a4666db284f393c759f67168
https://github.com/coder/code-server/pull/4733/files#diff-8e0c46b152f3d9710115bb467980a690ffa07d39a4666db284f393c759f67168
Please reload this pagehttps://github.com/coder/code-server/pull/4733/files
https://github.com/coder/code-server/pull/4733/files#diff-8e0c46b152f3d9710115bb467980a690ffa07d39a4666db284f393c759f67168
https://github.com/coder/code-server/blob/main/.github/CODEOWNERS#L1
test/e2e/extensions/test-extension/package.jsonhttps://github.com/coder/code-server/pull/4733/files#diff-0688ea97822df369dc3c5507ba251e1a23794eebc086667d8767413813bf0307
View file https://github.com/coder/code-server/blob/c02b98afce2a2ab5fa46f5f6b0361bd99d31ad99/test/e2e/extensions/test-extension/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/code-server/pull/4733/{{ revealButtonHref }}
https://github.com/coder/code-server/pull/4733/files#diff-0688ea97822df369dc3c5507ba251e1a23794eebc086667d8767413813bf0307
https://github.com/coder/code-server/blob/main/.github/CODEOWNERS#L1
test/e2e/extensions/test-extension/tsconfig.jsonhttps://github.com/coder/code-server/pull/4733/files#diff-451c60a36aecf0b6ccd10d603f83b8f6f657b205bc89d370d4b34b80bab7c99d
View file https://github.com/coder/code-server/blob/c02b98afce2a2ab5fa46f5f6b0361bd99d31ad99/test/e2e/extensions/test-extension/tsconfig.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/code-server/pull/4733/{{ revealButtonHref }}
https://github.com/coder/code-server/pull/4733/files#diff-451c60a36aecf0b6ccd10d603f83b8f6f657b205bc89d370d4b34b80bab7c99d
https://github.com/coder/code-server/blob/main/.github/CODEOWNERS#L1
test/package.jsonhttps://github.com/coder/code-server/pull/4733/files#diff-b9188cc104c28fc06ff913ef07a9fa1a038b3f4de944a86c32f85fe3df17efaf
View file https://github.com/coder/code-server/blob/c02b98afce2a2ab5fa46f5f6b0361bd99d31ad99/test/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/code-server/pull/4733/{{ revealButtonHref }}
https://github.com/coder/code-server/pull/4733/files#diff-b9188cc104c28fc06ff913ef07a9fa1a038b3f4de944a86c32f85fe3df17efaf
https://github.com/coder/code-server/pull/4733/files#diff-b9188cc104c28fc06ff913ef07a9fa1a038b3f4de944a86c32f85fe3df17efaf
https://github.com/coder/code-server/pull/4733/files#diff-b9188cc104c28fc06ff913ef07a9fa1a038b3f4de944a86c32f85fe3df17efaf
https://github.com/coder/code-server/blob/main/.github/CODEOWNERS#L1
test/unit/node/util.test.tshttps://github.com/coder/code-server/pull/4733/files#diff-881b3614113f118dc48372c43448a3b5ab3a414b59f9c60cc310839104de4758
View file https://github.com/coder/code-server/blob/c02b98afce2a2ab5fa46f5f6b0361bd99d31ad99/test/unit/node/util.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/code-server/pull/4733/{{ revealButtonHref }}
https://github.com/coder/code-server/pull/4733/files#diff-881b3614113f118dc48372c43448a3b5ab3a414b59f9c60cc310839104de4758
https://github.com/coder/code-server/pull/4733/files#diff-881b3614113f118dc48372c43448a3b5ab3a414b59f9c60cc310839104de4758
https://github.com/coder/code-server/pull/4733/files#diff-881b3614113f118dc48372c43448a3b5ab3a414b59f9c60cc310839104de4758
https://github.com/coder/code-server/pull/4733/files#diff-881b3614113f118dc48372c43448a3b5ab3a414b59f9c60cc310839104de4758
https://github.com/coder/code-server/pull/4733/files#diff-881b3614113f118dc48372c43448a3b5ab3a414b59f9c60cc310839104de4758
https://github.com/coder/code-server/pull/4733/files#diff-881b3614113f118dc48372c43448a3b5ab3a414b59f9c60cc310839104de4758
https://github.com/coder/code-server/pull/4733/files#diff-881b3614113f118dc48372c43448a3b5ab3a414b59f9c60cc310839104de4758
https://github.com/coder/code-server/pull/4733/files#diff-881b3614113f118dc48372c43448a3b5ab3a414b59f9c60cc310839104de4758
https://github.com/coder/code-server/pull/4733/files#diff-881b3614113f118dc48372c43448a3b5ab3a414b59f9c60cc310839104de4758
Please reload this pagehttps://github.com/coder/code-server/pull/4733/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.