René's URL Explorer Experiment


Title: Add separate function for VS Code arguments by code-asher · Pull Request #4599 · coder/code-server · GitHub

Open Graph Title: Add separate function for VS Code arguments by code-asher · Pull Request #4599 · coder/code-server

X Title: Add separate function for VS Code arguments by code-asher · Pull Request #4599 · coder/code-server

Description: The problem before was that the pop() caused the open in existing instance functionality to break because the arguments no longer contained the workspace or directory (files are left untouched). We could simply remove the pop() but since workspace and folder are not CLI arguments I think it makes sense to handle them in a separate function which can be called at the point where they are needed. This also lets us de-duplicate some logic since we create these arguments in two spots and lets us skip this logic when we do not need it. The pop() is still avoided because manipulating a passed-in object in-place seems like a risky move. If we really need to do this we should copy the positional argument array instead.

Open Graph Description: The problem before was that the pop() caused the open in existing instance functionality to break because the arguments no longer contained the workspace or directory (files are left untouched). We...

X Description: The problem before was that the pop() caused the open in existing instance functionality to break because the arguments no longer contained the workspace or directory (files are left untouched). We...

Opengraph URL: https://github.com/coder/code-server/pull/4599

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7dfc943e-13b0-9dba-bb19-6db4abc9750d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9BE6:EDA7A:3375BED:4165542:6B01DA43
html-safe-nonceef0d35f4ffba165d392b10b68c8ba22c16c30e60a452566e988dca88d75c64ea
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QkU2OkVEQTdBOjMzNzVCRUQ6NDE2NTU0Mjo2QjAxREE0MyIsInZpc2l0b3JfaWQiOiI1NDM3NTIyNjk2OTY5NzcxNTg3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac6dc791413f40264c297e0c6139ad5f943d9d01f42e93d1f46a8ef95128204b63
hovercard-subject-tagpull_request:799370205
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/coder/code-server/pull/4599/files
twitter:imagehttps://avatars.githubusercontent.com/u/45609798?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/45609798?s=400&v=4
og:image:altThe problem before was that the pop() caused the open in existing instance functionality to break because the arguments no longer contained the workspace or directory (files are left untouched). We...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/coder/code-server git https://github.com/coder/code-server.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id172953845
octolytics-dimension-repository_nwocoder/code-server
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id172953845
octolytics-dimension-repository_network_root_nwocoder/code-server
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/coder/code-server/pull/4599/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcode-server%2Fpull%2F4599%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcode-server%2Fpull%2F4599%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=coder%2Fcode-server
Reloadhttps://github.com/coder/code-server/pull/4599/files
Reloadhttps://github.com/coder/code-server/pull/4599/files
Reloadhttps://github.com/coder/code-server/pull/4599/files
coderhttps://github.com/coder
code-serverhttps://github.com/coder/code-server
Codehttps://github.com/coder/code-server
Issues147 (147)https://github.com/coder/code-server/issues
Pull requests17 (17)https://github.com/coder/code-server/pulls
Discussionshttps://github.com/coder/code-server/discussions
Actionshttps://github.com/coder/code-server/actions
Projectshttps://github.com/coder/code-server/projects
Security and quality3 (3)https://github.com/coder/code-server/security
Insightshttps://github.com/coder/code-server/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fcoder%2Fcode-server%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fcoder%2Fcode-server%2Fissues%2Fnew%2Fchoose
code-asherhttps://github.com/code-asher
coder:mainhttps://github.com/coder/code-server/tree/main
code-asher:fix-open-folderhttps://github.com/code-asher/code-server/tree/fix-open-folder
Conversation 2 https://github.com/coder/code-server/pull/4599
Commits 2 https://github.com/coder/code-server/pull/4599/commits
Checks 0 https://github.com/coder/code-server/pull/4599/checks
Files changed https://github.com/coder/code-server/pull/4599/files
Please reload this pagehttps://github.com/coder/code-server/pull/4599/files
Add separate function for VS Code arguments https://github.com/coder/code-server/pull/4599/files#top
Show all changes 2 commits https://github.com/coder/code-server/pull/4599/files
009b55c Add separate function for VS Code arguments code-asher Dec 9, 2021 https://github.com/coder/code-server/pull/4599/commits/009b55c0a8abf30c18f6a72c95b65627d4f16232
e844d1d Merge branch 'main' into fix-open-folder code-asher Dec 10, 2021 https://github.com/coder/code-server/pull/4599/commits/e844d1da1e36535887bff790898ee88668334e43
Clear filters https://github.com/coder/code-server/pull/4599/files
Please reload this pagehttps://github.com/coder/code-server/pull/4599/files
Please reload this pagehttps://github.com/coder/code-server/pull/4599/files
cli.ts https://github.com/coder/code-server/pull/4599/files#diff-e1f89aee8992fa7022cc43adb93042f9bbb4b223f0d6cd0e70719cf4b795afa4
main.ts https://github.com/coder/code-server/pull/4599/files#diff-d50b34386e855c746ccf4a2677f0c271596e178764708ec2ca999dc0eaf4a0f6
vscode.ts https://github.com/coder/code-server/pull/4599/files#diff-5fbe57eda7a212ceb1db215bdd957812629b6e3f6722a80d8b0abac4b53e8dc6
cli.test.ts https://github.com/coder/code-server/pull/4599/files#diff-259502f3217ff57aa0efe8405a96d85558f638b6a1a27a3f772f7dda96ddc8f2
plugin.test.ts https://github.com/coder/code-server/pull/4599/files#diff-3d4bee263ec5cf79458b7281619c0519c32415cbb30ee813cbf0cca9a0e0d72b
https://github.com/coder/code-server/blob/main/.github/CODEOWNERS#L1
src/node/cli.tshttps://github.com/coder/code-server/pull/4599/files#diff-e1f89aee8992fa7022cc43adb93042f9bbb4b223f0d6cd0e70719cf4b795afa4
View file https://github.com/code-asher/code-server/blob/e844d1da1e36535887bff790898ee88668334e43/src/node/cli.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/code-server/pull/4599/{{ revealButtonHref }}
https://github.com/coder/code-server/pull/4599/files#diff-e1f89aee8992fa7022cc43adb93042f9bbb4b223f0d6cd0e70719cf4b795afa4
https://github.com/coder/code-server/pull/4599/files#diff-e1f89aee8992fa7022cc43adb93042f9bbb4b223f0d6cd0e70719cf4b795afa4
https://github.com/coder/code-server/pull/4599/files#diff-e1f89aee8992fa7022cc43adb93042f9bbb4b223f0d6cd0e70719cf4b795afa4
https://github.com/coder/code-server/pull/4599/files#diff-e1f89aee8992fa7022cc43adb93042f9bbb4b223f0d6cd0e70719cf4b795afa4
https://github.com/coder/code-server/pull/4599/files#diff-e1f89aee8992fa7022cc43adb93042f9bbb4b223f0d6cd0e70719cf4b795afa4
https://github.com/coder/code-server/pull/4599/files#diff-e1f89aee8992fa7022cc43adb93042f9bbb4b223f0d6cd0e70719cf4b795afa4
https://github.com/coder/code-server/blob/main/.github/CODEOWNERS#L1
src/node/main.tshttps://github.com/coder/code-server/pull/4599/files#diff-d50b34386e855c746ccf4a2677f0c271596e178764708ec2ca999dc0eaf4a0f6
View file https://github.com/code-asher/code-server/blob/e844d1da1e36535887bff790898ee88668334e43/src/node/main.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/code-server/pull/4599/{{ revealButtonHref }}
https://github.com/coder/code-server/pull/4599/files#diff-d50b34386e855c746ccf4a2677f0c271596e178764708ec2ca999dc0eaf4a0f6
https://github.com/coder/code-server/pull/4599/files#diff-d50b34386e855c746ccf4a2677f0c271596e178764708ec2ca999dc0eaf4a0f6
https://github.com/coder/code-server/pull/4599/files#diff-d50b34386e855c746ccf4a2677f0c271596e178764708ec2ca999dc0eaf4a0f6
https://github.com/coder/code-server/pull/4599/files#diff-d50b34386e855c746ccf4a2677f0c271596e178764708ec2ca999dc0eaf4a0f6
https://github.com/coder/code-server/blob/main/.github/CODEOWNERS#L1
src/node/routes/vscode.tshttps://github.com/coder/code-server/pull/4599/files#diff-5fbe57eda7a212ceb1db215bdd957812629b6e3f6722a80d8b0abac4b53e8dc6
View file https://github.com/code-asher/code-server/blob/e844d1da1e36535887bff790898ee88668334e43/src/node/routes/vscode.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/code-server/pull/4599/{{ revealButtonHref }}
https://github.com/coder/code-server/pull/4599/files#diff-5fbe57eda7a212ceb1db215bdd957812629b6e3f6722a80d8b0abac4b53e8dc6
https://github.com/coder/code-server/pull/4599/files#diff-5fbe57eda7a212ceb1db215bdd957812629b6e3f6722a80d8b0abac4b53e8dc6
https://github.com/coder/code-server/pull/4599/files#diff-5fbe57eda7a212ceb1db215bdd957812629b6e3f6722a80d8b0abac4b53e8dc6
https://github.com/coder/code-server/pull/4599/files#diff-5fbe57eda7a212ceb1db215bdd957812629b6e3f6722a80d8b0abac4b53e8dc6
https://github.com/coder/code-server/blob/main/.github/CODEOWNERS#L1
test/unit/node/cli.test.tshttps://github.com/coder/code-server/pull/4599/files#diff-259502f3217ff57aa0efe8405a96d85558f638b6a1a27a3f772f7dda96ddc8f2
View file https://github.com/code-asher/code-server/blob/e844d1da1e36535887bff790898ee88668334e43/test/unit/node/cli.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/code-server/pull/4599/{{ revealButtonHref }}
https://github.com/coder/code-server/pull/4599/files#diff-259502f3217ff57aa0efe8405a96d85558f638b6a1a27a3f772f7dda96ddc8f2
https://github.com/coder/code-server/pull/4599/files#diff-259502f3217ff57aa0efe8405a96d85558f638b6a1a27a3f772f7dda96ddc8f2
https://github.com/coder/code-server/pull/4599/files#diff-259502f3217ff57aa0efe8405a96d85558f638b6a1a27a3f772f7dda96ddc8f2
https://github.com/coder/code-server/pull/4599/files#diff-259502f3217ff57aa0efe8405a96d85558f638b6a1a27a3f772f7dda96ddc8f2
https://github.com/coder/code-server/blob/main/.github/CODEOWNERS#L1
test/unit/node/plugin.test.tshttps://github.com/coder/code-server/pull/4599/files#diff-3d4bee263ec5cf79458b7281619c0519c32415cbb30ee813cbf0cca9a0e0d72b
View file https://github.com/code-asher/code-server/blob/e844d1da1e36535887bff790898ee88668334e43/test/unit/node/plugin.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/code-server/pull/4599/{{ revealButtonHref }}
https://github.com/coder/code-server/pull/4599/files#diff-3d4bee263ec5cf79458b7281619c0519c32415cbb30ee813cbf0cca9a0e0d72b
https://github.com/coder/code-server/pull/4599/files#diff-3d4bee263ec5cf79458b7281619c0519c32415cbb30ee813cbf0cca9a0e0d72b
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.