René's URL Explorer Experiment


Title: Revert "fix: run postinstall script explicitly with bash (#4116)" by jsjoeio · Pull Request #4231 · coder/code-server · GitHub

Open Graph Title: Revert "fix: run postinstall script explicitly with bash (#4116)" by jsjoeio · Pull Request #4231 · coder/code-server

X Title: Revert "fix: run postinstall script explicitly with bash (#4116)" by jsjoeio · Pull Request #4231 · coder/code-server

Description: Summary This reverts commit b32b4ed. We are reverting this because we found out that while this fixes the postinstall on Windows, it breaks it on mac and other devices. See: #3874 (comment) Additional Context This change came in #4116 came from @MaxLOh with the goal of: Currently, Windows default script-shell (cmd) fails to run the postinstall script. This commit fixes the problem by running postinstall.sh explicitly with the default bash executable of the OS. While that fixed the postinstall issue on Windows, it broke it for anyone installing with Homebrew since our formula does not depend on bash. Instead of modifying the formula, we are opting for reverting b32b4ed and using sh instead. Our reasoning is that if someone on Windows has bash, surely they have sh as well. Note: we don't know how @MaxLOh was actually installing code-server so we don't have an exact way to test for their situation but this should work. I had also proposed doing this: "scripts": { "postinstall": "[ $(command -v bash) >/dev/null ] && bash ./postinstall.sh || ./postinstall.sh" } but that assumes the person has command installed Windows which may or may not be the case. We think we should also try to add some tests for this, which we may do in a follow-up PR. Todos open up follow-up issue #4232 Fixes #3874 Fixes #4209

Open Graph Description: Summary This reverts commit b32b4ed. We are reverting this because we found out that while this fixes the postinstall on Windows, it breaks it on mac and other devices. See: #3874 (comment) Additio...

X Description: Summary This reverts commit b32b4ed. We are reverting this because we found out that while this fixes the postinstall on Windows, it breaks it on mac and other devices. See: #3874 (comment) Additio...

Opengraph URL: https://github.com/coder/code-server/pull/4231

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a5efad0d-21f7-8bc7-692d-ede819a07c4f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC3C6:291B58:296E24E:34986CF:6B01DBCE
html-safe-noncead3b6b496af775a408fec3644fb249472393f3d8c0408868c532da0f6b6792b2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDM0M2OjI5MUI1ODoyOTZFMjRFOjM0OTg2Q0Y6NkIwMURCQ0UiLCJ2aXNpdG9yX2lkIjoiMTc4NjI0NDcwNTEyNjgzMzEwMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd556a2ee4b13c3f533c99c83c14f8da5a20c8879ccac4151873b3097598728ca
hovercard-subject-tagpull_request:741622742
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/coder/code-server/pull/4231/files
twitter:imagehttps://avatars.githubusercontent.com/u/3806031?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3806031?s=400&v=4
og:image:altSummary This reverts commit b32b4ed. We are reverting this because we found out that while this fixes the postinstall on Windows, it breaks it on mac and other devices. See: #3874 (comment) Additio...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/coder/code-server git https://github.com/coder/code-server.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id172953845
octolytics-dimension-repository_nwocoder/code-server
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id172953845
octolytics-dimension-repository_network_root_nwocoder/code-server
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/coder/code-server/pull/4231/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcode-server%2Fpull%2F4231%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcode-server%2Fpull%2F4231%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=coder%2Fcode-server
Reloadhttps://github.com/coder/code-server/pull/4231/files
Reloadhttps://github.com/coder/code-server/pull/4231/files
Reloadhttps://github.com/coder/code-server/pull/4231/files
coderhttps://github.com/coder
code-serverhttps://github.com/coder/code-server
Codehttps://github.com/coder/code-server
Issues147 (147)https://github.com/coder/code-server/issues
Pull requests17 (17)https://github.com/coder/code-server/pulls
Discussionshttps://github.com/coder/code-server/discussions
Actionshttps://github.com/coder/code-server/actions
Projectshttps://github.com/coder/code-server/projects
Security and quality3 (3)https://github.com/coder/code-server/security
Insightshttps://github.com/coder/code-server/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fcoder%2Fcode-server%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fcoder%2Fcode-server%2Fissues%2Fnew%2Fchoose
jsjoeiohttps://github.com/jsjoeio
mainhttps://github.com/coder/code-server/tree/main
jsjoeio/revert-4116https://github.com/coder/code-server/tree/jsjoeio/revert-4116
Conversation 4 https://github.com/coder/code-server/pull/4231
Commits 2 https://github.com/coder/code-server/pull/4231/commits
Checks 0 https://github.com/coder/code-server/pull/4231/checks
Files changed https://github.com/coder/code-server/pull/4231/files
Please reload this pagehttps://github.com/coder/code-server/pull/4231/files
Revert "fix: run postinstall script explicitly with bash (#4116)" https://github.com/coder/code-server/pull/4231/files#top
Show all changes 2 commits https://github.com/coder/code-server/pull/4231/files
1f95a23 Revert "fix: run postinstall script explicitly with bash (#4116)" jsjoeio Sep 23, 2021 https://github.com/coder/code-server/pull/4231/commits/1f95a23d1dd9834e881ec750fad0934bc7127f78
014faf5 feat: use sh in postinstall in build-release.sh jsjoeio Sep 23, 2021 https://github.com/coder/code-server/pull/4231/commits/014faf5b1cac866bf9a645429bc3fd014efc79f7
Clear filters https://github.com/coder/code-server/pull/4231/files
Please reload this pagehttps://github.com/coder/code-server/pull/4231/files
Please reload this pagehttps://github.com/coder/code-server/pull/4231/files
https://github.com/coder/code-server/blob/main/.github/CODEOWNERS#L1
ci/build/build-release.shhttps://github.com/coder/code-server/pull/4231/files#diff-471375dd1b99488272fffd0471bbd64b79dfd813b8d5b631b0f072a8ca40fcaa
View file https://github.com/coder/code-server/blob/014faf5b1cac866bf9a645429bc3fd014efc79f7/ci/build/build-release.sh
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/code-server/pull/4231/{{ revealButtonHref }}
https://github.com/coder/code-server/pull/4231/files#diff-471375dd1b99488272fffd0471bbd64b79dfd813b8d5b631b0f072a8ca40fcaa
https://github.com/coder/code-server/pull/4231/files#diff-471375dd1b99488272fffd0471bbd64b79dfd813b8d5b631b0f072a8ca40fcaa
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.